78640 2012-02-14 15:04:55 -0800 NRWT is broken for the default port 2012-02-14 15:20:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke oldest_to_newest 556654 0 dpranke 2012-02-14 15:04:55 -0800 NRWT is broken for the default port 556657 1 127054 dpranke 2012-02-14 15:09:25 -0800 Created attachment 127054 Patch 556659 2 127054 tony 2012-02-14 15:11:25 -0800 Comment on attachment 127054 Patch Can you add a unit test that passes self._options that matches what's passed in by the default port? Or just passes in self._options.platform. 556665 3 dpranke 2012-02-14 15:17:09 -0800 (In reply to comment #2) > (From update of attachment 127054 [details]) > Can you add a unit test that passes self._options that matches what's passed in by the default port? Or just passes in self._options.platform. Yeah, although it'll be a little bit ugly, so I'll add that as a separate patch on a separate bug to not hold this up or confuse it. 556671 4 dpranke 2012-02-14 15:20:37 -0800 Committed r107746: <http://trac.webkit.org/changeset/107746> 127054 2012-02-14 15:09:25 -0800 2012-02-14 15:11:25 -0800 Patch bug-78640-20120214150924.patch text/plain 1934 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYThkMDhiM2U5ZjNlZWFhYWY1Njg2MzE3ZDk5NmJlZjMx OWQ5YmY5Yi4uNDgyN2VjYzVjZTdlYTdhZjNmNzVmYzNkODE3ZTYxNDcwMTBkMzI3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTAyLTE0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIE5SV1QgaXMgYnJva2VuIGZvciB0aGUgZGVmYXVsdCBwb3J0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODY0MAorICAgIAorICAgICAgICBU aGUgY2hhbmdlIGluIHIxMDc3MTggKGJ1ZyA3ODU2NSkgYnJva2UgTlJXVCBpZiB5b3UgZGlkbid0 CisgICAgICAgIHNwZWNpZnkgYW55IHNvcnQgb2YgLS1wbGF0Zm9ybSBmbGFnIG9yIGVxdWl2YWxl bnQuIEkgZGlkbid0CisgICAgICAgIGNhdGNoIHRoaXMgYmVjYXVzZSBpdCdzIGEgZnVsbCBpbnRl Z3JhdGlvbiB0ZXN0ICh3aGljaCB3ZSBkb24ndAorICAgICAgICBoYXZlIGFuIGF1dG9tYXRlZCB0 ZXN0IGZvcikgYW5kIEkgbWlzc2VkIHRoaXMgY29tbWFuZCBsaW5lCisgICAgICAgIHZhcmlhbnQg d2hlbiB0ZXN0aW5nIGludGVyYWN0aXZlbHkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy93b3JrZXIucHk6CisgICAgICAgIChXb3JrZXIucnVuKToKKworMjAxMi0wMi0xNCAg RGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICB3ZWJraXRweTog Y3JlYXRlIHBvcnRzIGluIFdvcmtlcnMsIG5vdCBpbiBtYW5hZ2VyX3dvcmtlcl9icm9rZXIKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NTY1CiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJz L3dvcmtlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL3dvcmtlci5weQppbmRleCAwMjNlYjcxNzMyNmVlNjk2NDc0YjAzMWFkNzJmMzZiZmEwZjFk OGI1Li40NDk3MmVmNDkzODg4Nzk5Yzc3OTUyZWYzNGRiODA0MjcwYWViMjIwIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy93b3JrZXIu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMv d29ya2VyLnB5CkBAIC04OCw3ICs4OCw3IEBAIGNsYXNzIFdvcmtlcihtYW5hZ2VyX3dvcmtlcl9i cm9rZXIuQWJzdHJhY3RXb3JrZXIpOgogICAgICAgICAgICAgc2VsZi5fcG9ydCA9IHBvcnQKICAg ICAgICAgZWxzZToKICAgICAgICAgICAgICMgV2UgYXJlIHJ1bm5pbmcgaW4gYSBjaGlsZCBwcm9j ZXNzIGFuZCBuZWVkIHRvIGNyZWF0ZSBhIG5ldyBIb3N0LgotICAgICAgICAgICAgaWYgJ3Rlc3Qn IGluIHNlbGYuX29wdGlvbnMucGxhdGZvcm06CisgICAgICAgICAgICBpZiBzZWxmLl9vcHRpb25z LnBsYXRmb3JtIGFuZCAndGVzdCcgaW4gc2VsZi5fb3B0aW9ucy5wbGF0Zm9ybToKICAgICAgICAg ICAgICAgICAjIEl0IGlzIGxhbWUgdG8gaW1wb3J0IG1vY2tzIGludG8gcmVhbCBjb2RlLCBidXQg dGhpcyBhbGxvd3MgdXMgdG8gdXNlIHRoZSB0ZXN0IHBvcnQgaW4gbXVsdGktcHJvY2VzcyB0ZXN0 cyBhcyB3ZWxsLgogICAgICAgICAgICAgICAgIGZyb20gd2Via2l0cHkuY29tbW9uLmhvc3RfbW9j ayBpbXBvcnQgTW9ja0hvc3QKICAgICAgICAgICAgICAgICBob3N0ID0gTW9ja0hvc3QoKQo=