78639 2012-02-14 15:03:55 -0800 [MutationObservers] Clear pending mutation records on disconnect() 2012-02-27 18:34:42 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68729 1 rafaelw adamk adamk annevk ojan rniwa sam webkit.review.bot oldest_to_newest 556652 0 rafaelw 2012-02-14 15:03:55 -0800 It's pretty strange to call disconnect() and still *possibly* get one invocation of your callback. We should just clear any pending deliveries. It's possible that script way want to know immediately prior to calling disconnect() *what* mutation records are pending delivery. If this happens in practice, we can add a method to synchronously retrieve & clear pending mutation records. 556680 1 rniwa 2012-02-14 15:28:25 -0800 What does the spec says? 556685 2 adamk 2012-02-14 15:30:40 -0800 (In reply to comment #1) > What does the spec says? The spec matches the current behavior. Once the text is part of DOM4 (annevk said he was going to patch it in this week), we'll open a bug there too. This bug should be seen as depending on the spec change. 556706 3 rniwa 2012-02-14 15:41:30 -0800 (In reply to comment #2) > The spec matches the current behavior. Once the text is part of DOM4 (annevk said he was going to patch it in this week), we'll open a bug there too. > > This bug should be seen as depending on the spec change. Okay. Could you guys start a new thread or reply to an existing thread about this? I would be interested to hear what Jonas and Olli have to say about this. 556710 4 adamk 2012-02-14 15:43:36 -0800 (In reply to comment #3) > (In reply to comment #2) > > The spec matches the current behavior. Once the text is part of DOM4 (annevk said he was going to patch it in this week), we'll open a bug there too. > > > > This bug should be seen as depending on the spec change. > > Okay. Could you guys start a new thread or reply to an existing thread about this? I would be interested to hear what Jonas and Olli have to say about this. As noted above, my plan is to file this as a bug against the spec once the initial spec text is checked in. I asked Raf to file this bug since we were just talking about it and I didn't want it to get lost. 556712 5 rniwa 2012-02-14 15:44:14 -0800 (In reply to comment #4) > As noted above, my plan is to file this as a bug against the spec once the initial spec text is checked in. I asked Raf to file this bug since we were just talking about it and I didn't want it to get lost. Okay. That makes sense. 563206 6 adamk 2012-02-23 10:25:20 -0800 (In reply to comment #5) > (In reply to comment #4) > > As noted above, my plan is to file this as a bug against the spec once the initial spec text is checked in. I asked Raf to file this bug since we were just talking about it and I didn't want it to get lost. > > Okay. That makes sense. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16092 565986 7 129100 adamk 2012-02-27 14:37:49 -0800 Created attachment 129100 Patch 566240 8 129100 webkit.review.bot 2012-02-27 18:34:37 -0800 Comment on attachment 129100 Patch Clearing flags on attachment: 129100 Committed r109058: <http://trac.webkit.org/changeset/109058> 566241 9 webkit.review.bot 2012-02-27 18:34:42 -0800 All reviewed patches have been landed. Closing bug. 129100 2012-02-27 14:37:49 -0800 2012-02-27 18:34:37 -0800 Patch bug-78639-20120227143748.patch text/plain 5007 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdlNzQ3ODdlMjI0MTUx NjZkOWE4ZjFkMzMyMjc0MTJkOWQ1N2QwOS4uNmZlMjhmYjQ0ZDYxMDNmZmRhYTM0YWRjZDZiZjVk NWZhNDBkYjA2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTI3ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtNdXRhdGlvbk9ic2VydmVy c10gQ2xlYXIgcGVuZGluZyBtdXRhdGlvbiByZWNvcmRzIG9uIGRpc2Nvbm5lY3QoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg2MzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L211dGF0 aW9uL2Rpc2Nvbm5lY3QtY2FuY2VsLXBlbmRpbmcuaHRtbAorCisgICAgICAgICogZG9tL1dlYktp dE11dGF0aW9uT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViS2l0TXV0YXRpb25P YnNlcnZlcjo6ZGlzY29ubmVjdCk6IENsZWFyIHBlbmRpbmcgcmVjb3Jkcy4KKyAgICAgICAgKFdl YkNvcmU6OldlYktpdE11dGF0aW9uT2JzZXJ2ZXI6OmRlbGl2ZXIpOiBBdm9pZCBjYWxsaW5nIHRo ZSBjYWxsYmFjayBpZiBubyByZWNvcmRzIGFyZSBwZW5kaW5nIGRlbGl2ZXJ5LgorCiAyMDEyLTAy LTI3ICBLZW4gQnVjaGFuYW4gIDxrZW5yYkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWJzb2x1 dGUgcG9zaXRpb25lZCBlbGVtZW50cyB3aXRoIElubGluZSBSZWxhdGl2ZSBQb3NpdGlvbmVkIENv bnRhaW5lciBhcmUgbm90IGxheW91dCBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9XZWJLaXRNdXRhdGlvbk9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9X ZWJLaXRNdXRhdGlvbk9ic2VydmVyLmNwcAppbmRleCA2MDE1MzYyN2M1OGY0NDcwMzY2OWNlODhm ZmRlZmNkZDczYjJiNDMxLi4zMzBjZGNhNDYzYzk3MzM3NTFhZjA5M2ZhNDQ0YjczZDI2YjVlZTQ1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0TXV0YXRpb25PYnNlcnZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1dlYktpdE11dGF0aW9uT2JzZXJ2ZXIuY3BwCkBA IC04OSw2ICs4OSw3IEBAIHZvaWQgV2ViS2l0TXV0YXRpb25PYnNlcnZlcjo6b2JzZXJ2ZShOb2Rl KiBub2RlLCBNdXRhdGlvbk9ic2VydmVyT3B0aW9ucyBvcHRpb25zCiAKIHZvaWQgV2ViS2l0TXV0 YXRpb25PYnNlcnZlcjo6ZGlzY29ubmVjdCgpCiB7CisgICAgbV9yZWNvcmRzLmNsZWFyKCk7CiAg ICAgSGFzaFNldDxNdXRhdGlvbk9ic2VydmVyUmVnaXN0cmF0aW9uKj4gcmVnaXN0cmF0aW9ucyht X3JlZ2lzdHJhdGlvbnMpOwogICAgIGZvciAoSGFzaFNldDxNdXRhdGlvbk9ic2VydmVyUmVnaXN0 cmF0aW9uKj46Oml0ZXJhdG9yIGl0ZXIgPSByZWdpc3RyYXRpb25zLmJlZ2luKCk7IGl0ZXIgIT0g cmVnaXN0cmF0aW9ucy5lbmQoKTsgKytpdGVyKQogICAgICAgICAoKml0ZXIpLT51bnJlZ2lzdGVy KCk7CkBAIC0xMjMsNiArMTI0LDkgQEAgdm9pZCBXZWJLaXRNdXRhdGlvbk9ic2VydmVyOjplbnF1 ZXVlTXV0YXRpb25SZWNvcmQoUGFzc1JlZlB0cjxNdXRhdGlvblJlY29yZD4gbXUKIAogdm9pZCBX ZWJLaXRNdXRhdGlvbk9ic2VydmVyOjpkZWxpdmVyKCkKIHsKKyAgICBpZiAobV9yZWNvcmRzLmlz RW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgTXV0YXRpb25SZWNvcmRBcnJheSByZWNv cmRzOwogICAgIHJlY29yZHMuc3dhcChtX3JlY29yZHMpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjdkYWU2MDk1ODk0 ZDhhNDRjYjNkMjI2NGYyZWUxODE5NGJmZWY4ZS4uYzFmNDI1Y2E0ZjVhN2Q4MGNhZGY2MTQyM2Yy ODc0ZGQ3OGVhMGMwZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTI3ICBBZGFtIEts ZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtNdXRhdGlvbk9ic2VydmVyc10g Q2xlYXIgcGVuZGluZyBtdXRhdGlvbiByZWNvcmRzIG9uIGRpc2Nvbm5lY3QoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg2MzkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbXV0YXRpb24vZGlz Y29ubmVjdC1jYW5jZWwtcGVuZGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvbXV0YXRpb24vZGlzY29ubmVjdC1jYW5jZWwtcGVuZGluZy5odG1sOiBBZGRlZC4KKwogMjAx Mi0wMi0yNyAgS2VuIEJ1Y2hhbmFuICA8a2VucmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFi c29sdXRlIHBvc2l0aW9uZWQgZWxlbWVudHMgd2l0aCBJbmxpbmUgUmVsYXRpdmUgUG9zaXRpb25l ZCBDb250YWluZXIgYXJlIG5vdCBsYXlvdXQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L211dGF0aW9uL2Rpc2Nvbm5lY3QtY2FuY2VsLXBlbmRpbmctZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9kaXNjb25uZWN0LWNhbmNlbC1wZW5kaW5nLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYjVkOTdlNzUzMmQ2OGY2NjZlYmFlOWZhNWMwYTNjYWQz ZmIxYjEyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9kaXNj b25uZWN0LWNhbmNlbC1wZW5kaW5nLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE0IEBACitUZXN0 IHRoYXQgV2ViS2l0TXV0YXRpb25PYnNlcnZlci5kaXNjb25uZWN0IGNhbmNlbHMgcGVuZGluZyBk ZWxpdmVyeQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworRGlzY29ubmVjdGluZyBz aG91bGQgY2FuY2VsIGFueSBwZW5kaW5nIGRlbGl2ZXJ5Li4uCitQQVNTIG11dGF0aW9ucyBpcyBu dWxsCisuLi5hbmQgcmUtb2JzZXJ2aW5nIHNob3VsZCBub3Qgc2VlIGFueSBvZiB0aGUgcHJldmlv dXNseS1nZW5lcmF0ZWQgcmVjb3Jkcy4KK1BBU1MgbXV0YXRpb25zLmxlbmd0aCBpcyAxCitQQVNT IG11dGF0aW9uc1swXS5hdHRyaWJ1dGVOYW1lIGlzICJiYXIiCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9tdXRhdGlvbi9kaXNjb25uZWN0LWNhbmNlbC1wZW5kaW5nLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L211dGF0aW9uL2Rpc2Nvbm5lY3QtY2FuY2VsLXBlbmRpbmcuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5mNjJmZDUyOWUzOWM1MWFjN2M0NjhjOTliZWEzNzEzNzUwMTU2YWQxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9kaXNjb25uZWN0LWNhbmNlbC1wZW5kaW5n Lmh0bWwKQEAgLTAsMCArMSw0NSBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0IHNyYz0iLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNjcmlw dGlvbignVGVzdCB0aGF0IFdlYktpdE11dGF0aW9uT2JzZXJ2ZXIuZGlzY29ubmVjdCBjYW5jZWxz IHBlbmRpbmcgZGVsaXZlcnknKTsKKword2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOwordmFy IG11dGF0aW9uczsKK3ZhciBvYnNlcnZlcjsKKworZnVuY3Rpb24gc3RhcnQoKSB7CisgICAgbXV0 YXRpb25zID0gbnVsbDsKKyAgICBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsK KworICAgIG9ic2VydmVyID0gbmV3IFdlYktpdE11dGF0aW9uT2JzZXJ2ZXIoZnVuY3Rpb24obSkg eworICAgICAgICBtdXRhdGlvbnMgPSBtOworICAgIH0pOworCisgICAgb2JzZXJ2ZXIub2JzZXJ2 ZShkaXYsIHsgYXR0cmlidXRlczogdHJ1ZSB9KTsKKyAgICBkaXYuc2V0QXR0cmlidXRlKCdmb28n LCAnYmFyJyk7CisgICAgb2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAgIHNldFRpbWVvdXQobmV4 dCwgMCk7Cit9CisKK2Z1bmN0aW9uIG5leHQoKSB7CisgICAgZGVidWcoJ0Rpc2Nvbm5lY3Rpbmcg c2hvdWxkIGNhbmNlbCBhbnkgcGVuZGluZyBkZWxpdmVyeS4uLicpOworICAgIHNob3VsZEJlTnVs bCgnbXV0YXRpb25zJyk7CisgICAgb2JzZXJ2ZXIub2JzZXJ2ZShkaXYsIHsgYXR0cmlidXRlczog dHJ1ZSB9KTsKKyAgICBkaXYuc2V0QXR0cmlidXRlKCdiYXInLCAnYmF6Jyk7CisgICAgc2V0VGlt ZW91dChmaW5pc2gsIDApOworfQorCitmdW5jdGlvbiBmaW5pc2goKSB7CisgICAgZGVidWcoJy4u LmFuZCByZS1vYnNlcnZpbmcgc2hvdWxkIG5vdCBzZWUgYW55IG9mIHRoZSBwcmV2aW91c2x5LWdl bmVyYXRlZCByZWNvcmRzLicpOworICAgIHNob3VsZEJlKCdtdXRhdGlvbnMubGVuZ3RoJywgJzEn KTsKKyAgICBzaG91bGRCZSgnbXV0YXRpb25zWzBdLmF0dHJpYnV0ZU5hbWUnLCAnImJhciInKTsK KyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKworaWYgKCF3aW5kb3cuV2ViS2l0TXV0YXRpb25PYnNl cnZlcikKKyAgICB0ZXN0RmFpbGVkKCdUaGlzIHRlc3QgcmVxdWlyZXMgRU5BQkxFKE1VVEFUSU9O X09CU0VSVkVSUyknKTsKK2Vsc2UKKyAgICBzdGFydCgpOworCis8L3NjcmlwdD4KKzxzY3JpcHQg c3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4K