78637 2012-02-14 14:55:50 -0800 Node::isContentEditable should only update styles, not layout 2012-02-21 19:35:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr ap cshu darin enrica rniwa tonikitoo webkit.review.bot oldest_to_newest 556642 0 jamesr 2012-02-14 14:55:50 -0800 Node::isContentEditable should only update styles, not layout 556679 1 127058 jamesr 2012-02-14 15:27:01 -0800 Created attachment 127058 Patch 556683 2 jamesr 2012-02-14 15:29:49 -0800 The updateLayout..() call in handleMousePressEvent() is because the code was previously relying on an isContentEditable() call to update layout. 556701 3 127058 rniwa 2012-02-14 15:39:32 -0800 Comment on attachment 127058 Patch Looks reasonable to me. 561502 4 127058 webkit.review.bot 2012-02-21 19:35:19 -0800 Comment on attachment 127058 Patch Clearing flags on attachment: 127058 Committed r108436: <http://trac.webkit.org/changeset/108436> 561503 5 webkit.review.bot 2012-02-21 19:35:24 -0800 All reviewed patches have been landed. Closing bug. 127058 2012-02-14 15:27:01 -0800 2012-02-21 19:35:19 -0800 Patch bug-78637-20120214152700.patch text/plain 2433 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZiYTE4MmY2YjE4MDg4 NGZlYjAyY2VkM2FmYmUxYjQ1NGQ0ZWE4Ni4uMGI2ZDY2NmNkOWZkZTkxMjg0Zjg3NDIzOWM5MzUw ODg3MWRmNGYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTE0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTm9kZTo6aXNDb250 ZW50RWRpdGFibGUgc2hvdWxkIG9ubHkgdXBkYXRlIHN0eWxlcywgbm90IGxheW91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg2MzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpc0NvbnRlbnRFZGl0YWJs ZSBkZXBlbmRzIG9uIGtub3dpbmcgdGhlIG5vZGUncyBjdXJyZW50IGNvbXB1dGVkIHN0eWxlLCBz byBpdCBoYXMgdG8gdXBkYXRlIHN0eWxlcyBpZiB0aGV5IGFyZQorICAgICAgICBvdXQgb2YgZGF0 ZS4gIEl0IGRvZXMgbm90IGRlcGVuZCBvbiBrbm93aW5nIGFueSBsYXlvdXQtZGVyaXZlZCBwcm9w ZXJ0aWVzLCBob3dldmVyLCBzbyB1cGRhdGluZyBsYXlvdXQgaXMganVzdCBhCisgICAgICAgIHdh c3RlIG9mIHRpbWUuCisKKyAgICAgICAgQmVoYXZpb3IgaXMgY292ZXJlZCBieSBleGlzdGluZyBs YXlvdXQgdGVzdHMsIHByaW1hcmlseSBpbiBlZGl0aW5nLworCisgICAgICAgICogZG9tL05vZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6aXNDb250ZW50RWRpdGFibGUpOgorICAgICAg ICAoV2ViQ29yZTo6Tm9kZTo6aXNDb250ZW50UmljaGx5RWRpdGFibGUpOgorCiAyMDEyLTAyLTEy ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCBp bmNsdWRlIENhY2hlZFJlc291cmNlcyB0aGF0IGhhdmVuJ3QgZG93bmxvYWRlZCB3aGVuIHBvcHVs YXRpbmcgdGhlIFdlYiBJbnNwZWN0b3Igb24gbG9hZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCAzZDlh YzNlNWIwYTFhMjEyNzc0YjJmMmU5ZjUwZmI4Y2E2YmJjMDBkLi44NGEyNmUyZGQwYjYzMThiMjk2 NGI0YjM3ZWI0YjcyMzg4NDZmMDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9k ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC02OTMsMTMgKzY5Mywx MyBAQCBjb25zdCBBdG9taWNTdHJpbmcmIE5vZGU6OnZpcnR1YWxOYW1lc3BhY2VVUkkoKSBjb25z dAogCiBib29sIE5vZGU6OmlzQ29udGVudEVkaXRhYmxlKCkKIHsKLSAgICBkb2N1bWVudCgpLT51 cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKKyAgICBkb2N1bWVudCgpLT51 cGRhdGVTdHlsZUlmTmVlZGVkKCk7CiAgICAgcmV0dXJuIHJlbmRlcmVySXNFZGl0YWJsZShFZGl0 YWJsZSk7CiB9CiAKIGJvb2wgTm9kZTo6aXNDb250ZW50UmljaGx5RWRpdGFibGUoKQogewotICAg IGRvY3VtZW50KCktPnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOworICAg IGRvY3VtZW50KCktPnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKICAgICByZXR1cm4gcmVuZGVyZXJJ c0VkaXRhYmxlKFJpY2hseUVkaXRhYmxlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCmluZGV4IGFiY2M1MTc4ZWRkODllYmY3OGU0MzNjNTFjNjhkY2Y0ZjE5ZTcwNWIuLjNi MWU3NjY3ZTkwYWMzOTk1ZDFhODUyMmQzZDczMDdmNDMyODFiNGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0V2ZW50SGFuZGxlci5jcHAKQEAgLTUzMSw2ICs1MzEsOCBAQCBib29sIEV2ZW50SGFuZGxlcjo6 aGFuZGxlTW91c2VQcmVzc0V2ZW50KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMm IGV2ZQogCiAgICAgY2FuY2VsRmFrZU1vdXNlTW92ZUV2ZW50KCk7CiAKKyAgICBtX2ZyYW1lLT5k b2N1bWVudCgpLT51cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKKwogICAg IGlmIChTY3JvbGxWaWV3KiBzY3JvbGxWaWV3ID0gbV9mcmFtZS0+dmlldygpKSB7CiAgICAgICAg IGlmIChzY3JvbGxWaWV3LT5pc1BvaW50SW5TY3JvbGxiYXJDb3JuZXIoZXZlbnQuZXZlbnQoKS5w b3NpdGlvbigpKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK