78628 2012-02-14 13:28:08 -0800 perf tests are flaky 2012-05-24 02:42:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86800 87267 63769 78593 1 tony tmpsantos abarth dpranke ojan ossy tmpsantos webkit.review.bot oldest_to_newest 556555 0 tony 2012-02-14 13:28:08 -0800 We should consider running them at the end of new-run-webkit-tests without other processes running so they're less flaky. Note that I already disabled them for debug builds because they're really flaky in debug. I don't have time for this now, but someone else might! 614216 1 139795 tmpsantos 2012-05-02 05:57:02 -0700 Created attachment 139795 patch Perf tests are affected by external factors (load, i/o, etc), makes sense to lock other threads when running them. This patch solves the problem on my machine of perf tests flaking/timeouting when building a Debug version of EFL port. IMO we have such a few perf tests that it is OK to put them on the locked shard, should not affect the total elapsed time of running layout tests. 614379 2 139795 tony 2012-05-02 09:52:55 -0700 Comment on attachment 139795 patch Seems fine to me. I'll give dirk a chance to review the code as well. I'd also be curious to know how this impacts total running time, although I suspect it's relatively small. 615621 3 139795 dpranke 2012-05-03 14:20:59 -0700 Comment on attachment 139795 patch looks fine. 615676 4 139795 webkit.review.bot 2012-05-03 15:08:50 -0700 Comment on attachment 139795 patch Clearing flags on attachment: 139795 Committed r116021: <http://trac.webkit.org/changeset/116021> 615677 5 webkit.review.bot 2012-05-03 15:08:56 -0700 All reviewed patches have been landed. Closing bug. 616052 6 tmpsantos 2012-05-04 02:21:18 -0700 Got no flakes on perf anymore on the EFL buildbot and no change on the run-webkit-tests total time. 631685 7 ossy 2012-05-23 08:27:10 -0700 It caused a regression, could you check and fix it, please? See https://bugs.webkit.org/show_bug.cgi?id=86800 for details. 632558 8 tmpsantos 2012-05-24 02:42:07 -0700 (In reply to comment #7) > It caused a regression, could you check and fix it, please? > See https://bugs.webkit.org/show_bug.cgi?id=86800 for details. Thanks for informing. Working on it right now. 139795 2012-05-02 05:57:02 -0700 2012-05-03 15:08:50 -0700 patch perf_lock.patch text/plain 3726 tmpsantos Y29tbWl0IGEyNjIwNmY3YzRlNGU3MTljY2RiZWFiZjc2MzdlYjQ4Yjk5ZThkNTYKQXV0aG9yOiBU aGlhZ28gTWFyY29zIFAuIFNhbnRvcyA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CkRhdGU6ICAg V2VkIE1heSAyIDE1OjM1OjM4IDIwMTIgKzAzMDAKCiAgICBbTlJXVF0gUnVuIHBlcmZvcm1hbmNl IHRlc3RzIHdpdGggbG9jawogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc4NjI4CiAgICAKICAgIExvY2tpbmcgcGVyZm9ybWFuY2UgdGVzdHMgKGxpa2Ugd2UgZG8g Zm9yIGh0dHAgdGVzdHMpIHdpbGwgZm9yY2UgdGhlbQogICAgdG8gcnVuIGluIHNlcmlhbC4gVGhp cyByZWR1Y2VzIHRoZSBsb2FkIG9mIHRoZSBtYWNoaW5lIHdoZW4gcnVubmluZyBwZXJmCiAgICB0 ZXN0cyBhbmQgbWluaW1pemVzIHRoZSBjaGFuY2VzIG9mIHRoZSB0ZXN0cyB0byBmYWlsLCBzcGVj aWFsbHkKICAgIHRpbWVvdXRzLgoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCA3NGFlMzcxLi4wMjgxMzFlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDUtMDIg IFRoaWFnbyBNYXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAg ICAgICAgW05SV1RdIFJ1biBwZXJmb3JtYW5jZSB0ZXN0cyB3aXRoIGxvY2sKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NjI4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9ja2luZyBwZXJmb3JtYW5jZSB0 ZXN0cyAobGlrZSB3ZSBkbyBmb3IgaHR0cCB0ZXN0cykgd2lsbCBmb3JjZSB0aGVtCisgICAgICAg IHRvIHJ1biBpbiBzZXJpYWwuIFRoaXMgcmVkdWNlcyB0aGUgbG9hZCBvZiB0aGUgbWFjaGluZSB3 aGVuIHJ1bm5pbmcgcGVyZgorICAgICAgICB0ZXN0cyBhbmQgbWluaW1pemVzIHRoZSBjaGFuY2Vz IG9mIHRoZSB0ZXN0cyB0byBmYWlsLCBzcGVjaWFsbHkKKyAgICAgICAgdGltZW91dHMuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2Vy LnB5OgorICAgICAgICAoTWFuYWdlci5fX2luaXRfXyk6CisgICAgICAgIChNYW5hZ2VyLl9pc19w ZXJmX3Rlc3QpOgorICAgICAgICAoTWFuYWdlci5fdGVzdF9yZXF1aXJlc19sb2NrKToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfbG9jay5weToKKwog MjAxMi0wNS0wMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgd2Via2l0cHk6IFJlbW92ZSB1bnVzZWQgcGxhdGZvcm0gaW1wb3J0cy4KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21h bmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyLnB5CmluZGV4IGQ5NjBlNzguLjBhNDg4YmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5w eQpAQCAtMzAwLDYgKzMwMCw3IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgc2Vs Zi5fZXhwZWN0YXRpb25zID0gTm9uZQogCiAgICAgICAgIHNlbGYuSFRUUF9TVUJESVIgPSAnaHR0 cCcgKyBwb3J0LlRFU1RfUEFUSF9TRVBBUkFUT1IKKyAgICAgICAgc2VsZi5QRVJGX1NVQkRJUiA9 ICdwZXJmJwogICAgICAgICBzZWxmLldFQlNPQ0tFVF9TVUJESVIgPSAnd2Vic29ja2V0JyArIHBv cnQuVEVTVF9QQVRIX1NFUEFSQVRPUgogICAgICAgICBzZWxmLkxBWU9VVF9URVNUU19ESVJFQ1RP UlkgPSAnTGF5b3V0VGVzdHMnCiAgICAgICAgIHNlbGYuX2hhc19odHRwX2xvY2sgPSBGYWxzZQpA QCAtMzU2LDYgKzM1Nyw5IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICBkZWYgX2h0dHBf dGVzdHMoc2VsZik6CiAgICAgICAgIHJldHVybiBzZXQodGVzdCBmb3IgdGVzdCBpbiBzZWxmLl90 ZXN0X2ZpbGVzIGlmIHNlbGYuX2lzX2h0dHBfdGVzdCh0ZXN0KSkKIAorICAgIGRlZiBfaXNfcGVy Zl90ZXN0KHNlbGYsIHRlc3QpOgorICAgICAgICByZXR1cm4gc2VsZi5QRVJGX1NVQkRJUiA9PSB0 ZXN0IG9yIChzZWxmLlBFUkZfU1VCRElSICsgc2VsZi5fcG9ydC5URVNUX1BBVEhfU0VQQVJBVE9S KSBpbiB0ZXN0CisKICAgICBkZWYgcGFyc2VfZXhwZWN0YXRpb25zKHNlbGYpOgogICAgICAgICAi IiJQYXJzZSB0aGUgZXhwZWN0YXRpb25zIGZyb20gdGhlIHRlc3RfbGlzdCBmaWxlcyBhbmQgcmV0 dXJuIGEgZGF0YQogICAgICAgICBzdHJ1Y3R1cmUgaG9sZGluZyB0aGVtLiBUaHJvd3MgYW4gZXJy b3IgaWYgdGhlIHRlc3RfbGlzdCBmaWxlcyBoYXZlCkBAIC01NTMsOCArNTU3LDEwIEBAIGNsYXNz IE1hbmFnZXIob2JqZWN0KToKIAogICAgIGRlZiBfdGVzdF9yZXF1aXJlc19sb2NrKHNlbGYsIHRl c3RfZmlsZSk6CiAgICAgICAgICIiIlJldHVybiBUcnVlIGlmIHRoZSB0ZXN0IG5lZWRzIHRvIGJl IGxvY2tlZCB3aGVuCi0gICAgICAgIHJ1bm5pbmcgbXVsdGlwbGUgY29waWVzIG9mIE5SV1RzLiIi IgotICAgICAgICByZXR1cm4gc2VsZi5faXNfaHR0cF90ZXN0KHRlc3RfZmlsZSkKKyAgICAgICAg cnVubmluZyBtdWx0aXBsZSBjb3BpZXMgb2YgTlJXVHMuIFBlcmYgdGVzdHMgYXJlIGxvY2tlZAor ICAgICAgICBiZWNhdXNlIGhlYXZ5IGxvYWQgY2F1c2VkIGJ5IHJ1bm5pbmcgb3RoZXIgdGVzdHMg aW4gcGFyYWxsZWwKKyAgICAgICAgbWlnaHQgY2F1c2Ugc29tZSBvZiB0aGVtIHRvIHRpbWVvdXQu IiIiCisgICAgICAgIHJldHVybiBzZWxmLl9pc19odHRwX3Rlc3QodGVzdF9maWxlKSBvciBzZWxm Ll9pc19wZXJmX3Rlc3QodGVzdF9maWxlKQogCiAgICAgZGVmIF90ZXN0X2lzX3Nsb3coc2VsZiwg dGVzdF9maWxlKToKICAgICAgICAgcmV0dXJuIHNlbGYuX2V4cGVjdGF0aW9ucy5oYXNfbW9kaWZp ZXIodGVzdF9maWxlLCB0ZXN0X2V4cGVjdGF0aW9ucy5TTE9XKQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2sucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfbG9jay5weQppbmRleCBlZTM0 NDkxLi5jMmVlY2UzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2h0dHBfbG9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2h0dHBfbG9jay5weQpAQCAtMjYsNyArMjYsNyBAQAogIyBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogCiAiIiJUaGlzIGNsYXNzIGhlbHBzIHRvIGJsb2NrIE5SV1QgdGhyZWFkcyB3aGVuIG1vcmUg TlJXVHMgcnVuCi1odHRwIGFuZCB3ZWJzb2NrZXQgdGVzdHMgaW4gYSBzYW1lIHRpbWUuIiIiCitw ZXJmLCBodHRwIGFuZCB3ZWJzb2NrZXQgdGVzdHMgaW4gYSBzYW1lIHRpbWUuIiIiCiAKIGltcG9y dCBsb2dnaW5nCiBpbXBvcnQgb3MK