78582 2012-02-13 23:44:46 -0800 Finish implementing start_helper for ChromiumAndroidPort 2012-02-14 12:29:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78524 1 abarth abarth dpranke eric jnd ojan webkit.review.bot oldest_to_newest 556008 0 abarth 2012-02-13 23:44:46 -0800 Finish implementing start_helper for ChromiumAndroidPort 556010 1 126917 abarth 2012-02-13 23:46:30 -0800 Created attachment 126917 Patch 556340 2 126917 eric 2012-02-14 09:22:22 -0800 Comment on attachment 126917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126917&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:315 > + except: > + # Reset to 1970-01-01 00:00:00 UTC. > + host_datetime = 0 I wonder if anyone has ever used this except: path... I doubt it works. I'm not sure having an except here is helpful. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:326 > + def _run_adb_command(self, cmd, ignore_error=False): IT seems ignore_error=true is never used. 556373 3 126917 abarth 2012-02-14 10:09:04 -0800 Comment on attachment 126917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126917&action=review >> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:315 >> + host_datetime = 0 > > I wonder if anyone has ever used this except: path... I doubt it works. I'm not sure having an except here is helpful. Another question is whether we should be using os.popen at all rather than using Executive. I'll probably switch it to executive before landing. >> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:326 >> + def _run_adb_command(self, cmd, ignore_error=False): > > IT seems ignore_error=true is never used. It's used on the very next line in the if condition. 556397 4 126917 dpranke 2012-02-14 10:39:32 -0800 Comment on attachment 126917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126917&action=review Patch looks fine to me, just some editing of the comments ... > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:51 > +# FIXME: find a solution foe multi-core devices. Nit: "for", not "foe". > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:63 > +FORWARD_PORTS = '8000 8080 8443 8880 9323' These comments could use some grammatical editing as well. As an aside, I didn't realize 9323 was being used for anything ... > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:208 > + # Start the HTTP server for device to access test cases. Nit: s/for device to access/so the device can access the/. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:309 > + # We need to make them synchronized, otherwise test may fail. Nit: s/test/tests/ (or 'a test'). 556447 5 127006 abarth 2012-02-14 11:32:27 -0800 Created attachment 127006 Patch for landing 556494 6 abarth 2012-02-14 12:29:20 -0800 Committed r107725: <http://trac.webkit.org/changeset/107725> 126917 2012-02-13 23:46:30 -0800 2012-02-14 11:32:22 -0800 Patch bug-78582-20120213234629.patch text/plain 4585 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNzY3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTAyLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgRmluaXNoIGltcGxlbWVudGluZyBzdGFydF9oZWxwZXIgZm9yIENocm9taXVtQW5k cm9pZFBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4NTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBwYXRjaCBjb250YWlucyB0aGUgcmVtYWluaW5nIG9kZHMgYW5kIGVuZHMgZm9yIHRoZSBz dGFydF9oZWxwZXIgZnVuY3Rpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJv aWRQb3J0LnN0YXJ0X2hlbHBlcik6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0Ll9zeW5j aHJvbml6ZV9kYXRldGltZSk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0KToKKyAgICAg ICAgKENocm9taXVtQW5kcm9pZFBvcnQuX2NoZWNrX3ZlcnNpb24pOgorICAgICAgICAoQ2hyb21p dW1BbmRyb2lkUG9ydC5fcnVuX2FkYl9jb21tYW5kKToKKyAgICAgICAgKENocm9taXVtQW5kcm9p ZFBvcnQuX2NvcHlfZGV2aWNlX2ZpbGUpOgorCiAyMDEyLTAyLTEzICBSb2IgRmxhY2sgIDxmbGFj a3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBMaW51eCBDaHJvbWl1bU9TIHRlc3QgcmVz dWx0cyB0byBmbGFraW5lc3MgZGFzaGJvYXJkLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5w eQkocmV2aXNpb24gMTA3NjYwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0Nywy MSBAQCBERVZJQ0VfRFJUX1NUREVSUiA9IERFVklDRV9EUlRfRElSICsgJ0R1CiBERVZJQ0VfRk9S V0FSREVSX1BBVEggPSBERVZJQ0VfRFJUX0RJUiArICdmb3J3YXJkZXInCiBERVZJQ0VfRFJUX1NU QU1QX1BBVEggPSBERVZJQ0VfRFJUX0RJUiArICdEdW1wUmVuZGVyVHJlZS5zdGFtcCcKIAorIyBU aGlzIG9ubHkgd29ya3MgZm9yIHNpbmdsZSBjb3JlIGRldmljZXMgc28gZmFyLgorIyBGSVhNRTog ZmluZCBhIHNvbHV0aW9uIGZvZSBtdWx0aS1jb3JlIGRldmljZXMuCitTQ0FMSU5HX0dPVkVSTk9S ID0gIi9zeXMvZGV2aWNlcy9zeXN0ZW0vY3B1L2NwdTAvY3B1ZnJlcS9zY2FsaW5nX2dvdmVybm9y IgorCisjIE5vdyBhbGwgdGVzdCBjYXNlcyBhcmUgc3RpbGwgc2VydmVkIHRvIER1bXBSZW5kZXJU cmVlIHRocm91Z2ggZmlsZSBwcm90b2NvbCwKKyMgdGhlbiB3ZSB1c2UgZmlsZS10by1odHRwIGZl YXR1cmUgdG8gYnJpZGdlIHRoZSBmaWxlIHJlcXVlc3QgdG8gaG9zdCdzIGh0dHAKKyMgc2VydmVy IHRvIGdldCB0aGUgcmVhbCB0ZXN0IGZpbGVzIGFuZCBjb3JyZXNwb25kaW5nIHJlc291cmNlcyB2 aWEgZm9yd2FyZC4KK1RFU1RfUEFUSF9QUkVGSVggPSAnL2FsbC10ZXN0cycKKworIyBBbGwgcG9y dHMgdGhlIEFuZHJvaWQgZm9yd2FyZGVyIHRvIGZvcndhcmQuCisjIDgwMDAsIDgwODAgYW5kIDg0 NDMgYXJlIGZvciBodHRwL2h0dHBzIHRlc3RzLgorIyA4ODgwIGFuZCA5MzIzIGFyZSBmb3Igd2Vi c29ja2V0IHRlc3RzCisjIChzZWUgaHR0cF9zZXJ2ZXIucHksIGFwYWNoZV9odHRwX3NlcnZlci5w eSBhbmQgd2Vic29ja2V0X3NlcnZlci5weSkuCitGT1JXQVJEX1BPUlRTID0gJzgwMDAgODA4MCA4 NDQzIDg4ODAgOTMyMycKKwogTVNfVFJVRVRZUEVfRk9OVFNfRElSID0gJy91c3Ivc2hhcmUvZm9u dHMvdHJ1ZXR5cGUvbXN0dGNvcmVmb250cy8nCiAKICMgTGlzdCBvZiBmb250cyB0aGF0IGxheW91 dCB0ZXN0cyBleHBlY3QsIGNvcGllZCBmcm9tIER1bXBSZW5kZXJUcmVlL2d0ay9UZXN0U2hlbGxH dGsuY3BwLgpAQCAtMTg4LDYgKzIwMywxMyBAQCBjbGFzcyBDaHJvbWl1bUFuZHJvaWRQb3J0KGNo cm9taXVtLkNocm9tCiAgICAgICAgIHNlbGYuX3B1c2hfZXhlY3V0YWJsZSgpCiAgICAgICAgIHNl bGYuX3B1c2hfZm9udHMoKQogICAgICAgICBzZWxmLl9zZXR1cF9zeXN0ZW1fZm9udF9mb3JfdGVz dCgpCisgICAgICAgIHNlbGYuX3N5bmNocm9uaXplX2RhdGV0aW1lKCkKKworICAgICAgICAjIFN0 YXJ0IHRoZSBIVFRQIHNlcnZlciBmb3IgZGV2aWNlIHRvIGFjY2VzcyB0ZXN0IGNhc2VzLgorICAg ICAgICBjaHJvbWl1bS5DaHJvbWl1bVBvcnQuc3RhcnRfaHR0cF9zZXJ2ZXIoc2VsZiwgYWRkaXRp b25hbF9kaXJzPXtURVNUX1BBVEhfUFJFRklYOiBzZWxmLmxheW91dF90ZXN0c19kaXIoKX0pCisK KyAgICAgICAgX2xvZy5kZWJ1ZygnU3RhcnRpbmcgZm9yd2FyZGVyJykKKyAgICAgICAgY21kID0g c2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnJXMgJXMnICUgKERFVklDRV9GT1JXQVJE RVJfUEFUSCwgRk9SV0FSRF9QT1JUUyldKQogCiAgICAgZGVmIHN0b3BfaGVscGVyKHNlbGYpOgog ICAgICAgICBzZWxmLl9yZXN0b3JlX3N5c3RlbV9mb250KCkKQEAgLTI4Miw2ICszMDQsMzYgQEAg Y2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydChjaHJvbWl1bS5DaHJvbQogICAgICAgICBmb3IgcmVz b3VyY2UgaW4gVEVTVF9SRVNPVVJDRVNfVE9fUFVTSDoKICAgICAgICAgICAgIHNlbGYuX3B1c2hf dG9fZGV2aWNlKHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpICsgJy8nICsgcmVzb3VyY2UsIERFVklD RV9MQVlPVVRfVEVTVFNfRElSICsgcmVzb3VyY2UpCiAKKyAgICBkZWYgX3N5bmNocm9uaXplX2Rh dGV0aW1lKHNlbGYpOgorICAgICAgICAjIFRoZSBkYXRlL3RpbWUgYmV0d2VlbiBob3N0IGFuZCBk ZXZpY2UgbWF5IG5vdCBiZSBzeW5jaHJvbml6ZWQuCisgICAgICAgICMgV2UgbmVlZCB0byBtYWtl IHRoZW0gc3luY2hyb25pemVkLCBvdGhlcndpc2UgdGVzdCBtYXkgZmFpbC4KKyAgICAgICAgdHJ5 OgorICAgICAgICAgICAgIyBHZXQgc2Vjb25kcyBzaW5jZSAxOTcwLTAxLTAxIDAwOjAwOjAwIFVU Qy4KKyAgICAgICAgICAgIGhvc3RfZGF0ZXRpbWUgPSBvcy5wb3BlbignZGF0ZSAtdSArJXMnKS5y ZWFkKCkKKyAgICAgICAgZXhjZXB0OgorICAgICAgICAgICAgIyBSZXNldCB0byAxOTcwLTAxLTAx IDAwOjAwOjAwIFVUQy4KKyAgICAgICAgICAgIGhvc3RfZGF0ZXRpbWUgPSAwCisgICAgICAgIHNl bGYuX3J1bl9hZGJfY29tbWFuZChbJ3NoZWxsJywgJ2RhdGUgLXUgJXMnICUgKGhvc3RfZGF0ZXRp bWUpXSkKKworICAgIGRlZiBfY2hlY2tfdmVyc2lvbihzZWxmLCBkaXIsIHZlcnNpb24pOgorICAg ICAgICBhc3NlcnQoZGlyLmVuZHN3aXRoKCcvJykpCisgICAgICAgIHRyeToKKyAgICAgICAgICAg IGRldmljZV92ZXJzaW9uID0gaW50KHNlbGYuX3J1bl9hZGJfY29tbWFuZChbJ3NoZWxsJywgJ2Nh dCAlc1ZFUlNJT04gfHwgZWNobyAwJyAlIGRpcl0pKQorICAgICAgICAgICAgcmV0dXJuIGRldmlj ZV92ZXJzaW9uID09IHZlcnNpb24KKyAgICAgICAgZXhjZXB0OgorICAgICAgICAgICAgcmV0dXJu IEZhbHNlCisKKyAgICBkZWYgX3J1bl9hZGJfY29tbWFuZChzZWxmLCBjbWQsIGlnbm9yZV9lcnJv cj1GYWxzZSk6CisgICAgICAgIGlmIGlnbm9yZV9lcnJvcjoKKyAgICAgICAgICAgIGVycm9yX2hh bmRsZXIgPSBzZWxmLl9leGVjdXRpdmUuaWdub3JlX2Vycm9yCisgICAgICAgIGVsc2U6CisgICAg ICAgICAgICBlcnJvcl9oYW5kbGVyID0gTm9uZQorICAgICAgICByZXR1cm4gc2VsZi5fZXhlY3V0 aXZlLnJ1bl9jb21tYW5kKHNlbGYuX2FkYl9jb21tYW5kICsgY21kLCBlcnJvcl9oYW5kbGVyPWVy cm9yX2hhbmRsZXIpCisKKyAgICBkZWYgX2NvcHlfZGV2aWNlX2ZpbGUoc2VsZiwgZnJvbV9maWxl LCB0b19maWxlLCBpZ25vcmVfZXJyb3I9RmFsc2UpOgorICAgICAgICAjICdjcCcgaXMgdW5hdmFp bGFibGUgb24gQW5kcm9pZCwgc28gdXNlICdkZCcgaW5zdGVhZC4KKyAgICAgICAgcmV0dXJuIHNl bGYuX3J1bl9hZGJfY29tbWFuZChbJ3NoZWxsJywgJ2RkJywgJ2lmPScgKyBmcm9tX2ZpbGUsICdv Zj0nICsgdG9fZmlsZV0sIGlnbm9yZV9lcnJvcikKKwogICAgIGRlZiBfcHVzaF90b19kZXZpY2Uo c2VsZiwgaG9zdF9wYXRoLCBkZXZpY2VfcGF0aCwgaWdub3JlX2Vycm9yPUZhbHNlKToKICAgICAg ICAgcmV0dXJuIHNlbGYuX3J1bl9hZGJfY29tbWFuZChbJ3B1c2gnLCBob3N0X3BhdGgsIGRldmlj ZV9wYXRoXSwgaWdub3JlX2Vycm9yKQogCg== 127006 2012-02-14 11:32:27 -0800 2012-02-14 11:32:27 -0800 Patch for landing bug-78582-20120214113232.patch text/plain 4635 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNzcxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTAyLTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgRmluaXNoIGltcGxlbWVudGluZyBzdGFydF9oZWxwZXIgZm9yIENocm9taXVtQW5k cm9pZFBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4NTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgVGhp cyBwYXRjaCBjb250YWlucyB0aGUgcmVtYWluaW5nIG9kZHMgYW5kIGVuZHMgZm9yIHRoZSBzdGFy dF9oZWxwZXIgZnVuY3Rpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQ b3J0LnN0YXJ0X2hlbHBlcik6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0Ll9zeW5jaHJv bml6ZV9kYXRldGltZSk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0KToKKyAgICAgICAg KENocm9taXVtQW5kcm9pZFBvcnQuX2NoZWNrX3ZlcnNpb24pOgorICAgICAgICAoQ2hyb21pdW1B bmRyb2lkUG9ydC5fcnVuX2FkYl9jb21tYW5kKToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZFBv cnQuX2NvcHlfZGV2aWNlX2ZpbGUpOgorCiAyMDEyLTAyLTE0ICBKb2NoZW4gRWlzaW5nZXIgIDxq b2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gY2hlY2sgdGhhdCB3ZSdy ZSBub3QgcnVubmluZyBtdWx0aXBsZSBtb2RhbCBkaWFsb2dzIGF0IHRoZSBzYW1lIHRpbWUKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5k cm9pZC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkJKHJldmlzaW9uIDEwNzcxNykKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weQkod29y a2luZyBjb3B5KQpAQCAtNDcsNiArNDcsMjEgQEAgREVWSUNFX0RSVF9TVERFUlIgPSBERVZJQ0Vf RFJUX0RJUiArICdEdQogREVWSUNFX0ZPUldBUkRFUl9QQVRIID0gREVWSUNFX0RSVF9ESVIgKyAn Zm9yd2FyZGVyJwogREVWSUNFX0RSVF9TVEFNUF9QQVRIID0gREVWSUNFX0RSVF9ESVIgKyAnRHVt cFJlbmRlclRyZWUuc3RhbXAnCiAKKyMgVGhpcyBvbmx5IHdvcmtzIGZvciBzaW5nbGUgY29yZSBk ZXZpY2VzIHNvIGZhci4KKyMgRklYTUU6IEZpbmQgYSBzb2x1dGlvbiBmb3IgbXVsdGktY29yZSBk ZXZpY2VzLgorU0NBTElOR19HT1ZFUk5PUiA9ICIvc3lzL2RldmljZXMvc3lzdGVtL2NwdS9jcHUw L2NwdWZyZXEvc2NhbGluZ19nb3Zlcm5vciIKKworIyBBbGwgdGhlIHRlc3QgY2FzZXMgYXJlIHN0 aWxsIHNlcnZlZCB0byBEdW1wUmVuZGVyVHJlZSB0aHJvdWdoIGZpbGUgcHJvdG9jb2wsCisjIGJ1 dCB3ZSB1c2UgYSBmaWxlLXRvLWh0dHAgZmVhdHVyZSB0byBicmlkZ2UgdGhlIGZpbGUgcmVxdWVz dCB0byBob3N0J3MgaHR0cAorIyBzZXJ2ZXIgdG8gZ2V0IHRoZSByZWFsIHRlc3QgZmlsZXMgYW5k IGNvcnJlc3BvbmRpbmcgcmVzb3VyY2VzLgorVEVTVF9QQVRIX1BSRUZJWCA9ICcvYWxsLXRlc3Rz JworCisjIEFsbCBwb3J0cyB0aGUgQW5kcm9pZCBmb3J3YXJkZXIgdG8gZm9yd2FyZC4KKyMgODAw MCwgODA4MCBhbmQgODQ0MyBhcmUgZm9yIGh0dHAvaHR0cHMgdGVzdHMuCisjIDg4ODAgYW5kIDkz MjMgYXJlIGZvciB3ZWJzb2NrZXQgdGVzdHMKKyMgKHNlZSBodHRwX3NlcnZlci5weSwgYXBhY2hl X2h0dHBfc2VydmVyLnB5IGFuZCB3ZWJzb2NrZXRfc2VydmVyLnB5KS4KK0ZPUldBUkRfUE9SVFMg PSAnODAwMCA4MDgwIDg0NDMgODg4MCA5MzIzJworCiBNU19UUlVFVFlQRV9GT05UU19ESVIgPSAn L3Vzci9zaGFyZS9mb250cy90cnVldHlwZS9tc3R0Y29yZWZvbnRzLycKIAogIyBMaXN0IG9mIGZv bnRzIHRoYXQgbGF5b3V0IHRlc3RzIGV4cGVjdCwgY29waWVkIGZyb20gRHVtcFJlbmRlclRyZWUv Z3RrL1Rlc3RTaGVsbEd0ay5jcHAuCkBAIC0xOTQsNiArMjA5LDEzIEBAIGNsYXNzIENocm9taXVt QW5kcm9pZFBvcnQoY2hyb21pdW0uQ2hyb20KICAgICAgICAgc2VsZi5fcHVzaF9leGVjdXRhYmxl KCkKICAgICAgICAgc2VsZi5fcHVzaF9mb250cygpCiAgICAgICAgIHNlbGYuX3NldHVwX3N5c3Rl bV9mb250X2Zvcl90ZXN0KCkKKyAgICAgICAgc2VsZi5fc3luY2hyb25pemVfZGF0ZXRpbWUoKQor CisgICAgICAgICMgU3RhcnQgdGhlIEhUVFAgc2VydmVyIHNvIHRoYXQgdGhlIGRldmljZSBjYW4g YWNjZXNzIHRoZSB0ZXN0IGNhc2VzLgorICAgICAgICBjaHJvbWl1bS5DaHJvbWl1bVBvcnQuc3Rh cnRfaHR0cF9zZXJ2ZXIoc2VsZiwgYWRkaXRpb25hbF9kaXJzPXtURVNUX1BBVEhfUFJFRklYOiBz ZWxmLmxheW91dF90ZXN0c19kaXIoKX0pCisKKyAgICAgICAgX2xvZy5kZWJ1ZygnU3RhcnRpbmcg Zm9yd2FyZGVyJykKKyAgICAgICAgY21kID0gc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwn LCAnJXMgJXMnICUgKERFVklDRV9GT1JXQVJERVJfUEFUSCwgRk9SV0FSRF9QT1JUUyldKQogCiAg ICAgZGVmIHN0b3BfaGVscGVyKHNlbGYpOgogICAgICAgICBzZWxmLl9yZXN0b3JlX3N5c3RlbV9m b250KCkKQEAgLTI4OCw2ICszMTAsMzYgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydChjaHJv bWl1bS5DaHJvbQogICAgICAgICBmb3IgcmVzb3VyY2UgaW4gVEVTVF9SRVNPVVJDRVNfVE9fUFVT SDoKICAgICAgICAgICAgIHNlbGYuX3B1c2hfdG9fZGV2aWNlKHNlbGYubGF5b3V0X3Rlc3RzX2Rp cigpICsgJy8nICsgcmVzb3VyY2UsIERFVklDRV9MQVlPVVRfVEVTVFNfRElSICsgcmVzb3VyY2Up CiAKKyAgICBkZWYgX3N5bmNocm9uaXplX2RhdGV0aW1lKHNlbGYpOgorICAgICAgICAjIFRoZSBk YXRlL3RpbWUgYmV0d2VlbiBob3N0IGFuZCBkZXZpY2UgbWF5IG5vdCBiZSBzeW5jaHJvbml6ZWQu CisgICAgICAgICMgV2UgbmVlZCB0byBtYWtlIHRoZW0gc3luY2hyb25pemVkLCBvdGhlcndpc2Ug dGVzdHMgbWlnaHQgZmFpbC4KKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgIyBHZXQgc2Vjb25k cyBzaW5jZSAxOTcwLTAxLTAxIDAwOjAwOjAwIFVUQy4KKyAgICAgICAgICAgIGhvc3RfZGF0ZXRp bWUgPSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWydkYXRlJywgJy11JywgJyslcyddKQor ICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICAjIFJlc2V0IHRvIDE5NzAtMDEtMDEgMDA6MDA6 MDAgVVRDLgorICAgICAgICAgICAgaG9zdF9kYXRldGltZSA9IDAKKyAgICAgICAgc2VsZi5fcnVu X2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnZGF0ZSAtdSAlcycgJSAoaG9zdF9kYXRldGltZSldKQor CisgICAgZGVmIF9jaGVja192ZXJzaW9uKHNlbGYsIGRpciwgdmVyc2lvbik6CisgICAgICAgIGFz c2VydChkaXIuZW5kc3dpdGgoJy8nKSkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgZGV2aWNl X3ZlcnNpb24gPSBpbnQoc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnY2F0ICVzVkVS U0lPTiB8fCBlY2hvIDAnICUgZGlyXSkpCisgICAgICAgICAgICByZXR1cm4gZGV2aWNlX3ZlcnNp b24gPT0gdmVyc2lvbgorICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICByZXR1cm4gRmFsc2UK KworICAgIGRlZiBfcnVuX2FkYl9jb21tYW5kKHNlbGYsIGNtZCwgaWdub3JlX2Vycm9yPUZhbHNl KToKKyAgICAgICAgaWYgaWdub3JlX2Vycm9yOgorICAgICAgICAgICAgZXJyb3JfaGFuZGxlciA9 IHNlbGYuX2V4ZWN1dGl2ZS5pZ25vcmVfZXJyb3IKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAg IGVycm9yX2hhbmRsZXIgPSBOb25lCisgICAgICAgIHJldHVybiBzZWxmLl9leGVjdXRpdmUucnVu X2NvbW1hbmQoc2VsZi5fYWRiX2NvbW1hbmQgKyBjbWQsIGVycm9yX2hhbmRsZXI9ZXJyb3JfaGFu ZGxlcikKKworICAgIGRlZiBfY29weV9kZXZpY2VfZmlsZShzZWxmLCBmcm9tX2ZpbGUsIHRvX2Zp bGUsIGlnbm9yZV9lcnJvcj1GYWxzZSk6CisgICAgICAgICMgJ2NwJyBpcyB1bmF2YWlsYWJsZSBv biBBbmRyb2lkLCBzbyB1c2UgJ2RkJyBpbnN0ZWFkLgorICAgICAgICByZXR1cm4gc2VsZi5fcnVu X2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnZGQnLCAnaWY9JyArIGZyb21fZmlsZSwgJ29mPScgKyB0 b19maWxlXSwgaWdub3JlX2Vycm9yKQorCiAgICAgZGVmIF9wdXNoX3RvX2RldmljZShzZWxmLCBo b3N0X3BhdGgsIGRldmljZV9wYXRoLCBpZ25vcmVfZXJyb3I9RmFsc2UpOgogICAgICAgICByZXR1 cm4gc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsncHVzaCcsIGhvc3RfcGF0aCwgZGV2aWNlX3BhdGhd LCBpZ25vcmVfZXJyb3IpCiAK