<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78565</bug_id>
          
          <creation_ts>2012-02-13 19:12:20 -0800</creation_ts>
          <short_desc>webkitpy: create ports in Workers, not in manager_worker_broker</short_desc>
          <delta_ts>2019-05-02 16:23:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>78171</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>ojan</cc>
    
    <cc>oscar.underground.oscar</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>555872</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-13 19:12:20 -0800</bug_when>
    <thetext>webkitpy: create ports in Workers, not in manager_worker_broker</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555873</commentid>
    <comment_count>1</comment_count>
      <attachid>126888</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-13 19:14:58 -0800</bug_when>
    <thetext>Created attachment 126888
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555876</commentid>
    <comment_count>2</comment_count>
      <attachid>126889</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-13 19:16:15 -0800</bug_when>
    <thetext>Created attachment 126889
add comment about the change in run_webkit_tests.py</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555882</commentid>
    <comment_count>3</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-13 19:29:11 -0800</bug_when>
    <thetext>Tony, can you take a look?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556414</commentid>
    <comment_count>4</comment_count>
      <attachid>126889</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-02-14 11:03:02 -0800</bug_when>
    <thetext>Comment on attachment 126889
add comment about the change in run_webkit_tests.py

View in context: https://bugs.webkit.org/attachment.cgi?id=126889&amp;action=review

&gt; Tools/ChangeLog:13
&gt; +        bug 78171.
&gt; +
&gt; +        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

Is this covered by existing tests? Please name the tests that cover this in the ChangeLog.

&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:90
&gt; +            # we are running in a child process and need to create a new Host.

Nit: Capitalize &apos;we&apos;.

&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:97
&gt; +            host._initialize_scm()

For my education, do we always have to call _initialize_scm() on host objects?  I noticed that running layout tests always calls this, which runs svn and git to determine the checkout type, even though we never use the information (e.g., if all the tests pass).  It&apos;s slow on my Windows machine.

&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:107
&gt; +            # FIXME: this won&apos;t work if the calling process is logging

Nit: Capitalize &apos;this&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556418</commentid>
    <comment_count>5</comment_count>
      <attachid>126889</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-14 11:10:01 -0800</bug_when>
    <thetext>Comment on attachment 126889
add comment about the change in run_webkit_tests.py

View in context: https://bugs.webkit.org/attachment.cgi?id=126889&amp;action=review

&gt;&gt; Tools/ChangeLog:13
&gt;&gt; +        * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
&gt; 
&gt; Is this covered by existing tests? Please name the tests that cover this in the ChangeLog.

Yes, this is well-covered by run_webkit_tests_integrationtest.py; will note that.

&gt;&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:90
&gt;&gt; +            # we are running in a child process and need to create a new Host.
&gt; 
&gt; Nit: Capitalize &apos;we&apos;.

Will do.

&gt;&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:97
&gt;&gt; +            host._initialize_scm()
&gt; 
&gt; For my education, do we always have to call _initialize_scm() on host objects?  I noticed that running layout tests always calls this, which runs svn and git to determine the checkout type, even though we never use the information (e.g., if all the tests pass).  It&apos;s slow on my Windows machine.

You only need to call initialize_scm() if you need to actually access scm/checkout objects. We need this in the manager process in order to properly generate the json result information (although I thought Ojan had patched the code at some point to only do this during that routine). 

I don&apos;t think we need it at all in the child process ... this code was cloned from run_webkit_tests.py, and I will remove it. It is slow.

&gt;&gt; Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:107
&gt;&gt; +            # FIXME: this won&apos;t work if the calling process is logging
&gt; 
&gt; Nit: Capitalize &apos;this&apos;.

Will do.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556438</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-02-14 11:25:52 -0800</bug_when>
    <thetext>Committed r107718: &lt;http://trac.webkit.org/changeset/107718&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556639</commentid>
    <comment_count>7</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-02-14 14:52:24 -0800</bug_when>
    <thetext>When I run &quot;new-run-webkit-tests --pixel --release svg&quot; on the command line, I get:

No handlers could be found for logger &quot;webkitpy.layout_tests.port.mac&quot;
Starting 1 worker ...Process _Process-1:
Traceback (most recent call last):
  File &quot;/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/process.py&quot;, line 231, in _bootstrap
    self.run()
  File &quot;/Users/tc/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py&quot;, line 246, in run
    self._client.run(port=None)
  File &quot;/Users/tc/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py&quot;, line 91, in run
    if &apos;test&apos; in self._options.platform:
TypeError: argument of type &apos;NoneType&apos; is not iterable

Starting testing ...</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126888</attachid>
            <date>2012-02-13 19:14:58 -0800</date>
            <delta_ts>2012-02-13 19:16:09 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78565-20120213191455.patch</filename>
            <type>text/plain</type>
            <size>7952</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NjUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTJlYzY5YzVkYjlhMTliYTM2YzBhNzRmOTA3ZDZiYTcw
NGY0ZjY4NC4uODdmZmIyYjhiZDQ5MWI4YmY5MGRmZmExZjc1YzI4YjI2NDc0YjhiNCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2
IEBACisyMDEyLTAyLTEzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIHdlYmtpdHB5OiBjcmVhdGUgcG9ydHMgaW4gV29ya2Vycywgbm90IGluIG1hbmFnZXJf
d29ya2VyX2Jyb2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9Nzg1NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBXZSB3aWxsIG5vdyBjcmVhdGUgdGhlIFBvcnQgb2JqZWN0IChpZiBuZWNlc3NhcnkpIGlu
IHRoZSBXb3JrZXIKKyAgICAgICAgZGlyZWN0bHksIHNvIHRoYXQgdGhlIG1hbmFnZXJfd29ya2Vy
X2Jyb2tlciBtb2R1bGUgZG9lc24ndCBuZWVkCisgICAgICAgIGFsbCBvZiB0aGlzIGxheW91dF90
ZXN0LXNwZWNpZmljIGxvZ2ljLiBQYXJ0IG9mIHRoZSBmaXhlcyBmb3IKKyAgICAgICAgYnVnIDc4
MTcxLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxl
cnMvbWFuYWdlcl93b3JrZXJfYnJva2VyLnB5OgorICAgICAgICAoX1Byb2Nlc3MucnVuKToKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy93b3JrZXIu
cHk6CisgICAgICAgIChXb3JrZXIuX19pbml0X18pOgorICAgICAgICAoV29ya2VyLnNhZmVfaW5p
dCk6CisgICAgICAgIChXb3JrZXIucnVuKToKKyAgICAgICAgKFdvcmtlci5jbGVhbnVwKToKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5
OgorICAgICAgICAocGFyc2VfYXJncyk6CisgICAgICAgIChtYWluKToKKwogMjAxMi0wMi0xMyAg
QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBlbm91
Z2ggb2YgQ2hyb21pdW1BbmRyb2lkUG9ydCB0byBtYWtlIENocm9taXVtQW5kcm9pZFBvcnRUZXN0
IHBhc3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv
bnRyb2xsZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weQppbmRl
eCAzNDEzNmZmMzc3ODFjOWI4NGE4OWZmMTMxNjgzOGVjYjJhM2RiYTRmLi5jYmI5NGEzYTRhNWFk
MmE4Y2MxOWRiZGNmZTYyNTc5YjQzMDM1YTI3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl
YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dvcmtlcl9icm9rZXIucHkK
KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFu
YWdlcl93b3JrZXJfYnJva2VyLnB5CkBAIC00NywxMiArNDcsNyBAQCBpbXBvcnQgb3B0cGFyc2UK
IGltcG9ydCBRdWV1ZQogaW1wb3J0IHN5cwogCi0jIFRoZXNlIGFyZSBuZWVkZWQgd2hlbiB3b3Jr
ZXJzIGFyZSBsYXVuY2hlZCBpbiBuZXcgY2hpbGQgcHJvY2Vzc2VzLgotZnJvbSB3ZWJraXRweS5j
b21tb24uaG9zdCBpbXBvcnQgSG9zdAotZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdF9tb2NrIGlt
cG9ydCBNb2NrSG9zdAotCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5jb250cm9sbGVycyBp
bXBvcnQgbWVzc2FnZV9icm9rZXIKLWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnZpZXdzIGlt
cG9ydCBwcmludGluZwogCiAKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKQEAg
LTI0OCwzMCArMjQzLDcgQEAgY2xhc3MgX1Byb2Nlc3MobXVsdGlwcm9jZXNzaW5nLlByb2Nlc3Mp
OgogICAgICAgICBzZWxmLl9jbGllbnQgPSBjbGllbnQKIAogICAgIGRlZiBydW4oc2VsZik6Ci0g
ICAgICAgICMgV2UgbmVlZCB0byBjcmVhdGUgYSBuZXcgSG9zdCBvYmplY3QgaGVyZSBiZWNhdXNl
IHRoaXMgaXMKLSAgICAgICAgIyBydW5uaW5nIGluIGEgbmV3IHByb2Nlc3MgYW5kIHdlIGNhbid0
IHJlcXVpcmUgdGhlIHBhcmVudCdzCi0gICAgICAgICMgSG9zdCB0byBiZSBwaWNrbGVhYmxlIGFu
ZCBwYXNzZWQgdG8gdGhlIGNoaWxkLgotICAgICAgICBpZiBzZWxmLl9wbGF0Zm9ybV9uYW1lLnN0
YXJ0c3dpdGgoJ3Rlc3QnKToKLSAgICAgICAgICAgIGhvc3QgPSBNb2NrSG9zdCgpCi0gICAgICAg
IGVsc2U6Ci0gICAgICAgICAgICBob3N0ID0gSG9zdCgpCi0gICAgICAgIGhvc3QuX2luaXRpYWxp
emVfc2NtKCkKLQotICAgICAgICBvcHRpb25zID0gc2VsZi5fb3B0aW9ucwotICAgICAgICBwb3J0
X29iaiA9IGhvc3QucG9ydF9mYWN0b3J5LmdldChzZWxmLl9wbGF0Zm9ybV9uYW1lLCBvcHRpb25z
KQotCi0gICAgICAgICMgVGhlIHVuaXggbXVsdGlwcm9jZXNzaW5nIGltcGxlbWVudGF0aW9uIGNs
b25lcyB0aGUKLSAgICAgICAgIyBsb2cgaGFuZGxlciBjb25maWd1cmF0aW9uIGludG8gdGhlIGNo
aWxkIHByb2Nlc3NlcywKLSAgICAgICAgIyBidXQgdGhlIHdpbiBpbXBsZW1lbnRhdGlvbiBkb2Vz
bid0LgotICAgICAgICBjb25maWd1cmVfbG9nZ2luZyA9IChzeXMucGxhdGZvcm0gPT0gJ3dpbjMy
JykKLQotICAgICAgICAjIEZJWE1FOiB0aGlzIHdvbid0IHdvcmsgaWYgdGhlIGNhbGxpbmcgcHJv
Y2VzcyBpcyBsb2dnaW5nCi0gICAgICAgICMgc29tZXdoZXJlIG90aGVyIHRoYW4gc3lzLnN0ZGVy
ciBhbmQgc3lzLnN0ZG91dCwgYnV0IEknbSBub3Qgc3VyZQotICAgICAgICAjIGlmIHRoaXMgd2ls
bCBiZSBhbiBpc3N1ZSBpbiBwcmFjdGljZS4KLSAgICAgICAgcHJpbnRlciA9IHByaW50aW5nLlBy
aW50ZXIocG9ydF9vYmosIG9wdGlvbnMsIHN5cy5zdGRlcnIsIHN5cy5zdGRvdXQsIGNvbmZpZ3Vy
ZV9sb2dnaW5nKQotICAgICAgICBzZWxmLl9jbGllbnQucnVuKHBvcnRfb2JqKQotICAgICAgICBw
cmludGVyLmNsZWFudXAoKQotCisgICAgICAgIHNlbGYuX2NsaWVudC5ydW4ocG9ydD1Ob25lKQog
CiBjbGFzcyBfTXVsdGlQcm9jZXNzV29ya2VyQ29ubmVjdGlvbihfV29ya2VyQ29ubmVjdGlvbik6
CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGJyb2tlciwgcGxhdGZvcm1fbmFtZSwgd29ya2VyX2Ns
YXNzLCB3b3JrZXJfbnVtYmVyLCByZXN1bHRzX2RpcmVjdG9yeSwgb3B0aW9ucyk6CmRpZmYgLS1n
aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy93b3Jr
ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy93
b3JrZXIucHkKaW5kZXggZmM3ODMxZGZiNjdjNjJkMmNlNTkxYmUxMmE3NTg2MWM4MjljODRjZi4u
NGZlNjQyMGE5MDgxNTU1YTJhYTQyMTFhNjFiYWVjYmFlY2Y1ZmFhZiAxMDA2NDQKLS0tIGEvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvd29ya2VyLnB5Cisr
KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3dvcmtl
ci5weQpAQCAtMzMsMTAgKzMzLDEyIEBAIGltcG9ydCBzeXMKIGltcG9ydCB0aHJlYWRpbmcKIGlt
cG9ydCB0aW1lCiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLmhvc3QgaW1wb3J0IEhvc3QKIGZyb20g
d2Via2l0cHkubGF5b3V0X3Rlc3RzLmNvbnRyb2xsZXJzIGltcG9ydCBtYW5hZ2VyX3dvcmtlcl9i
cm9rZXIKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLmNvbnRyb2xsZXJzIGltcG9ydCBzaW5n
bGVfdGVzdF9ydW5uZXIKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscyBpbXBvcnQg
dGVzdF9leHBlY3RhdGlvbnMKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVscyBpbXBv
cnQgdGVzdF9yZXN1bHRzCitmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy52aWV3cyBpbXBvcnQg
cHJpbnRpbmcKIAogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCkBAIC01NCwx
OCArNTYsMTggQEAgY2xhc3MgV29ya2VyKG1hbmFnZXJfd29ya2VyX2Jyb2tlci5BYnN0cmFjdFdv
cmtlcik6CiAgICAgICAgIHNlbGYuX2RyaXZlciA9IE5vbmUKICAgICAgICAgc2VsZi5fdGVzdHNf
cnVuX2ZpbGUgPSBOb25lCiAgICAgICAgIHNlbGYuX3Rlc3RzX3J1bl9maWxlbmFtZSA9IE5vbmUK
KyAgICAgICAgc2VsZi5fcHJpbnRlciA9IE5vbmUKIAogICAgIGRlZiBfX2RlbF9fKHNlbGYpOgog
ICAgICAgICBzZWxmLmNsZWFudXAoKQogCi0gICAgZGVmIHNhZmVfaW5pdChzZWxmLCBwb3J0KToK
KyAgICBkZWYgc2FmZV9pbml0KHNlbGYpOgogICAgICAgICAiIiJUaGlzIG1ldGhvZCBzaG91bGQg
b25seSBiZSBjYWxsZWQgd2hlbiBpdCBpcyBpcyBzYWZlIGZvciB0aGUgbWl4aW4KICAgICAgICAg
dG8gY3JlYXRlIHN0YXRlIHRoYXQgY2FuJ3QgYmUgUGlja2xlZC4KIAogICAgICAgICBUaGlzIHJv
dXRpbmUgZXhpc3RzIHNvIHRoYXQgdGhlIG1peGluIGNhbiBiZSBjcmVhdGVkIGFuZCB0aGVuIG1h
cnNoYWxlZAogICAgICAgICBhY3Jvc3MgaW50byBhIGNoaWxkIHByb2Nlc3MuIiIiCi0gICAgICAg
IHNlbGYuX3BvcnQgPSBwb3J0Ci0gICAgICAgIHNlbGYuX2ZpbGVzeXN0ZW0gPSBwb3J0Lmhvc3Qu
ZmlsZXN5c3RlbQorICAgICAgICBzZWxmLl9maWxlc3lzdGVtID0gc2VsZi5fcG9ydC5ob3N0LmZp
bGVzeXN0ZW0KICAgICAgICAgc2VsZi5fYmF0Y2hfY291bnQgPSAwCiAgICAgICAgIHNlbGYuX2Jh
dGNoX3NpemUgPSBzZWxmLl9vcHRpb25zLmJhdGNoX3NpemUgb3IgMAogICAgICAgICB0ZXN0c19y
dW5fZmlsZW5hbWUgPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5fcmVzdWx0c19kaXJlY3Rv
cnksICJ0ZXN0c19ydW4lZC50eHQiICUgc2VsZi5fd29ya2VyX251bWJlcikKQEAgLTgyLDcgKzg0
LDMyIEBAIGNsYXNzIFdvcmtlcihtYW5hZ2VyX3dvcmtlcl9icm9rZXIuQWJzdHJhY3RXb3JrZXIp
OgogICAgICAgICByZXR1cm4gc2VsZi5fbmFtZQogCiAgICAgZGVmIHJ1bihzZWxmLCBwb3J0KToK
LSAgICAgICAgc2VsZi5zYWZlX2luaXQocG9ydCkKKyAgICAgICAgaWYgcG9ydDoKKyAgICAgICAg
ICAgIHNlbGYuX3BvcnQgPSBwb3J0CisgICAgICAgIGVsc2U6CisgICAgICAgICAgICAjIHdlIGFy
ZSBydW5uaW5nIGluIGEgY2hpbGQgcHJvY2VzcyBhbmQgbmVlZCB0byBjcmVhdGUgYSBuZXcgSG9z
dC4KKyAgICAgICAgICAgIGlmICd0ZXN0JyBpbiBzZWxmLl9vcHRpb25zLnBsYXRmb3JtOgorICAg
ICAgICAgICAgICAgICMgSXQgaXMgbGFtZSB0byBpbXBvcnQgbW9ja3MgaW50byByZWFsIGNvZGUs
IGJ1dCB0aGlzIGFsbG93cyB1cyB0byB1c2UgdGhlIHRlc3QgcG9ydCBpbiBtdWx0aS1wcm9jZXNz
IHRlc3RzIGFzIHdlbGwuCisgICAgICAgICAgICAgICAgZnJvbSB3ZWJraXRweS5jb21tb24uaG9z
dF9tb2NrIGltcG9ydCBNb2NrSG9zdAorICAgICAgICAgICAgICAgIGhvc3QgPSBNb2NrSG9zdCgp
CisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIGhvc3QgPSBIb3N0KCkKKyAgICAg
ICAgICAgIGhvc3QuX2luaXRpYWxpemVfc2NtKCkKKworICAgICAgICAgICAgb3B0aW9ucyA9IHNl
bGYuX29wdGlvbnMKKyAgICAgICAgICAgIHNlbGYuX3BvcnQgPSBob3N0LnBvcnRfZmFjdG9yeS5n
ZXQob3B0aW9ucy5wbGF0Zm9ybSwgb3B0aW9ucykKKworICAgICAgICAgICAgIyBUaGUgdW5peCBt
dWx0aXByb2Nlc3NpbmcgaW1wbGVtZW50YXRpb24gY2xvbmVzIHRoZQorICAgICAgICAgICAgIyBs
b2cgaGFuZGxlciBjb25maWd1cmF0aW9uIGludG8gdGhlIGNoaWxkIHByb2Nlc3NlcywKKyAgICAg
ICAgICAgICMgYnV0IHRoZSB3aW4gaW1wbGVtZW50YXRpb24gZG9lc24ndC4KKyAgICAgICAgICAg
IGNvbmZpZ3VyZV9sb2dnaW5nID0gKHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInKQorCisgICAgICAg
ICAgICAjIEZJWE1FOiB0aGlzIHdvbid0IHdvcmsgaWYgdGhlIGNhbGxpbmcgcHJvY2VzcyBpcyBs
b2dnaW5nCisgICAgICAgICAgICAjIHNvbWV3aGVyZSBvdGhlciB0aGFuIHN5cy5zdGRlcnIgYW5k
IHN5cy5zdGRvdXQsIGJ1dCBJJ20gbm90IHN1cmUKKyAgICAgICAgICAgICMgaWYgdGhpcyB3aWxs
IGJlIGFuIGlzc3VlIGluIHByYWN0aWNlLgorICAgICAgICAgICAgc2VsZi5fcHJpbnRlciA9IHBy
aW50aW5nLlByaW50ZXIoc2VsZi5fcG9ydCwgb3B0aW9ucywgc3lzLnN0ZGVyciwgc3lzLnN0ZG91
dCwgY29uZmlndXJlX2xvZ2dpbmcpCisKKyAgICAgICAgc2VsZi5zYWZlX2luaXQoKQogCiAgICAg
ICAgIGV4Y2VwdGlvbl9tc2cgPSAiIgogICAgICAgICBfbG9nLmRlYnVnKCIlcyBzdGFydGluZyIg
JSBzZWxmLl9uYW1lKQpAQCAtMTM5LDYgKzE2Niw5IEBAIGNsYXNzIFdvcmtlcihtYW5hZ2VyX3dv
cmtlcl9icm9rZXIuQWJzdHJhY3RXb3JrZXIpOgogICAgICAgICBpZiBzZWxmLl90ZXN0c19ydW5f
ZmlsZToKICAgICAgICAgICAgIHNlbGYuX3Rlc3RzX3J1bl9maWxlLmNsb3NlKCkKICAgICAgICAg
ICAgIHNlbGYuX3Rlc3RzX3J1bl9maWxlID0gTm9uZQorICAgICAgICBpZiBzZWxmLl9wcmludGVy
OgorICAgICAgICAgICAgc2VsZi5fcHJpbnRlci5jbGVhbnVwKCkKKyAgICAgICAgICAgIHNlbGYu
X3ByaW50ZXIgPSBOb25lCiAKICAgICBkZWYgdGltZW91dChzZWxmLCB0ZXN0X2lucHV0KToKICAg
ICAgICAgIiIiQ29tcHV0ZSB0aGUgYXBwcm9wcmlhdGUgdGltZW91dCB2YWx1ZSBmb3IgYSB0ZXN0
LiIiIgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVu
X3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1
bl93ZWJraXRfdGVzdHMucHkKaW5kZXggZTNjNWQyM2YwMzFlNmRlMjliODJiYjg4MTFhZmQ4Mzhk
ZDcxMjYxNS4uNzdhMzQzOGJkNzQ5NTRhMjllZDY1YTNiNjYyNjc2MDQyYzQwNzhjNSAxMDA3NTUK
LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0
cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0
X3Rlc3RzLnB5CkBAIC0xOTgsNyArMTk4LDcgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToK
ICAgICAiIiJQcm92aWRlcyBhIGRlZmF1bHQgc2V0IG9mIGNvbW1hbmQgbGluZSBhcmdzLgogCiAg
ICAgUmV0dXJucyBhIHR1cGxlIG9mIG9wdGlvbnMsIGFyZ3MgZnJvbSBvcHRwYXJzZSIiIgotICAg
IAorCiAgICAgb3B0aW9uX2dyb3VwX2RlZmluaXRpb25zID0gW10KIAogICAgICMgRklYTUU6IEFs
bCBvZiB0aGVzZSBvcHRpb25zIHNob3VsZCBiZSBzdG9yZWQgY2xvc2VyIHRvIHRoZSBjb2RlIHdo
aWNoCkBAIC00NjgsNyArNDY4LDcgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKIAogZGVm
IG1haW4oKToKICAgICBvcHRpb25zLCBhcmdzID0gcGFyc2VfYXJncygpCi0gICAgaWYgb3B0aW9u
cy5wbGF0Zm9ybSBhbmQgb3B0aW9ucy5wbGF0Zm9ybS5zdGFydHN3aXRoKCd0ZXN0Jyk6CisgICAg
aWYgb3B0aW9ucy5wbGF0Zm9ybSBhbmQgJ3Rlc3QnIGluIG9wdGlvbnMucGxhdGZvcm06CiAgICAg
ICAgICMgSXQncyBhIGJpdCBsYW1lIHRvIGltcG9ydCBtb2NrcyBpbnRvIHJlYWwgY29kZSwgYnV0
IHRoaXMgYWxsb3dzIHRoZSB1c2VyCiAgICAgICAgICMgdG8gcnVuIHRlc3RzIGFnYWluc3QgdGhl
IHRlc3QgcGxhdGZvcm0gaW50ZXJhY3RpdmVseSwgd2hpY2ggaXMgdXNlZnVsIGZvcgogICAgICAg
ICAjIGRlYnVnZ2luZyB0ZXN0IGZhaWx1cmVzLgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126889</attachid>
            <date>2012-02-13 19:16:15 -0800</date>
            <delta_ts>2012-02-14 11:10:01 -0800</delta_ts>
            <desc>add comment about the change in run_webkit_tests.py</desc>
            <filename>bug-78565-20120213191612.patch</filename>
            <type>text/plain</type>
            <size>8022</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NjUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTJlYzY5YzVkYjlhMTliYTM2YzBhNzRmOTA3ZDZiYTcw
NGY0ZjY4NC4uMmUyNTVlNWQ2MTJiNDExZThjZWFhYTdiZWE2Y2RhYzczYTBkMTA5NSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2
IEBACisyMDEyLTAyLTEzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIHdlYmtpdHB5OiBjcmVhdGUgcG9ydHMgaW4gV29ya2Vycywgbm90IGluIG1hbmFnZXJf
d29ya2VyX2Jyb2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9Nzg1NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBXZSB3aWxsIG5vdyBjcmVhdGUgdGhlIFBvcnQgb2JqZWN0IChpZiBuZWNlc3NhcnkpIGlu
IHRoZSBXb3JrZXIKKyAgICAgICAgZGlyZWN0bHksIHNvIHRoYXQgdGhlIG1hbmFnZXJfd29ya2Vy
X2Jyb2tlciBtb2R1bGUgZG9lc24ndCBuZWVkCisgICAgICAgIGFsbCBvZiB0aGlzIGxheW91dF90
ZXN0LXNwZWNpZmljIGxvZ2ljLiBQYXJ0IG9mIHRoZSBmaXhlcyBmb3IKKyAgICAgICAgYnVnIDc4
MTcxLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxl
cnMvbWFuYWdlcl93b3JrZXJfYnJva2VyLnB5OgorICAgICAgICAoX1Byb2Nlc3MucnVuKToKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy93b3JrZXIu
cHk6CisgICAgICAgIChXb3JrZXIuX19pbml0X18pOgorICAgICAgICAoV29ya2VyLnNhZmVfaW5p
dCk6CisgICAgICAgIChXb3JrZXIucnVuKToKKyAgICAgICAgKFdvcmtlci5jbGVhbnVwKToKKyAg
ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5
OgorICAgICAgICAocGFyc2VfYXJncyk6CisgICAgICAgIChtYWluKTogRml4IGEgbWlub3IgYnVn
IHdoZXJlIHJ1bm5pbmcgdGhlICdtb2NrLXRlc3QnIHBvcnQgZGlkbid0IHdvcmsgcmlnaHQuCisK
IDIwMTItMDItMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBJ
bXBsZW1lbnQgZW5vdWdoIG9mIENocm9taXVtQW5kcm9pZFBvcnQgdG8gbWFrZSBDaHJvbWl1bUFu
ZHJvaWRQb3J0VGVzdCBwYXNzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh
eW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dvcmtlcl9icm9rZXIucHkgYi9Ub29scy9T
Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dvcmtlcl9i
cm9rZXIucHkKaW5kZXggMzQxMzZmZjM3NzgxYzliODRhODlmZjEzMTY4MzhlY2IyYTNkYmE0Zi4u
Y2JiOTRhM2E0YTVhZDJhOGNjMTlkYmRjZmU2MjU3OWI0MzAzNWEyNyAxMDA3NTUKLS0tIGEvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl93b3Jr
ZXJfYnJva2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv
bnRyb2xsZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weQpAQCAtNDcsMTIgKzQ3LDcgQEAgaW1w
b3J0IG9wdHBhcnNlCiBpbXBvcnQgUXVldWUKIGltcG9ydCBzeXMKIAotIyBUaGVzZSBhcmUgbmVl
ZGVkIHdoZW4gd29ya2VycyBhcmUgbGF1bmNoZWQgaW4gbmV3IGNoaWxkIHByb2Nlc3Nlcy4KLWZy
b20gd2Via2l0cHkuY29tbW9uLmhvc3QgaW1wb3J0IEhvc3QKLWZyb20gd2Via2l0cHkuY29tbW9u
Lmhvc3RfbW9jayBpbXBvcnQgTW9ja0hvc3QKLQogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMu
Y29udHJvbGxlcnMgaW1wb3J0IG1lc3NhZ2VfYnJva2VyCi1mcm9tIHdlYmtpdHB5LmxheW91dF90
ZXN0cy52aWV3cyBpbXBvcnQgcHJpbnRpbmcKIAogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIo
X19uYW1lX18pCkBAIC0yNDgsMzAgKzI0Myw3IEBAIGNsYXNzIF9Qcm9jZXNzKG11bHRpcHJvY2Vz
c2luZy5Qcm9jZXNzKToKICAgICAgICAgc2VsZi5fY2xpZW50ID0gY2xpZW50CiAKICAgICBkZWYg
cnVuKHNlbGYpOgotICAgICAgICAjIFdlIG5lZWQgdG8gY3JlYXRlIGEgbmV3IEhvc3Qgb2JqZWN0
IGhlcmUgYmVjYXVzZSB0aGlzIGlzCi0gICAgICAgICMgcnVubmluZyBpbiBhIG5ldyBwcm9jZXNz
IGFuZCB3ZSBjYW4ndCByZXF1aXJlIHRoZSBwYXJlbnQncwotICAgICAgICAjIEhvc3QgdG8gYmUg
cGlja2xlYWJsZSBhbmQgcGFzc2VkIHRvIHRoZSBjaGlsZC4KLSAgICAgICAgaWYgc2VsZi5fcGxh
dGZvcm1fbmFtZS5zdGFydHN3aXRoKCd0ZXN0Jyk6Ci0gICAgICAgICAgICBob3N0ID0gTW9ja0hv
c3QoKQotICAgICAgICBlbHNlOgotICAgICAgICAgICAgaG9zdCA9IEhvc3QoKQotICAgICAgICBo
b3N0Ll9pbml0aWFsaXplX3NjbSgpCi0KLSAgICAgICAgb3B0aW9ucyA9IHNlbGYuX29wdGlvbnMK
LSAgICAgICAgcG9ydF9vYmogPSBob3N0LnBvcnRfZmFjdG9yeS5nZXQoc2VsZi5fcGxhdGZvcm1f
bmFtZSwgb3B0aW9ucykKLQotICAgICAgICAjIFRoZSB1bml4IG11bHRpcHJvY2Vzc2luZyBpbXBs
ZW1lbnRhdGlvbiBjbG9uZXMgdGhlCi0gICAgICAgICMgbG9nIGhhbmRsZXIgY29uZmlndXJhdGlv
biBpbnRvIHRoZSBjaGlsZCBwcm9jZXNzZXMsCi0gICAgICAgICMgYnV0IHRoZSB3aW4gaW1wbGVt
ZW50YXRpb24gZG9lc24ndC4KLSAgICAgICAgY29uZmlndXJlX2xvZ2dpbmcgPSAoc3lzLnBsYXRm
b3JtID09ICd3aW4zMicpCi0KLSAgICAgICAgIyBGSVhNRTogdGhpcyB3b24ndCB3b3JrIGlmIHRo
ZSBjYWxsaW5nIHByb2Nlc3MgaXMgbG9nZ2luZwotICAgICAgICAjIHNvbWV3aGVyZSBvdGhlciB0
aGFuIHN5cy5zdGRlcnIgYW5kIHN5cy5zdGRvdXQsIGJ1dCBJJ20gbm90IHN1cmUKLSAgICAgICAg
IyBpZiB0aGlzIHdpbGwgYmUgYW4gaXNzdWUgaW4gcHJhY3RpY2UuCi0gICAgICAgIHByaW50ZXIg
PSBwcmludGluZy5QcmludGVyKHBvcnRfb2JqLCBvcHRpb25zLCBzeXMuc3RkZXJyLCBzeXMuc3Rk
b3V0LCBjb25maWd1cmVfbG9nZ2luZykKLSAgICAgICAgc2VsZi5fY2xpZW50LnJ1bihwb3J0X29i
aikKLSAgICAgICAgcHJpbnRlci5jbGVhbnVwKCkKLQorICAgICAgICBzZWxmLl9jbGllbnQucnVu
KHBvcnQ9Tm9uZSkKIAogY2xhc3MgX011bHRpUHJvY2Vzc1dvcmtlckNvbm5lY3Rpb24oX1dvcmtl
ckNvbm5lY3Rpb24pOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBicm9rZXIsIHBsYXRmb3JtX25h
bWUsIHdvcmtlcl9jbGFzcywgd29ya2VyX251bWJlciwgcmVzdWx0c19kaXJlY3RvcnksIG9wdGlv
bnMpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u
dHJvbGxlcnMvd29ya2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv
Y29udHJvbGxlcnMvd29ya2VyLnB5CmluZGV4IGZjNzgzMWRmYjY3YzYyZDJjZTU5MWJlMTJhNzU4
NjFjODI5Yzg0Y2YuLjRmZTY0MjBhOTA4MTU1NWEyYWE0MjExYTYxYmFlY2JhZWNmNWZhYWYgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJz
L3dvcmtlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250
cm9sbGVycy93b3JrZXIucHkKQEAgLTMzLDEwICszMywxMiBAQCBpbXBvcnQgc3lzCiBpbXBvcnQg
dGhyZWFkaW5nCiBpbXBvcnQgdGltZQogCitmcm9tIHdlYmtpdHB5LmNvbW1vbi5ob3N0IGltcG9y
dCBIb3N0CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5jb250cm9sbGVycyBpbXBvcnQgbWFu
YWdlcl93b3JrZXJfYnJva2VyCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5jb250cm9sbGVy
cyBpbXBvcnQgc2luZ2xlX3Rlc3RfcnVubmVyCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5t
b2RlbHMgaW1wb3J0IHRlc3RfZXhwZWN0YXRpb25zCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0
cy5tb2RlbHMgaW1wb3J0IHRlc3RfcmVzdWx0cworZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMu
dmlld3MgaW1wb3J0IHByaW50aW5nCiAKIAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFt
ZV9fKQpAQCAtNTQsMTggKzU2LDE4IEBAIGNsYXNzIFdvcmtlcihtYW5hZ2VyX3dvcmtlcl9icm9r
ZXIuQWJzdHJhY3RXb3JrZXIpOgogICAgICAgICBzZWxmLl9kcml2ZXIgPSBOb25lCiAgICAgICAg
IHNlbGYuX3Rlc3RzX3J1bl9maWxlID0gTm9uZQogICAgICAgICBzZWxmLl90ZXN0c19ydW5fZmls
ZW5hbWUgPSBOb25lCisgICAgICAgIHNlbGYuX3ByaW50ZXIgPSBOb25lCiAKICAgICBkZWYgX19k
ZWxfXyhzZWxmKToKICAgICAgICAgc2VsZi5jbGVhbnVwKCkKIAotICAgIGRlZiBzYWZlX2luaXQo
c2VsZiwgcG9ydCk6CisgICAgZGVmIHNhZmVfaW5pdChzZWxmKToKICAgICAgICAgIiIiVGhpcyBt
ZXRob2Qgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIHdoZW4gaXQgaXMgaXMgc2FmZSBmb3IgdGhlIG1p
eGluCiAgICAgICAgIHRvIGNyZWF0ZSBzdGF0ZSB0aGF0IGNhbid0IGJlIFBpY2tsZWQuCiAKICAg
ICAgICAgVGhpcyByb3V0aW5lIGV4aXN0cyBzbyB0aGF0IHRoZSBtaXhpbiBjYW4gYmUgY3JlYXRl
ZCBhbmQgdGhlbiBtYXJzaGFsZWQKICAgICAgICAgYWNyb3NzIGludG8gYSBjaGlsZCBwcm9jZXNz
LiIiIgotICAgICAgICBzZWxmLl9wb3J0ID0gcG9ydAotICAgICAgICBzZWxmLl9maWxlc3lzdGVt
ID0gcG9ydC5ob3N0LmZpbGVzeXN0ZW0KKyAgICAgICAgc2VsZi5fZmlsZXN5c3RlbSA9IHNlbGYu
X3BvcnQuaG9zdC5maWxlc3lzdGVtCiAgICAgICAgIHNlbGYuX2JhdGNoX2NvdW50ID0gMAogICAg
ICAgICBzZWxmLl9iYXRjaF9zaXplID0gc2VsZi5fb3B0aW9ucy5iYXRjaF9zaXplIG9yIDAKICAg
ICAgICAgdGVzdHNfcnVuX2ZpbGVuYW1lID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuX3Jl
c3VsdHNfZGlyZWN0b3J5LCAidGVzdHNfcnVuJWQudHh0IiAlIHNlbGYuX3dvcmtlcl9udW1iZXIp
CkBAIC04Miw3ICs4NCwzMiBAQCBjbGFzcyBXb3JrZXIobWFuYWdlcl93b3JrZXJfYnJva2VyLkFi
c3RyYWN0V29ya2VyKToKICAgICAgICAgcmV0dXJuIHNlbGYuX25hbWUKIAogICAgIGRlZiBydW4o
c2VsZiwgcG9ydCk6Ci0gICAgICAgIHNlbGYuc2FmZV9pbml0KHBvcnQpCisgICAgICAgIGlmIHBv
cnQ6CisgICAgICAgICAgICBzZWxmLl9wb3J0ID0gcG9ydAorICAgICAgICBlbHNlOgorICAgICAg
ICAgICAgIyB3ZSBhcmUgcnVubmluZyBpbiBhIGNoaWxkIHByb2Nlc3MgYW5kIG5lZWQgdG8gY3Jl
YXRlIGEgbmV3IEhvc3QuCisgICAgICAgICAgICBpZiAndGVzdCcgaW4gc2VsZi5fb3B0aW9ucy5w
bGF0Zm9ybToKKyAgICAgICAgICAgICAgICAjIEl0IGlzIGxhbWUgdG8gaW1wb3J0IG1vY2tzIGlu
dG8gcmVhbCBjb2RlLCBidXQgdGhpcyBhbGxvd3MgdXMgdG8gdXNlIHRoZSB0ZXN0IHBvcnQgaW4g
bXVsdGktcHJvY2VzcyB0ZXN0cyBhcyB3ZWxsLgorICAgICAgICAgICAgICAgIGZyb20gd2Via2l0
cHkuY29tbW9uLmhvc3RfbW9jayBpbXBvcnQgTW9ja0hvc3QKKyAgICAgICAgICAgICAgICBob3N0
ID0gTW9ja0hvc3QoKQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICBob3N0ID0g
SG9zdCgpCisgICAgICAgICAgICBob3N0Ll9pbml0aWFsaXplX3NjbSgpCisKKyAgICAgICAgICAg
IG9wdGlvbnMgPSBzZWxmLl9vcHRpb25zCisgICAgICAgICAgICBzZWxmLl9wb3J0ID0gaG9zdC5w
b3J0X2ZhY3RvcnkuZ2V0KG9wdGlvbnMucGxhdGZvcm0sIG9wdGlvbnMpCisKKyAgICAgICAgICAg
ICMgVGhlIHVuaXggbXVsdGlwcm9jZXNzaW5nIGltcGxlbWVudGF0aW9uIGNsb25lcyB0aGUKKyAg
ICAgICAgICAgICMgbG9nIGhhbmRsZXIgY29uZmlndXJhdGlvbiBpbnRvIHRoZSBjaGlsZCBwcm9j
ZXNzZXMsCisgICAgICAgICAgICAjIGJ1dCB0aGUgd2luIGltcGxlbWVudGF0aW9uIGRvZXNuJ3Qu
CisgICAgICAgICAgICBjb25maWd1cmVfbG9nZ2luZyA9IChzeXMucGxhdGZvcm0gPT0gJ3dpbjMy
JykKKworICAgICAgICAgICAgIyBGSVhNRTogdGhpcyB3b24ndCB3b3JrIGlmIHRoZSBjYWxsaW5n
IHByb2Nlc3MgaXMgbG9nZ2luZworICAgICAgICAgICAgIyBzb21ld2hlcmUgb3RoZXIgdGhhbiBz
eXMuc3RkZXJyIGFuZCBzeXMuc3Rkb3V0LCBidXQgSSdtIG5vdCBzdXJlCisgICAgICAgICAgICAj
IGlmIHRoaXMgd2lsbCBiZSBhbiBpc3N1ZSBpbiBwcmFjdGljZS4KKyAgICAgICAgICAgIHNlbGYu
X3ByaW50ZXIgPSBwcmludGluZy5QcmludGVyKHNlbGYuX3BvcnQsIG9wdGlvbnMsIHN5cy5zdGRl
cnIsIHN5cy5zdGRvdXQsIGNvbmZpZ3VyZV9sb2dnaW5nKQorCisgICAgICAgIHNlbGYuc2FmZV9p
bml0KCkKIAogICAgICAgICBleGNlcHRpb25fbXNnID0gIiIKICAgICAgICAgX2xvZy5kZWJ1Zygi
JXMgc3RhcnRpbmciICUgc2VsZi5fbmFtZSkKQEAgLTEzOSw2ICsxNjYsOSBAQCBjbGFzcyBXb3Jr
ZXIobWFuYWdlcl93b3JrZXJfYnJva2VyLkFic3RyYWN0V29ya2VyKToKICAgICAgICAgaWYgc2Vs
Zi5fdGVzdHNfcnVuX2ZpbGU6CiAgICAgICAgICAgICBzZWxmLl90ZXN0c19ydW5fZmlsZS5jbG9z
ZSgpCiAgICAgICAgICAgICBzZWxmLl90ZXN0c19ydW5fZmlsZSA9IE5vbmUKKyAgICAgICAgaWYg
c2VsZi5fcHJpbnRlcjoKKyAgICAgICAgICAgIHNlbGYuX3ByaW50ZXIuY2xlYW51cCgpCisgICAg
ICAgICAgICBzZWxmLl9wcmludGVyID0gTm9uZQogCiAgICAgZGVmIHRpbWVvdXQoc2VsZiwgdGVz
dF9pbnB1dCk6CiAgICAgICAgICIiIkNvbXB1dGUgdGhlIGFwcHJvcHJpYXRlIHRpbWVvdXQgdmFs
dWUgZm9yIGEgdGVzdC4iIiIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5
b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh
eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGUzYzVkMjNmMDMxZTZkZTI5Yjgy
YmI4ODExYWZkODM4ZGQ3MTI2MTUuLjc3YTM0MzhiZDc0OTU0YTI5ZWQ2NWEzYjY2MjY3NjA0MmM0
MDc4YzUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1
bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz
dHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMTk4LDcgKzE5OCw3IEBAIGRlZiBwYXJzZV9hcmdz
KGFyZ3M9Tm9uZSk6CiAgICAgIiIiUHJvdmlkZXMgYSBkZWZhdWx0IHNldCBvZiBjb21tYW5kIGxp
bmUgYXJncy4KIAogICAgIFJldHVybnMgYSB0dXBsZSBvZiBvcHRpb25zLCBhcmdzIGZyb20gb3B0
cGFyc2UiIiIKLSAgICAKKwogICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucyA9IFtdCiAKICAg
ICAjIEZJWE1FOiBBbGwgb2YgdGhlc2Ugb3B0aW9ucyBzaG91bGQgYmUgc3RvcmVkIGNsb3NlciB0
byB0aGUgY29kZSB3aGljaApAQCAtNDY4LDcgKzQ2OCw3IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9
Tm9uZSk6CiAKIGRlZiBtYWluKCk6CiAgICAgb3B0aW9ucywgYXJncyA9IHBhcnNlX2FyZ3MoKQot
ICAgIGlmIG9wdGlvbnMucGxhdGZvcm0gYW5kIG9wdGlvbnMucGxhdGZvcm0uc3RhcnRzd2l0aCgn
dGVzdCcpOgorICAgIGlmIG9wdGlvbnMucGxhdGZvcm0gYW5kICd0ZXN0JyBpbiBvcHRpb25zLnBs
YXRmb3JtOgogICAgICAgICAjIEl0J3MgYSBiaXQgbGFtZSB0byBpbXBvcnQgbW9ja3MgaW50byBy
ZWFsIGNvZGUsIGJ1dCB0aGlzIGFsbG93cyB0aGUgdXNlcgogICAgICAgICAjIHRvIHJ1biB0ZXN0
cyBhZ2FpbnN0IHRoZSB0ZXN0IHBsYXRmb3JtIGludGVyYWN0aXZlbHksIHdoaWNoIGlzIHVzZWZ1
bCBmb3IKICAgICAgICAgIyBkZWJ1Z2dpbmcgdGVzdCBmYWlsdXJlcy4K
</data>
<flag name="review"
          id="128844"
          type_id="1"
          status="+"
          setter="tony"
    />
          </attachment>
      

    </bug>

</bugzilla>