78560 2012-02-13 18:27:41 -0800 The tile cache layer should have its background set to the page background 2012-02-14 15:46:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 555841 0 andersca 2012-02-13 18:27:41 -0800 The tile cache layer should have its background set to the page background 555843 1 126883 andersca 2012-02-13 18:29:34 -0800 Created attachment 126883 Patch 555844 2 andersca 2012-02-13 18:36:24 -0800 Committed r107657: <http://trac.webkit.org/changeset/107657> 556714 3 126883 darin 2012-02-14 15:46:19 -0800 Comment on attachment 126883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126883&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:1658 > + if (!backgroundColor.isValid() || backgroundColor.hasAlpha()) The isValid check is redundant because invalid colors always have alpha of 0 so return true for hasAlpha. 126883 2012-02-13 18:29:34 -0800 2012-02-14 15:46:19 -0800 Patch bug-78560-20120213183015.patch text/plain 4847 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBiMDUyZjA2ZWEyNDIw ODUxZDdjMjE0MGE5N2UzMzgyMjhjYjAwMC4uOGJjOTE2NTQxZjEzODdlNjZjMjA2NzQ2NWQ0MWE2 YWM2MDk1ZWJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTAyLTEzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgVGhlIHRpbGUgY2Fj aGUgbGF5ZXIgc2hvdWxkIGhhdmUgaXRzIGJhY2tncm91bmQgc2V0IHRvIHRoZSBwYWdlIGJhY2tn cm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4 NTYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDg1NzQ3Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cmVjYWxjdWxhdGVTY3JvbGxiYXJPdmVybGF5U3R5 bGUpOgorICAgICAgICBJbmZvcm0gdGhlIFJlbmRlckxheWVyQ29tcG9zaXRvciB0aGF0IHRoZSBi YWNrZ3JvdW5kIGNvbG9yIGhhcyBjaGFuZ2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5 ZXJDQTo6dXBkYXRlTGF5ZXJCYWNrZ3JvdW5kQ29sb3IpOgorICAgICAgICBGb3IgdGlsZSBjYWNo ZSBsYXllcnMgd2UgZG9uJ3QgbmVlZCBhIHNlcGFyYXRlIGNvbnRlbnRzIGxheWVyIGZvciB0aGUg YmFja2dyb3VuZCBjb2xvciBzbworICAgICAgICBqdXN0IHNldCB0aGUgYmFja2dyb3VuZCBjb2xv ciBvbiB0aGUgbGF5ZXIgZGlyZWN0bHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRv cjo6ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3JEaWRDaGFuZ2UpOgorICAgICAgICBJZiB0aGUgcm9v dCByZW5kZXIgbGF5ZXIgaXMgdXNpbmcgYSB0aWxlIGNhY2hlIGxheWVyLCB1cGRhdGUgaXRzIGJh Y2tncm91bmQgY29sb3IuCisKKzIwMTItMDItMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBGb3JjZSBzbG93LXNjcm9sbGluZyBtb2RlIHdoZW4gdGhl cmUgYXJlIHBvc2l0aW9uOmZpeGVkIGVsZW1lbnRzIG9uIGEgcGFnZQogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1NTMKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzEwMjQ3OTM0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGM0MDI3ZTBl NTY0MjBiYjcyOGU0MjU5NTVlMjg4N2FiMjk4YjE2MTIuLjgzYjY0NDBlMjdiZDFhYWNmNTcwODc4 YTJkOTY3NmFlZTFmZmM4YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTMyNyw2 ICszMjcsMTMgQEAgdm9pZCBGcmFtZVZpZXc6OnJlY2FsY3VsYXRlU2Nyb2xsYmFyT3ZlcmxheVN0 eWxlKCkKICAgICBTY3JvbGxiYXJPdmVybGF5U3R5bGUgb3ZlcmxheVN0eWxlID0gU2Nyb2xsYmFy T3ZlcmxheVN0eWxlRGVmYXVsdDsKIAogICAgIENvbG9yIGJhY2tncm91bmRDb2xvciA9IGRvY3Vt ZW50QmFja2dyb3VuZENvbG9yKCk7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQor ICAgIGlmIChSZW5kZXJWaWV3KiByb290ID0gcm9vdFJlbmRlcmVyKHRoaXMpKSB7CisgICAgICAg IFJlbmRlckxheWVyQ29tcG9zaXRvciogY29tcG9zaXRvciA9IHJvb3QtPmNvbXBvc2l0b3IoKTsK KyAgICAgICAgY29tcG9zaXRvci0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3JEaWRDaGFuZ2UoKTsK KyAgICB9CisjZW5kaWYKKwogICAgIGlmIChiYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpKSB7CiAg ICAgICAgIC8vIFJlZHVjZSB0aGUgYmFja2dyb3VuZCBjb2xvciBmcm9tIFJHQiB0byBhIGxpZ2h0 bmVzcyB2YWx1ZQogICAgICAgICAvLyBhbmQgZGV0ZXJtaW5lIHdoaWNoIHNjcm9sbGJhciBzdHls ZSB0byB1c2UgYmFzZWQgb24gYSBsaWdodG5lc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCmluZGV4IDNmNzE3Y2U3 ODQ1ODY4NGNiYmNlOTMyOTQyNGFiMWRiOTM2N2U4NWIuLmY2ZTcxNGIyYTkzMTgxODZhODgwZjk5 MGMwZWU1OTQ1NGM5M2U2MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcApAQCAtMTQzOCw2ICsxNDM4LDExIEBA IHZvaWQgR3JhcGhpY3NMYXllckNBOjp1cGRhdGVBY2NlbGVyYXRlc0RyYXdpbmcoKQogICAgIAog dm9pZCBHcmFwaGljc0xheWVyQ0E6OnVwZGF0ZUxheWVyQmFja2dyb3VuZENvbG9yKCkKIHsKKyAg ICBpZiAobV9sYXllci0+bGF5ZXJUeXBlKCkgPT0gUGxhdGZvcm1DQUxheWVyOjpMYXllclR5cGVU aWxlQ2FjaGVMYXllcikgeworICAgICAgICBtX2xheWVyLT5zZXRCYWNrZ3JvdW5kQ29sb3IobV9i YWNrZ3JvdW5kQ29sb3IpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgaWYgKCFtX2Nv bnRlbnRzTGF5ZXIpCiAgICAgICAgIHJldHVybjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBiMGZkNzBhYzNhZDQzNzQy MzE2MDQ3NmMzMzQ5Mzc3NzI1MDJhMWMyLi5lY2JlNDRmZTE2NmMzNDU1ODdjOTFlMTM5M2VhZjk3 Yzg2ODE1NTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcApAQCAtMTY0NCw2ICsxNjQ0LDIzIEBAIHZvaWQgUmVuZGVyTGF5ZXJD b21wb3NpdG9yOjpwYWludENvbnRlbnRzKGNvbnN0IEdyYXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5 ZXIsIEdyCiAgICAgfQogfQogCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZG9jdW1lbnRC YWNrZ3JvdW5kQ29sb3JEaWRDaGFuZ2UoKQoreworICAgIFJlbmRlckxheWVyQmFja2luZyogYmFj a2luZyA9IHJvb3RSZW5kZXJMYXllcigpLT5iYWNraW5nKCk7CisgICAgaWYgKCFiYWNraW5nKQor ICAgICAgICByZXR1cm47CisKKyAgICBHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyID0gYmFj a2luZy0+Z3JhcGhpY3NMYXllcigpOworICAgIGlmICghZ3JhcGhpY3NMYXllci0+Y2xpZW50KCkt PnNob3VsZFVzZVRpbGVDYWNoZShncmFwaGljc0xheWVyKSkKKyAgICAgICAgcmV0dXJuOworCisg ICAgQ29sb3IgYmFja2dyb3VuZENvbG9yID0gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZG9j dW1lbnRCYWNrZ3JvdW5kQ29sb3IoKTsKKyAgICBpZiAoIWJhY2tncm91bmRDb2xvci5pc1ZhbGlk KCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0FscGhhKCkpCisgICAgICAgIGJhY2tncm91bmRDb2xv ciA9IENvbG9yOjp3aGl0ZTsKKworICAgIGdyYXBoaWNzTGF5ZXItPnNldEJhY2tncm91bmRDb2xv cihiYWNrZ3JvdW5kQ29sb3IpOworfQorCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c2hv d0RlYnVnQm9yZGVycyhjb25zdCBHcmFwaGljc0xheWVyKiBsYXllcikgY29uc3QKIHsKICAgICBp ZiAobGF5ZXIgPT0gbV9sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIgfHwgbGF5ZXIgPT0gbV9s YXllckZvclZlcnRpY2FsU2Nyb2xsYmFyIHx8IGxheWVyID09IG1fbGF5ZXJGb3JTY3JvbGxDb3Ju ZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmgKaW5kZXggMDA1MThmM2RmODFiY2ZhNmI1YTEwMWM4N2RiOWI4OTMwNjYxZTFjNC4uYzlhYWI5 MjFiYzJmZmFhODYxMTNkYzA1NDk1M2YxY2NmZTM1NmY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMjA5LDYgKzIwOSw4IEBA IHB1YmxpYzoKICAgICBHcmFwaGljc0xheWVyKiBsYXllckZvck92ZXJoYW5nQXJlYXMoKSBjb25z dCB7IHJldHVybiBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcy5nZXQoKTsgfQogI2VuZGlmCiAKKyAg ICB2b2lkIGRvY3VtZW50QmFja2dyb3VuZENvbG9yRGlkQ2hhbmdlKCk7CisKIHByaXZhdGU6CiAg ICAgLy8gR3JhcGhpY3NMYXllckNsaWVudCBJbXBsZW1lbnRhdGlvbgogICAgIHZpcnR1YWwgdm9p ZCBub3RpZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IEdyYXBoaWNzTGF5ZXIqLCBkb3VibGUpIHsg fQo=