78552 2012-02-13 16:54:22 -0800 SharedBuffer's Vector<RetainPtr<CFDataRef> > should have a typedef 2019-08-07 11:51:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED EasyFix P2 Normal --- 1 benjamin webkit-unassigned benjamin ddkilzer oldest_to_newest 555767 0 benjamin 2012-02-13 16:54:22 -0800 From https://bugs.webkit.org/show_bug.cgi?id=77718 > Source/WebCore/platform/cf/SharedBufferCF.cpp:121 > + Vector<RetainPtr<CFDataRef> >::const_iterator end = m_dataArray.end(); Nit: Might be nice to have a typedef for Vector<RetainPtr<CFDataRef> >. 1559226 1 ddkilzer 2019-08-07 11:51:34 -0700 SharedBufferCF.cpp no longer has this code, and the only data structure it iterates over: mutable DataSegmentVector m_segments; Already has the equivalent of a typedef: using DataSegmentVector = Vector<DataSegmentVectorEntry, 1>; DataSegmentVector::const_iterator begin() const { return m_segments.begin(); } DataSegmentVector::const_iterator end() const { return m_segments.end(); } So moving to RESOLVED/CONFIGURATION CHANGED.