78540 2012-02-13 14:39:38 -0800 Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder 2012-02-14 00:16:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth noel.gordon satish webkit.review.bot oldest_to_newest 555615 0 eric 2012-02-13 14:39:38 -0800 Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder 555617 1 126839 eric 2012-02-13 14:40:18 -0800 Created attachment 126839 Patch 555619 2 eric 2012-02-13 14:41:17 -0800 Someone with familiarity of Skia and the JPEGEncoder should look at this and make sure it's sane. 555625 3 126839 abarth 2012-02-13 14:44:29 -0800 Comment on attachment 126839 Patch Looks reasonable. Noel should double-check. 555637 4 126839 eric 2012-02-13 14:49:46 -0800 Comment on attachment 126839 Patch I'd like to wait for his comment before landing. Would hate to land useless code. :) 555651 5 noel.gordon 2012-02-13 15:05:04 -0800 Looks sane tome. 555654 6 126839 abarth 2012-02-13 15:07:49 -0800 Comment on attachment 126839 Patch Thanks Noel. 556032 7 noel.gordon 2012-02-14 00:07:01 -0800 np, and sane because the little-endian skia-using ports (chrome) use BGRA skia bitmaps, except chrome android where RGBA skia bitmaps are in vogue for some reason - see jpeg decoder fix bug 75861. 556041 8 126839 webkit.review.bot 2012-02-14 00:16:53 -0800 Comment on attachment 126839 Patch Clearing flags on attachment: 126839 Committed r107679: <http://trac.webkit.org/changeset/107679> 556042 9 webkit.review.bot 2012-02-14 00:16:57 -0800 All reviewed patches have been landed. Closing bug. 126839 2012-02-13 14:40:18 -0800 2012-02-14 00:16:53 -0800 Patch bug-78540-20120213144021.patch text/plain 1444 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTMwNzYyYmU4ZjJhYzJm OTYzZjMyYzEyYTZmMWRkMjZkYmQ1NTRhMS4uMGEyNDE2ZjYwYzE5M2ZmMjE2NDJhMjY2MDA1NjQ3 YmQ5YjZiNjA2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAyLTEzICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBVcHN0cmVhbSBBbmRyb2lkJ3Mg c3VwcG9ydCBmb3IgU0tfQjMyX1NISUZUIHRvIEpQRUdJbWFnZUVuY29kZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NTQwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1lbmNv ZGVycy9za2lhL0pQRUdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZW5jb2Rl UGl4ZWxzKToKKwogMjAxMi0wMi0wNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBVc2UgQ01DbG9jayBhcyBhIHRpbWluZyBzb3VyY2UgZm9yIFBsYXRmb3JtQ2xv Y2sgd2hlcmUgYXZhaWxhYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvc2tpYS9KUEVHSW1hZ2VFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rlci5jcHAKaW5kZXgg MDFiMGRjNWE0NjZiZTk3ODA0Zjg3N2U2ZDQyYTRkNDdmMzMwNjVjZC4uZWIzMzQxY2M1MzE2Yzk2 YzA1ZWU0N2IyYjFkNjhhZGJmNDUxYThjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9KUEVHSW1hZ2VFbmNvZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL0pQRUdJbWFnZUVuY29kZXIu Y3BwCkBAIC0xMzYsNyArMTM2LDggQEAgc3RhdGljIGJvb2wgZW5jb2RlUGl4ZWxzKEludFNpemUg aW1hZ2VTaXplLCB1bnNpZ25lZCBjaGFyKiBpbnB1dFBpeGVscywgYm9vbCBwcmUKIAogI2lmIGRl ZmluZWQoSkNTX0VYVEVOU0lPTlMpCiAgICAgaWYgKHByZW11bHRpcGxpZWQpIHsKLSAgICAgICAg Y2luZm8uaW5fY29sb3Jfc3BhY2UgPSBKQ1NfRVhUX0JHUlg7CisgICAgICAgIGNpbmZvLmluX2Nv bG9yX3NwYWNlID0gU0tfQjMyX1NISUZUID8gSkNTX0VYVF9SR0JYIDogSkNTX0VYVF9CR1JYOwor CiAgICAgICAgIGNpbmZvLmlucHV0X2NvbXBvbmVudHMgPSA0OwogCiAgICAgICAgIGpwZWdfc2V0 X2RlZmF1bHRzKCZjaW5mbyk7Cg==