7854 2006-03-18 20:52:54 -0800 CanvasGradient leaks 2006-03-19 23:22:18 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 darin darin oldest_to_newest 36890 0 darin 2006-03-18 20:52:54 -0800 With my recent changes, I introduced a leak of the canvas gradient object. 36891 1 7167 darin 2006-03-18 20:56:31 -0800 Created attachment 7167 patch with detailed change log 36970 2 7167 eric 2006-03-19 22:14:33 -0800 Comment on attachment 7167 patch with detailed change log Looks good. Eventually it would be nice to merge some of this code with the SVG code. Probably more of making the SVG gradient code sit on top of this stuff. 7167 2006-03-18 20:56:31 -0800 2006-03-19 22:14:33 -0800 patch with detailed change log CanvasGradientLeakPatch.txt text/plain 1991 darin SW5kZXg6IGh0bWwvQ2FudmFzR3JhZGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGh0bWwvQ2FudmFz R3JhZGllbnQuY3BwCShyZXZpc2lvbiAxMzM3MikKKysrIGh0bWwvQ2FudmFzR3JhZGllbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04MiwxMSArODIsNiBAQAogICAgIHN0YXRpY19jYXN0PENhbnZh c0dyYWRpZW50Kj4oaW5mbyktPmdldENvbG9yKCppbiwgJm91dFswXSwgJm91dFsxXSwgJm91dFsy XSwgJm91dFszXSk7CiB9CiAKLXN0YXRpYyB2b2lkIGdyYWRpZW50UmVsZWFzZUNhbGxiYWNrKHZv aWQqIGluZm8pCi17Ci0gICAgc3RhdGljX2Nhc3Q8Q2FudmFzR3JhZGllbnQqPihpbmZvKS0+ZGVy ZWYoKTsKLX0KLQogQ0dTaGFkaW5nUmVmIENhbnZhc0dyYWRpZW50OjpwbGF0Zm9ybVNoYWRpbmco KQogewogICAgIGlmIChtX3NoYWRpbmcpCkBAIC05NCw4ICs4OSw3IEBACiAKICAgICBjb25zdCBm bG9hdCBpbnRlcnZhbFJhbmdlc1syXSA9IHsgMCwgMSB9OwogICAgIGNvbnN0IGZsb2F0IGNvbG9y Q29tcG9uZW50UmFuZ2VzWzQgKiAyXSA9IHsgMCwgMSwgMCwgMSwgMCwgMSwgMCwgMSB9OwotICAg IGNvbnN0IENHRnVuY3Rpb25DYWxsYmFja3MgZ3JhZGllbnRDYWxsYmFja3MgPSB7IDAsIGdyYWRp ZW50Q2FsbGJhY2ssIGdyYWRpZW50UmVsZWFzZUNhbGxiYWNrIH07Ci0gICAgcmVmKCk7CisgICAg Y29uc3QgQ0dGdW5jdGlvbkNhbGxiYWNrcyBncmFkaWVudENhbGxiYWNrcyA9IHsgMCwgZ3JhZGll bnRDYWxsYmFjaywgMCB9OwogICAgIENHRnVuY3Rpb25SZWYgY29sb3JGdW5jdGlvbiA9IENHRnVu Y3Rpb25DcmVhdGUodGhpcywgMSwgaW50ZXJ2YWxSYW5nZXMsIDQsIGNvbG9yQ29tcG9uZW50UmFu Z2VzLCAmZ3JhZGllbnRDYWxsYmFja3MpOwogCiAgICAgQ0dDb2xvclNwYWNlUmVmIGNvbG9yU3Bh Y2UgPSBDR0NvbG9yU3BhY2VDcmVhdGVEZXZpY2VSR0IoKTsKSW5kZXg6IENoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzc3KQorKysgQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDUgKzEsMTkgQEAKIDIwMDYtMDMtMTggIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzg1NAorICAgICAgICAgIENhbnZhc0dyYWRpZW50IGxlYWtzCisKKyAgICAgICAgKiBodG1s L0NhbnZhc0dyYWRpZW50LmNwcDogKFdlYkNvcmU6OkNhbnZhc0dyYWRpZW50OjpwbGF0Zm9ybVNo YWRpbmcpOgorICAgICAgICBEb24ndCBtYWtlIHRoZSBDRyBzaGFkaW5nIG9iamVjdCBrZWVwIGEg cmVmZXJlbmNlIHRvIHRoZSBET00gZ3JhZGllbnQgb2JqZWN0LgorICAgICAgICBJIGdvdCBjb25m dXNlZCBiZWNhdXNlIGluIHRoZSBjYXNlIG9mIGEgQ2FudmFzUGF0dGVybiwgdGhlIHBhdHRlcm4g ZG9lcyBuZWVkCisgICAgICAgIHRvIGtlZXAgYSByZWZlcmVuY2UgdG8gdGhlIERPTSBwYXR0ZXJu IG9iamVjdCwgYnV0IHRoZSBvYmplY3QgbGlmZXRpbWUgaXMKKyAgICAgICAgaGFuZGxlZCBkaWZm ZXJlbnRseSBoZXJlLiBUaGUgQ0cgc2hhZGluZyBvYmplY3QgaXMgdXNlZCByaWdodCBhd2F5LCBu b3Qgc2V0CisgICAgICAgIGluIGEgZ3JhcGhpY3MgY29udGV4dC4KKworMjAwNi0wMy0xOCAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAgICAgLSBhbm90aGVyIHRyeSBhdCBm aXhpbmcgV2luZG93cyBidWlsZAogCiAgICAgICAgICogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS9X ZWJDb3JlLnZjcHJvajogQWRkZWQgRXZlbnRUYXJnZXROb2RlSW1wbC5oIGFuZCAuY3BwLgo=