<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78536</bug_id>
          
          <creation_ts>2012-02-13 14:07:50 -0800</creation_ts>
          <short_desc>Upstream Android&apos;s additions to Platform.h</short_desc>
          <delta_ts>2012-02-14 00:06:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          <cc>abarth</cc>
    
    <cc>johnme</cc>
    
    <cc>satish</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>555579</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-13 14:07:50 -0800</bug_when>
    <thetext>Upstream Android&apos;s additions to Platform.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555584</commentid>
    <comment_count>1</comment_count>
      <attachid>126833</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-13 14:08:31 -0800</bug_when>
    <thetext>Created attachment 126833
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555586</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-13 14:09:55 -0800</bug_when>
    <thetext>Android also had some lines:

#define WTF_OS_WIN ERROR &quot;USE WINDOWS WITH OS NOT WIN&quot;
#define WTF_OS_MAC ERROR &quot;USE MAC_OS_X WITH OS NOT MAC&quot;

But they seemed unrelated to android (and likely due to a bad merge), thus I did not upstream them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555591</commentid>
    <comment_count>3</comment_count>
    <who name="Satish Sampath">satish</who>
    <bug_when>2012-02-13 14:14:20 -0800</bug_when>
    <thetext>Looks good to me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556029</commentid>
    <comment_count>4</comment_count>
      <attachid>126833</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-14 00:06:06 -0800</bug_when>
    <thetext>Comment on attachment 126833
Patch

Clearing flags on attachment: 126833

Committed r107678: &lt;http://trac.webkit.org/changeset/107678&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>556030</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-14 00:06:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126833</attachid>
            <date>2012-02-13 14:08:31 -0800</date>
            <delta_ts>2012-02-14 00:06:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78536-20120213140833.patch</filename>
            <type>text/plain</type>
            <size>1380</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5
MTg3MmI3NWRjYmQ3YzcwZGQ5YWU5ZmUzYzllYmI0YjY0ZjYzZjgwLi5mZjlhYzIyZTY0MjljNTcw
NTU4NzQ1NTIwMWIzMmUyNTBkZWUyMjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMiBAQAorMjAxMi0wMi0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisK
KyAgICAgICAgVXBzdHJlYW0gQW5kcm9pZCdzIGFkZGl0aW9ucyB0byBQbGF0Zm9ybS5oCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODUzNgorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt
Lmg6CisKIDIwMTItMDItMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAg
ICAgICAgVXNlIENNQ2xvY2sgYXMgYSB0aW1pbmcgc291cmNlIGZvciBQbGF0Zm9ybUNsb2NrIHdo
ZXJlIGF2YWlsYWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxh
dGZvcm0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCBiOWQx
YWYxYzQ5NWNjZTVmNDY0YjA1M2MyMzQ5YTM2MDYxOTc1Mzc4Li4xNzUyMDI5YmQ1NTVhYjA3MDAx
ZDFmZjExOTE1NjY2NDFiODg2OTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
d3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o
CkBAIC00NTksNyArNDU5LDcgQEAKICNkZWZpbmUgV1RGX1VTRV9DQSAxCiAjZW5kaWYKIAotLyog
VVNFKFNLSUEpIGZvciBXaW4vTGludXgsIENHIGZvciBNYWMsIHVubGVzcyBlbmFibGVkICovCisv
KiBVU0UoU0tJQSkgZm9yIFdpbi9MaW51eC9NYWMvQW5kcm9pZCAqLwogI2lmIFBMQVRGT1JNKENI
Uk9NSVVNKQogI2lmIE9TKERBUldJTikKICNpZiBVU0UoU0tJQV9PTl9NQUNfQ0hST01JVU0pCkBA
IC00NzAsNiArNDcwLDkgQEAKICNkZWZpbmUgV1RGX1VTRV9BVFNVSSAxCiAjZGVmaW5lIFdURl9V
U0VfQ09SRV9URVhUIDEKICNkZWZpbmUgV1RGX1VTRV9JQ0NKUEVHIDEKKyNlbGlmIE9TKEFORFJP
SUQpCisjZGVmaW5lIFdURl9VU0VfU0tJQSAxCisjZGVmaW5lIFdURl9VU0VfR0xFUzJfUkVOREVS
SU5HIDAKICNlbHNlCiAjZGVmaW5lIFdURl9VU0VfU0tJQSAxCiAjZGVmaW5lIFdURl9VU0VfQ0hS
T01JVU1fTkVUIDEK
</data>

          </attachment>
      

    </bug>

</bugzilla>