78513 2012-02-13 11:51:50 -0800 If memset gets inlined at WebKit/Source/JavaScriptCore/wtf/Vector.h, it may produce a warning 2012-02-17 23:28:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 asharif.tools webkit-unassigned abarth ap eric thakis vapier webkit.review.bot oldest_to_newest 555434 0 asharif.tools 2012-02-13 11:51:50 -0800 This warning happens in the following conditions: 1. If chain of calls is inlined, including memset. 2. memset has a fill value of non-0, but a size of 0. 3. -D_FORTIFY_SOURCE=2 was passed. This is the warning that I see when building Chrome. In file included from /build/amd64-generic/usr/include/string.h:640:0, from third_party/WebKit/Source/JavaScriptCore/wtf/FastAllocBase.h:90, from third_party/WebKit/Source/JavaScriptCore/wtf/Vector.h:25, from third_party/WebKit/Source/JavaScriptCore/wtf/text/StringImpl.h:31, from third_party/WebKit/Source/JavaScriptCore/wtf/text/WTFString.h:29, from third_party/WebKit/Source/WebCore/platform/text/PlatformString.h:28, from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:28, from third_party/WebKit/Source/WebCore/loader/cache/CachedImage.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderObject.h:29, from third_party/WebKit/Source/WebCore/rendering/RenderBoxModelObject.h:27, from third_party/WebKit/Source/WebCore/rendering/RenderBox.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderFrameSet.h:26, from third_party/WebKit/Source/WebCore/rendering/RenderFrameSet.cpp:25: In function 'void* memset(void*, int, size_t)', inlined from 'WebCore::FrameEdgeInfo WebCore::RenderFrameSet::edgeInfo() const' at third_party/WebKit/Source/JavaScriptCore/wtf/Vector.h:184:13, inlined from 'void WebCore::RenderFrameSet::computeEdgeInfo()' at third_party/WebKit/Source/WebCore/rendering/RenderFrameSet.cpp:430:62: /build/amd64-generic/usr/include/bits/string3.h:82:35: error: call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter; this could be due to transposed parameters [-Werror] cc1plus: all warnings being treated as errors This can be fixed with the following patch: diff --git a/Source/JavaScriptCore/wtf/Vector.h b/Source/JavaScriptCore/wtf/Vector.h index 175f1a5..bf15998 100644 --- a/Source/JavaScriptCore/wtf/Vector.h +++ b/Source/JavaScriptCore/wtf/Vector.h @@ -181,7 +181,8 @@ namespace WTF { static void uninitializedFill(T* dst, T* dstEnd, const T& val) { ASSERT(sizeof(T) == sizeof(char)); - memset(dst, val, dstEnd - dst); + if (dstEnd - dst) + memset(dst, val, dstEnd - dst); } }; 555608 1 126836 asharif.tools 2012-02-13 14:32:33 -0800 Created attachment 126836 Fixes the problem. 555650 2 thakis 2012-02-13 15:04:03 -0800 You usually upload patches with "Reviewed by NOBODY (OOPS)", and the scripts put in a name after someone reviewed this. I'm not a webkit reviewer, so I can't review this. I also don't think this should be done, the error sounds like a toolchain bug. 555777 3 126836 ap 2012-02-13 17:04:10 -0800 Comment on attachment 126836 Fixes the problem. This makes uninitializedFill slower for the benefit of a platform specific tool. There must be a way to shut down the warning that doesn't have runtime costs. 555906 4 126899 asharif.tools 2012-02-13 20:26:55 -0800 Created attachment 126899 Should not have any runtime overhead with this patch at -O2. This patch is now checking if dstEnd - dst is a constant before doing the 0 check. If dstEnd - dst is not a constant, the first part of the if condition is true and the whole if condition should be folded away. 555907 5 webkit.review.bot 2012-02-13 20:29:38 -0800 Attachment 126899 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/Vector.h:185: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/JavaScriptCore/wtf/Vector.h:185: Extra space for operator ! [whitespace/operators] [4] Source/JavaScriptCore/wtf/Vector.h:186: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 555920 6 126901 asharif.tools 2012-02-13 20:48:09 -0800 Created attachment 126901 Fixed style warnings. 556376 7 126901 ap 2012-02-14 10:13:56 -0800 Comment on attachment 126901 Fixed style warnings. View in context: https://bugs.webkit.org/attachment.cgi?id=126901&action=review This might be OK, but the whole warning seems like something that should be just globally disabled somehow. > Source/JavaScriptCore/wtf/Vector.h:186 > + if (!__builtin_constant_p(dstEnd - dst) > + || (!(dstEnd - dst))) Please don't wrap this line. 556381 8 126995 asharif.tools 2012-02-14 10:15:46 -0800 Created attachment 126995 Fixed line-wrap issue. 557020 9 webkit.review.bot 2012-02-15 01:15:45 -0800 Attachment 126995 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource From git://git.webkit.org/WebKit + a9730c4...fb50dbd master -> origin/master (forced update) First, rewinding head to replay your work on top of it... Applying: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets Using index info to reconstruct a base tree... <stdin>:1578: trailing whitespace. <stdin>:1647: trailing whitespace. <stdin>:1657: trailing whitespace. <stdin>:1672: trailing whitespace. return 0; <stdin>:1674: trailing whitespace. warning: squelched 7 whitespace errors warning: 12 lines add whitespace errors. Falling back to patching base and 3-way merge... warning: too many files (created: 168753 deleted: 3), skipping inexact rename detection Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/wk2/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Auto-merging Source/WebCore/css/CSSCalculationValue.cpp Auto-merging Source/WebCore/css/CSSCalculationValue.h Auto-merging Source/WebCore/css/CSSParser.cpp Auto-merging Source/WebKit/mac/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog Auto-merging Source/WebKit2/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style. 557872 10 127304 asharif.tools 2012-02-15 20:33:38 -0800 Created attachment 127304 Proposed fix. I rebased this patch. 559277 11 asharif.tools 2012-02-17 10:02:39 -0800 Ping? Any updates on this? If this solution is not acceptable, let me know so we can close this bug. 559285 12 ap 2012-02-17 10:21:05 -0800 One question is whether there is a less intrusive way to disable this warning. A quick web search reveals that "With -D_FORTIFY_SOURCE=2 ... some conforming programs might fail." <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>. So, I'm not sure if we want to subscribe to supporting this mode. A discussion on webkit-dev mailing list may clarify things. 559321 13 vapier 2012-02-17 10:44:38 -0800 while it's true that fortify breaks code that is correct from the language/runtime pov, we're talking about snippets that arguably go against style tastes. such as: struct { char a[2]; char b; char d[3]; } foo; strcpy(&foo.a[0], "aabdd"); many distros now build with fortify enabled by default for pretty much all packages (Debian/Ubuntu/Fedora/Redhat/Gentoo). it has certainly been a much bigger benefit than the handful of downsides. the proposed patch probably should have a comment in there explaining why this magic check is active. or perhaps replace/augment the GCC define with _FORTIFY_SOURCE so that the code is self-documenting. 559467 14 ap 2012-02-17 13:18:58 -0800 > replace/augment the GCC define with _FORTIFY_SOURCE so that the code is self-documenting I like this idea (augmenting would likely be more self-documenting). 559481 15 127643 asharif.tools 2012-02-17 13:34:18 -0800 Created attachment 127643 Proposed fix. Added ifdef _FORTIFY_SOURCE around the patch. I kept the COMPILER(GCC) because __builtin_constant_p() may not be available on other compilers. 559536 16 127643 ap 2012-02-17 14:17:55 -0800 Comment on attachment 127643 Proposed fix. I think that this is OK to land, but please merge the #ifs in one line: #if COMPILER(GCC) && defined(_FORTIFY_SOURCE) 559537 17 ap 2012-02-17 14:18:21 -0800 Oh, and please mention Fortify in ChangeLog. 559541 18 127659 asharif.tools 2012-02-17 14:23:02 -0800 Created attachment 127659 Proposed fix. Addressed reviewers' comments. 559546 19 127659 ap 2012-02-17 14:29:58 -0800 Comment on attachment 127659 Proposed fix. Thank you! 559595 20 127659 webkit.review.bot 2012-02-17 15:29:53 -0800 Comment on attachment 127659 Proposed fix. Rejecting attachment 127659 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11543290 559658 21 ap 2012-02-17 16:57:38 -0800 I don't understand why the commit queue freaked out. Adam, Eric, do you see what's wrong? 559678 22 127659 eric 2012-02-17 17:54:35 -0800 Comment on attachment 127659 Proposed fix. View in context: https://bugs.webkit.org/attachment.cgi?id=127659&action=review > Source/JavaScriptCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS). I believe it normally has a ! after the OOPS. http://trac.webkit.org/browser/trunk/Tools/Scripts/VCSUtils.pm#L1399 559679 23 eric 2012-02-17 17:55:07 -0800 Our OOPS! convention in WebKit is not very discoverable. I think we should consider changing it to DO_NOT_COMMIT or similar. 559680 24 127682 asharif.tools 2012-02-17 17:56:59 -0800 Created attachment 127682 Proposed fix. Rebased patch. Added exclamation point after OOPS. 559734 25 127682 webkit.review.bot 2012-02-17 23:28:38 -0800 Comment on attachment 127682 Proposed fix. Clearing flags on attachment: 127682 Committed r108153: <http://trac.webkit.org/changeset/108153> 559735 26 webkit.review.bot 2012-02-17 23:28:44 -0800 All reviewed patches have been landed. Closing bug. 126836 2012-02-13 14:32:33 -0800 2012-02-13 20:26:55 -0800 Fixes the problem. warning.patch text/plain 1117 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3NjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOaWNvIFdlYmVyLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAyMDEy LTAyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBKU0Mg cmVsYXRlZCBhc3NlcnRpb25zIG91dCBvZiBBc3NlcnRpb25zLmggYW5kIGludG8gdGhlaXIgb3du IGhlYWRlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lvbiAxMDc2 MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNvcHkp CkBAIC0xODEsNyArMTgxLDggQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHN0YXRpYyB2b2lk IHVuaW5pdGlhbGl6ZWRGaWxsKFQqIGRzdCwgVCogZHN0RW5kLCBjb25zdCBUJiB2YWwpIAogICAg ICAgICB7CiAgICAgICAgICAgICBBU1NFUlQoc2l6ZW9mKFQpID09IHNpemVvZihjaGFyKSk7Ci0g ICAgICAgICAgICBtZW1zZXQoZHN0LCB2YWwsIGRzdEVuZCAtIGRzdCk7CisgICAgICAgICAgICBp ZiAoZHN0RW5kIC0gZHN0KQorICAgICAgICAgICAgICAgIG1lbXNldChkc3QsIHZhbCwgZHN0RW5k IC0gZHN0KTsKICAgICAgICAgfQogICAgIH07CiAgICAgCg== 126899 2012-02-13 20:26:55 -0800 2012-02-13 20:48:09 -0800 Should not have any runtime overhead with this patch at -O2. warning.patch text/plain 1210 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3NjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAy MDEyLTAyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBK U0MgcmVsYXRlZCBhc3NlcnRpb25zIG91dCBvZiBBc3NlcnRpb25zLmggYW5kIGludG8gdGhlaXIg b3duIGhlYWRlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lvbiAx MDc2MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xODEsNyArMTgxLDExIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBzdGF0aWMg dm9pZCB1bmluaXRpYWxpemVkRmlsbChUKiBkc3QsIFQqIGRzdEVuZCwgY29uc3QgVCYgdmFsKSAK ICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUKHNpemVvZihUKSA9PSBzaXplb2YoY2hhcikp OwotICAgICAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOworI2lmIENPTVBJ TEVSKEdDQykKKyAgICAgICAgICAgIGlmICghIF9fYnVpbHRpbl9jb25zdGFudF9wKGRzdEVuZCAt IGRzdCkgfHwKKyAgICAgICAgICAgICAgICBkc3RFbmQgLSBkc3QgIT0gMCkKKyNlbmRpZgorICAg ICAgICAgICAgICAgIG1lbXNldChkc3QsIHZhbCwgZHN0RW5kIC0gZHN0KTsKICAgICAgICAgfQog ICAgIH07CiAgICAgCg== 126901 2012-02-13 20:48:09 -0800 2012-02-14 10:15:46 -0800 Fixed style warnings. warning.patch text/plain 1209 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3NjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAy MDEyLTAyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBK U0MgcmVsYXRlZCBhc3NlcnRpb25zIG91dCBvZiBBc3NlcnRpb25zLmggYW5kIGludG8gdGhlaXIg b3duIGhlYWRlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lvbiAx MDc2MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xODEsNyArMTgxLDExIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBzdGF0aWMg dm9pZCB1bmluaXRpYWxpemVkRmlsbChUKiBkc3QsIFQqIGRzdEVuZCwgY29uc3QgVCYgdmFsKSAK ICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUKHNpemVvZihUKSA9PSBzaXplb2YoY2hhcikp OwotICAgICAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOworI2lmIENPTVBJ TEVSKEdDQykKKyAgICAgICAgICAgIGlmICghX19idWlsdGluX2NvbnN0YW50X3AoZHN0RW5kIC0g ZHN0KQorICAgICAgICAgICAgICAgIHx8ICghKGRzdEVuZCAtIGRzdCkpKQorI2VuZGlmCisgICAg ICAgICAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOwogICAgICAgICB9CiAg ICAgfTsKICAgICAK 126995 2012-02-14 10:15:46 -0800 2012-02-15 20:33:38 -0800 Fixed line-wrap issue. warning.patch text/plain 1192 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3NjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAy MDEyLTAyLTEzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBK U0MgcmVsYXRlZCBhc3NlcnRpb25zIG91dCBvZiBBc3NlcnRpb25zLmggYW5kIGludG8gdGhlaXIg b3duIGhlYWRlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lvbiAx MDc2MTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xODEsNyArMTgxLDEwIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBzdGF0aWMg dm9pZCB1bmluaXRpYWxpemVkRmlsbChUKiBkc3QsIFQqIGRzdEVuZCwgY29uc3QgVCYgdmFsKSAK ICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUKHNpemVvZihUKSA9PSBzaXplb2YoY2hhcikp OwotICAgICAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOworI2lmIENPTVBJ TEVSKEdDQykKKyAgICAgICAgICAgIGlmICghX19idWlsdGluX2NvbnN0YW50X3AoZHN0RW5kIC0g ZHN0KSB8fCAoIShkc3RFbmQgLSBkc3QpKSkKKyNlbmRpZgorICAgICAgICAgICAgICAgIG1lbXNl dChkc3QsIHZhbCwgZHN0RW5kIC0gZHN0KTsKICAgICAgICAgfQogICAgIH07CiAgICAgCg== 127304 2012-02-15 20:33:38 -0800 2012-02-17 13:34:18 -0800 Proposed fix. warning.patch text/plain 1190 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3ODc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAy MDEyLTAyLTE1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5z dXJlIHRoYXQgdGhlIERGRyBKSVQgYWx3YXlzIHBsYW50cyBhIENvZGVPcmlnaW4gd2hlbiBtYWtp bmcgY2FsbHMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAkocmV2aXNpb24gMTA3 ODc5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMTgxLDcgKzE4MSwxMCBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgc3RhdGljIHZv aWQgdW5pbml0aWFsaXplZEZpbGwoVCogZHN0LCBUKiBkc3RFbmQsIGNvbnN0IFQmIHZhbCkgCiAg ICAgICAgIHsKICAgICAgICAgICAgIEFTU0VSVChzaXplb2YoVCkgPT0gc2l6ZW9mKGNoYXIpKTsK LSAgICAgICAgICAgIG1lbXNldChkc3QsIHZhbCwgZHN0RW5kIC0gZHN0KTsKKyNpZiBDT01QSUxF UihHQ0MpCisgICAgICAgICAgICBpZiAoIV9fYnVpbHRpbl9jb25zdGFudF9wKGRzdEVuZCAtIGRz dCkgfHwgKCEoZHN0RW5kIC0gZHN0KSkpCisjZW5kaWYKKyAgICAgICAgICAgICAgICBtZW1zZXQo ZHN0LCB2YWwsIGRzdEVuZCAtIGRzdCk7CiAgICAgICAgIH0KICAgICB9OwogICAgIAo= 127643 2012-02-17 13:34:18 -0800 2012-02-17 14:23:30 -0800 Proposed fix. warning.patch text/plain 1175 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA4MTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBGaXhlZCBjb2RlIHNvIGEgd2FybmluZyBpcyBzdXBwcmVzc2VkLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzg1MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorCiAy MDEyLTAyLTE2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgSW1w bGVtZW50IEVycm9yLnN0YWNrCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rv ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHJl dmlzaW9uIDEwODExNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHdv cmtpbmcgY29weSkKQEAgLTE4MSw3ICsxODEsMTIgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAg IHN0YXRpYyB2b2lkIHVuaW5pdGlhbGl6ZWRGaWxsKFQqIGRzdCwgVCogZHN0RW5kLCBjb25zdCBU JiB2YWwpIAogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQoc2l6ZW9mKFQpID09IHNpemVv ZihjaGFyKSk7Ci0gICAgICAgICAgICBtZW1zZXQoZHN0LCB2YWwsIGRzdEVuZCAtIGRzdCk7Cisj aWYgQ09NUElMRVIoR0NDKQorI2lmZGVmIF9GT1JUSUZZX1NPVVJDRQorICAgICAgICAgICAgaWYg KCFfX2J1aWx0aW5fY29uc3RhbnRfcChkc3RFbmQgLSBkc3QpIHx8ICghKGRzdEVuZCAtIGRzdCkp KQorI2VuZGlmCisjZW5kaWYKKyAgICAgICAgICAgICAgICBtZW1zZXQoZHN0LCB2YWwsIGRzdEVu ZCAtIGRzdCk7CiAgICAgICAgIH0KICAgICB9OwogICAgIAo= 127659 2012-02-17 14:23:02 -0800 2012-02-17 17:56:59 -0800 Proposed fix. warning.patch text/plain 1407 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA4MTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBUaGVyZSBpcyBhIHdhcm5pbmcgaW4gbWVtc2V0IGluIGdsaWJjIHRoYXQgZ2V0cyB0 cmlnZ2VyZWQgdGhyb3VnaCBhCisgICAgICAgIHdhcm5kZWNsIHdoZW4gdGhlIGZpbGwtdmFsdWUg b2YgbWVtc2V0IGlzIGEgbm9uLXplcm8gY29uc3RhbnQgYW5kIHRoZQorICAgICAgICBzaXplIGlz IHplcm8uIFRoaXMgd2FybmluZyBpcyBlbmFibGVkIHdoZW4gYnVpbGRpbmcgd2l0aAorICAgICAg ICAtRF9GT1JUSUZZX1NPVVJDRT0yLiBUaGlzIHBhdGNoIGZpeGVzIHRoZSB3YXJuaW5nLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODUxMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUykuCisKKyAgICAgICAgKiB3dGYvVmVjdG9y Lmg6CisKIDIwMTItMDItMTYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBJbXBsZW1lbnQgRXJyb3Iuc3RhY2sKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvVmVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0 b3IuaAkocmV2aXNpb24gMTA4MTE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0 b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTgxLDcgKzE4MSwxMCBAQCBuYW1lc3BhY2UgV1RGIHsK ICAgICAgICAgc3RhdGljIHZvaWQgdW5pbml0aWFsaXplZEZpbGwoVCogZHN0LCBUKiBkc3RFbmQs IGNvbnN0IFQmIHZhbCkgCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VSVChzaXplb2YoVCkg PT0gc2l6ZW9mKGNoYXIpKTsKLSAgICAgICAgICAgIG1lbXNldChkc3QsIHZhbCwgZHN0RW5kIC0g ZHN0KTsKKyNpZiBDT01QSUxFUihHQ0MpICYmIGRlZmluZWQoX0ZPUlRJRllfU09VUkNFKQorICAg ICAgICAgICAgaWYgKCFfX2J1aWx0aW5fY29uc3RhbnRfcChkc3RFbmQgLSBkc3QpIHx8ICghKGRz dEVuZCAtIGRzdCkpKQorI2VuZGlmCisgICAgICAgICAgICAgICAgbWVtc2V0KGRzdCwgdmFsLCBk c3RFbmQgLSBkc3QpOwogICAgICAgICB9CiAgICAgfTsKICAgICAK 127682 2012-02-17 17:56:59 -0800 2012-02-17 23:28:38 -0800 Proposed fix. warning.patch text/plain 1439 asharif.tools SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA4MTQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAyLTEzICBBaG1hZCBTaGFyaWYgIDxhc2hhcmlmLnRvb2xzQGdtYWlsLmNvbT4KKwor ICAgICAgICBUaGVyZSBpcyBhIHdhcm5pbmcgaW4gbWVtc2V0IGluIGdsaWJjIHRoYXQgZ2V0cyB0 cmlnZ2VyZWQgdGhyb3VnaCBhCisgICAgICAgIHdhcm5kZWNsIHdoZW4gdGhlIGZpbGwtdmFsdWUg b2YgbWVtc2V0IGlzIGEgbm9uLXplcm8gY29uc3RhbnQgYW5kIHRoZQorICAgICAgICBzaXplIGlz IHplcm8uIFRoaXMgd2FybmluZyBpcyBlbmFibGVkIHdoZW4gYnVpbGRpbmcgd2l0aAorICAgICAg ICAtRF9GT1JUSUZZX1NPVVJDRT0yLiBUaGlzIHBhdGNoIGZpeGVzIHRoZSB3YXJuaW5nLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODUxMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpCisKKyAgICAgICAgKiB3dGYvVmVjdG9y Lmg6CisKIDIwMTItMDItMTcgIEthbGV2IExlbWJlciAgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K IAogICAgICAgICBSZW1vdmUgdW51c2VkIHBhcmFtZXRlcnMgZnJvbSBXVEYgdGhyZWFkaW5nIEFQ SQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lvbiAxMDgxNDYpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0x ODEsNyArMTgxLDEwIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBzdGF0aWMgdm9pZCB1bmlu aXRpYWxpemVkRmlsbChUKiBkc3QsIFQqIGRzdEVuZCwgY29uc3QgVCYgdmFsKSAKICAgICAgICAg ewogICAgICAgICAgICAgQVNTRVJUKHNpemVvZihUKSA9PSBzaXplb2YoY2hhcikpOwotICAgICAg ICAgICAgbWVtc2V0KGRzdCwgdmFsLCBkc3RFbmQgLSBkc3QpOworI2lmIENPTVBJTEVSKEdDQykg JiYgZGVmaW5lZChfRk9SVElGWV9TT1VSQ0UpCisgICAgICAgICAgICBpZiAoIV9fYnVpbHRpbl9j b25zdGFudF9wKGRzdEVuZCAtIGRzdCkgfHwgKCEoZHN0RW5kIC0gZHN0KSkpCisjZW5kaWYKKyAg ICAgICAgICAgICAgICBtZW1zZXQoZHN0LCB2YWwsIGRzdEVuZCAtIGRzdCk7CiAgICAgICAgIH0K ICAgICB9OwogICAgIAo=