78498 2012-02-13 08:05:16 -0800 [chromium] Set opaque flag on SkBitmap in per-tile layer updater 2012-02-14 18:04:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer cc-bugs jamesr noel.gordon piman reed reveman senorblanco webkit.review.bot oldest_to_newest 555264 0 danakj 2012-02-13 08:05:16 -0800 [chromium] Set opaque flag on SkBitmap in per-tile layer updater 555266 1 126773 danakj 2012-02-13 08:06:21 -0800 Created attachment 126773 Patch 555307 2 danakj 2012-02-13 08:58:43 -0800 Provide opaque information to skia so it can perform optimizations now or in the future. 555309 3 126773 senorblanco 2012-02-13 09:00:49 -0800 Comment on attachment 126773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126773&action=review > Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:52 > + virtual void setOpaque(bool); > + Out of curiosity, why does this need to be public now? It doesn't seem to be called from anywhere new. 555310 4 126773 danakj 2012-02-13 09:03:00 -0800 Comment on attachment 126773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126773&action=review >> Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:52 >> + > > Out of curiosity, why does this need to be public now? It doesn't seem to be called from anywhere new. It should have been public to start with. The function its overriding in LayerTextureUpdater.h is public. 555335 5 126773 senorblanco 2012-02-13 09:41:00 -0800 Comment on attachment 126773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126773&action=review Looks good. r=me >>> Source/WebCore/platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:52 >>> + >> >> Out of curiosity, why does this need to be public now? It doesn't seem to be called from anywhere new. > > It should have been public to start with. The function its overriding in LayerTextureUpdater.h is public. Ah, thanks for the explanation. 555353 6 reed 2012-02-13 10:10:36 -0800 probably better to set the opaqueness *after* the call to allocPixels(). I think this may work today, but it is likely we'll want to pass this hint onto the pixelref, which we don't have until the alloc call. 555359 7 danakj 2012-02-13 10:20:53 -0800 Would the bitmap not pass the current isOpaque() value on to the pixelref when the pixelref becomes available? 555362 8 reed 2012-02-13 10:29:21 -0800 it may. I am just thinking about future evolution of the API. 555378 9 126795 danakj 2012-02-13 10:47:39 -0800 Created attachment 126795 Patch reversed the call order to skbitmap as per @reed's comments. 555932 10 noel.gordon 2012-02-13 21:24:48 -0800 Kinda reminds me of http://crbug.com/113171, where calling setIsOpaque() on bitmap lead to all sorts of trouble. Maybe I worry too much? 555944 11 126795 webkit.review.bot 2012-02-13 21:57:42 -0800 Comment on attachment 126795 Patch Clearing flags on attachment: 126795 Committed r107669: <http://trac.webkit.org/changeset/107669> 555945 12 webkit.review.bot 2012-02-13 21:57:47 -0800 All reviewed patches have been landed. Closing bug. 556304 13 danakj 2012-02-14 07:54:12 -0800 Looks like a fun bug. I think we'll be okay. We fill the bitmap with things before using the pixels here, as they are used for texture upload. 556837 14 noel.gordon 2012-02-14 18:04:21 -0800 Yeah fun bug, and very glad to hear you don't have it :) 126773 2012-02-13 08:06:21 -0800 2012-02-13 10:47:34 -0800 Patch bug-78498-20120213110620.patch text/plain 3008 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ3ZGU1OTViOWRlMzMw YTdjMjU3ZWRhYjc3NDM3ZGRmNDllNzZkZC4uNTZlNmM5MGMyZTllMWNmZjc4MjA2NTU0YTQ3NGU1 MjU4Y2NmY2MxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTEzICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gU2V0 IG9wYXF1ZSBmbGFnIG9uIFNrQml0bWFwIGluIHBlci10aWxlIGxheWVyIHVwZGF0ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NDk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQml0bWFwU2tQaWN0dXJlQ2Fu dmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBTa1Bp Y3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyOjpUZXh0dXJlOjpwcmVwYXJlUmVjdCk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2tQaWN0dXJlQ2FudmFzTGF5ZXJU ZXh0dXJlVXBkYXRlci5oOgorICAgICAgICAoU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBk YXRlcik6CisgICAgICAgIChXZWJDb3JlOjpTa1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRh dGVyOjpsYXllcklzT3BhcXVlKToKKwogMjAxMi0wMi0xMyAgQ2FpbyBNYXJjZWxvIGRlIE9saXZl aXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIE1vdmUg YXR0cmlidXRlIHN0b3JhZ2UgZnJvbSBOYW1lZE5vZGVNYXAgdG8gRWxlbWVudEF0dHJpYnV0ZURh dGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0JpdG1hcFNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQml0bWFwU2tQaWN0dXJlQ2FudmFzTGF5 ZXJUZXh0dXJlVXBkYXRlci5jcHAKaW5kZXggNjU4NWIzNGIzZTFlNWNiMTFjODc3Mzk3ZDVlZmRh ZDdiNmVmZjIxMy4uMzI5ZjM2MDBhMzFlNTY1MGY2MGJjYzk3MmFhMzNhNGZmNTk0MmM4MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQml0bWFw U2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQml0bWFwU2tQaWN0dXJlQ2FudmFzTGF5ZXJU ZXh0dXJlVXBkYXRlci5jcHAKQEAgLTQ2LDYgKzQ2LDcgQEAgQml0bWFwU2tQaWN0dXJlQ2FudmFz TGF5ZXJUZXh0dXJlVXBkYXRlcjo6VGV4dHVyZTo6VGV4dHVyZShCaXRtYXBTa1BpY3R1cmVDYW52 YXMKIHZvaWQgQml0bWFwU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlcjo6VGV4dHVy ZTo6cHJlcGFyZVJlY3QoY29uc3QgSW50UmVjdCYgc291cmNlUmVjdCkKIHsKICAgICBtX2JpdG1h cC5zZXRDb25maWcoU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnLCBzb3VyY2VSZWN0LndpZHRo KCksIHNvdXJjZVJlY3QuaGVpZ2h0KCkpOworICAgIG1fYml0bWFwLnNldElzT3BhcXVlKG1fdGV4 dHVyZVVwZGF0ZXItPmxheWVySXNPcGFxdWUoKSk7CiAgICAgbV9iaXRtYXAuYWxsb2NQaXhlbHMo KTsKICAgICBTa0RldmljZSBkZXZpY2UobV9iaXRtYXApOwogICAgIFNrQ2FudmFzIGNhbnZhcygm ZGV2aWNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1NrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVy ZVVwZGF0ZXIuaAppbmRleCA3ZmNjNjA1OWY5MGU3ZDlkMWMzMDFiZjJhNzBmNTE1MmE0OTI3YjAw Li5lY2RlZmE0MTExYjAyNzUyMDRlM2Q2MzY0ODdmN2I2MjFlNWE5YWQ4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Ta1BpY3R1cmVDYW52YXNM YXllclRleHR1cmVVcGRhdGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5oCkBAIC00OCwx MyArNDgsMTUgQEAgY2xhc3MgU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlciA6IHB1 YmxpYyBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5T a1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyKCk7CiAKKyAgICB2aXJ0dWFsIHZvaWQg c2V0T3BhcXVlKGJvb2wpOworCiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGljaXQgU2tQaWN0dXJlQ2Fu dmFzTGF5ZXJUZXh0dXJlVXBkYXRlcihQYXNzT3duUHRyPExheWVyUGFpbnRlckNocm9taXVtPik7 CiAKICAgICB2aXJ0dWFsIHZvaWQgcHJlcGFyZVRvVXBkYXRlKGNvbnN0IEludFJlY3QmIGNvbnRl bnRSZWN0LCBjb25zdCBJbnRTaXplJiB0aWxlU2l6ZSwgaW50IGJvcmRlclRleGVscywgZmxvYXQg Y29udGVudHNTY2FsZSwgSW50UmVjdCogcmVzdWx0aW5nT3BhcXVlUmVjdCk7CiAgICAgdm9pZCBk cmF3UGljdHVyZShTa0NhbnZhcyopOwogCi0gICAgdmlydHVhbCB2b2lkIHNldE9wYXF1ZShib29s KTsKKyAgICBib29sIGxheWVySXNPcGFxdWUoKSBjb25zdCB7IHJldHVybiBtX2xheWVySXNPcGFx dWU7IH0KIAogcHJpdmF0ZToKICAgICAvLyBSZWNvcmRpbmcgY2FudmFzLgo= 126795 2012-02-13 10:47:39 -0800 2012-02-13 21:57:42 -0800 Patch bug-78498-20120213134738.patch text/plain 2974 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ3ZGU1OTViOWRlMzMw YTdjMjU3ZWRhYjc3NDM3ZGRmNDllNzZkZC4uNmRlOTE1NmRjMmRmYjM0Yzg1YTRiMmExY2I5N2Ey MzFlYjI3MDJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAyLTEzICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gU2V0 IG9wYXF1ZSBmbGFnIG9uIFNrQml0bWFwIGluIHBlci10aWxlIGxheWVyIHVwZGF0ZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NDk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgU3RlcGhlbiBXaGl0ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9CaXRtYXBTa1BpY3R1cmVDYW52 YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcFNrUGlj dHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXI6OlRleHR1cmU6OnByZXBhcmVSZWN0KToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Ta1BpY3R1cmVDYW52YXNMYXllclRl eHR1cmVVcGRhdGVyLmg6CisgICAgICAgIChTa1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRh dGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0 ZXI6OmxheWVySXNPcGFxdWUpOgorCiAyMDEyLTAyLTEzICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVp cmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgTW92ZSBh dHRyaWJ1dGUgc3RvcmFnZSBmcm9tIE5hbWVkTm9kZU1hcCB0byBFbGVtZW50QXR0cmlidXRlRGF0 YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Qml0bWFwU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9CaXRtYXBTa1BpY3R1cmVDYW52YXNMYXll clRleHR1cmVVcGRhdGVyLmNwcAppbmRleCA2NTg1YjM0YjNlMWU1Y2IxMWM4NzczOTdkNWVmZGFk N2I2ZWZmMjEzLi45YjkxMmE0NGY3YzJmM2RlZGQzOThhZDJiMjgxMTU2YThiNTczMGIzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9CaXRtYXBT a1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9CaXRtYXBTa1BpY3R1cmVDYW52YXNMYXllclRl eHR1cmVVcGRhdGVyLmNwcApAQCAtNDcsNiArNDcsNyBAQCB2b2lkIEJpdG1hcFNrUGljdHVyZUNh bnZhc0xheWVyVGV4dHVyZVVwZGF0ZXI6OlRleHR1cmU6OnByZXBhcmVSZWN0KGNvbnN0IEludFJl YwogewogICAgIG1fYml0bWFwLnNldENvbmZpZyhTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcs IHNvdXJjZVJlY3Qud2lkdGgoKSwgc291cmNlUmVjdC5oZWlnaHQoKSk7CiAgICAgbV9iaXRtYXAu YWxsb2NQaXhlbHMoKTsKKyAgICBtX2JpdG1hcC5zZXRJc09wYXF1ZShtX3RleHR1cmVVcGRhdGVy LT5sYXllcklzT3BhcXVlKCkpOwogICAgIFNrRGV2aWNlIGRldmljZShtX2JpdG1hcCk7CiAgICAg U2tDYW52YXMgY2FudmFzKCZkZXZpY2UpOwogICAgIHRleHR1cmVVcGRhdGVyKCktPnBhaW50Q29u dGVudHNSZWN0KCZjYW52YXMsIHNvdXJjZVJlY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJl VXBkYXRlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2tQ aWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5oCmluZGV4IDdmY2M2MDU5ZjkwZTdkOWQx YzMwMWJmMmE3MGY1MTUyYTQ5MjdiMDAuLmVjZGVmYTQxMTFiMDI3NTIwNGUzZDYzNjQ4N2Y3YjYy MWU1YTlhZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1NrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Ta1BpY3R1cmVDYW52YXNMYXllclRl eHR1cmVVcGRhdGVyLmgKQEAgLTQ4LDEzICs0OCwxNSBAQCBjbGFzcyBTa1BpY3R1cmVDYW52YXNM YXllclRleHR1cmVVcGRhdGVyIDogcHVibGljIENhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIgewog cHVibGljOgogICAgIHZpcnR1YWwgflNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIo KTsKIAorICAgIHZpcnR1YWwgdm9pZCBzZXRPcGFxdWUoYm9vbCk7CisKIHByb3RlY3RlZDoKICAg ICBleHBsaWNpdCBTa1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyKFBhc3NPd25QdHI8 TGF5ZXJQYWludGVyQ2hyb21pdW0+KTsKIAogICAgIHZpcnR1YWwgdm9pZCBwcmVwYXJlVG9VcGRh dGUoY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QsIGNvbnN0IEludFNpemUmIHRpbGVTaXplLCBp bnQgYm9yZGVyVGV4ZWxzLCBmbG9hdCBjb250ZW50c1NjYWxlLCBJbnRSZWN0KiByZXN1bHRpbmdP cGFxdWVSZWN0KTsKICAgICB2b2lkIGRyYXdQaWN0dXJlKFNrQ2FudmFzKik7CiAKLSAgICB2aXJ0 dWFsIHZvaWQgc2V0T3BhcXVlKGJvb2wpOworICAgIGJvb2wgbGF5ZXJJc09wYXF1ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fbGF5ZXJJc09wYXF1ZTsgfQogCiBwcml2YXRlOgogICAgIC8vIFJlY29yZGlu ZyBjYW52YXMuCg==