78495 2012-02-13 06:47:02 -0800 Flakiness dashboard should show Linux ChromiumOS test results. 2012-02-14 14:44:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 flackr webkit-unassigned ojan webkit.review.bot oldest_to_newest 555236 0 flackr 2012-02-13 06:47:02 -0800 The ChromiumOS waterfall at http://build.chromium.org/p/chromium.chromiumos/console links to the flakiness dashboard for failed Linux ChromiumOS tests. These tests use the same infrastructure as the Chromium tests and are for the most part a superset of the Chromium tests (Chromium tests + ChromiumOS tests). We should be able to view these test failures on the flakiness dashboard as with any other Chromium tests. 555237 1 126767 flackr 2012-02-13 06:49:53 -0800 Created attachment 126767 Patch to add Chromium.ChromiumOS master and relevant builders to flakiness dashboard. 555347 2 126767 ojan 2012-02-13 09:58:48 -0800 Comment on attachment 126767 Patch to add Chromium.ChromiumOS master and relevant builders to flakiness dashboard. View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review Just a couple style nits. This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ". That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review. > Tools/TestResultServer/static-dashboards/builders.js:44 > +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/'); Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'? > Tools/TestResultServer/static-dashboards/dashboard_base.js:181 > + function() { return value in LAYOUT_TESTS_BUILDER_GROUPS || > + value in CHROMIUM_GTESTS_BUILDER_GROUPS; }); I'd either make this a single-line or break it up into normal function format like so: function() { return foo || bar; } 555365 3 126792 flackr 2012-02-13 10:36:12 -0800 Created attachment 126792 Patch 555373 4 flackr 2012-02-13 10:44:15 -0800 (In reply to comment #2) > (From update of attachment 126767 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review > > Just a couple style nits. > > This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ". That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review. > > > Tools/TestResultServer/static-dashboards/builders.js:44 > > +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/'); > > Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'? > I changed the variable to CHROMIUMOS_BUILDER_MASTER. As for the master name, the master on test-results.appspot.com is called ChromiumChromiumOS, if I change this here I would have to map it back to ChromiumChromiumOS when building the request URL for test results. I think to change the actual master name would require many changes elsewhere. > > Tools/TestResultServer/static-dashboards/dashboard_base.js:181 > > + function() { return value in LAYOUT_TESTS_BUILDER_GROUPS || > > + value in CHROMIUM_GTESTS_BUILDER_GROUPS; }); > > I'd either make this a single-line or break it up into normal function format like so: > function() { > return foo || > bar; > } Done. 555374 5 126792 ojan 2012-02-13 10:45:21 -0800 Comment on attachment 126792 Patch Thanks for doing this. I'm also setting cq+ so that this goes through the commit queue. For future reference, you need to set cq? to tell the reviewer you'd like it in the commit queue once it's been reviewed. Once this patch is committed, it'll need to be pushed to the appengine server. I can do that later today. 555929 6 126792 webkit.review.bot 2012-02-13 21:19:38 -0800 Comment on attachment 126792 Patch Clearing flags on attachment: 126792 Committed r107667: <http://trac.webkit.org/changeset/107667> 555930 7 webkit.review.bot 2012-02-13 21:19:42 -0800 All reviewed patches have been landed. Closing bug. 556628 8 ojan 2012-02-14 14:44:47 -0800 I've pushed this to appengine. Looks like it's working. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40DEPS%20CrOS%20-%20chromium.org&testType=ui_tests 126767 2012-02-13 06:49:53 -0800 2012-02-13 10:36:06 -0800 Patch to add Chromium.ChromiumOS master and relevant builders to flakiness dashboard. chromiumos_builders.patch text/plain 3548 flackr SW5kZXg6IFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk cy9idWlsZGVycy5qcwkocmV2aXNpb24gMTA3Mjc1KQorKysgVG9vbHMvVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcwkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsx LDQgQEAKLS8vIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorLy8gQ29weXJpZ2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAvLwogLy8gUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAvLyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC00MSw2ICs0MSw3IEBA IEJ1aWxkZXJNYXN0ZXIucHJvdG90eXBlLmdldExvZ1BhdGggPSBmdW4KIH07CiAKIENIUk9NSVVN X0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJNYXN0ZXIoJ0Nocm9taXVtJywgJ2h0dHA6Ly9i dWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS9idWlsZGVycy8nKTsKK0NIUk9NSVVNX0NIUk9N SVVNT1NfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1DaHJvbWl1 bU9TJywgJ2h0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS5jaHJvbWl1bW9zL2J1 aWxkZXJzLycpOwogQ0hST01JVU1fV0VCS0lUX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJN YXN0ZXIoJ0Nocm9taXVtV2Via2l0JywgJ2h0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJv bWl1bS53ZWJraXQvYnVpbGRlcnMvJyk7CiBDSFJPTUlVTV9HUFVfQlVJTERFUl9NQVNURVIgPSBu ZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1HUFUnLCAnaHR0cDovL2J1aWxkLmNocm9taXVtLm9y Zy9wL2Nocm9taXVtLmdwdS9idWlsZGVycy8nKTsKIFdFQktJVF9CVUlMREVSX01BU1RFUiA9IG5l dyBCdWlsZGVyTWFzdGVyKCd3ZWJraXQub3JnJywgJ2h0dHA6Ly9idWlsZC53ZWJraXQub3JnL2J1 aWxkZXJzLycpOwpAQCAtMTUyLDYgKzE1Myw3IEBAIHZhciBMQVlPVVRfVEVTVFNfQlVJTERFUl9H Uk9VUFMgPSB7CiAKIHZhciBMRUdBQ1lfQlVJTERFUl9NQVNURVJTX1RPX0dST1VQUyA9IHsKICAg ICAnQ2hyb21pdW0nOiAnQERFUFMgLSBjaHJvbWl1bS5vcmcnLAorICAgICdDaHJvbWl1bUNocm9t aXVtT1MnOiAnQERFUFMgQ3JPUyAtIGNocm9taXVtLm9yZycsCiAgICAgJ0Nocm9taXVtV2Via2l0 JzogJ0BUb1QgLSBjaHJvbWl1bS5vcmcnLAogICAgICd3ZWJraXQub3JnJzogJ0BUb1QgLSB3ZWJr aXQub3JnJwogfTsKQEAgLTIwOSw3ICsyMTEsMTMgQEAgdmFyIENIUk9NSVVNX0dURVNUU19ERVBT X0JVSUxERVJTID0gWwogXTsKIGFzc29jaWF0ZUJ1aWxkZXJzV2l0aE1hc3RlcihDSFJPTUlVTV9H VEVTVFNfREVQU19CVUlMREVSUywgQ0hST01JVU1fQlVJTERFUl9NQVNURVIpOwogCi12YXIgQ0hS T01JVU1fR1RFU1RTX1RPVF9CVUlMREVSUyA9IFsKK3ZhciBDSFJPTUlVTV9DSFJPTUlVTU9TX0dU RVNUU19ERVBTX0JVSUxERVJTID0gWworICAgIFsnTGludXggQ2hyb21pdW1PUycsIEJ1aWxkZXJH cm91cC5ERUZBVUxUX0JVSUxERVJdLAorICAgIFsnTGludXggQ2hyb21pdW1PUyBUZXN0cyAoZGJn KSddLAorXTsKK2Fzc29jaWF0ZUJ1aWxkZXJzV2l0aE1hc3RlcihDSFJPTUlVTV9DSFJPTUlVTU9T X0dURVNUU19ERVBTX0JVSUxERVJTLCBDSFJPTUlVTV9DSFJPTUlVTU9TX0JVSUxERVJfTUFTVEVS KTsKKworIHZhciBDSFJPTUlVTV9HVEVTVFNfVE9UX0JVSUxERVJTID0gWwogICAgIFsnV2luIChk YmcpJywgQnVpbGRlckdyb3VwLkRFRkFVTFRfQlVJTERFUl0sCiAgICAgWydNYWMxMC42IFRlc3Rz J10sCiAgICAgWydMaW51eCBUZXN0cyddLApAQCAtMjE4LDYgKzIyNiw3IEBAIGFzc29jaWF0ZUJ1 aWxkZXJzV2l0aE1hc3RlcihDSFJPTUlVTV9HVEUKIAogdmFyIENIUk9NSVVNX0dURVNUU19CVUlM REVSX0dST1VQUyA9IHsKICAgICAnQERFUFMgLSBjaHJvbWl1bS5vcmcnOiBuZXcgQnVpbGRlckdy b3VwKEJ1aWxkZXJHcm91cC5ERVBTX1dFQktJVCwgQ0hST01JVU1fR1RFU1RTX0RFUFNfQlVJTERF UlMpLAorICAgICdAREVQUyBDck9TIC0gY2hyb21pdW0ub3JnJzogbmV3IEJ1aWxkZXJHcm91cChC dWlsZGVyR3JvdXAuREVQU19XRUJLSVQsIENIUk9NSVVNX0NIUk9NSVVNT1NfR1RFU1RTX0RFUFNf QlVJTERFUlMpLAogICAgICdAVG9UIC0gY2hyb21pdW0ub3JnJzogbmV3IEJ1aWxkZXJHcm91cChC dWlsZGVyR3JvdXAuVE9UX1dFQktJVCwgQ0hST01JVU1fR1RFU1RTX1RPVF9CVUlMREVSUyksCiB9 OwogCkluZGV4OiBUb29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hi b2FyZF9iYXNlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMJKHJldmlzaW9uIDEwNzI3NSkKKysrIFRvb2xz L1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMJKHdv cmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0vLyBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKy8vIENvcHlyaWdodCAoQykgMjAxMiBHb29nbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogLy8KIC8vIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogLy8gbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z IGFyZQpAQCAtMTc3LDcgKzE3Nyw4IEBAIGZ1bmN0aW9uIGhhbmRsZVZhbGlkSGFzaFBhcmFtZXRl cldyYXBwZXIKIAogICAgIGNhc2UgJ2dyb3VwJzoKICAgICAgICAgdmFsaWRhdGVQYXJhbWV0ZXIo Z19jdXJyZW50U3RhdGUsIGtleSwgdmFsdWUsCi0gICAgICAgICAgICBmdW5jdGlvbigpIHsgcmV0 dXJuIHZhbHVlIGluIExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQUzsgfSk7CisgICAgICAgICAg ICBmdW5jdGlvbigpIHsgcmV0dXJuIHZhbHVlIGluIExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQ UyB8fAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZSBpbiBDSFJPTUlVTV9H VEVTVFNfQlVJTERFUl9HUk9VUFM7IH0pOwogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8v IEZJWE1FOiByZW1vdmUgc3VwcG9ydCBmb3IgdGhpcyBwYXJhbWV0ZXIgb25jZSB0aGUgd2F0ZXJm YWxsIHN0YXJ0cyB0bwo= 126792 2012-02-13 10:36:12 -0800 2012-02-13 21:19:38 -0800 Patch bug-78495-20120213133610.patch text/plain 4150 flackr SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNzU4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAyLTEzICBSb2IgRmxhY2sgIDxmbGFja3JAY2hyb21pdW0ub3JnPgor CisgICAgICAgIEFkZCBMaW51eCBDaHJvbWl1bU9TIHRlc3QgcmVzdWx0cyB0byBmbGFraW5lc3Mg ZGFzaGJvYXJkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Nzg0OTUKKworICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgorCisgICAgICAgICog VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qczoKKyAgICAgICAg KiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzOgor CiAyMDEyLTAyLTA2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2Jp PgogCiAgICAgICAgIFtFRkxdIERyb3Agc3VwcG9ydCBmb3IgdGhlIEN1cmwgbmV0d29yayBiYWNr ZW5kLgpJbmRleDogVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWls ZGVycy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNo Ym9hcmRzL2J1aWxkZXJzLmpzCShyZXZpc2lvbiAxMDcyNzUpCisrKyBUb29scy9UZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0x LDQgKzEsNCBAQAotLy8gQ29weXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisvLyBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KIC8vCiAvLyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKIC8vIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTQxLDYgKzQx LDcgQEAgQnVpbGRlck1hc3Rlci5wcm90b3R5cGUuZ2V0TG9nUGF0aCA9IGZ1bgogfTsKIAogQ0hS T01JVU1fQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW0nLCAnaHR0 cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtL2J1aWxkZXJzLycpOworQ0hST01JVU1P U19CVUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bUNocm9taXVtT1Mn LCAnaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLmNocm9taXVtb3MvYnVpbGRl cnMvJyk7CiBDSFJPTUlVTV9XRUJLSVRfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3Rl cignQ2hyb21pdW1XZWJraXQnLCAnaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVt LndlYmtpdC9idWlsZGVycy8nKTsKIENIUk9NSVVNX0dQVV9CVUlMREVSX01BU1RFUiA9IG5ldyBC dWlsZGVyTWFzdGVyKCdDaHJvbWl1bUdQVScsICdodHRwOi8vYnVpbGQuY2hyb21pdW0ub3JnL3Av Y2hyb21pdW0uZ3B1L2J1aWxkZXJzLycpOwogV0VCS0lUX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1 aWxkZXJNYXN0ZXIoJ3dlYmtpdC5vcmcnLCAnaHR0cDovL2J1aWxkLndlYmtpdC5vcmcvYnVpbGRl cnMvJyk7CkBAIC0xNTIsNiArMTUzLDcgQEAgdmFyIExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQ UyA9IHsKIAogdmFyIExFR0FDWV9CVUlMREVSX01BU1RFUlNfVE9fR1JPVVBTID0gewogICAgICdD aHJvbWl1bSc6ICdAREVQUyAtIGNocm9taXVtLm9yZycsCisgICAgJ0Nocm9taXVtQ2hyb21pdW1P Uyc6ICdAREVQUyBDck9TIC0gY2hyb21pdW0ub3JnJywKICAgICAnQ2hyb21pdW1XZWJraXQnOiAn QFRvVCAtIGNocm9taXVtLm9yZycsCiAgICAgJ3dlYmtpdC5vcmcnOiAnQFRvVCAtIHdlYmtpdC5v cmcnCiB9OwpAQCAtMjA5LDcgKzIxMSwxMyBAQCB2YXIgQ0hST01JVU1fR1RFU1RTX0RFUFNfQlVJ TERFUlMgPSBbCiBdOwogYXNzb2NpYXRlQnVpbGRlcnNXaXRoTWFzdGVyKENIUk9NSVVNX0dURVNU U19ERVBTX0JVSUxERVJTLCBDSFJPTUlVTV9CVUlMREVSX01BU1RFUik7CiAKLXZhciBDSFJPTUlV TV9HVEVTVFNfVE9UX0JVSUxERVJTID0gWwordmFyIENIUk9NSVVNT1NfR1RFU1RTX0RFUFNfQlVJ TERFUlMgPSBbCisgICAgWydMaW51eCBDaHJvbWl1bU9TJywgQnVpbGRlckdyb3VwLkRFRkFVTFRf QlVJTERFUl0sCisgICAgWydMaW51eCBDaHJvbWl1bU9TIFRlc3RzIChkYmcpJ10sCitdOworYXNz b2NpYXRlQnVpbGRlcnNXaXRoTWFzdGVyKENIUk9NSVVNT1NfR1RFU1RTX0RFUFNfQlVJTERFUlMs IENIUk9NSVVNT1NfQlVJTERFUl9NQVNURVIpOworCisgdmFyIENIUk9NSVVNX0dURVNUU19UT1Rf QlVJTERFUlMgPSBbCiAgICAgWydXaW4gKGRiZyknLCBCdWlsZGVyR3JvdXAuREVGQVVMVF9CVUlM REVSXSwKICAgICBbJ01hYzEwLjYgVGVzdHMnXSwKICAgICBbJ0xpbnV4IFRlc3RzJ10sCkBAIC0y MTgsNiArMjI2LDcgQEAgYXNzb2NpYXRlQnVpbGRlcnNXaXRoTWFzdGVyKENIUk9NSVVNX0dURQog CiB2YXIgQ0hST01JVU1fR1RFU1RTX0JVSUxERVJfR1JPVVBTID0gewogICAgICdAREVQUyAtIGNo cm9taXVtLm9yZyc6IG5ldyBCdWlsZGVyR3JvdXAoQnVpbGRlckdyb3VwLkRFUFNfV0VCS0lULCBD SFJPTUlVTV9HVEVTVFNfREVQU19CVUlMREVSUyksCisgICAgJ0BERVBTIENyT1MgLSBjaHJvbWl1 bS5vcmcnOiBuZXcgQnVpbGRlckdyb3VwKEJ1aWxkZXJHcm91cC5ERVBTX1dFQktJVCwgQ0hST01J VU1PU19HVEVTVFNfREVQU19CVUlMREVSUyksCiAgICAgJ0BUb1QgLSBjaHJvbWl1bS5vcmcnOiBu ZXcgQnVpbGRlckdyb3VwKEJ1aWxkZXJHcm91cC5UT1RfV0VCS0lULCBDSFJPTUlVTV9HVEVTVFNf VE9UX0JVSUxERVJTKSwKIH07CiAKSW5kZXg6IFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJl c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcwkocmV2aXNpb24g MTA3Mjc1KQorKysgVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNo Ym9hcmRfYmFzZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLS8vIENvcHlyaWdo dCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorLy8gQ29weXJpZ2h0 IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAvLwogLy8gUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAvLyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0xNzcsNyArMTc3LDEwIEBAIGZ1bmN0aW9uIGhhbmRs ZVZhbGlkSGFzaFBhcmFtZXRlcldyYXBwZXIKIAogICAgIGNhc2UgJ2dyb3VwJzoKICAgICAgICAg dmFsaWRhdGVQYXJhbWV0ZXIoZ19jdXJyZW50U3RhdGUsIGtleSwgdmFsdWUsCi0gICAgICAgICAg ICBmdW5jdGlvbigpIHsgcmV0dXJuIHZhbHVlIGluIExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQ UzsgfSk7CisgICAgICAgICAgICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgcmV0dXJuIHZh bHVlIGluIExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQUyB8fAorICAgICAgICAgICAgICAgICAg dmFsdWUgaW4gQ0hST01JVU1fR1RFU1RTX0JVSUxERVJfR1JPVVBTOworICAgICAgICAgICAgfSk7 CiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8gRklYTUU6IHJlbW92ZSBzdXBwb3J0IGZv ciB0aGlzIHBhcmFtZXRlciBvbmNlIHRoZSB3YXRlcmZhbGwgc3RhcnRzIHRvCg==