78470 2012-02-13 00:26:55 -0800 Improve usability of coding-style.html 2012-02-16 17:16:55 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76428 1 tkent tkent levin mitz oldest_to_newest 555080 0 tkent 2012-02-13 00:26:55 -0800 Comment from mitz: > This change made it extremely hard to use double- or triple-clicking to select anything on the Coding Style Guidelines webpage, and to click to clear the selection. In OS X, it also made WebKit almost always show a tool tip over the page, obscuring the content. 556864 1 127099 tkent 2012-02-14 18:52:58 -0800 Created attachment 127099 Patch 558480 2 127099 eric 2012-02-16 13:38:27 -0800 Comment on attachment 127099 Patch OK. 558696 3 127099 tkent 2012-02-16 16:57:24 -0800 Comment on attachment 127099 Patch Clearing flags on attachment: 127099 Committed r108002: <http://trac.webkit.org/changeset/108002> 558698 4 tkent 2012-02-16 16:57:30 -0800 All reviewed patches have been landed. Closing bug. 558726 5 mitz 2012-02-16 17:16:55 -0800 Thank you. 127099 2012-02-14 18:52:58 -0800 2012-02-16 16:57:24 -0800 Patch bug-78470-20120215115256.patch text/plain 2331 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NzEwCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDYzNzg4 ZTZkNjZhYWJmOWY1OTQ4YjIyMmRkZTVlZTk1ZDllYWFjNWMuLmZkNWQyZTZiZDNjNGM2MmQxNmQw ZmRiYWFhZWQ2Mjg1MmI0YjIyODggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDItMTQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIEltcHJvdmUgdXNhYmlsaXR5IG9mIGNvZGluZy1zdHlsZS5odG1sCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODQ3MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5o dG1sOgorICAgICAgICAtIERvIG5vdCBhZGQgYSB0aXRsZSBhdHRyaWJ1dGUgdG8gZWFjaCBvZiBM SSBlbGVtZW50cworICAgICAgICAtIERvIG5vdCBhZGQgYSBjbGljayBoYW5kbGVyIHRvIGVhY2gg b2YgdGhlbQorICAgICAgICAtIEFkZCBhIFNQQU4gZWxlbWVudCBpbiBvcmRlciB0byBzaG93IFtp ZC1uYW1lXSBhbmQgcHJvdmlkZSBzbWFsbGVyIGNsaWNrYWJsZSBhcmVhLgorCiAyMDEyLTAxLTIz ICBTZW8gU2FuZ2h5ZW9uICA8c2g0LnNlb0BzYW1zdW5nLmNvbT4KIAogICAgICAgICB3ZWJzaXRl OiBSZXdvcmQgV0VCS0lUT1VUUFVURElSIGRvY3VtZW50YXRpb24gb24gQnVpbGRpbmcgV2ViS2l0 IHBhZ2UKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvZGluZy1zdHls ZS5odG1sIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKaW5k ZXggMDhkMDY0MjJjMmI4YzU2ZmIyYTYxMWNmNTNjMDA4MDI1YjI2MTkyMS4uNDM0YmI4MDU3Mjdj ODE2NzM3ZjJhN2U2ZTcxOTY4ZDcwMzhiNThhOSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0 Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9j b2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKQEAgLTE0LDYgKzE0LDEyIEBAIHByZSAuY29kZSB7CiAu d3JvbmcgewogICBjb2xvcjogI2YwMCAhaW1wb3J0YW50OwogfQorCisuaWRidXR0b24geworICBj b2xvcjogIzg4ODsKKyAgZm9udC1zaXplOiBzbWFsbGVyOworICBjdXJzb3I6IHBvaW50ZXI7Cit9 CiA8L3N0eWxlPgogCiAKQEAgLTExMDQsMTEgKzExMTAsMTQgQEAgZHJhd0pwZygpOyAvLyBUT0RP OiBNYWtlIHRoaXMgY29kZSBoYW5kbGUganBnIGluIGFkZGl0aW9uIHRvIHRoZSBwbmcgc3VwcG9y dC4KICAgICAgICAgdmFyIGl0ZW0gPSBsaXN0SXRlbXNbaV07CiAgICAgICAgIGlmICghaXRlbS5p ZCkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBpdGVtLnNldEF0dHJpYnV0ZSgndGl0 bGUnLCAnIycgKyBsaXN0SXRlbXNbaV0uaWQpOwotICAgICAgICBpdGVtLnN0eWxlLmN1cnNvciA9 ICdwb2ludGVyJzsKLSAgICAgICAgaXRlbS5hZGRFdmVudExpc3RlbmVyKCdjbGljaycsIGZ1bmN0 aW9uKGV2ZW50KSB7Ci0gICAgICAgICAgICB3aW5kb3cubG9jYXRpb24uaGFzaCA9IGV2ZW50LmN1 cnJlbnRUYXJnZXQudGl0bGU7CisgICAgICAgIHZhciBidXR0b24gPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdzcGFuJyk7CisgICAgICAgIGJ1dHRvbi5jbGFzc05hbWUgPSAnaWRidXR0b24nOwor ICAgICAgICBidXR0b24uc2V0QXR0cmlidXRlKCdkYXRhLXRhcmdldC1pZCcsIGxpc3RJdGVtc1tp XS5pZCk7CisgICAgICAgIGJ1dHRvbi5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9k ZSgnIFsnICsgbGlzdEl0ZW1zW2ldLmlkICsgJ10nKSk7CisgICAgICAgIGJ1dHRvbi5hZGRFdmVu dExpc3RlbmVyKCdjbGljaycsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgICAgICB3aW5kb3cu bG9jYXRpb24uaGFzaCA9ICcjJyArIGV2ZW50LmN1cnJlbnRUYXJnZXQuZ2V0QXR0cmlidXRlKCdk YXRhLXRhcmdldC1pZCcpOwogICAgICAgICB9KTsKKyAgICAgICAgbGlzdEl0ZW1zW2ldLmFwcGVu ZENoaWxkKGJ1dHRvbik7CiAgICAgICAgIGlmIChpZHNVc2VkW2l0ZW0uaWRdKQogICAgICAgICAg ICAgYWxlcnQoJ1RoZSBpZCAnICsgaXRlbS5pZCArICcgaXMgdXNlZCBtb3JlIHRoYW4gb25jZSBp biB0aGlzIGRvY3VtZW50LicpOwogICAgICAgICBpZHNVc2VkW2l0ZW0uaWRdID0gMTsK