78466 2012-02-12 23:56:38 -0800 Add [JSCustomToJSObject] IDL attribute to interfaces that have custom toJS() but do not have custom toV8() 2012-02-13 02:24:47 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 555059 0 haraken 2012-02-12 23:56:38 -0800 The goal is to remove hard-coding in HasCustomToV8Implementation() in CodeGeneratorV8.pm, in the following steps: (1) Add [V8CustomToJSObject] to interfaces which have custom toV8() but do not have custom toJS(). (2) Replace [JSCustomToJS] with [JSCustomToJSObject] for interfaces which have custom toJS() but do not have custom toV8(). (3) Replace [JSCustomToJS] with [CustomToJSObject] for interfaces which have custom toV8() and toJS(). (4) Remove HasCustomToV8Implementation() from CodeGeneratorV8.pm. In this bug we fixes (2). 555063 1 126728 haraken 2012-02-13 00:02:45 -0800 Created attachment 126728 Patch 555071 2 haraken 2012-02-13 00:11:55 -0800 BTW, I noticed the hard-coding had been buggy...:-) return 1 if $interfaceName eq "DOMStringMap"; return 1 if $interfaceName eq "DOMTokenList"; ...; return 0 if $interfaceName eq "DOMStringMap"; return 0 if $interfaceName eq "DOMTokenList"; http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm&exact_package=chromium&q=codegeneratorv8.pm&type=cs&l=3136 555073 3 abarth 2012-02-13 00:16:34 -0800 > BTW, I noticed the hard-coding had been buggy...:-) I'm not surprised. :) 555126 4 126728 webkit.review.bot 2012-02-13 02:24:42 -0800 Comment on attachment 126728 Patch Clearing flags on attachment: 126728 Committed r107553: <http://trac.webkit.org/changeset/107553> 555127 5 webkit.review.bot 2012-02-13 02:24:47 -0800 All reviewed patches have been landed. Closing bug. 126728 2012-02-13 00:02:45 -0800 2012-02-13 02:24:42 -0800 Patch bug-78466-20120213170244.patch text/plain 5370 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE0NDM0MzhmZDY4MGEw N2ZiNjJiMWQ0MDM4NDI4NWFmNzg2ODE0Ny4uOTY4ODk4NTk3NTRjMTYxNTU1NWY0ZTRhYWZiMDM5 YzZkZTMzY2NjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTAyLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgW0pTQ3VzdG9t VG9KU09iamVjdF0gSURMIGF0dHJpYnV0ZSB0byBpbnRlcmZhY2VzIHRoYXQgaGF2ZQorICAgICAg ICBjdXN0b20gdG9KUygpIGJ1dCBkbyBub3QgaGF2ZSBjdXN0b20gdG9WOCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODQ2NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhlIHNlY29uZCBz dGVwIHRvIHJlbW92ZSBoYXJkLWNvZGluZyBpbiBIYXNDdXN0b21Ub1Y4SW1wbGVtZW50YXRpb24o KQorICAgICAgICBpbiBDb2RlR2VuZXJhdG9yVjgucG0uIFRoaXMgcGF0Y2ggcmVwbGFjZXMgW0pT Q3VzdG9tVG9KU10gd2l0aCBbSlNDdXN0b21Ub0pTT2JqZWN0XQorICAgICAgICBmb3IgaW50ZXJm YWNlcyB3aGljaCBoYXZlIGN1c3RvbSB0b0pTKCkgYnV0IGRvIG5vdCBoYXZlIGN1c3RvbSB0b1Y4 KCkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJh dGVIZWFkZXIpOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChIYXNDdXN0b21U b1Y4SW1wbGVtZW50YXRpb24pOiBJIGZvdW5kIHRoYXQgQWJzdHJhY3RXb3JrZXIgYW5kIENhbnZh c1JlbmRlcmluZ0NvbnRleHQKKyAgICAgICAgYXJlIHRoZSBvbmx5IElETCBmaWxlcyB0byB3aGlj aCBJIG5lZWQgdG8gYWRkIFtKU0N1c3RvbVRvSlNPYmplY3RdLgorICAgICAgICBPdGhlciBJREwg ZmlsZXMgd2hpY2ggaGFkIGJlZW4gbGlzdGVkIGhlcmUgZG8gbm90IGhhdmUgW0pTQ3VzdG9tVG9K U10uCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dC5pZGw6Cisg ICAgICAgICogd29ya2Vycy9BYnN0cmFjdFdvcmtlci5pZGw6CisKIDIwMTItMDItMTIgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBOYXZpZ2F0b3Iud2Via2l0R2V0 VXNlck1lZGlhIGRvZXNuJ3QgbmVlZCB0byBiZSBjdXN0b20KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggNzIwN2JmOGYzM2E4 NTM4Mjg5NTQzOGQ4YjI5ZDdkMmY4Y2Y4NTc0ZC4uM2Q4MTljMWYxZTlhMmQ4MDM5YmM5OTI4ZTIw YWEyZTRlNTg4NzEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTEwMDMsNyArMTAwMyw3IEBAIHN1YiBHZW5lcmF0ZUhl YWRlcgogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiXG4iKTsKICAgICB9CiAKLSAgICBp ZiAoISRoYXNQYXJlbnQgfHwgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNHZW5l cmF0ZVRvSlMifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0N1c3RvbVRv SlMifSkgeworICAgIGlmICghJGhhc1BhcmVudCB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJKU0dlbmVyYXRlVG9KUyJ9IHx8ICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJKU0N1c3RvbVRvSlMifSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJK U0N1c3RvbVRvSlNPYmplY3QifSkpIHsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIkpT Qzo6SlNWYWx1ZSB0b0pTKEpTQzo6RXhlY1N0YXRlKiwgSlNET01HbG9iYWxPYmplY3QqLCAkaW1w bFR5cGUqKTtcbiIpOwogICAgIH0KICAgICBpZiAoISRoYXNQYXJlbnQgfHwgJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNHZW5lcmF0ZVRvTmF0aXZlT2JqZWN0In0pIHsKQEAgLTIz MTAsNyArMjMxMCw3IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgIHB1c2go QGltcGxDb250ZW50LCAifVxuXG4iKTsKICAgICB9CiAKLSAgICBpZiAoKCEkaGFzUGFyZW50IG9y ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTR2VuZXJhdGVUb0pTIn0pIGFuZCAh JGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSlNDdXN0b21Ub0pTIn0pIHsKKyAgICBp ZiAoKCEkaGFzUGFyZW50IG9yICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTR2Vu ZXJhdGVUb0pTIn0pIGFuZCAhKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3Vz dG9tVG9KUyJ9IG9yICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3VzdG9tVG9K U09iamVjdCJ9KSkgewogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIkpTQzo6SlNWYWx1ZSB0 b0pTKEpTQzo6RXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0 LCAkaW1wbFR5cGUqIGltcGwpXG4iKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ7XG4i KTsKICAgICAgICAgaWYgKCRzdmdQcm9wZXJ0eVR5cGUpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYzZkODU4Njc1MjU3 ODIyMjFiZTY0YzdkNTdjYzliNTYwZjhkOTMzOC4uMDJiODUyZTZiNzNkMTBjZWUzOWMxYTFkYjFh OGEzMDRhMDUwNzA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTMxMDgsMjAgKzMxMDgsNiBAQCBzdWIgSGFzQ3VzdG9t VG9WOEltcGxlbWVudGF0aW9uIHsKIAogICAgIHJldHVybiAxIGlmICRkYXRhTm9kZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tVG9KU09iamVjdCJ9OwogCi0gICAgIyBXZSBkb24ndCBn ZW5lcmF0ZSBhIGN1c3RvbSBjb252ZXJ0ZXIgKGJ1dCBKU0MgZG9lcykgZm9yIHRoZSBmb2xsb3dp bmc6Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFjZU5hbWUgZXEgIkFic3RyYWN0V29ya2VyIjsK LSAgICByZXR1cm4gMCBpZiAkaW50ZXJmYWNlTmFtZSBlcSAiQ2FudmFzUmVuZGVyaW5nQ29udGV4 dCI7Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFjZU5hbWUgZXEgIlNWR0VsZW1lbnRJbnN0YW5j ZSI7Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFjZU5hbWUgZXEgIk5vZGVMaXN0IjsKLSAgICBy ZXR1cm4gMCBpZiAkaW50ZXJmYWNlTmFtZSBlcSAiQ1NTUnVsZUxpc3QiOwotICAgIHJldHVybiAw IGlmICRpbnRlcmZhY2VOYW1lIGVxICJDU1NTdHlsZURlY2xhcmF0aW9uIjsKLSAgICByZXR1cm4g MCBpZiAkaW50ZXJmYWNlTmFtZSBlcSAiTWVkaWFMaXN0IjsKLSAgICByZXR1cm4gMCBpZiAkaW50 ZXJmYWNlTmFtZSBlcSAiU3R5bGVTaGVldExpc3QiOwotICAgIHJldHVybiAwIGlmICRpbnRlcmZh Y2VOYW1lIGVxICJET01JbXBsZW1lbnRhdGlvbiI7Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFj ZU5hbWUgZXEgIkRPTVN0cmluZ01hcCI7Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFjZU5hbWUg ZXEgIkRPTVRva2VuTGlzdCI7Ci0gICAgcmV0dXJuIDAgaWYgJGludGVyZmFjZU5hbWUgZXEgIlRl eHRUcmFjayI7Ci0KICAgICAjIEZvciBldmVyeXRoaW5nIGVsc2UsIGRvIHdoYXQgSlNDIGRvZXMu CiAgICAgcmV0dXJuICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3VzdG9tVG9K UyJ9OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVu ZGVyaW5nQ29udGV4dC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5k ZXJpbmdDb250ZXh0LmlkbAppbmRleCBhY2RkMGI3NWNhZDAxNDg2ZGIwNzdlMWE0NTQyYzllZjNl ZmQ5MWU2Li5iOTM3MzkzMWY2ZjY1ZjYzZjIzNDdiNzEyNzI4NDliZTExZDQ4ZTkzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0Lmlk bAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 LmlkbApAQCAtMjgsNyArMjgsNyBAQCBtb2R1bGUgaHRtbCB7CiAgICAgaW50ZXJmYWNlIFsKICAg ICAgICAgSlNDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIEpTR2VuZXJhdGVJc1JlYWNoYWJs ZSwKLSAgICAgICAgSlNDdXN0b21Ub0pTCisgICAgICAgIEpTQ3VzdG9tVG9KU09iamVjdAogICAg IF0gQ2FudmFzUmVuZGVyaW5nQ29udGV4dCB7CiAKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IEhUTUxDYW52YXNFbGVtZW50IGNhbnZhczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvQWJzdHJhY3RXb3JrZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9BYnN0cmFj dFdvcmtlci5pZGwKaW5kZXggZTExZTM0YzEwM2Y2ZjU5NzE2ZDNkOTgwYTQ0YTc2MWRjMzQ3N2Qw Mi4uM2M5MGQxZWQ3OTdiZWQ4MTQwMzIxZmNiZjY1ZTdhOGJlM2IxYzQ3OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvd29ya2Vycy9BYnN0cmFjdFdvcmtlci5pZGwKKysrIGIvU291cmNlL1dl YkNvcmUvd29ya2Vycy9BYnN0cmFjdFdvcmtlci5pZGwKQEAgLTM0LDcgKzM0LDcgQEAgbW9kdWxl IHRocmVhZHMgewogICAgIGludGVyZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPVdPUktFUlMs CiAgICAgICAgIEFjdGl2ZURPTU9iamVjdCwKLSAgICAgICAgSlNDdXN0b21Ub0pTLAorICAgICAg ICBKU0N1c3RvbVRvSlNPYmplY3QsCiAgICAgICAgIEV2ZW50VGFyZ2V0CiAgICAgXSBBYnN0cmFj dFdvcmtlciB7CiAK