78444 2012-02-12 16:43:52 -0800 [Qt] Middle clicking a scrollbar causes text to be pasted. 2012-07-11 08:05:44 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 yatt12+webkit webkit-unassigned bruno.abinader hausmann igor.oliveira steffen.imhof webkit.review.bot oldest_to_newest 554884 0 yatt12+webkit 2012-02-12 16:43:52 -0800 QtWebKit version 2.2.1 Whenever I have a text field selected and middle click on the scroll bar to scroll to a particular part of the page, the text from my clipboard is pasted to the text field. Reproducible: Always Reproducible with: rekonq, arora, qupzilla Steps to Reproduce: 1. Select and copy the title of this bug report 2. Resize browser so the scroll bar is visible 3. Click on the comment text area in this bug report 4. Middle click on the scroll bar 3. Middle click on the scroll bar Actual Results: The scroll bar jumps to the clicked location, then jumps back and the copied text is in the text field. Expected Results: The scroll bar jumps to the clicked location, stays there, and no text is pasted 630392 1 143305 steffen.imhof 2012-05-22 08:25:53 -0700 Created attachment 143305 Patch with fix and improved layout test I had a look into this and think that the clipboard handling should simply not be executed when the event was already handled. When checking how to make a layout test for this, I stumbled upon an existing one. But this was a PASS all the time (at least for the Qt version). So I changed the test to be a bit more like the use case described in this bug (using an <input> field). Now it correctly switches from FAIL to PASS when the change in qwebpage.cpp is applied. 631949 2 143305 hausmann 2012-05-23 13:09:23 -0700 Comment on attachment 143305 Patch with fix and improved layout test The patch (again) looks correct to me, but I would really like to see a slightly more elaborate explanation in the ChangeLog why the change in the layout test makes it more sensitive to triggering this bug. Since this is a cross-port/platform layout test it may not be obvious, especially not when looking at the ChangeLog in three months and all we see is "made it more sensitive" :) 632548 3 143770 steffen.imhof 2012-05-24 02:26:54 -0700 Created attachment 143770 Patch with more elaborate LayoutTests ChangeLog Ok, a reasonable request :-) I tried to explain the changed test a bit more in the ChangeLog. What I manually tried, besides the Qt case, was a recent Chromium build. For Chromium the original test seemed to work, but the new one works, too. I am not sure if the not-triggering of onpaste on the non-editable <body> is another bug in Qt? I did not find something like a specification for onpaste... as far as I could see it was originally introduced in Internet Explorer, so it's probably not well specified. FWIW Firefox did not trigger onpaste for <body> either. Just for my education: All green EWS bots should indicate that the changed test does not break any of the tested platforms now, right? 633907 4 hausmann 2012-05-25 07:36:16 -0700 (In reply to comment #3) > Just for my education: All green EWS bots should indicate that the changed test does not break any of the tested platforms now, right? It merely indicates that the patch _builds_ on those platforms. Only the chromium EWS is fast enough currently to also _run_ the tests (unless that test is skipped). So this should probably be landed manually with care. 635750 5 steffen.imhof 2012-05-29 02:05:56 -0700 (In reply to comment #4) > It merely indicates that the patch _builds_ on those platforms. Only the chromium EWS is fast enough currently to also _run_ the tests (unless that test is skipped). So this should probably be landed manually with care. Ok, thanks for the info. So how will this proceed? Can you do the manual landing or shall I just ask "someone" on IRC? 666691 6 143770 bruno.abinader 2012-07-11 05:33:29 -0700 Comment on attachment 143770 Patch with more elaborate LayoutTests ChangeLog Asking "commit-queue" flag. 666762 7 143770 webkit.review.bot 2012-07-11 08:05:40 -0700 Comment on attachment 143770 Patch with more elaborate LayoutTests ChangeLog Clearing flags on attachment: 143770 Committed r122333: <http://trac.webkit.org/changeset/122333> 666763 8 webkit.review.bot 2012-07-11 08:05:44 -0700 All reviewed patches have been landed. Closing bug. 143305 2012-05-22 08:25:53 -0700 2012-05-24 02:26:54 -0700 Patch with fix and improved layout test 78444_middle_click_scrollbar.patch text/plain 3030 steffen.imhof ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZDZiOWRiLi5jNGZmNjg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUt MjIgIFN0ZWZmZW4gSW1ob2YgIDxzdGVmZmVuLmltaG9mQGJhc3lza29tLmNvbT4KKworICAgICAg ICBbUXRdIE1pZGRsZSBjbGlja2luZyBhIHNjcm9sbGJhciBjYXVzZXMgdGV4dCB0byBiZSBwYXN0 ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODQ0 NAorCisgICAgICAgIFVwZGF0ZWQgYSBsYXlvdXQgdGVzdCB0byBiZSBhIGJpdCBtb3JlIHNlbnNp dGl2ZSwgYXMgaXQgZGlkIG5vdCBzaG93CisgICAgICAgIHRoZSBidWcgaW4gdGhlIFF0IHBvcnQg YmVmb3JlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc2Nyb2xsYmFycy9zY3JvbGxiYXItbWlkZGxlY2xpY2stbm9wYXN0ZS5odG1sOgorCiAyMDEy LTA1LTIyICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYXJr IHR3byB0ZXN0cyBhcyBza2lwcGVkIHdoaWxlIHdlIGZpZ3VyZSBvdXQgd2h5IHRoZXkgYXJlIGZh aWxpbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1taWRk bGVjbGljay1ub3Bhc3RlLmh0bWwgYi9MYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1t aWRkbGVjbGljay1ub3Bhc3RlLmh0bWwKaW5kZXggOTEzODJkZTIuLjNjNzY4NTEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLW1pZGRsZWNsaWNrLW5vcGFzdGUu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1taWRkbGVjbGljay1u b3Bhc3RlLmh0bWwKQEAgLTEwLDkgKzEwLDEyIEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpIHsKIAogPGRpdiBpZD0iY29uc29sZSIgc3R5bGU9IndpZHRoOjIwMCU7aGVpZ2h0OjIw MCU7Ij4KIDxkaXYgc3R5bGU9ImJvcmRlcjoycHggc29saWQgYmxhY2s7d2lkdGg6MjUlOyIgb25j bGljaz0iZmluaXNoZWQoKTsiPiBUaGlzIHRlc3QgY2hlY2tzIHRoYXQgbWlkZGxlIGNsaWNraW5n IHRoZSBzY3JvbGwgYmFycyBkb2Vzbid0IHRyaWdnZXIgYSBwYXN0ZSBldmVudCAoU2VlIDxhIGhy ZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzA2MiI+QnVnIDMz MDYyPC9hPikuIElmIHRoZSB0ZXN0IHBhc3NlcywgdGhlIG91dHB1dCB3aWxsIGJlIGEgc2luZ2xl IGxpbmUgdGhhdCBzYXlzIFBBU1MuIFRvIHJ1biB0aGUgdGVzdHMgbWFudWFsbHksIG1pZGRsZSBj bGljayBlYWNoIG9mIHRoZSBzY3JvbGwgYmFycywgdGhlbiBjbGljayB0aGlzIHBhcmFncmFwaC48 L2Rpdj4KKzxpbnB1dCB0eXBlPSJ0ZXh0IiBpZD0iaW5wdXQtZmllbGQiIG9ucGFzdGU9InBhc3Rl Q291bnQrKzsiLz4KIDwvZGl2PgotCiA8c2NyaXB0PgordmFyIGkgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnaW5wdXQtZmllbGQnKTsKK2kuZm9jdXMoKTsKKwogaWYgKHdpbmRvdy5ldmVudFNl bmRlcikgewogICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHdpbmRvdy5pbm5lcldpZHRoIC0g MSwgMSk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKDEpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwCmluZGV4IDJlMzMwYWMuLjM4ZmMxOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKQEAgLTc5NCw3ICs3OTQsOCBAQCB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6bW91c2VSZWxlYXNl RXZlbnQoVCAqZXYpCiAgICAgICAgIGFjY2VwdGVkID0gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5o YW5kbGVNb3VzZVJlbGVhc2VFdmVudChtZXYpOwogICAgIGV2LT5zZXRBY2NlcHRlZChhY2NlcHRl ZCk7CiAKLSAgICBoYW5kbGVDbGlwYm9hcmQoZXYsIGV2LT5idXR0b24oKSk7CisgICAgaWYgKCFl di0+aXNBY2NlcHRlZCgpKQorICAgICAgICBoYW5kbGVDbGlwYm9hcmQoZXYsIGV2LT5idXR0b24o KSk7CiAgICAgaGFuZGxlU29mdHdhcmVJbnB1dFBhbmVsKGV2LT5idXR0b24oKSwgUVBvaW50Rihl di0+cG9zKCkpLnRvUG9pbnQoKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNDY5ZGJlZi4uZGY1 OTViYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNS0yMiAgU3RlZmZl biBJbWhvZiAgPHN0ZWZmZW4uaW1ob2ZAYmFzeXNrb20uY29tPgorCisgICAgICAgIFtRdF0gTWlk ZGxlIGNsaWNraW5nIGEgc2Nyb2xsYmFyIGNhdXNlcyB0ZXh0IHRvIGJlIHBhc3RlZC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4NDQ0CisKKyAgICAg ICAgQ2hlY2sgaWYgdGhlIGV2ZW50IHdhcyBhbHJlYWR5IGFjY2VwdGVkIGJlZm9yZSBoYW5kbGlu ZyB0aGUgY2xpcGJvYXJkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6 bW91c2VSZWxlYXNlRXZlbnQpOgorCiAyMDEyLTA1LTIxICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVp cmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgTW92ZSBz ZXRFZGl0aW5nQmVoYXZpb3IoKSBmcm9tIGxheW91dFRlc3RDb250cm9sbGVyIHRvIHdpbmRvdy5p bnRlcm5hbHMK 143770 2012-05-24 02:26:54 -0700 2012-07-11 08:05:39 -0700 Patch with more elaborate LayoutTests ChangeLog 78444_middle_click_scrollbar_v2.patch text/plain 3361 steffen.imhof ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MWQ5YWM4Li5iNWU0OGY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDUt MjIgIFN0ZWZmZW4gSW1ob2YgIDxzdGVmZmVuLmltaG9mQGJhc3lza29tLmNvbT4KKworICAgICAg ICBbUXRdIE1pZGRsZSBjbGlja2luZyBhIHNjcm9sbGJhciBjYXVzZXMgdGV4dCB0byBiZSBwYXN0 ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODQ0 NAorCisgICAgICAgIFVwZGF0ZWQgdGhlIHNjcm9sbGJhcnMvc2Nyb2xsYmFyLW1pZGRsZWNsaWNr LW5vcGFzdGUuaHRtbCB0ZXN0IHRvIHVzZSBhbgorICAgICAgICA8aW5wdXQ+IGZpZWxkIGFzIHRh cmdldCBmb3Igb25wYXN0ZSBldmVudHMuIFVzaW5nIDxib2R5PiBkaWQgbm90IHdvcmsKKyAgICAg ICAgKGF0IGxlYXN0IGZvciBRdCksIGJlY2F1c2UgdGhlIG9ucGFzdGUgZXZlbnRzIGFyZSBub3Qg ZmlyZWQsIGV2ZW4gaWYKKyAgICAgICAgbWFudWFsbHkgbWlkZGxlLWNsaWNraW5nIGludG8gdGhl IGJvZHkuIE15IGd1ZXNzIHdvdWxkIGJlIHRoYXQgdGhleSBhcmUKKyAgICAgICAgbm90IHNlbnQs IGJlY2F1c2UgdGhlIGJvZHkgaXMgbm9uLWVkaXRhYmxlLiBUaGUgY2hhbmdlZCB0ZXN0IHNob3Vs ZAorICAgICAgICByZWZsZWN0IHRoZSBjb21tb24gdXNlLWNhc2UgdHJpZ2dlcmluZyB0aGUgcHJv YmxlbSBiZXR0ZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBzY3JvbGxiYXJzL3Njcm9sbGJhci1taWRkbGVjbGljay1ub3Bhc3RlLmh0bWw6CisK IDIwMTItMDUtMjMgIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CiAKICAgICAg ICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzM0NwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItbWlkZGxlY2xpY2stbm9w YXN0ZS5odG1sIGIvTGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItbWlkZGxlY2xpY2st bm9wYXN0ZS5odG1sCmluZGV4IDkxMzgyZGUyLi4zYzc2ODUxIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1taWRkbGVjbGljay1ub3Bhc3RlLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItbWlkZGxlY2xpY2stbm9wYXN0ZS5odG1s CkBAIC0xMCw5ICsxMCwxMiBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAK IDxkaXYgaWQ9ImNvbnNvbGUiIHN0eWxlPSJ3aWR0aDoyMDAlO2hlaWdodDoyMDAlOyI+CiA8ZGl2 IHN0eWxlPSJib3JkZXI6MnB4IHNvbGlkIGJsYWNrO3dpZHRoOjI1JTsiIG9uY2xpY2s9ImZpbmlz aGVkKCk7Ij4gVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IG1pZGRsZSBjbGlja2luZyB0aGUgc2Nyb2xs IGJhcnMgZG9lc24ndCB0cmlnZ2VyIGEgcGFzdGUgZXZlbnQgKFNlZSA8YSBocmVmPSJodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMwNjIiPkJ1ZyAzMzA2MjwvYT4pLiBJ ZiB0aGUgdGVzdCBwYXNzZXMsIHRoZSBvdXRwdXQgd2lsbCBiZSBhIHNpbmdsZSBsaW5lIHRoYXQg c2F5cyBQQVNTLiBUbyBydW4gdGhlIHRlc3RzIG1hbnVhbGx5LCBtaWRkbGUgY2xpY2sgZWFjaCBv ZiB0aGUgc2Nyb2xsIGJhcnMsIHRoZW4gY2xpY2sgdGhpcyBwYXJhZ3JhcGguPC9kaXY+Cis8aW5w dXQgdHlwZT0idGV4dCIgaWQ9ImlucHV0LWZpZWxkIiBvbnBhc3RlPSJwYXN0ZUNvdW50Kys7Ii8+ CiA8L2Rpdj4KLQogPHNjcmlwdD4KK3ZhciBpID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lu cHV0LWZpZWxkJyk7CitpLmZvY3VzKCk7CisKIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKICAg ICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh3aW5kb3cuaW5uZXJXaWR0aCAtIDEsIDEpOwogICAg IGV2ZW50U2VuZGVyLm1vdXNlRG93bigxKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRl eCAyZTMzMGFjLi4zOGZjMTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vi cGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC03OTQs NyArNzk0LDggQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6Om1vdXNlUmVsZWFzZUV2ZW50KFQgKmV2 KQogICAgICAgICBhY2NlcHRlZCA9IGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VS ZWxlYXNlRXZlbnQobWV2KTsKICAgICBldi0+c2V0QWNjZXB0ZWQoYWNjZXB0ZWQpOwogCi0gICAg aGFuZGxlQ2xpcGJvYXJkKGV2LCBldi0+YnV0dG9uKCkpOworICAgIGlmICghZXYtPmlzQWNjZXB0 ZWQoKSkKKyAgICAgICAgaGFuZGxlQ2xpcGJvYXJkKGV2LCBldi0+YnV0dG9uKCkpOwogICAgIGhh bmRsZVNvZnR3YXJlSW5wdXRQYW5lbChldi0+YnV0dG9uKCksIFFQb2ludEYoZXYtPnBvcygpKS50 b1BvaW50KCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDQ2OWRiZWYuLmRmNTk1YmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDUtMjIgIFN0ZWZmZW4gSW1ob2YgIDxz dGVmZmVuLmltaG9mQGJhc3lza29tLmNvbT4KKworICAgICAgICBbUXRdIE1pZGRsZSBjbGlja2lu ZyBhIHNjcm9sbGJhciBjYXVzZXMgdGV4dCB0byBiZSBwYXN0ZWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODQ0NAorCisgICAgICAgIENoZWNrIGlm IHRoZSBldmVudCB3YXMgYWxyZWFkeSBhY2NlcHRlZCBiZWZvcmUgaGFuZGxpbmcgdGhlIGNsaXBi b2FyZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6Om1vdXNlUmVsZWFz ZUV2ZW50KToKKwogMjAxMi0wNS0yMSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8 Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIE1vdmUgc2V0RWRpdGluZ0Jl aGF2aW9yKCkgZnJvbSBsYXlvdXRUZXN0Q29udHJvbGxlciB0byB3aW5kb3cuaW50ZXJuYWxzCg==