<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78392</bug_id>
          
          <creation_ts>2012-02-10 15:19:17 -0800</creation_ts>
          <short_desc>Update MIPS patchOffsetGetByIdSlowCaseCall</short_desc>
          <delta_ts>2012-02-27 18:13:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Chao-ying Fu">fu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>554433</commentid>
    <comment_count>0</comment_count>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2012-02-10 15:19:17 -0800</bug_when>
    <thetext>Hi,
Due to recent change, I need to update MIPS patchOffsetGetByIdSlowCaseCall values.  I will post a patch soon.  Thanks!

Regards,
Chao-ying</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>554435</commentid>
    <comment_count>1</comment_count>
      <attachid>126592</attachid>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2012-02-10 15:27:39 -0800</bug_when>
    <thetext>Created attachment 126592
Update patchOffsetGetByIdSlowCaseCall values

Here is the patch.  Testing is ok.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555430</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-13 11:39:50 -0800</bug_when>
    <thetext>Who should review this?  I believe this only affects MIPS?  How do we test this change?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555462</commentid>
    <comment_count>3</comment_count>
      <attachid>126592</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-13 12:32:04 -0800</bug_when>
    <thetext>Comment on attachment 126592
Update patchOffsetGetByIdSlowCaseCall values

Clearing flags on attachment: 126592

Committed r107594: &lt;http://trac.webkit.org/changeset/107594&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>555463</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-13 12:32:15 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>566222</commentid>
    <comment_count>5</comment_count>
      <attachid>129155</attachid>
    <who name="Chao-ying Fu">fu</who>
    <bug_when>2012-02-27 18:11:22 -0800</bug_when>
    <thetext>Created attachment 129155
Update patchOffsetGetByIdSlowCaseCall values

The MIPS patchOffsetGetByIdSlowCaseCall values are wrong again, due to recent change in updateTopCallFrame().
Here is the patch to corret them.  JIT testing is ok.
Thanks a lot!

Regards,
Chao-ying</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126592</attachid>
            <date>2012-02-10 15:27:39 -0800</date>
            <delta_ts>2012-02-27 18:11:22 -0800</delta_ts>
            <desc>Update patchOffsetGetByIdSlowCaseCall values</desc>
            <filename>mips20120210.diff</filename>
            <type>text/plain</type>
            <size>1579</size>
            <attacher name="Chao-ying Fu">fu</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA3NDQ3KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDEyLTAyLTEwICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBVcGRh
dGUgTUlQUyBwYXRjaE9mZnNldEdldEJ5SWRTbG93Q2FzZUNhbGwKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgIChKSVQp
OgorCiAyMDEyLTAyLTEwICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIEVOQUJM
RShBU1NFTUJMRVJfV1hfRVhDTFVTSVZFKTogTGlua0J1ZmZlciBjYW4gbGVhdmUgcGFnZXMgbm90
IG1hcmtlZCBhcyBleGVjdXRhYmxlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K
SVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCShyZXZp
c2lvbiAxMDczNzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCSh3b3JraW5n
IGNvcHkpCkBAIC01MDAsNyArNTAwLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAjaWYgRU5BQkxFKE9Q
Q09ERV9TQU1QTElORykKICAgICAgICAgI2Vycm9yICJPUENPREVfU0FNUExJTkcgaXMgbm90IHll
dCBzdXBwb3J0ZWQiCiAjZWxzZQotICAgICAgICBzdGF0aWMgY29uc3QgaW50IHBhdGNoT2Zmc2V0
R2V0QnlJZFNsb3dDYXNlQ2FsbCA9IDU2OworICAgICAgICBzdGF0aWMgY29uc3QgaW50IHBhdGNo
T2Zmc2V0R2V0QnlJZFNsb3dDYXNlQ2FsbCA9IDY0OwogI2VuZGlmCiAgICAgICAgIHN0YXRpYyBj
b25zdCBpbnQgcGF0Y2hPZmZzZXRPcENhbGxDb21wYXJlVG9KdW1wID0gMzI7CiAgICAgICAgIHN0
YXRpYyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRNZXRob2RDaGVja1Byb3RvT2JqID0gMzI7CkBAIC01
MTgsNyArNTE4LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAjaWYgRU5BQkxFKE9QQ09ERV9TQU1QTElO
RykKICAgICAgICAgI2Vycm9yICJPUENPREVfU0FNUExJTkcgaXMgbm90IHlldCBzdXBwb3J0ZWQi
CiAjZWxzZQotICAgICAgICBzdGF0aWMgY29uc3QgaW50IHBhdGNoT2Zmc2V0R2V0QnlJZFNsb3dD
YXNlQ2FsbCA9IDU2OworICAgICAgICBzdGF0aWMgY29uc3QgaW50IHBhdGNoT2Zmc2V0R2V0QnlJ
ZFNsb3dDYXNlQ2FsbCA9IDY0OwogI2VuZGlmCiAgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgcGF0
Y2hPZmZzZXRPcENhbGxDb21wYXJlVG9KdW1wID0gMzI7CiAgICAgICAgIHN0YXRpYyBjb25zdCBp
bnQgcGF0Y2hPZmZzZXRNZXRob2RDaGVja1Byb3RvT2JqID0gMzI7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>129155</attachid>
            <date>2012-02-27 18:11:22 -0800</date>
            <delta_ts>2012-02-27 18:13:09 -0800</delta_ts>
            <desc>Update patchOffsetGetByIdSlowCaseCall values</desc>
            <filename>mips20120227.diff</filename>
            <type>text/plain</type>
            <size>1563</size>
            <attacher name="Chao-ying Fu">fu</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA5MDU1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDEyLTAyLTI3ICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBVcGRh
dGUgTUlQUyBwYXRjaE9mZnNldEdldEJ5SWRTbG93Q2FzZUNhbGwKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgIChKSVQp
OgorCiAyMDEyLTAyLTI3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAg
ICAgT2xkIEpJVCdzIHN0eWxlIG9mIEpTVkFMVUU2NCBzdHJpY3QgZXF1YWxpdHkgaXMgc3VidGx5
IHdyb25nCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHJldmlzaW9uIDEwODk2MikKKysr
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTUwMiw3
ICs1MDIsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICNpZiBFTkFCTEUoT1BDT0RFX1NBTVBMSU5HKQog
ICAgICAgICAjZXJyb3IgIk9QQ09ERV9TQU1QTElORyBpcyBub3QgeWV0IHN1cHBvcnRlZCIKICNl
bHNlCi0gICAgICAgIHN0YXRpYyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xvd0Nhc2VD
YWxsID0gNjQ7CisgICAgICAgIHN0YXRpYyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xv
d0Nhc2VDYWxsID0gNjg7CiAjZW5kaWYKICAgICAgICAgc3RhdGljIGNvbnN0IGludCBwYXRjaE9m
ZnNldE9wQ2FsbENvbXBhcmVUb0p1bXAgPSAzMjsKICAgICAgICAgc3RhdGljIGNvbnN0IGludCBw
YXRjaE9mZnNldE1ldGhvZENoZWNrUHJvdG9PYmogPSAzMjsKQEAgLTUyMCw3ICs1MjAsNyBAQCBu
YW1lc3BhY2UgSlNDIHsKICNpZiBFTkFCTEUoT1BDT0RFX1NBTVBMSU5HKQogICAgICAgICAjZXJy
b3IgIk9QQ09ERV9TQU1QTElORyBpcyBub3QgeWV0IHN1cHBvcnRlZCIKICNlbHNlCi0gICAgICAg
IHN0YXRpYyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xvd0Nhc2VDYWxsID0gNjQ7Cisg
ICAgICAgIHN0YXRpYyBjb25zdCBpbnQgcGF0Y2hPZmZzZXRHZXRCeUlkU2xvd0Nhc2VDYWxsID0g
Njg7CiAjZW5kaWYKICAgICAgICAgc3RhdGljIGNvbnN0IGludCBwYXRjaE9mZnNldE9wQ2FsbENv
bXBhcmVUb0p1bXAgPSAzMjsKICAgICAgICAgc3RhdGljIGNvbnN0IGludCBwYXRjaE9mZnNldE1l
dGhvZENoZWNrUHJvdG9PYmogPSAzMjsK
</data>
<flag name="review"
          id="131752"
          type_id="1"
          status="+"
          setter="barraclough"
    />
    <flag name="commit-queue"
          id="131753"
          type_id="3"
          status="+"
          setter="barraclough"
    />
          </attachment>
      

    </bug>

</bugzilla>