78355 2012-02-10 05:35:19 -0800 Remove clipToImageBuffer from SourceAlpha and feComposite 2012-02-15 07:56:40 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned zimmermann oldest_to_newest 554037 0 zherczeg 2012-02-10 05:35:19 -0800 Since clipToImageBuffer is mac specific, other platforms would benefit if we could remove it from the project. 554038 1 126507 zherczeg 2012-02-10 05:40:37 -0800 Created attachment 126507 patch 554048 2 zherczeg 2012-02-10 06:17:11 -0800 I did some measurements on mac and Qt-Linux with the following filter combination: <feFlood result="a" flood-color="red" flood-opacity="0.5" x="0" y="0" width="800" height="600"/> <feFlood result="b" flood-color="green" flood-opacity="0.5" x="0" y="0" width="800" height="600"/> <feComposite id="test" in="a" in2="b" operator="in"/> Mac is unaffected by this change, but Qt is 10% faster (full browser). 557262 3 126507 zimmermann 2012-02-15 07:29:12 -0800 Comment on attachment 126507 patch r=me, this is a first step towards killing clipToImageBuffer, thus resolving some Qt crashes that recently appeared in that area. 557277 4 zherczeg 2012-02-15 07:56:40 -0800 Landed as http://trac.webkit.org/changeset/107818 126507 2012-02-10 05:40:37 -0800 2012-02-15 07:29:12 -0800 patch 0001-cliptoimage.patch text/plain 4246 zherczeg RnJvbSA5MjVlOWEwM2M2ODZiN2RmYTI3YmUwZmU3NTljMDYwOTg4Y2I2NGNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAd2Via2l0Lm9yZz4K RGF0ZTogRnJpLCAxMCBGZWIgMjAxMiAwNTozODo1OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGNs aXB0b2ltYWdlCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVDb21wb3NpdGUuY3BwICAgICAgfCAgIDE2ICsrKysrKysrKysrKystLS0KIC4u Li9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL1NvdXJjZUFscGhhLmNwcCAgICAgIHwgICAgMyAr LS0KIDMgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggOTFiNjY3MC4uYWFiOWM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDEyLTAyLTEwICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmVtb3ZlIGNsaXBUb0ltYWdlQnVmZmVyIGZyb20gU291cmNlQWxwaGEgYW5kIGZlQ29t cG9zaXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 ODM1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBpbXBsZW1lbnRhdGlvbiBvZiBjbGlwVG9JbWFnZUJ1ZmZlciBpcyBpbmVmZmljaWVudCBvbgor ICAgICAgICBub24tbWFjIHBsYXRmb3Jtcywgc28gd2Ugd291bGQgYmVuZWZpdCBpZiByZW1vdmUg aXQuCisKKyAgICAgICAgRXhpc3RpbmcgdGVzdHMgY292ZXIgdGhpcyBmZWF0dXJlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvc2l0ZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGRUNvbXBvc2l0ZTo6cGxhdGZvcm1BcHBseVNvZnR3YXJlKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL1NvdXJjZUFscGhhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNvdXJjZUFscGhhOjpwbGF0Zm9ybUFwcGx5U29mdHdhcmUpOgorCiAyMDEyLTAyLTA5 ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLiBGaXhlZCB0eXBvIGluIHRoZSBmb2xsb3dpbmcgZmlsZXMuIFtUcmVhdFJldHVybmVkTnVs bFN0cmluZ1RvPV0gPT4gW1RyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXM9XS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb3NpdGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvc2l0ZS5j cHAKaW5kZXggYzY0ZDAyYy4uZmJjMmMxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvc2l0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvc2l0ZS5jcHAKQEAgLTIzOSw5ICsy MzksMTkgQEAgdm9pZCBGRUNvbXBvc2l0ZTo6cGxhdGZvcm1BcHBseVNvZnR3YXJlKCkKICAgICAg ICAgZmlsdGVyQ29udGV4dC0+ZHJhd0ltYWdlQnVmZmVyKGluLT5hc0ltYWdlQnVmZmVyKCksIENv bG9yU3BhY2VEZXZpY2VSR0IsIGRyYXdpbmdSZWdpb25PZklucHV0SW1hZ2UoaW4tPmFic29sdXRl UGFpbnRSZWN0KCkpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBGRUNPTVBPU0lURV9PUEVS QVRPUl9JTjogewotICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIo KmZpbHRlckNvbnRleHQpOwotICAgICAgICBmaWx0ZXJDb250ZXh0LT5jbGlwVG9JbWFnZUJ1ZmZl cihpbjItPmFzSW1hZ2VCdWZmZXIoKSwgZHJhd2luZ1JlZ2lvbk9mSW5wdXRJbWFnZShpbjItPmFi c29sdXRlUGFpbnRSZWN0KCkpKTsKLSAgICAgICAgZmlsdGVyQ29udGV4dC0+ZHJhd0ltYWdlQnVm ZmVyKGluLT5hc0ltYWdlQnVmZmVyKCksIENvbG9yU3BhY2VEZXZpY2VSR0IsIGRyYXdpbmdSZWdp b25PZklucHV0SW1hZ2UoaW4tPmFic29sdXRlUGFpbnRSZWN0KCkpKTsKKyAgICAgICAgLy8gQXBw bGllcyBvbmx5IHRvIHRoZSBpbnRlcnNlY3RlZCByZWdpb24uCisgICAgICAgIEludFJlY3QgZGVz dGluYXRpb25SZWN0ID0gaW4tPmFic29sdXRlUGFpbnRSZWN0KCk7CisgICAgICAgIGRlc3RpbmF0 aW9uUmVjdC5pbnRlcnNlY3QoaW4yLT5hYnNvbHV0ZVBhaW50UmVjdCgpKTsKKyAgICAgICAgZGVz dGluYXRpb25SZWN0LmludGVyc2VjdChhYnNvbHV0ZVBhaW50UmVjdCgpKTsKKyAgICAgICAgaWYg KGRlc3RpbmF0aW9uUmVjdC5pc0VtcHR5KCkpCisgICAgICAgICAgICBicmVhazsKKyAgICAgICAg SW50UG9pbnQgZGVzdGluYXRpb25Qb2ludChkZXN0aW5hdGlvblJlY3QueCgpIC0gYWJzb2x1dGVQ YWludFJlY3QoKS54KCksIGRlc3RpbmF0aW9uUmVjdC55KCkgLSBhYnNvbHV0ZVBhaW50UmVjdCgp LnkoKSk7CisgICAgICAgIEludFJlY3Qgc291cmNlUmVjdChJbnRQb2ludChkZXN0aW5hdGlvblJl Y3QueCgpIC0gaW4tPmFic29sdXRlUGFpbnRSZWN0KCkueCgpLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZGVzdGluYXRpb25SZWN0LnkoKSAtIGluLT5hYnNvbHV0ZVBhaW50 UmVjdCgpLnkoKSksIGRlc3RpbmF0aW9uUmVjdC5zaXplKCkpOworICAgICAgICBJbnRSZWN0IHNv dXJjZTJSZWN0KEludFBvaW50KGRlc3RpbmF0aW9uUmVjdC54KCkgLSBpbjItPmFic29sdXRlUGFp bnRSZWN0KCkueCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlc3Rp bmF0aW9uUmVjdC55KCkgLSBpbjItPmFic29sdXRlUGFpbnRSZWN0KCkueSgpKSwgZGVzdGluYXRp b25SZWN0LnNpemUoKSk7CisgICAgICAgIGZpbHRlckNvbnRleHQtPmRyYXdJbWFnZUJ1ZmZlcihp bjItPmFzSW1hZ2VCdWZmZXIoKSwgQ29sb3JTcGFjZURldmljZVJHQiwgZGVzdGluYXRpb25Qb2lu dCwgc291cmNlMlJlY3QpOworICAgICAgICBmaWx0ZXJDb250ZXh0LT5kcmF3SW1hZ2VCdWZmZXIo aW4tPmFzSW1hZ2VCdWZmZXIoKSwgQ29sb3JTcGFjZURldmljZVJHQiwgZGVzdGluYXRpb25Qb2lu dCwgc291cmNlUmVjdCwgQ29tcG9zaXRlU291cmNlSW4pOwogICAgICAgICBicmVhazsKICAgICB9 CiAgICAgY2FzZSBGRUNPTVBPU0lURV9PUEVSQVRPUl9PVVQ6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL1NvdXJjZUFscGhhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvU291cmNlQWxwaGEuY3BwCmluZGV4 IGFlZWJkZTYuLjBiZDVjYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvU291cmNlQWxwaGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2ZpbHRlcnMvU291cmNlQWxwaGEuY3BwCkBAIC02Myw5ICs2Myw4IEBAIHZv aWQgU291cmNlQWxwaGE6OnBsYXRmb3JtQXBwbHlTb2Z0d2FyZSgpCiAKICAgICBGbG9hdFJlY3Qg aW1hZ2VSZWN0KEZsb2F0UG9pbnQoKSwgYWJzb2x1dGVQYWludFJlY3QoKS5zaXplKCkpOwogICAg IEdyYXBoaWNzQ29udGV4dCogZmlsdGVyQ29udGV4dCA9IHJlc3VsdEltYWdlLT5jb250ZXh0KCk7 Ci0gICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKCpmaWx0ZXJDb250ZXh0 KTsKLSAgICBmaWx0ZXJDb250ZXh0LT5jbGlwVG9JbWFnZUJ1ZmZlcihmaWx0ZXItPnNvdXJjZUlt YWdlKCksIGltYWdlUmVjdCk7CiAgICAgZmlsdGVyQ29udGV4dC0+ZmlsbFJlY3QoaW1hZ2VSZWN0 LCBDb2xvcjo6YmxhY2ssIENvbG9yU3BhY2VEZXZpY2VSR0IpOworICAgIGZpbHRlckNvbnRleHQt PmRyYXdJbWFnZUJ1ZmZlcihmaWx0ZXItPnNvdXJjZUltYWdlKCksIENvbG9yU3BhY2VEZXZpY2VS R0IsIEludFBvaW50KCksIENvbXBvc2l0ZURlc3RpbmF0aW9uSW4pOwogfQogCiB2b2lkIFNvdXJj ZUFscGhhOjpkdW1wKCkKLS0gCjEuNy4yLjUKCg==