78353 2012-02-10 05:15:53 -0800 Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype] 2012-02-10 14:40:56 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan tony webkit.review.bot oldest_to_newest 554027 0 haraken 2012-02-10 05:15:53 -0800 [JSCustomPrototypePutDelegate] is used to write custom code for named getters on a prototype interface. "PutDelegate" is just a method name in implementation and not so descriptive. We can rename it to [JSCustomNamedGetterOnPrototype]. This is also for naming consistency with [CustomNamedGetter]. 554029 1 126504 haraken 2012-02-10 05:18:50 -0800 Created attachment 126504 Patch 554356 2 126504 webkit.review.bot 2012-02-10 13:43:39 -0800 Comment on attachment 126504 Patch Clearing flags on attachment: 126504 Committed r107436: <http://trac.webkit.org/changeset/107436> 554357 3 webkit.review.bot 2012-02-10 13:43:45 -0800 All reviewed patches have been landed. Closing bug. 554394 4 tony 2012-02-10 14:27:05 -0800 This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute. 554398 5 tony 2012-02-10 14:35:58 -0800 (In reply to comment #4) > This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute. Hmm, and now it's passing. I'll keep watching the bots to see if a pattern emerges. 554402 6 abarth 2012-02-10 14:40:56 -0800 This change should only have affected JSC. 126504 2012-02-10 05:18:50 -0800 2012-02-10 13:43:39 -0800 Patch bug-78353-20120210221849.patch text/plain 3367 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWYxMTYzOGEwZTZjZjg1 NGVlMDc1OTY4ZDI2OTdmYzA0MmRiNWU4Yi4uNmUzZDgwODRlMGM3Y2EyNTI5YjVmNDgwNDRmODIz MzY4ZTA0MzJjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTAyLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW5hbWUgW0pTQ3Vz dG9tUHJvdG90eXBlUHV0RGVsZWdhdGVdIHRvIFtKU0N1c3RvbU5hbWVkR2V0dGVyT25Qcm90b3R5 cGVdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODM1 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtKU0N1 c3RvbVByb3RvdHlwZVB1dERlbGVnYXRlXSBpcyB1c2VkIHRvIHdyaXRlIGN1c3RvbSBjb2RlIGZv ciBuYW1lZAorICAgICAgICBnZXR0ZXJzIG9uIGEgcHJvdG90eXBlIGludGVyZmFjZS4gIlB1dERl bGVnYXRlIiBpcyBqdXN0IGEgbWV0aG9kIG5hbWUKKyAgICAgICAgaW4gaW1wbGVtZW50YXRpb24g YW5kIG5vdCBzbyBkZXNjcmlwdGl2ZS4gVGhpcyBwYXRjaCByZW5hbWVzIGl0IHRvCisgICAgICAg IFtKU0N1c3RvbU5hbWVkR2V0dGVyT25Qcm90b3R5cGVdLiBUaGlzIGlzIGFsc28gZm9yIG5hbWlu ZyBjb25zaXN0ZW5jeQorICAgICAgICB3aXRoIFtDdXN0b21OYW1lZEdldHRlcl0uCisKKyAgICAg ICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgor ICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICogcGFnZS9Mb2NhdGlv bi5pZGw6CisKKzIwMTItMDItMTAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFJlcGxhY2UgW0N1c3RvbUFyZ3VtZW50SGFuZGxpbmddIHdpdGggW0NhbGxX aXRoPVNjcmlwdEFyZ3VtZW50c3xDYWxsU3RhY2tdCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODMyNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDQxMjdlNGEyMWNiODljMzNj YjljMmMwNzRkMGViY2ZlOWZjNGNmZjIuLjkzYThiOWI2ZTJhNGEyYTA3MTZjNjBkYWU3MjE2YzU5 OTFmM2U5ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCkBAIC0xMDQ4LDcgKzEwNDgsNyBAQCBzdWIgR2VuZXJhdGVIZWFkZXIK ICAgICAgICAgIiAgICB7XG4iIC4KICAgICAgICAgIiAgICAgICAgcmV0dXJuIEpTQzo6U3RydWN0 dXJlOjpjcmVhdGUoZ2xvYmFsRGF0YSwgZ2xvYmFsT2JqZWN0LCBwcm90b3R5cGUsIEpTQzo6VHlw ZUluZm8oSlNDOjpPYmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksICZzX2luZm8pO1xuIiAuCiAg ICAgICAgICIgICAgfVxuIik7Ci0gICAgaWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkpTQ3VzdG9tUHJvdG90eXBlUHV0RGVsZWdhdGUifSkgeworICAgIGlmICgkZGF0YU5vZGUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJKU0N1c3RvbU5hbWVkR2V0dGVyT25Qcm90b3R5cGUifSkg ewogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHN0YXRpYyB2b2lkIHB1dChKU0M6 OkpTQ2VsbCosIEpTQzo6RXhlY1N0YXRlKiwgY29uc3QgSlNDOjpJZGVudGlmaWVyJiBwcm9wZXJ0 eU5hbWUsIEpTQzo6SlNWYWx1ZSwgSlNDOjpQdXRQcm9wZXJ0eVNsb3QmKTtcbiIpOwogICAgICAg ICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIGJvb2wgcHV0RGVsZWdhdGUoSlNDOjpFeGVjU3Rh dGUqLCBjb25zdCBKU0M6OklkZW50aWZpZXImLCBKU0M6OkpTVmFsdWUsIEpTQzo6UHV0UHJvcGVy dHlTbG90Jik7XG4iKTsKICAgICB9CkBAIC0xNTE3LDcgKzE1MTcsNyBAQCBzdWIgR2VuZXJhdGVJ bXBsZW1lbnRhdGlvbgogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn1cblxuIik7CiAgICAg fQogCi0gICAgaWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3VzdG9tUHJv dG90eXBlUHV0RGVsZWdhdGUifSkgeworICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJKU0N1c3RvbU5hbWVkR2V0dGVyT25Qcm90b3R5cGUifSkgewogICAgICAgICBwdXNo KEBpbXBsQ29udGVudCwgInZvaWQgJHtjbGFzc05hbWV9UHJvdG90eXBlOjpwdXQoSlNDZWxsKiBj ZWxsLCBFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNW YWx1ZSB2YWx1ZSwgUHV0UHJvcGVydHlTbG90JiBzbG90KVxuIik7CiAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAie1xuIik7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICR7Y2xh c3NOYW1lfVByb3RvdHlwZSogdGhpc09iamVjdCA9IGpzQ2FzdDwke2NsYXNzTmFtZX1Qcm90b3R5 cGUqPihjZWxsKTtcbiIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlv bi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbAppbmRleCA4OWQ2M2Y3NGJh NTRiNGM5ZmRjYTc3NTdiNjU2MjExZjIzMjYyYmZhLi5jYWM2MGY5OGE0NTAzMTNmZmMyOTdjMDNi MGM2YjczYjgwMzViNWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9u LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmlkbApAQCAtMzgsNyArMzgs NyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgQ3VzdG9tRGVsZXRlUHJvcGVydHksCiAgICAg ICAgIEN1c3RvbUdldFByb3BlcnR5TmFtZXMsCiAgICAgICAgIEpTQ3VzdG9tRGVmaW5lT3duUHJv cGVydHksCi0gICAgICAgIEpTQ3VzdG9tUHJvdG90eXBlUHV0RGVsZWdhdGUsCisgICAgICAgIEpT Q3VzdG9tTmFtZWRHZXR0ZXJPblByb3RvdHlwZSwKICAgICAgICAgSlNDdXN0b21Qcm90b3R5cGVE ZWZpbmVPd25Qcm9wZXJ0eSwKICAgICAgICAgT21pdENvbnN0cnVjdG9yCiAgICAgXSBMb2NhdGlv biB7Cg==