78342 2012-02-10 02:56:52 -0800 Remove [CPPCustom] from CodeGeneratorCPP.pm 2012-02-12 03:17:35 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 553978 0 haraken 2012-02-10 02:56:52 -0800 [CPPCustom] is used in DOMWindow.location only. [CPPCustom] means that the attribute or method should be ignored because CPP does not support it. - At least, it should be renamed to [CPPIgnore] (or something like that). - There are many attributes and methods that CPP does not support (e.g. [CallWith=...], [CustomSetter], etc), but they are not yet marked with [CPPCustom] (except for DOMWindow.location). CPP just generates "meaningless" code for those unsupported attributes and methods. - Ideally we can mark all unsupported attributes and functions with [CPPCustom], but it would not be so practical. Otherwise, removing [CPPCustom] would make sense. The side effect of removing [CPPCustom] is just that CPP will generate "meaningless" code for DOMWindow.location. 553982 1 126487 haraken 2012-02-10 03:06:33 -0800 Created attachment 126487 Patch 554115 2 126487 abarth 2012-02-10 09:23:56 -0800 Comment on attachment 126487 Patch ok 554420 3 126487 webkit.review.bot 2012-02-10 15:03:25 -0800 Comment on attachment 126487 Patch Rejecting attachment 126487 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: om patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm Hunk #1 FAILED at 194. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm.rej patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11473818 554793 4 126673 haraken 2012-02-12 01:15:12 -0800 Created attachment 126673 rebased patch for commit 554806 5 126673 webkit.review.bot 2012-02-12 03:16:43 -0800 Comment on attachment 126673 rebased patch for commit Clearing flags on attachment: 126673 Committed r107508: <http://trac.webkit.org/changeset/107508> 126487 2012-02-10 03:06:33 -0800 2012-02-12 03:17:35 -0800 Patch bug-78342-20120210200631.patch text/plain 3174 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmM4YzIxYWY5ZGNiZGY1 MGJjNjNiMjE5MWRlYTM3OTMzYTdhNDBkYi4uODQxODk4MjhmYTBjOWIzMTc5MTZiMzJiZTQ0NjQy MzFlMzE4ZTc3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTAyLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0NQUEN1 c3RvbV0gZnJvbSBDb2RlR2VuZXJhdG9yQ1BQLnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODM0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyBbQ1BQQ3VzdG9tXS4KKwor ICAgICAgICBbQ1BQQ3VzdG9tXSBoYXMgYmVlbiB1c2VkIGluIERPTVdpbmRvdy5sb2NhdGlvbiBv bmx5IHRvIGluZGljYXRlIHRoYXQKKyAgICAgICAgRE9NV2luZG93LmxvY2F0aW9uIHNob3VsZCBi ZSBpZ25vcmVkIGluIENQUC4gSG93ZXZlciwgdGhlcmUgYXJlIG1hbnkKKyAgICAgICAgb3RoZXIg YXR0cmlidXRlcyBhbmQgbWV0aG9kcyB0aGF0IENQUCBkb2VzIG5vdCBzdXBwb3J0IChlLmcuIFtD YWxsV2l0aD0uLi5dLAorICAgICAgICBbQ3VzdG9tU2V0dGVyXSwgZXRjKSwgYW5kIHRoZXkgYXJl IG5vdCB5ZXQgbWFya2VkIHdpdGggW0NQUEN1c3RvbV0uCisgICAgICAgIENQUCBqdXN0IGdlbmVy YXRlcyAibWVhbmluZ2xlc3MiIGNvZGUgZm9yIHRob3NlIHVuc3VwcG9ydGVkIGF0dHJpYnV0ZXMK KyAgICAgICAgYW5kIG1ldGhvZHMuIElkZWFsbHkgd2UgY2FuIG1hcmsgYWxsIHVuc3VwcG9ydGVk IGF0dHJpYnV0ZXMgYW5kIG1ldGhvZHMKKyAgICAgICAgd2l0aCBbQ1BQQ3VzdG9tXSwgYnV0IGl0 IHdvdWxkIG5vdCBiZSBzbyBwcmFjdGljYWwuIE90aGVyd2lzZSwgcmVtb3ZpbmcKKyAgICAgICAg W0NQUEN1c3RvbV0gd291bGQgbWFrZSBzZW5zZS4gVGhlIHNpZGUgZWZmZWN0IG9mIHJlbW92aW5n IFtDUFBDdXN0b21dCisgICAgICAgIGlzIGp1c3QgdGhhdCBDUFAgd2lsbCBnZW5lcmF0ZSAibWVh bmluZ2xlc3MiIGNvZGUgZm9yIERPTVdpbmRvdy5sb2NhdGlvbi4KKworICAgICAgICBObyB0ZXN0 cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yQ1BQLnBtOgorICAgICAgICAoU2hvdWxkU2tpcFR5cGUpOgorICAgICAgICAq IHBhZ2UvRE9NV2luZG93LmlkbDoKKwogMjAxMi0wMi0xMCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMDcyNDIpOiBJdCBt YWRlIDUgaW5zcGVjdG9yIHRlc3RzIGNyYXNoIGluIGRlYnVnIG1vZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbSBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQppbmRleCAzMjky OGQxOWNmM2U0M2Y1Y2FiMDZhNTQyOGMxZTc2OGFjNjhjYjEzLi5mMDBlNDI4Y2UzNTdkNjNmOTZh ZDM1YThhNTUzNDZkYTMxZjIxNGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCkBAIC0xOTQsOCArMTk0LDcgQEAgc3ViIFNo b3VsZFNraXBUeXBlCiAgICAgcmV0dXJuIDEgaWYgJHR5cGVJbmZvLT5zaWduYXR1cmUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJDdXN0b20ifTsKIAogICAgIHJldHVybiAxIGlmICR0eXBlSW5mby0+ c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tQXJndW1lbnRIYW5kbGluZyJ9 Ci0gICAgICAgICAgICAgb3IgJHR5cGVJbmZvLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJDdXN0b21HZXR0ZXIifQotICAgICAgICAgICAgIG9yICR0eXBlSW5mby0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ1BQQ3VzdG9tIn07CisgICAgICAgICAgICAgb3IgJHR5 cGVJbmZvLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21HZXR0ZXIifTsK IAogICAgICMgRklYTUU6IFdlIGRvbid0IGdlbmVyYXRlIGJpbmRpbmdzIGZvciBTVkcgcmVsYXRl ZCBpbnRlcmZhY2VzIHlldAogICAgIHJldHVybiAxIGlmICR0eXBlSW5mby0+c2lnbmF0dXJlLT5u YW1lID1+IC9nZXRTVkdEb2N1bWVudC87CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKaW5kZXgg MDkwMDc0YzhiZWU1Y2IwZTkxZTVjZjZmOWNlOWEwMjA1YTUwNzczNy4uY2QxMzA4MjI5ZjM1OWFh M2IwY2YyNmMzNzM1M2M1MWM2NjAxZGYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApA QCAtNTMsNyArNTMsNyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgYXR0cmlidXRlIFtSZXBs YWNlYWJsZV0gTmF2aWdhdG9yIG5hdmlnYXRvcjsKICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNl YWJsZV0gTmF2aWdhdG9yIGNsaWVudEluZm9ybWF0aW9uOwogICAgICAgICByZWFkb25seSBhdHRy aWJ1dGUgQ3J5cHRvIGNyeXB0bzsKLSAgICAgICAgYXR0cmlidXRlIFtEb05vdENoZWNrRG9tYWlu U2VjdXJpdHksIEpTQ3VzdG9tLCBWOEN1c3RvbVNldHRlciwgVjhVbmZvcmdlYWJsZSwgQ1BQQ3Vz dG9tXSBMb2NhdGlvbiBsb2NhdGlvbjsKKyAgICAgICAgYXR0cmlidXRlIFtEb05vdENoZWNrRG9t YWluU2VjdXJpdHksIEpTQ3VzdG9tLCBWOEN1c3RvbVNldHRlciwgVjhVbmZvcmdlYWJsZV0gTG9j YXRpb24gbG9jYXRpb247CiAKICAgICAgICAgYXR0cmlidXRlIFtSZXBsYWNlYWJsZSwgQ3VzdG9t R2V0dGVyLCBWOEN1c3RvbVNldHRlcl0gRXZlbnQgZXZlbnQ7CiAK 126673 2012-02-12 01:15:12 -0800 2012-02-12 03:16:43 -0800 rebased patch for commit bug-78342-20120212181511.patch text/plain 3104 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3NTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNlYmVhZjg4NDRhMDA5 ZjBlYzdiNTgzYzg5YzdjZjUwZmRhODJjZS4uMWIwNGE5OGM2NjRiMDNiODY2OGVkOGUzNzZjMzIw ZWVjMDQwOWRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTAyLTEwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0NQUEN1 c3RvbV0gZnJvbSBDb2RlR2VuZXJhdG9yQ1BQLnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODM0MgorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIFtDUFBDdXN0b21dLgorCisgICAg ICAgIFtDUFBDdXN0b21dIGhhcyBiZWVuIHVzZWQgaW4gRE9NV2luZG93LmxvY2F0aW9uIG9ubHkg dG8gaW5kaWNhdGUgdGhhdAorICAgICAgICBET01XaW5kb3cubG9jYXRpb24gc2hvdWxkIGJlIGln bm9yZWQgaW4gQ1BQLiBIb3dldmVyLCB0aGVyZSBhcmUgbWFueQorICAgICAgICBvdGhlciBhdHRy aWJ1dGVzIGFuZCBtZXRob2RzIHRoYXQgQ1BQIGRvZXMgbm90IHN1cHBvcnQgKGUuZy4gW0NhbGxX aXRoPS4uLl0sCisgICAgICAgIFtDdXN0b21TZXR0ZXJdLCBldGMpLCBhbmQgdGhleSBhcmUgbm90 IHlldCBtYXJrZWQgd2l0aCBbQ1BQQ3VzdG9tXS4KKyAgICAgICAgQ1BQIGp1c3QgZ2VuZXJhdGVz ICJtZWFuaW5nbGVzcyIgY29kZSBmb3IgdGhvc2UgdW5zdXBwb3J0ZWQgYXR0cmlidXRlcworICAg ICAgICBhbmQgbWV0aG9kcy4gSWRlYWxseSB3ZSBjYW4gbWFyayBhbGwgdW5zdXBwb3J0ZWQgYXR0 cmlidXRlcyBhbmQgbWV0aG9kcworICAgICAgICB3aXRoIFtDUFBDdXN0b21dLCBidXQgaXQgd291 bGQgbm90IGJlIHNvIHByYWN0aWNhbC4gT3RoZXJ3aXNlLCByZW1vdmluZworICAgICAgICBbQ1BQ Q3VzdG9tXSB3b3VsZCBtYWtlIHNlbnNlLiBUaGUgc2lkZSBlZmZlY3Qgb2YgcmVtb3ZpbmcgW0NQ UEN1c3RvbV0KKyAgICAgICAgaXMganVzdCB0aGF0IENQUCB3aWxsIGdlbmVyYXRlICJtZWFuaW5n bGVzcyIgY29kZSBmb3IgRE9NV2luZG93LmxvY2F0aW9uLgorCisgICAgICAgIE5vIHRlc3RzLiBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JDUFAucG06CisgICAgICAgIChTaG91bGRTa2lwVHlwZSk6CisgICAgICAgICogcGFn ZS9ET01XaW5kb3cuaWRsOgorCiAyMDEyLTAyLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIHNlbmQgYWxsIEpTQyBk ZWJ1ZyBsb2dnaW5nIHRvIGEgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCmluZGV4IGRjZWY3NDNhZGEzNDE4YzFlYjJiMmYx MzM5NzhkN2Y0Yjc2ODFjNWUuLjU4MjZlZGQ1MjM1MjNkMDY0Njk5ODUyZTFiYzc0MTIwYTEwMzdm NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckNQUC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JDUFAucG0KQEAgLTE5Miw4ICsxOTIsNyBAQCBzdWIgU2hvdWxkU2tpcFR5cGUKICAgICBt eSAkdHlwZUluZm8gPSBzaGlmdDsKIAogICAgIHJldHVybiAxIGlmICR0eXBlSW5mby0+c2lnbmF0 dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tIn0KLSAgICAgICAgICAgICAgICBvciAk dHlwZUluZm8tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldHRlciJ9 Ci0gICAgICAgICAgICAgICAgb3IgJHR5cGVJbmZvLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJDUFBDdXN0b20ifTsKKyAgICAgICAgICAgICAgICBvciAkdHlwZUluZm8tPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbUdldHRlciJ9OwogCiAgICAgIyBGSVhN RTogV2UgZG9uJ3QgZ2VuZXJhdGUgYmluZGluZ3MgZm9yIFNWRyByZWxhdGVkIGludGVyZmFjZXMg eWV0CiAgICAgcmV0dXJuIDEgaWYgJHR5cGVJbmZvLT5zaWduYXR1cmUtPm5hbWUgPX4gL2dldFNW R0RvY3VtZW50LzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93Lmlk bCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAppbmRleCBjZTAzZDQyZTdjNzNj NTBkYTU1MzBkZjkyMmM0NGQ1YzY5OGE1MmE5Li5kMDc2N2I1YTcxZDZkZTgwNDU0YzM0MDNjMDlh NjEzYjA3NjBiMTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5p ZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBAIC01Myw3ICs1Myw3 IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBOYXZp Z2F0b3IgbmF2aWdhdG9yOwogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlXSBOYXZpZ2F0 b3IgY2xpZW50SW5mb3JtYXRpb247CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBDcnlwdG8g Y3J5cHRvOwotICAgICAgICBhdHRyaWJ1dGUgW0RvTm90Q2hlY2tEb21haW5TZWN1cml0eSwgSlND dXN0b20sIFY4Q3VzdG9tU2V0dGVyLCBWOFVuZm9yZ2VhYmxlLCBDUFBDdXN0b21dIExvY2F0aW9u IGxvY2F0aW9uOworICAgICAgICBhdHRyaWJ1dGUgW0RvTm90Q2hlY2tEb21haW5TZWN1cml0eSwg SlNDdXN0b20sIFY4Q3VzdG9tU2V0dGVyLCBWOFVuZm9yZ2VhYmxlXSBMb2NhdGlvbiBsb2NhdGlv bjsKIAogICAgICAgICBhdHRyaWJ1dGUgW1JlcGxhY2VhYmxlLCBDdXN0b21HZXR0ZXIsIFY4Q3Vz dG9tU2V0dGVyXSBFdmVudCBldmVudDsKIAo=