78341 2012-02-10 02:40:16 -0800 [WIN] Add abstraction for HWND_MESSAGE 2012-02-13 11:54:56 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 78340 76781 1 paroga paroga aroben webkit.review.bot oldest_to_newest 553968 0 paroga 2012-02-10 02:40:16 -0800 [WIN] Add abstraction for HWND_MESSAGE 553969 1 126483 paroga 2012-02-10 02:44:44 -0800 Created attachment 126483 Patch 555258 2 126483 aroben 2012-02-13 07:48:46 -0800 Comment on attachment 126483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126483&action=review > Source/WebCore/platform/win/WindowsExtras.h:36 > +#ifdef HWND_MESSAGE > +const HWND kHwndMessage = HWND_MESSAGE; > +#else > +const HWND kHwndMessage = 0; > +#endif Why not just do this? #ifndef HWND_MESSAGE const HWND HWND_MESSAGE = 0; #endif Then we could use HWND_MESSAGE everywhere. 555291 3 126777 paroga 2012-02-13 08:38:53 -0800 Created attachment 126777 Patch 555297 4 webkit.review.bot 2012-02-13 08:45:09 -0800 Attachment 126777 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/win/WindowsExtras.h:33: HWND_MESSAGE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 555437 5 126777 webkit.review.bot 2012-02-13 11:54:51 -0800 Comment on attachment 126777 Patch Clearing flags on attachment: 126777 Committed r107592: <http://trac.webkit.org/changeset/107592> 555438 6 webkit.review.bot 2012-02-13 11:54:56 -0800 All reviewed patches have been landed. Closing bug. 126483 2012-02-10 02:44:44 -0800 2012-02-13 08:38:53 -0800 Patch bug-78341.patch text/plain 2975 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MzAwZTA2Li45MjdkNjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDItMTAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dJTl0gQWRkIGFic3RyYWN0aW9uIGZvciBIV05EX01FU1NBR0UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFdORF9NRVNTQUdFIGlzIG5v dCBkZWZpbmVkIG9uIFdpbkNFLiBEZWZpbmUgYW5kIHVzZQorICAgICAgICBrSHduZE1lc3NhZ2Ug aW5zdGVhZCwgdG8gYXZvaWQgaWZkZWZzIGFjcm9zcyB0aGUgY29kZS4KKworICAgICAgICAqIHBs YXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhc3RlYm9h cmQ6OlBhc3RlYm9hcmQpOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9SdW5Mb29wV2luLmNwcDoK KyAgICAgICAgKiBwbGF0Zm9ybS93aW4vV2luZG93c0V4dHJhcy5oOgorICAgICAgICAoV2ViQ29y ZSk6CisKIDIwMTItMDItMTAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQWRkIFdpbmRvd3NFeHRyYXMuaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCmluZGV4IDg4N2ZjOTEuLmU5ZmRmMjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAKQEAgLTQyLDYgKzQy LDcgQEAKICNpbmNsdWRlICJSZW5kZXJJbWFnZS5oIgogI2luY2x1ZGUgIlRleHRFbmNvZGluZy5o IgogI2luY2x1ZGUgIldlYkNvcmVJbnN0YW5jZUhhbmRsZS5oIgorI2luY2x1ZGUgIldpbmRvd3NF eHRyYXMuaCIKICNpbmNsdWRlICJtYXJrdXAuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5n Lmg+CiAKQEAgLTg4LDExICs4OSw2IEBAIFBhc3RlYm9hcmQqIFBhc3RlYm9hcmQ6OmdlbmVyYWxQ YXN0ZWJvYXJkKCkKIAogUGFzdGVib2FyZDo6UGFzdGVib2FyZCgpCiB7Ci0gICAgSFdORCBoV25k UGFyZW50ID0gMDsKLSNpZiAhT1MoV0lOQ0UpCi0gICAgaFduZFBhcmVudCA9IEhXTkRfTUVTU0FH RTsKLSNlbmRpZgotCiAgICAgV05EQ0xBU1Mgd2M7CiAgICAgbWVtc2V0KCZ3YywgMCwgc2l6ZW9m KFdORENMQVNTKSk7CiAgICAgd2MubHBmblduZFByb2MgICAgPSBQYXN0ZWJvYXJkT3duZXJXbmRQ cm9jOwpAQCAtMTAxLDcgKzk3LDcgQEAgUGFzdGVib2FyZDo6UGFzdGVib2FyZCgpCiAgICAgUmVn aXN0ZXJDbGFzcygmd2MpOwogCiAgICAgbV9vd25lciA9IDo6Q3JlYXRlV2luZG93KEwiUGFzdGVi b2FyZE93bmVyV2luZG93Q2xhc3MiLCBMIlBhc3RlYm9hcmRPd25lcldpbmRvdyIsIDAsIDAsIDAs IDAsIDAsCi0gICAgICAgIGhXbmRQYXJlbnQsIDAsIDAsIDApOworICAgICAgICBrSHduZE1lc3Nh Z2UsIDAsIDAsIDApOwogCiAgICAgSFRNTENsaXBib2FyZEZvcm1hdCA9IDo6UmVnaXN0ZXJDbGlw Ym9hcmRGb3JtYXQoTCJIVE1MIEZvcm1hdCIpOwogICAgIEJvb2ttYXJrQ2xpcGJvYXJkRm9ybWF0 ID0gOjpSZWdpc3RlckNsaXBib2FyZEZvcm1hdChMIlVuaWZvcm1SZXNvdXJjZUxvY2F0b3JXIik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUnVuTG9vcFdpbi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUnVuTG9vcFdpbi5jcHAKaW5kZXggYzQ5YjJk Ny4uZGY4YzdlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1J1bkxv b3BXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9SdW5Mb29wV2luLmNw cApAQCAtMTAxLDcgKzEwMSw3IEBAIFJ1bkxvb3A6OlJ1bkxvb3AoKQogCiAgICAgbV9ydW5Mb29w TWVzc2FnZVdpbmRvdyA9IDo6Q3JlYXRlV2luZG93KGtSdW5Mb29wTWVzc2FnZVdpbmRvd0NsYXNz TmFtZSwgMCwgMCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Q1dfVVNFREVGQVVMVCwgMCwgQ1dfVVNFREVGQVVMVCwgMCwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgSFdORF9NRVNTQUdFLCAwLCAwLCB0aGlzKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAga0h3bmRNZXNzYWdlLCAwLCAw LCB0aGlzKTsKICAgICBBU1NFUlQoOjpJc1dpbmRvdyhtX3J1bkxvb3BNZXNzYWdlV2luZG93KSk7 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9XaW5kb3dzRXh0 cmFzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vV2luZG93c0V4dHJhcy5oCmluZGV4 IDFmY2Y1YTYuLmIwZjIxNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dp bi9XaW5kb3dzRXh0cmFzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1dpbmRv d3NFeHRyYXMuaApAQCAtMjksNiArMjksMTIgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisj aWZkZWYgSFdORF9NRVNTQUdFCitjb25zdCBIV05EIGtId25kTWVzc2FnZSA9IEhXTkRfTUVTU0FH RTsKKyNlbHNlCitjb25zdCBIV05EIGtId25kTWVzc2FnZSA9IDA7CisjZW5kaWYKKwogaW5saW5l IHZvaWQqIGdldFdpbmRvd1BvaW50ZXIoSFdORCBoV25kLCBpbnQgaW5kZXggPSAwKQogewogI2lm IE9TKFdJTkNFKQo= 126777 2012-02-13 08:38:53 -0800 2012-02-13 11:54:51 -0800 Patch xx.patch text/plain 2293 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZWU4M2FmLi5mZmE4OGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMDItMTMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK KyAgICAgICAgW1dJTl0gRGVmaW5lIEhXTkRfTUVTU0FHRSBpZiBub3QgZG9uZSBhbHJlYWR5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODM0MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhXTkRfTUVTU0FH RSBpcyBub3QgZGVmaW5lZCBvbiBXaW5DRS4KKyAgICAgICAgU2V0IGl0IHRvIDAgd2hlbiBub3Qg ZGVmaW5lZCB0byBhdm9pZCAjaWZkZWZzLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Bhc3Rl Ym9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6UGFzdGVib2FyZCk6 CisgICAgICAgICogcGxhdGZvcm0vd2luL1dpbmRvd3NFeHRyYXMuaDoKKyAgICAgICAgKFdlYkNv cmUpOgorCisyMDEyLTAyLTEzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3Jn PgorCiAgICAgICAgIEFkZCBXaW5kb3dzRXh0cmFzLmgKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dpbi9QYXN0ZWJvYXJkV2luLmNwcAppbmRleCA4ODdmYzkxLi4wNjVlM2E4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCkBAIC00Miw2ICs0 Miw3IEBACiAjaW5jbHVkZSAiUmVuZGVySW1hZ2UuaCIKICNpbmNsdWRlICJUZXh0RW5jb2Rpbmcu aCIKICNpbmNsdWRlICJXZWJDb3JlSW5zdGFuY2VIYW5kbGUuaCIKKyNpbmNsdWRlICJXaW5kb3dz RXh0cmFzLmgiCiAjaW5jbHVkZSAibWFya3VwLmgiCiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmlu Zy5oPgogCkBAIC04OCwxMSArODksNiBAQCBQYXN0ZWJvYXJkKiBQYXN0ZWJvYXJkOjpnZW5lcmFs UGFzdGVib2FyZCgpCiAKIFBhc3RlYm9hcmQ6OlBhc3RlYm9hcmQoKQogewotICAgIEhXTkQgaFdu ZFBhcmVudCA9IDA7Ci0jaWYgIU9TKFdJTkNFKQotICAgIGhXbmRQYXJlbnQgPSBIV05EX01FU1NB R0U7Ci0jZW5kaWYKLQogICAgIFdORENMQVNTIHdjOwogICAgIG1lbXNldCgmd2MsIDAsIHNpemVv ZihXTkRDTEFTUykpOwogICAgIHdjLmxwZm5XbmRQcm9jICAgID0gUGFzdGVib2FyZE93bmVyV25k UHJvYzsKQEAgLTEwMSw3ICs5Nyw3IEBAIFBhc3RlYm9hcmQ6OlBhc3RlYm9hcmQoKQogICAgIFJl Z2lzdGVyQ2xhc3MoJndjKTsKIAogICAgIG1fb3duZXIgPSA6OkNyZWF0ZVdpbmRvdyhMIlBhc3Rl Ym9hcmRPd25lcldpbmRvd0NsYXNzIiwgTCJQYXN0ZWJvYXJkT3duZXJXaW5kb3ciLCAwLCAwLCAw LCAwLCAwLAotICAgICAgICBoV25kUGFyZW50LCAwLCAwLCAwKTsKKyAgICAgICAgSFdORF9NRVNT QUdFLCAwLCAwLCAwKTsKIAogICAgIEhUTUxDbGlwYm9hcmRGb3JtYXQgPSA6OlJlZ2lzdGVyQ2xp cGJvYXJkRm9ybWF0KEwiSFRNTCBGb3JtYXQiKTsKICAgICBCb29rbWFya0NsaXBib2FyZEZvcm1h dCA9IDo6UmVnaXN0ZXJDbGlwYm9hcmRGb3JtYXQoTCJVbmlmb3JtUmVzb3VyY2VMb2NhdG9yVyIp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1dpbmRvd3NFeHRyYXMu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9XaW5kb3dzRXh0cmFzLmgKaW5kZXggZjc2 ODczYS4uYWIxZTg1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1dp bmRvd3NFeHRyYXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vV2luZG93c0V4 dHJhcy5oCkBAIC0yOSw2ICsyOSwxMCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZm5k ZWYgSFdORF9NRVNTQUdFCitjb25zdCBIV05EIEhXTkRfTUVTU0FHRSA9IDA7CisjZW5kaWYKKwog aW5saW5lIHZvaWQqIGdldFdpbmRvd1BvaW50ZXIoSFdORCBoV25kLCBpbnQgaW5kZXgpCiB7CiAj aWYgT1MoV0lOQ0UpCg==