78339 2012-02-10 01:52:08 -0800 [GTK] KURL::fileSystemPath() doesn't work if uri contains # 2012-02-10 03:51:24 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand xan.lopez oldest_to_newest 553950 0 cgarcia 2012-02-10 01:52:08 -0800 The problem is that KURL::fileSystemPath() uses g_filename_from_uri() to convert the uri to a local path. g_filename_from_uri() doesn't allow uris containing #, returning NULL in that case with a G_CONVERT_ERROR_BAD_URI error. In WebKit2, when html has been loaded from a string with loadHTML(), all relative paths must be relative to the baseURL passed to loadHTML(). To check whether a relative path is in the same directory than the baseURL, both are converted to local path. If the relative path contains a # KURL::fileSystemPath() returns an empty String and the condition is always false, making the web process to terminate. The solution is using GFile instead of g_filename_from_uri(), since GFile removes the anchor from the uri when converting the uri to a local path. 553952 1 126477 cgarcia 2012-02-10 01:56:21 -0800 Created attachment 126477 Patch Implementation with GFile is also bit cleaner and simpler. 553995 2 126477 pnormand 2012-02-10 03:42:10 -0800 Comment on attachment 126477 Patch Looks good! 554004 3 cgarcia 2012-02-10 03:51:24 -0800 Committed r107395: <http://trac.webkit.org/changeset/107395> 126477 2012-02-10 01:56:21 -0800 2012-02-10 03:42:10 -0800 Patch wk-kurl-filesystem-path.diff text/plain 1706 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMjk3OGNjLi4yNjhiMWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDItMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEtVUkw6OmZpbGVTeXN0ZW1QYXRoKCkgZG9lc24ndCB3b3JrIGlm IHVyaSBjb250YWlucyAjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03ODMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL0tVUkxHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S1VS TDo6ZmlsZVN5c3RlbVBhdGgpOiBVc2UgR0ZpbGUgQVBJIGluc3RlYWQgb2YKKyAgICAgICAgZ19m aWxlbmFtZV9mcm9tX3VyaSgpIHRvIGNvbnZlcnQgdGhlIHVyaSB0byBhIGxvY2FsCisgICAgICAg IHBhdGguIGdfZmlsZV9nZXRfcGF0aCgpIHJlbW92ZXMgdGhlIGFuY2hvciBmcm9tIHRoZSB1cmkg YW5kCisgICAgICAgIHJldHVybnMgYSB2YWxpZCBwYXRoIGluc3RlYWQgb2YgTlVMTC4KKwogMjAx Mi0wMi0wOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIERyb21h ZW8vZG9tLXRyYXZlcnNlLmh0bWwgc2hvdWxkIGdvIGZhc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9LVVJMR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9LVVJMR3RrLmNwcAppbmRleCA0N2JjNDhiLi4xMmQyYjE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS1VSTEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL0tVUkxHdGsuY3BwCkBAIC0yMCw2ICsyMCw5IEBACiAjaW5jbHVkZSAiS1VS TC5oIgogCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgorI2luY2x1ZGUgPGdpby9naW8uaD4KKyNp bmNsdWRlIDx3dGYvZ29iamVjdC9HT3duUHRyLmg+CisjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1Jl ZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogI2luY2x1ZGUgPGdsaWIu aD4KQEAgLTI4LDEzICszMSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogU3RyaW5nIEtVUkw6 OmZpbGVTeXN0ZW1QYXRoKCkgY29uc3QKIHsKLSAgICBnY2hhciogZmlsZW5hbWUgPSBnX2ZpbGVu YW1lX2Zyb21fdXJpKG1fc3RyaW5nLnV0ZjgoKS5kYXRhKCksIDAsIDApOwotICAgIGlmICghZmls ZW5hbWUpCi0gICAgICAgIHJldHVybiBTdHJpbmcoKTsKLQotICAgIFN0cmluZyBwYXRoID0gZmls ZW5hbWVUb1N0cmluZyhmaWxlbmFtZSk7Ci0gICAgZ19mcmVlKGZpbGVuYW1lKTsKLSAgICByZXR1 cm4gcGF0aDsKKyAgICBHUmVmUHRyPEdGaWxlPiBmaWxlID0gYWRvcHRHUmVmKGdfZmlsZV9uZXdf Zm9yX3VyaShtX3N0cmluZy51dGY4KCkuZGF0YSgpKSk7CisgICAgR093blB0cjxjaGFyPiBmaWxl bmFtZShnX2ZpbGVfZ2V0X3BhdGgoZmlsZS5nZXQoKSkpOworICAgIHJldHVybiBmaWxlbmFtZVRv U3RyaW5nKGZpbGVuYW1lLmdldCgpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=