78336 2012-02-10 01:15:10 -0800 CodeGeneratorJS doesn't always generate visitChildren() implementation when required 2012-02-10 03:46:48 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pf webkit-unassigned abarth haraken japhet webkit.review.bot oldest_to_newest 553934 0 pf 2012-02-10 01:15:10 -0800 In an IDL for an interface that declares no functions, but has attributes with [CachedAttribute], the implementation of visitChildren() is not generated by the JSC code generator. 553938 1 126474 pf 2012-02-10 01:19:27 -0800 Created attachment 126474 Patch 553999 2 126474 webkit.review.bot 2012-02-10 03:46:44 -0800 Comment on attachment 126474 Patch Clearing flags on attachment: 126474 Committed r107394: <http://trac.webkit.org/changeset/107394> 554001 3 webkit.review.bot 2012-02-10 03:46:48 -0800 All reviewed patches have been landed. Closing bug. 126474 2012-02-10 01:19:27 -0800 2012-02-10 03:46:43 -0800 Patch bug-78336-20120210011926.patch text/plain 4619 pf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThjYWUzNDVhOTMwNDE2 ZWIwMDNjZTcyYmM3YjdjNGNjNDdhN2ExOS4uOTNiNWEwZTY3MzQzMmEzNGJhOTlhZTFlMTdhOTdm YjRhMTQ0N2IxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAyLTEwICBQYWJs byBGbG91cmV0ICA8cGFibG9mQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBDb2RlR2VuZXJhdG9y SlMgZG9lc24ndCBhbHdheXMgZ2VuZXJhdGUgdmlzaXRDaGlsZHJlbigpIGltcGxlbWVudGF0aW9u IHdoZW4gcmVxdWlyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc4MzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBJbiBhbiBJREwgZm9yIGFuIGludGVyZmFjZSB0aGF0IGRlY2xhcmVzIG5v IGZ1bmN0aW9ucywgYnV0IGhhcworICAgICAgICBhdHRyaWJ1dGVzIHdpdGggW0NhY2hlZEF0dHJp YnV0ZV0sIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB2aXNpdENoaWxkcmVuKCkKKyAgICAgICAgaXMg bm90IGdlbmVyYXRlZCBieSB0aGUgSlNDIGNvZGUgZ2VuZXJhdG9yLgorCisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUltcGxl bWVudGF0aW9uKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0U2Vy aWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTVGVz dFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZTo6dmlzaXRDaGlsZHJlbik6CisgICAgICAg IChXZWJDb3JlKToKKwogMjAxMi0wMi0wOSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBbQ3VzdG9tQXJndW1lbnRIYW5kbGluZ10gd2l0aCBb Q2FsbFdpdGg9U2NyaXB0QXJndW1lbnRzfENhbGxTdGFja10KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggNGJmODMwODA3ZTI3 ZjgxYTg3YTBiZjQ2ZmM3ZmZmN2EyOTY1MmJkYy4uNDEyN2U0YTIxY2I4OWMzM2NiOWMyYzA3NGQw ZWJjZmU5ZmM0Y2ZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTIxMzUsNyArMjEzNSw5IEBAIHN1YiBHZW5lcmF0ZUlt cGxlbWVudGF0aW9uCiAKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiI2VuZGlmXG5c biIpIGlmICRjb25kaXRpb25hbDsKICAgICAgICAgfQotICAgICAgICAKKyAgICB9CisKKyAgICBp ZiAoJG51bUZ1bmN0aW9ucyA+IDAgfHwgJG51bUNhY2hlZEF0dHJpYnV0ZXMgPiAwKSB7CiAgICAg ICAgIGlmICgkbmVlZHNNYXJrQ2hpbGRyZW4gJiYgISRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57IkpTQ3VzdG9tTWFya0Z1bmN0aW9uIn0pIHsKICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCAidm9pZCAke2NsYXNzTmFtZX06OnZpc2l0Q2hpbGRyZW4oSlNDZWxsKiBjZWxsLCBT bG90VmlzaXRvciYgdmlzaXRvcilcbiIpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQs ICJ7XG4iKTsKQEAgLTIxNTgsMTIgKzIxNjAsMTMgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRp b24KICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAifVxuXG4i KTsKICAgICAgICAgfQotICAgICAgICAjIENhY2hlZCBhdHRyaWJ1dGVzIGFyZSBpbmRlZWQgYWxs b3dlZCB3aGVuIHRoZXJlIGlzIGEgY3VzdG9tIG1hcmsvdmlzaXRDaGlsZHJlbiBmdW5jdGlvbi4K LSAgICAgICAgIyBUaGUgY3VzdG9tIGZ1bmN0aW9uIG11c3QgbWFrZSBzdXJlIHRvIGFjY291bnQg Zm9yIHRoZSBjYWNoZWQgYXR0cmlidXRlLgotICAgICAgICAjIFVuY29tbWVudCB0aGUgYmVsb3cg bGluZSB0byB0ZW1wb3JhcmlseSBlbmZvcmNlIGdlbmVyYXRlZCBtYXJrIGZ1bmN0aW9ucyB3aGVu IGNhY2hlZCBhdHRyaWJ1dGVzIGFyZSBwcmVzZW50LgotICAgICAgICAjIGRpZSAiQ2FuJ3QgZ2Vu ZXJhdGUgYmluZGluZyBmb3IgY2xhc3Mgd2l0aCBjYWNoZWQgYXR0cmlidXRlIGFuZCBjdXN0b20g bWFyay4iIGlmICgoJG51bUNhY2hlZEF0dHJpYnV0ZXMgPiAwKSBhbmQgKCRkYXRhTm9kZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3VzdG9tTWFya0Z1bmN0aW9uIn0pKTsKICAgICB9CiAKKyAg ICAjIENhY2hlZCBhdHRyaWJ1dGVzIGFyZSBpbmRlZWQgYWxsb3dlZCB3aGVuIHRoZXJlIGlzIGEg Y3VzdG9tIG1hcmsvdmlzaXRDaGlsZHJlbiBmdW5jdGlvbi4KKyAgICAjIFRoZSBjdXN0b20gZnVu Y3Rpb24gbXVzdCBtYWtlIHN1cmUgdG8gYWNjb3VudCBmb3IgdGhlIGNhY2hlZCBhdHRyaWJ1dGUu CisgICAgIyBVbmNvbW1lbnQgdGhlIGJlbG93IGxpbmUgdG8gdGVtcG9yYXJpbHkgZW5mb3JjZSBn ZW5lcmF0ZWQgbWFyayBmdW5jdGlvbnMgd2hlbiBjYWNoZWQgYXR0cmlidXRlcyBhcmUgcHJlc2Vu dC4KKyAgICAjIGRpZSAiQ2FuJ3QgZ2VuZXJhdGUgYmluZGluZyBmb3IgY2xhc3Mgd2l0aCBjYWNo ZWQgYXR0cmlidXRlIGFuZCBjdXN0b20gbWFyay4iIGlmICgoJG51bUNhY2hlZEF0dHJpYnV0ZXMg PiAwKSBhbmQgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkpTQ3VzdG9tTWFya0Z1 bmN0aW9uIn0pKTsKKwogICAgIGlmICgkbnVtQ29uc3RhbnRzID4gMCkgewogICAgICAgICBwdXNo KEBpbXBsQ29udGVudCwgIi8vIENvbnN0YW50IGdldHRlcnNcblxuIik7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTZXJpYWxpemVk U2NyaXB0VmFsdWVJbnRlcmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS5jcHAKaW5kZXgg Yjk4N2ZhOTNkODIzMmM1N2IzODY2NzE2OWEzN2I1OTYwYWRhYjVhNS4uZjcxODNmMTkzNTkxYmM1 MTNlNjg3YTIwOWI2OGYwMDNiYzAwNmY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFj ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVz dFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS5jcHAKQEAgLTI0MCw2ICsyNDAsMTkgQEAg SlNWYWx1ZSBKU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2U6OmdldENvbnN0cnVj dG9yKEV4ZWNTdGF0ZSogZXhlYywgSlMKICAgICByZXR1cm4gZ2V0RE9NQ29uc3RydWN0b3I8SlNU ZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlQ29uc3RydWN0b3I+KGV4ZWMsIHN0YXRp Y19jYXN0PEpTRE9NR2xvYmFsT2JqZWN0Kj4oZ2xvYmFsT2JqZWN0KSk7CiB9CiAKK3ZvaWQgSlNU ZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlOjp2aXNpdENoaWxkcmVuKEpTQ2VsbCog Y2VsbCwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCit7CisgICAgSlNUZXN0U2VyaWFsaXplZFNjcmlw dFZhbHVlSW50ZXJmYWNlKiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTVGVzdFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZUludGVyZmFjZSo+KGNlbGwpOworICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFMo dGhpc09iamVjdCwgJnNfaW5mbyk7CisgICAgQ09NUElMRV9BU1NFUlQoU3RydWN0dXJlRmxhZ3Mg JiBPdmVycmlkZXNWaXNpdENoaWxkcmVuLCBPdmVycmlkZXNWaXNpdENoaWxkcmVuV2l0aG91dFNl dHRpbmdGbGFnKTsKKyAgICBBU1NFUlQodGhpc09iamVjdC0+c3RydWN0dXJlKCktPnR5cGVJbmZv KCkub3ZlcnJpZGVzVmlzaXRDaGlsZHJlbigpKTsKKyAgICBCYXNlOjp2aXNpdENoaWxkcmVuKHRo aXNPYmplY3QsIHZpc2l0b3IpOworICAgIGlmICh0aGlzT2JqZWN0LT5tX2NhY2hlZFZhbHVlKQor ICAgICAgICB2aXNpdG9yLmFwcGVuZCgmdGhpc09iamVjdC0+bV9jYWNoZWRWYWx1ZSk7CisgICAg aWYgKHRoaXNPYmplY3QtPm1fY2FjaGVkUmVhZG9ubHlWYWx1ZSkKKyAgICAgICAgdmlzaXRvci5h cHBlbmQoJnRoaXNPYmplY3QtPm1fY2FjaGVkUmVhZG9ubHlWYWx1ZSk7Cit9CisKIHN0YXRpYyBp bmxpbmUgYm9vbCBpc09ic2VydmFibGUoSlNUZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJm YWNlKiBqc1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UpCiB7CiAgICAgaWYgKGpz VGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS0+aGFzQ3VzdG9tUHJvcGVydGllcygp KQo=