78332 2012-02-10 00:46:27 -0800 [Qt] 6 SVG tests assert after r107207 2012-05-15 02:31:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED WORKSFORME Qt, QtTriaged P1 Critical --- 67543 78115 78219 79668 1 ossy webkit-unassigned kkristof ossy rhodovan.u-szeged zherczeg zimmermann oldest_to_newest 553918 0 ossy 2012-02-10 00:46:27 -0800 After r107207 the following tests started to assert in debug mode: svg/custom/mask-child-changes.svg svg/custom/mask-invalidation.svg svg/custom/absolute-sized-content-with-resources.xhtml ASSERTION FAILED: m_transparencyCount > 0 ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer() Nikos comment on the original bug: "hm, I guess this only exposes a Qt bug - that's now visible due the changed timing. It's not something I can fix without a Qt build" 553920 1 ossy 2012-02-10 00:57:13 -0800 I skipped the to paint the bot green - http://trac.webkit.org/changeset/107378 Please unskip them with the proper fix. 559091 2 zimmermann 2012-02-17 03:12:47 -0800 > ASSERTION FAILED: m_transparencyCount > 0 Hmpf, the problem is the m_transparencyCount generalization. Qt maintains a different count "layerCount" returned by isInTransparentLayer(), and it calls endTransparencyLayer too often, compared to all other ports - to support image clipping. Cairo has similar needs (mask image operation during restore()) but doesn't suffer from the problem - can this be reused instead? I hope Zoltan can have a look. 559101 3 zimmermann 2012-02-17 03:19:49 -0800 Bug 67543 is the culprit, leading to the Qt assertion. 560813 4 ossy 2012-02-21 04:59:08 -0800 Two more asserting test: svg/dynamic-updates/SVGMaskElement-svgdom-width-prop.html svg/dynamic-updates/SVGMaskElement-dom-x-attr.html 560818 5 ossy 2012-02-21 05:06:58 -0800 (In reply to comment #4) > Two more asserting test: > svg/dynamic-updates/SVGMaskElement-svgdom-width-prop.html > svg/dynamic-updates/SVGMaskElement-dom-x-attr.html And svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html I skipped them too. I hope once the test coverge will hit 0% and then all tests will pass forever. :) 623779 6 kkristof 2012-05-15 01:14:38 -0700 Committed r117040: <http://trac.webkit.org/changeset/117040> 623836 7 kkristof 2012-05-15 02:31:20 -0700 These don't asserts now, hence I unskipped them in r117040