78328 2012-02-09 23:25:07 -0800 Remove [ConvertingNullStringTo] from CloseEvent.idl 2012-02-14 15:39:14 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin ojan webkit.review.bot oldest_to_newest 553877 0 haraken 2012-02-09 23:25:07 -0800 In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo]. In bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]. In conclusion, we should replace [ConvertingNullStringTo] with [TreatReturnedNullStringAs]. 553881 1 126464 haraken 2012-02-09 23:32:54 -0800 Created attachment 126464 Patch 553882 2 126464 abarth 2012-02-09 23:37:28 -0800 Comment on attachment 126464 Patch Have you cross-checked this with the spec? 553899 3 126467 haraken 2012-02-10 00:04:37 -0800 Created attachment 126467 Patch 553900 4 haraken 2012-02-10 00:05:23 -0800 (In reply to comment #2) > (From update of attachment 126464 [details]) > Have you cross-checked this with the spec? The spec says "The reason attribute must return the value it was initialized to. When the object is created, this attribute must be initialized to empty string.". http://dev.w3.org/html5/websockets/#event-definitions So we should simply remove [ConvertingNullStringTo]. Uploaded a revised patch. 553944 5 126467 webkit.review.bot 2012-02-10 01:28:23 -0800 Comment on attachment 126467 Patch Clearing flags on attachment: 126467 Committed r107382: <http://trac.webkit.org/changeset/107382> 553945 6 webkit.review.bot 2012-02-10 01:28:27 -0800 All reviewed patches have been landed. Closing bug. 555672 7 darin 2012-02-13 15:31:58 -0800 All sounds fine, but what about test coverage? 555704 8 haraken 2012-02-13 16:01:34 -0800 (In reply to comment #7) > All sounds fine, but what about test coverage? Darin: The following existing test is in close-event-constructor.html: shouldBeEqualToString("new CloseEvent('eventType', { reason: '' }).reason", ""); Fortunately, we didn't need to change the test result (since [ConvertingNullStringTo] was typo and had not been working at all). 556687 9 darin 2012-02-14 15:33:14 -0800 (In reply to comment #8) > Fortunately, we didn't need to change the test result So if we had added the correctly spelled attribute the test would have failed? 556699 10 haraken 2012-02-14 15:39:14 -0800 (In reply to comment #9) > (In reply to comment #8) > > Fortunately, we didn't need to change the test result > > So if we had added the correctly spelled attribute the test would have failed? Yes. 126464 2012-02-09 23:32:54 -0800 2012-02-10 00:04:21 -0800 Patch bug-78328-20120210163252.patch text/plain 4496 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY5YWExOWI2Yzg4Nzdj ZDM1NDU3MTE3NTA0YjBjYTQxNDlhMDkyMy4uZTRkNzRkNThlMGMwMTQyYTY4NTE4OTA2ZmMyMDRh NjVlOTQ1N2JiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTAyLTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXBsYWNlIFtDb252 ZXJ0aW5nTnVsbFN0cmluZ1RvXSB3aXRoIFtUcmVhdFJldHVybmVkTnVsbFN0cmluZ0FzXQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgzMjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBDbG9zZUV2ZW50 LmlkbCwgW0NvbnZlcnRpbmdOdWxsU3RyaW5nVG9dIGlzIGEgdHlwbyBvZiBbQ29udmVydE51bGxT dHJpbmdUb10uCisgICAgICAgIEluIGJ1ZyA3ODEwOCwgW0NvbnZlcnROdWxsU3RyaW5nVG9dIHdh cyByZW5hbWVkIHRvIFtUcmVhdFJldHVybmVkTnVsbFN0cmluZ0FzXS4KKyAgICAgICAgSW4gY29u Y2x1c2lvbiwgdGhpcyBwYXRjaCByZXBsYWNlcyBbQ29udmVydGluZ051bGxTdHJpbmdUb10gd2l0 aCBbVHJlYXRSZXR1cm5lZE51bGxTdHJpbmdBc10uCisKKyAgICAgICAgVGVzdDogZmFzdC9ldmVu dHMvY29uc3RydWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwKKworICAgICAgICAq IHdlYnNvY2tldHMvQ2xvc2VFdmVudC5pZGw6CisKKzIwMTItMDItMDkgIEtlbnRhcm8gSGFyYSAg PGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJlcGxhY2UgW0N1c3RvbUFyZ3VtZW50 SGFuZGxpbmddIHdpdGggW0NhbGxXaXRoPVNjcmlwdEFyZ3VtZW50c3xDYWxsU3RhY2tdCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODMyNwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaWRsIGIvU291cmNl L1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmlkbAppbmRleCBlMzZjOTQ5NGExYzdjZTk4 ZTI5ZDI1N2U5NjBkNmIxMjZiMWE1NDA1Li42NThiNTJkMmM0MjVjYjEzMTdiODUyNGMwMDBmMDRk MTFhZTUxMjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZl bnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvQ2xvc2VFdmVudC5pZGwKQEAg LTM2LDcgKzM2LDcgQEAgbW9kdWxlIGV2ZW50cyB7CiAgICAgXSBDbG9zZUV2ZW50IDogRXZlbnQg ewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVj dG9yXSBib29sZWFuIHdhc0NsZWFuOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0luaXRp YWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSB1bnNpZ25lZCBzaG9ydCBjb2RlOwotICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yLCBDb252ZXJ0 aW5nTnVsbFN0cmluZ1RvPVVuZGVmaW5lZF0gRE9NU3RyaW5nIHJlYXNvbjsKKyAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3RvciwgVHJlYXRSZXR1 cm5lZE51bGxTdHJpbmdBcz1VbmRlZmluZWRdIERPTVN0cmluZyByZWFzb247CiAgICAgfTsKIAog fQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDFmYTc4OGJkNmYzZTc5ODcxNmZjNjAxYjRjY2UwMGJjYjg0YzMxNzYuLjMxYzY3 Zjg4NGQ5ZmM5MDVmYTY3YjYwZTg2ZDVjZDY1MTc2NzRiNDggMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxMi0wMi0wOSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmVwbGFjZSBbQ29udmVydGluZ051bGxTdHJpbmdUb10gd2l0aCBbVHJlYXRSZXR1cm5l ZE51bGxTdHJpbmdBc10KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc4MzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3RydWN0b3Iu aHRtbDogVXBkYXRlZCB0aGUgdGVzdCByZXN1bHQuCisgICAgICAgIENsb3NlRXZlbnQucmVhc29u IHNob3VsZCBiZSB1bmRlZmluZWQgaWYgaXQgaXMgbm90IHlldCBpbml0aWFsaXplZC4KKyAgICAg ICAgKiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3RydWN0b3ItZXhw ZWN0ZWQudHh0OiBEaXR0by4KKwogMjAxMi0wMi0wOSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFm ZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBbm90aGVyIHVucmV2aWV3ZWQgbWFzc2l2ZSBT VkcgcmViYXNlbGluZSAoYWxsIG91ciB3aW5kb3dzIGJvdHMgdGhhdCBJIG1pc3NlZCkuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQt Y29uc3RydWN0b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3Ry dWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAppbmRleCA1YzcxYTEw NDlkZTdjYjlhNTcyOThmNWUzYjJiMjhmNTQ4NWEwOTZjLi41OGE5ZGNlNTQ5MGJjYTRkYTU0OTE5 ZjViZTk1ZjkxNTI2ZjI4YjA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9j b25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9jbG9zZS1ldmVudC1jb25zdHJ1Y3Rv ci1leHBlY3RlZC50eHQKQEAgLTcsNyArNyw3IEBAIFBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50 VHlwZScpLmJ1YmJsZXMgaXMgZmFsc2UKIFBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScp LmNhbmNlbGFibGUgaXMgZmFsc2UKIFBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScpLndh c0NsZWFuIGlzIGZhbHNlCiBQQVNTIG5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnKS5jb2RlIGlz IDAKLVBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScpLnJlYXNvbiBpcyAiIgorUEFTUyBu ZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBlJykucmVhc29uIGlzIHVuZGVmaW5lZAogUEFTUyBuZXcg Q2xvc2VFdmVudCgnZXZlbnRUeXBlJywgeyBidWJibGVzOiBmYWxzZSB9KS5idWJibGVzIGlzIGZh bHNlCiBQQVNTIG5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7IGJ1YmJsZXM6IHRydWUgfSku YnViYmxlcyBpcyB0cnVlCiBQQVNTIG5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7IGNhbmNl bGFibGU6IGZhbHNlIH0pLmNhbmNlbGFibGUgaXMgZmFsc2UKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9jbG9zZS1ldmVudC1jb25zdHJ1Y3Rvci5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0 cnVjdG9yLmh0bWwKaW5kZXggYjE4MWNlYjM2Y2M5MzZiZTQ2ODg4YzAxZDJhZGEwYjFmMDAzZTdm Mi4uMTlkOGQ5MmViMDI1OTg3MzJiYjEwYTZiZDg0ZmUwZDdiY2M5NWMwYSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0cnVj dG9yLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2Nsb3Nl LWV2ZW50LWNvbnN0cnVjdG9yLmh0bWwKQEAgLTEzLDcgKzEzLDcgQEAgc2hvdWxkQmUoIm5ldyBD bG9zZUV2ZW50KCdldmVudFR5cGUnKS5idWJibGVzIiwgImZhbHNlIik7CiBzaG91bGRCZSgibmV3 IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScpLmNhbmNlbGFibGUiLCAiZmFsc2UiKTsKIHNob3VsZEJl KCJuZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBlJykud2FzQ2xlYW4iLCAiZmFsc2UiKTsKIHNob3Vs ZEJlKCJuZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBlJykuY29kZSIsICIwIik7Ci1zaG91bGRCZUVx dWFsVG9TdHJpbmcoIm5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnKS5yZWFzb24iLCAiIik7Citz aG91bGRCZSgibmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScpLnJlYXNvbiIsICJ1bmRlZmluZWQi KTsKIAogLy8gYnViYmxlcyBpcyBwYXNzZWQuCiBzaG91bGRCZSgibmV3IENsb3NlRXZlbnQoJ2V2 ZW50VHlwZScsIHsgYnViYmxlczogZmFsc2UgfSkuYnViYmxlcyIsICJmYWxzZSIpOwo= 126467 2012-02-10 00:04:37 -0800 2012-02-10 01:28:23 -0800 Patch bug-78328-20120210170436.patch text/plain 2026 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZiMWMzN2YzYmZmYjM0 YjU0MmU3MDMzZjQxNDcxMTllZmJiY2NmMS4uNDM2YWQ0ZTk0NWQzNmUzNmVjNGYxNjU4NTA1NDJm ZWUzYjAyZDlhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTAyLTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZW1vdmUgW0NvbnZl cnRpbmdOdWxsU3RyaW5nVG9dIGZyb20gQ2xvc2VFdmVudC5pZGwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MzI4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gQ2xvc2VFdmVudC5pZGwsIFtDb252ZXJ0 aW5nTnVsbFN0cmluZ1RvXSBpcyBhIHR5cG8gb2YgW0NvbnZlcnROdWxsU3RyaW5nVG9dLAorICAg ICAgICAoYWx0aG91Z2ggaW4gYnVnIDc4MTA4LCBbQ29udmVydE51bGxTdHJpbmdUb10gd2FzIHJl bmFtZWQgdG8gW1RyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXNdKS4KKworICAgICAgICBBbnl3YXks IHRoZSBzcGVjIHNheXMgdGhhdCAiVGhlIHJlYXNvbiBhdHRyaWJ1dGUgbXVzdCByZXR1cm4gdGhl IHZhbHVlIGl0IHdhcworICAgICAgICBpbml0aWFsaXplZCB0by4gV2hlbiB0aGUgb2JqZWN0IGlz IGNyZWF0ZWQsIHRoaXMgYXR0cmlidXRlIG11c3QgYmUgaW5pdGlhbGl6ZWQgdG8gZW1wdHkgc3Ry aW5nLiIKKyAgICAgICAgaHR0cDovL2Rldi53My5vcmcvaHRtbDUvd2Vic29ja2V0cy8jZXZlbnQt ZGVmaW5pdGlvbnMKKyAgICAgICAgVGh1cywgdGhpcyBwYXRjaCByZW1vdmVzIFtDb252ZXJ0aW5n TnVsbFN0cmluZ1RvXSBmcm9tIENsb3NlRXZlbnQuaWRsLgorCisgICAgICAgIFRlc3Q6IGZhc3Qv ZXZlbnRzL2NvbnN0cnVjdG9ycy9jbG9zZS1ldmVudC1jb25zdHJ1Y3Rvci5odG1sCisKKyAgICAg ICAgKiB3ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaWRsOgorCisyMDEyLTAyLTA5ICBLZW50YXJvIEhh cmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTA3MzY4LgogICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8x MDczNjgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4 MzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaWRs IGIvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmlkbAppbmRleCBlMzZjOTQ5 NGExYzdjZTk4ZTI5ZDI1N2U5NjBkNmIxMjZiMWE1NDA1Li5lYTc1MTExYWMzNjIyMGMxY2RlZWNm NGVlNTkxMmI4MmUxN2Q1ZTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRz L0Nsb3NlRXZlbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvQ2xvc2VFdmVu dC5pZGwKQEAgLTM2LDcgKzM2LDcgQEAgbW9kdWxlIGV2ZW50cyB7CiAgICAgXSBDbG9zZUV2ZW50 IDogRXZlbnQgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0luaXRpYWxpemVkQnlFdmVu dENvbnN0cnVjdG9yXSBib29sZWFuIHdhc0NsZWFuOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSB1bnNpZ25lZCBzaG9ydCBjb2RlOwot ICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9y LCBDb252ZXJ0aW5nTnVsbFN0cmluZ1RvPVVuZGVmaW5lZF0gRE9NU3RyaW5nIHJlYXNvbjsKKyAg ICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rvcl0g RE9NU3RyaW5nIHJlYXNvbjsKICAgICB9OwogCiB9Cg==