78316 2012-02-09 19:12:51 -0800 Disable IndexedDB permissions check from shared workers 2012-02-10 17:20:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan jsbell michaeln tony webkit.review.bot oldest_to_newest 553732 0 dgrogan 2012-02-09 19:12:51 -0800 Disable IndexedDB permissions check from workers 553734 1 126434 dgrogan 2012-02-09 19:14:20 -0800 Created attachment 126434 Patch 553738 2 dgrogan 2012-02-09 19:17:42 -0800 I left the rest of the code for 2 reasons: 1) To prevent it from not compiling. 2) To preserve the diff when I update it. I foresee a quite skeptical webkit reviewer. 553748 3 126434 michaeln 2012-02-09 19:41:29 -0800 Comment on attachment 126434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126434&action=review > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:165 > WebWorkerClientImpl* webWorkerClientImpl = static_cast<WebWorkerClientImpl*>(&workerContext->thread()->workerLoaderProxy()); david, you had mentioned an invalid cast in the shared worker case... is this it on line 165? 553751 4 michaeln 2012-02-09 19:44:59 -0800 maybe test if isSharedWorkerContext() and only short circuit that case to not regress for dedicated workers 554169 5 126533 dgrogan 2012-02-10 10:25:28 -0800 Created attachment 126533 Patch 554172 6 126533 dgrogan 2012-02-10 10:27:09 -0800 Comment on attachment 126533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126533&action=review Changed to only disable the test for shared workers. > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:166 > WebWorkerClientImpl* webWorkerClientImpl = static_cast<WebWorkerClientImpl*>(&workerContext->thread()->workerLoaderProxy()); Yes, this is the cast that needs to be changed to a WebWorkerBase. 554354 7 dgrogan 2012-02-10 13:42:31 -0800 Tony, could you review this? 554374 8 126533 tony 2012-02-10 14:06:05 -0800 Comment on attachment 126533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126533&action=review Can you write a LayoutTest for this? > Source/WebKit/chromium/ChangeLog:6 > + > + Reviewed by NOBODY (OOPS!). Please put include some of the comment here to explain why you're making this change. 554401 9 126533 dgrogan 2012-02-10 14:40:39 -0800 Comment on attachment 126533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126533&action=review The behavior that's changing here (for shared workers) can't be tested with the current DRT because it doesn't run multiple processes. I think a layout test for the dedicated worker case is possible, though it would involve changing layoutTestController. Which I don't want to do right now on account of expediency. (The only reason we're adding this bypass is to get the feature in front of developers ASAP.) Though I've been meaning to add a permissions test for a while. Bug filed at http://crbug.com/113738. Is that ok? >> Source/WebKit/chromium/ChangeLog:6 >> + Reviewed by NOBODY (OOPS!). > > Please put include some of the comment here to explain why you're making this change. Done. 554403 10 126586 dgrogan 2012-02-10 14:42:07 -0800 Created attachment 126586 Patch 554412 11 tony 2012-02-10 14:58:39 -0800 (In reply to comment #9) > The behavior that's changing here (for shared workers) can't be tested with the current DRT because it doesn't run multiple processes. Please mention this in the ChangeLog (e.g., No new tests because ....). > I think a layout test for the dedicated worker case is possible, though it would involve changing layoutTestController. Which I don't want to do right now on account of expediency. (The only reason we're adding this bypass is to get the feature in front of developers ASAP.) > Though I've been meaning to add a permissions test for a while. Bug filed at http://crbug.com/113738. Is that ok? Having a bug for this is fine for now. I would have filed it in webkit, but whatever works for you. 554428 12 126591 dgrogan 2012-02-10 15:12:20 -0800 Created attachment 126591 Patch for landing 554512 13 126591 webkit.review.bot 2012-02-10 17:20:51 -0800 Comment on attachment 126591 Patch for landing Clearing flags on attachment: 126591 Committed r107463: <http://trac.webkit.org/changeset/107463> 554513 14 webkit.review.bot 2012-02-10 17:20:58 -0800 All reviewed patches have been landed. Closing bug. 126434 2012-02-09 19:14:20 -0800 2012-02-10 10:25:25 -0800 Patch bug-78316-20120209191417.patch text/plain 1642 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMzODM3ZDFjZmZjNGY1Yjg1MDQ0MDFjY2IwNDJiZDE5NWNiMzM0OWUuLmFlYzM0MDdlOTEyNDA2 NjQwZWYyOTdjYmY2ODZkNzc5NjU1MzczNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMDkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIERpc2FibGUgSW5kZXhlZERCIHBlcm1pc3Npb25zIGNoZWNrIGZy b20gd29ya2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzgzMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHNyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SURC RmFjdG9yeUJhY2tlbmRQcm94eTo6YWxsb3dJREJGcm9tV29ya2VyVGhyZWFkKToKKwogMjAxMi0w Mi0wOCAgUmF5bW9uZCBMaXUgIDxyYXltb25kLmxpdUBpbnRlbC5jb20+CiAKICAgICAgICAgRml4 IGEgdHlwbyBmb3IgcjEwNzEyNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAppbmRleCA5OWEwYWZhZTRhN2NjMDIxOGZmZGU0 ZTM1NTU4NjQ2NGNiZTRmODc1Li5iYzNiMzIxMDIyZWQ4YmQxMjlkYTM5OGFhY2NkYjRiYTY2Zjlk MmM3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5QmFj a2VuZFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5 QmFja2VuZFByb3h5LmNwcApAQCAtMTU3LDYgKzE1NywxMSBAQCBwcml2YXRlOgogCiBib29sIElE QkZhY3RvcnlCYWNrZW5kUHJveHk6OmFsbG93SURCRnJvbVdvcmtlclRocmVhZChXb3JrZXJDb250 ZXh0KiB3b3JrZXJDb250ZXh0LCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlNlY3VyaXR5 T3JpZ2luJikKIHsKKyAgICAvLyBGSVhNRTogQnlwYXNzIGNoZWNraW5nIGZvciBwZXJtaXNzaW9u IHNvIGFzIG5vdCB0byBibG9jayBzaGFyZWQgd29ya2VyCisgICAgLy8gdGVzdGluZyB1bnRpbCBh IHBlcm1pc3Npb25zIGNoZWNrIGlzIGltcGxlbWVudGVkLiBUaGlzIGhhcyB0byBiZSBmaXhlZAor ICAgIC8vIGJlZm9yZSBtMTkgZ29lcyB0byBiZXRhLiBodHRwOi8vY3JidWcuY29tLzExMjg1NQor ICAgIHJldHVybiB0cnVlOworCiAgICAgV2ViV29ya2VyQ2xpZW50SW1wbCogd2ViV29ya2VyQ2xp ZW50SW1wbCA9IHN0YXRpY19jYXN0PFdlYldvcmtlckNsaWVudEltcGwqPigmd29ya2VyQ29udGV4 dC0+dGhyZWFkKCktPndvcmtlckxvYWRlclByb3h5KCkpOwogICAgIFdvcmtlclJ1bkxvb3AmIHJ1 bkxvb3AgPSB3b3JrZXJDb250ZXh0LT50aHJlYWQoKS0+cnVuTG9vcCgpOwogCg== 126533 2012-02-10 10:25:28 -0800 2012-02-10 14:42:03 -0800 Patch bug-78316-20120210102527.patch text/plain 1702 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMzODM3ZDFjZmZjNGY1Yjg1MDQ0MDFjY2IwNDJiZDE5NWNiMzM0OWUuLmFhYThkZDlkZjdhNTc4 NDFiOTM2MGUwYmVjODRiYzAzNmQ1Nzc0MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDItMDkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIERpc2FibGUgSW5kZXhlZERCIHBlcm1pc3Npb25zIGNoZWNrIGZy b20gc2hhcmVkIHdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4MzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBzcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHA6CisgICAgICAgIChXZWJL aXQ6OklEQkZhY3RvcnlCYWNrZW5kUHJveHk6OmFsbG93SURCRnJvbVdvcmtlclRocmVhZCk6CisK IDIwMTItMDItMDggIFJheW1vbmQgTGl1ICA8cmF5bW9uZC5saXVAaW50ZWwuY29tPgogCiAgICAg ICAgIEZpeCBhIHR5cG8gZm9yIHIxMDcxMjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL0lEQkZhY3RvcnlCYWNrZW5kUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHAKaW5kZXggOTlhMGFmYWU0YTdjYzAy MThmZmRlNGUzNTU1ODY0NjRjYmU0Zjg3NS4uNDI5NTM0MDI2NzJmYzMzMzk0ZmYyOWIxYzYyNDRh YjA5ZGE4MmY3MiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFj dG9yeUJhY2tlbmRQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURC RmFjdG9yeUJhY2tlbmRQcm94eS5jcHAKQEAgLTE1Nyw2ICsxNTcsMTIgQEAgcHJpdmF0ZToKIAog Ym9vbCBJREJGYWN0b3J5QmFja2VuZFByb3h5OjphbGxvd0lEQkZyb21Xb3JrZXJUaHJlYWQoV29y a2VyQ29udGV4dCogd29ya2VyQ29udGV4dCwgY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBXZWJT ZWN1cml0eU9yaWdpbiYpCiB7CisgICAgLy8gRklYTUU6IEJ5cGFzcyBjaGVja2luZyBmb3IgcGVy bWlzc2lvbiBzbyBhcyBub3QgdG8gYmxvY2sgc2hhcmVkIHdvcmtlcgorICAgIC8vIHRlc3Rpbmcg dW50aWwgYSBwZXJtaXNzaW9ucyBjaGVjayBpcyBpbXBsZW1lbnRlZC4gVGhpcyBoYXMgdG8gYmUg Zml4ZWQKKyAgICAvLyBiZWZvcmUgbTE5IGdvZXMgdG8gYmV0YS4gaHR0cDovL2NyYnVnLmNvbS8x MTI4NTUKKyAgICBpZiAod29ya2VyQ29udGV4dC0+aXNTaGFyZWRXb3JrZXJDb250ZXh0KCkpCisg ICAgICAgIHJldHVybiB0cnVlOworCiAgICAgV2ViV29ya2VyQ2xpZW50SW1wbCogd2ViV29ya2Vy Q2xpZW50SW1wbCA9IHN0YXRpY19jYXN0PFdlYldvcmtlckNsaWVudEltcGwqPigmd29ya2VyQ29u dGV4dC0+dGhyZWFkKCktPndvcmtlckxvYWRlclByb3h5KCkpOwogICAgIFdvcmtlclJ1bkxvb3Am IHJ1bkxvb3AgPSB3b3JrZXJDb250ZXh0LT50aHJlYWQoKS0+cnVuTG9vcCgpOwogCg== 126586 2012-02-10 14:42:07 -0800 2012-02-10 15:12:16 -0800 Patch bug-78316-20120210144206.patch text/plain 1989 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMzODM3ZDFjZmZjNGY1Yjg1MDQ0MDFjY2IwNDJiZDE5NWNiMzM0OWUuLmY2YjRiZDMzN2VjY2Rl MjQwY2NjZWM2NzUwMGFjMzU0N2YwOGIxMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDItMDkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIERpc2FibGUgSW5kZXhlZERCIHBlcm1pc3Npb25zIGNoZWNrIGZy b20gc2hhcmVkIHdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4MzE2CisKKyAgICAgICAgV2Ugd2FudCB0byB0ZW1wb3JhcmlseSBieXBhc3Mg dGhpcyBjaGVjayBiZWNhdXNlIGl0IGNhdXNlcyBhIGNyYXNoCisgICAgICAgIHdoZW4gY2FsbGVk IGZyb20gYSBzaGFyZWQgd29ya2VyLiAgV2UnbGwgaGF2ZSB0byBmaXggaXQgYmVmb3JlCisgICAg ICAgIGluY2x1ZGluZyBpZGIgb24gc2hhcmVkIHdvcmtlcnMgaW4gYSByZWxlYXNlIGJ1dCBkb24n dCB3YW50IHRvIHN0b3AKKyAgICAgICAgZGV2ZWxvcGVycyBmcm9tIHRlc3Rpbmcgb3V0IGlkYiBv biBzaGFyZWQgd29ya2Vycy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHNyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6SURCRmFjdG9yeUJhY2tlbmRQcm94eTo6YWxsb3dJREJGcm9tV29ya2VyVGhyZWFkKToK KwogMjAxMi0wMi0wOCAgUmF5bW9uZCBMaXUgIDxyYXltb25kLmxpdUBpbnRlbC5jb20+CiAKICAg ICAgICAgRml4IGEgdHlwbyBmb3IgcjEwNzEyNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAppbmRleCA5OWEwYWZhZTRhN2Nj MDIxOGZmZGU0ZTM1NTU4NjQ2NGNiZTRmODc1Li40Mjk1MzQwMjY3MmZjMzMzOTRmZjI5YjFjNjI0 NGFiMDlkYTgyZjcyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJG YWN0b3J5QmFja2VuZFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9J REJGYWN0b3J5QmFja2VuZFByb3h5LmNwcApAQCAtMTU3LDYgKzE1NywxMiBAQCBwcml2YXRlOgog CiBib29sIElEQkZhY3RvcnlCYWNrZW5kUHJveHk6OmFsbG93SURCRnJvbVdvcmtlclRocmVhZChX b3JrZXJDb250ZXh0KiB3b3JrZXJDb250ZXh0LCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFdl YlNlY3VyaXR5T3JpZ2luJikKIHsKKyAgICAvLyBGSVhNRTogQnlwYXNzIGNoZWNraW5nIGZvciBw ZXJtaXNzaW9uIHNvIGFzIG5vdCB0byBibG9jayBzaGFyZWQgd29ya2VyCisgICAgLy8gdGVzdGlu ZyB1bnRpbCBhIHBlcm1pc3Npb25zIGNoZWNrIGlzIGltcGxlbWVudGVkLiBUaGlzIGhhcyB0byBi ZSBmaXhlZAorICAgIC8vIGJlZm9yZSBtMTkgZ29lcyB0byBiZXRhLiBodHRwOi8vY3JidWcuY29t LzExMjg1NQorICAgIGlmICh3b3JrZXJDb250ZXh0LT5pc1NoYXJlZFdvcmtlckNvbnRleHQoKSkK KyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICBXZWJXb3JrZXJDbGllbnRJbXBsKiB3ZWJXb3Jr ZXJDbGllbnRJbXBsID0gc3RhdGljX2Nhc3Q8V2ViV29ya2VyQ2xpZW50SW1wbCo+KCZ3b3JrZXJD b250ZXh0LT50aHJlYWQoKS0+d29ya2VyTG9hZGVyUHJveHkoKSk7CiAgICAgV29ya2VyUnVuTG9v cCYgcnVuTG9vcCA9IHdvcmtlckNvbnRleHQtPnRocmVhZCgpLT5ydW5Mb29wKCk7CiAK 126591 2012-02-10 15:12:20 -0800 2012-02-10 17:20:51 -0800 Patch for landing bug-78316-20120210151220.patch text/plain 2088 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMzODM3ZDFjZmZjNGY1Yjg1MDQ0MDFjY2IwNDJiZDE5NWNiMzM0OWUuLjhhMTA1MWViODBkNzA0 YzczYTRhZDRhMzI1NjZhMjc3OTQ1NWJiMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDItMDkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIERpc2FibGUgSW5kZXhlZERCIHBlcm1pc3Npb25zIGNoZWNrIGZy b20gc2hhcmVkIHdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4MzE2CisKKyAgICAgICAgV2Ugd2FudCB0byB0ZW1wb3JhcmlseSBieXBhc3Mg dGhpcyBjaGVjayBiZWNhdXNlIGl0IGNhdXNlcyBhIGNyYXNoCisgICAgICAgIHdoZW4gY2FsbGVk IGZyb20gYSBzaGFyZWQgd29ya2VyLiAgV2UnbGwgaGF2ZSB0byBmaXggaXQgYmVmb3JlCisgICAg ICAgIGluY2x1ZGluZyBpZGIgb24gc2hhcmVkIHdvcmtlcnMgaW4gYSByZWxlYXNlIGJ1dCBkb24n dCB3YW50IHRvIHN0b3AKKyAgICAgICAgZGV2ZWxvcGVycyBmcm9tIHRlc3Rpbmcgb3V0IGlkYiBv biBzaGFyZWQgd29ya2Vycy4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBpdCBhZmZl Y3RzIHNoYXJlZCB3b3JrZXJzIG9ubHksIHdoaWNoIGFyZW4ndAorICAgICAgICB0ZXN0YWJsZSBi eSBEUlQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICAqIHNy Yy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SURCRmFjdG9y eUJhY2tlbmRQcm94eTo6YWxsb3dJREJGcm9tV29ya2VyVGhyZWFkKToKKwogMjAxMi0wMi0wOCAg UmF5bW9uZCBMaXUgIDxyYXltb25kLmxpdUBpbnRlbC5jb20+CiAKICAgICAgICAgRml4IGEgdHlw byBmb3IgcjEwNzEyNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURC RmFjdG9yeUJhY2tlbmRQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJG YWN0b3J5QmFja2VuZFByb3h5LmNwcAppbmRleCA5OWEwYWZhZTRhN2NjMDIxOGZmZGU0ZTM1NTU4 NjQ2NGNiZTRmODc1Li40Mjk1MzQwMjY3MmZjMzMzOTRmZjI5YjFjNjI0NGFiMDlkYTgyZjcyIDEw MDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2Vu ZFByb3h5LmNwcApAQCAtMTU3LDYgKzE1NywxMiBAQCBwcml2YXRlOgogCiBib29sIElEQkZhY3Rv cnlCYWNrZW5kUHJveHk6OmFsbG93SURCRnJvbVdvcmtlclRocmVhZChXb3JrZXJDb250ZXh0KiB3 b3JrZXJDb250ZXh0LCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2lu JikKIHsKKyAgICAvLyBGSVhNRTogQnlwYXNzIGNoZWNraW5nIGZvciBwZXJtaXNzaW9uIHNvIGFz IG5vdCB0byBibG9jayBzaGFyZWQgd29ya2VyCisgICAgLy8gdGVzdGluZyB1bnRpbCBhIHBlcm1p c3Npb25zIGNoZWNrIGlzIGltcGxlbWVudGVkLiBUaGlzIGhhcyB0byBiZSBmaXhlZAorICAgIC8v IGJlZm9yZSBtMTkgZ29lcyB0byBiZXRhLiBodHRwOi8vY3JidWcuY29tLzExMjg1NQorICAgIGlm ICh3b3JrZXJDb250ZXh0LT5pc1NoYXJlZFdvcmtlckNvbnRleHQoKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CisKICAgICBXZWJXb3JrZXJDbGllbnRJbXBsKiB3ZWJXb3JrZXJDbGllbnRJbXBsID0g c3RhdGljX2Nhc3Q8V2ViV29ya2VyQ2xpZW50SW1wbCo+KCZ3b3JrZXJDb250ZXh0LT50aHJlYWQo KS0+d29ya2VyTG9hZGVyUHJveHkoKSk7CiAgICAgV29ya2VyUnVuTG9vcCYgcnVuTG9vcCA9IHdv cmtlckNvbnRleHQtPnRocmVhZCgpLT5ydW5Mb29wKCk7CiAK