78308 2012-02-09 18:13:31 -0800 The JS Parser scope object needs a VectorTrait specialization 2012-02-10 10:37:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ggaren oldest_to_newest 553685 0 oliver 2012-02-09 18:13:31 -0800 The JS Parser scope object needs a VectorTrait specialization 553689 1 126421 oliver 2012-02-09 18:16:22 -0800 Created attachment 126421 Patch 553695 2 126421 barraclough 2012-02-09 18:20:13 -0800 Comment on attachment 126421 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126421&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:418 > + if (1) { Oooops, you probably want to remove that. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1227 > + if (JSActivation* activation = jsDynamicCast<JSActivation*>(currentVariableObject)) Will this if be optimized out in release builds? – I'd prefer to see: ASSERT(!jsDynamicCast<JSActivation*>(currentVariableObject) || jsDynamicCast<JSActivation*>(currentVariableObject)->isValidScopedLookup(entry.getIndex())); 553701 3 oliver 2012-02-09 18:26:34 -0800 Committed r107338: <http://trac.webkit.org/changeset/107338> 554188 4 ggaren 2012-02-10 10:37:04 -0800 <rdar://problem/10734517> 126421 2012-02-09 18:16:22 -0800 2012-02-09 18:20:12 -0800 Patch bug-78308-20120209181620.patch text/plain 6092 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YmVmMjM2MjgwZTdkMDE5MGJmZjdlMjhlZmU5NjlmNDkyMmVlNzc5Li43YzVkZmU4MzVjNGY1ZDM4 ZTNmYzQ1NTY5ZTQ3OWJkMTZiYTIzMGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMi0wMi0wOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFRoZSBKUyBQYXJzZXIgc2NvcGUgb2JqZWN0IG5lZWRzIGEgVmVjdG9yVHJhaXQg c3BlY2lhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc4MzA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBzaG93ZWQgdXAgYXMgYSBwZXJpb2RpYyBjcmFzaCBpbiB2YXJpb3VzIGJpdHMg b2YgZ2VuZXJhdGVkIGNvZGUKKyAgICAgICAgb3JpZ2luYWxseSwgYnV0IEkndmUgYWRkZWQgYW4g YXNzZXJ0aW9uIGluIHRoZSBieXRlY29kZSBnZW5lcmF0b3IKKyAgICAgICAgdGhhdCBtYWtlcyB0 aGUgZWZmZWN0ZWQgY29kZSBtdWNoIG1vcmUgY3Jhc2gtaGFwcHkgc2hvdWxkIGl0IGdvCisgICAg ICAgIHdyb25nIGFnYWluLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJh dG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVjb2RlR2VuZXJh dG9yKToKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OnJlc29sdmUpOgorICAgICAg ICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAgICAqIHBhcnNlci9QYXJzZXIuaDoKKyAgICAg ICAgKEpTQyk6CisgICAgICAgICogcnVudGltZS9KU0FjdGl2YXRpb24uaDoKKyAgICAgICAgKEpT Qzo6SlNBY3RpdmF0aW9uOjppc1ZhbGlkU2NvcGVkTG9va3VwKToKKyAgICAgICAgKEpTQWN0aXZh dGlvbik6CisKIDIwMTItMDItMDggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBXaG9vcHMsIGZpeCB0aGUgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCmluZGV4IDQzN2Rk NTNiMDdmNmIxZDlhN2U4OTYwN2VhYTE4OGUxNGU0NDI1MjAuLjE5NGRhM2I0YzEyYjM1ZGY5YTVh YmNlOWZlYzQ5ZjJhZWY4Y2I3YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCkBAIC0zMiw2ICszMiw3IEBA CiAjaW5jbHVkZSAiQnl0ZWNvZGVHZW5lcmF0b3IuaCIKIAogI2luY2x1ZGUgIkJhdGNoZWRUcmFu c2l0aW9uT3B0aW1pemVyLmgiCisjaW5jbHVkZSAiSlNBY3RpdmF0aW9uLmgiCiAjaW5jbHVkZSAi SlNGdW5jdGlvbi5oIgogI2luY2x1ZGUgIkludGVycHJldGVyLmgiCiAjaW5jbHVkZSAiU2NvcGVD aGFpbi5oIgpAQCAtNDE0LDYgKzQxNSwyMiBAQCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVH ZW5lcmF0b3IoRnVuY3Rpb25Cb2R5Tm9kZSogZnVuY3Rpb25Cb2R5LCBTY29wZUNoYWluTgogICAg ICAgICAgICAgYWRkVmFyKGlkZW50LCB2YXJTdGFja1tpXS5zZWNvbmQgJiBEZWNsYXJhdGlvblN0 YWNrczo6SXNDb25zdGFudCk7CiAgICAgfQogICAgIAorICAgIGlmICgxKSB7CisgICAgICAgIGlm IChmdW5jdGlvbkJvZHktPmhhc0NhcHR1cmVkVmFyaWFibGVzKCkpIHsKKyAgICAgICAgICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgZnVuY3Rpb25TdGFjay5zaXplKCk7ICsraSkgeworICAgICAg ICAgICAgICAgIEZ1bmN0aW9uQm9keU5vZGUqIGZ1bmN0aW9uID0gZnVuY3Rpb25TdGFja1tpXTsK KyAgICAgICAgICAgICAgICBjb25zdCBJZGVudGlmaWVyJiBpZGVudCA9IGZ1bmN0aW9uLT5pZGVu dCgpOworICAgICAgICAgICAgICAgIGlmIChmdW5jdGlvbkJvZHktPmNhcHR1cmVzKGlkZW50KSkK KyAgICAgICAgICAgICAgICAgICAgQVNTRVJUKG1fc3ltYm9sVGFibGUtPmdldChpZGVudC5pbXBs KCkpLmdldEluZGV4KCkgPCBjb2RlQmxvY2stPm1fbnVtQ2FwdHVyZWRWYXJzKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdmFyU3RhY2suc2l6ZSgp OyArK2kpIHsKKyAgICAgICAgICAgICAgICBjb25zdCBJZGVudGlmaWVyJiBpZGVudCA9ICp2YXJT dGFja1tpXS5maXJzdDsKKyAgICAgICAgICAgICAgICBpZiAoZnVuY3Rpb25Cb2R5LT5jYXB0dXJl cyhpZGVudCkpCisgICAgICAgICAgICAgICAgICAgIEFTU0VSVChtX3N5bWJvbFRhYmxlLT5nZXQo aWRlbnQuaW1wbCgpKS5nZXRJbmRleCgpIDwgY29kZUJsb2NrLT5tX251bUNhcHR1cmVkVmFycyk7 CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisgICAgCiAgICAgaWYgKG1fc2hvdWxk RW1pdERlYnVnSG9va3MpCiAgICAgICAgIGNvZGVCbG9jay0+bV9udW1DYXB0dXJlZFZhcnMgPSBj b2RlQmxvY2stPm1fbnVtVmFyczsKIApAQCAtMTIwNyw2ICsxMjI0LDkgQEAgUmVzb2x2ZVJlc3Vs dCBCeXRlY29kZUdlbmVyYXRvcjo6cmVzb2x2ZShjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eSkK ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFJlc29sdmVSZXN1bHQ6OmR5bmFtaWNJbmRleGVk R2xvYmFsUmVzb2x2ZShlbnRyeS5nZXRJbmRleCgpLCBkZXB0aCwgY3VycmVudFNjb3BlLCBmbGFn cyk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIFJlc29sdmVSZXN1bHQ6OmluZGV4ZWRHbG9iYWxS ZXNvbHZlKGVudHJ5LmdldEluZGV4KCksIGN1cnJlbnRTY29wZSwgZmxhZ3MpOwogICAgICAgICAg ICAgfQorICAgICAgICAgICAgaWYgKEpTQWN0aXZhdGlvbiogYWN0aXZhdGlvbiA9IGpzRHluYW1p Y0Nhc3Q8SlNBY3RpdmF0aW9uKj4oY3VycmVudFZhcmlhYmxlT2JqZWN0KSkKKyAgICAgICAgICAg ICAgICBBU1NFUlQoYWN0aXZhdGlvbi0+aXNWYWxpZFNjb3BlZExvb2t1cChlbnRyeS5nZXRJbmRl eCgpKSk7CisKICAgICAgICAgICAgIHJldHVybiBSZXNvbHZlUmVzdWx0OjpsZXhpY2FsUmVzb2x2 ZShlbnRyeS5nZXRJbmRleCgpLCBkZXB0aCwgZmxhZ3MpOwogICAgICAgICB9CiAgICAgICAgIGJv b2wgc2NvcGVSZXF1aXJlc0R5bmFtaWNDaGVja3MgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCAyNWFkYTU2MDY3ZWFkM2FjYTgwNzdjOGQzMzE5OTUw OWVmYzgzYWI0Li41OGU5ZTE5NzU0NjQzMzZmYjE0YzY5MTIyODczZDA5NGRlM2JiYzNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC0xLDcgKzEsNyBAQAogLyoK ICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMSBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3Jn KQogICogIENvcHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICog IENvcHlyaWdodCAoQykgMjAwMywgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCisgKiAgQ29weXJpZ2h0IChDKSAyMDAzLCAyMDA2LCAyMDA3LCAy MDA4LCAyMDA5LCAyMDEwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiAg VGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFu ZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl bmVyYWwgUHVibGljCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1Bh cnNlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuaAppbmRleCBmM2Q5 NmZmM2VjOWUyY2U3YTcxMjdiYTgyZjRjOWM2MjRmYzA2NGM5Li5lM2U2ZTFlMjMwMDk2MjkxZDJk ZDUxMjZjZjM4ZmFjOWRiZTBmZjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL1BhcnNlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2Vy LmgKQEAgLTEsNyArMSw3IEBACiAvKgogICogIENvcHlyaWdodCAoQykgMTk5OS0yMDAxIEhhcnJp IFBvcnRlbiAocG9ydGVuQGtkZS5vcmcpCiAgKiAgQ29weXJpZ2h0IChDKSAyMDAxIFBldGVyIEtl bGx5IChwbWtAcG9zdC5jb20pCi0gKiAgQ29weXJpZ2h0IChDKSAyMDAzLCAyMDA2LCAyMDA3LCAy MDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQg KEMpIDIwMDMsIDIwMDYsIDIwMDcsIDIwMDgsIDIwMDksIDIwMTAsIDIwMTEgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2Fy ZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRo ZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTM3LDYgKzM3LDE1 IEBACiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5o PgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KK25hbWVzcGFjZSBKU0Mgeworc3RydWN0IFNjb3Bl OworfQorCituYW1lc3BhY2UgV1RGIHsKK3RlbXBsYXRlIDw+IHN0cnVjdCBWZWN0b3JUcmFpdHM8 SlNDOjpTY29wZT4gOiBTaW1wbGVDbGFzc1ZlY3RvclRyYWl0cyB7CisgICAgc3RhdGljIGNvbnN0 IGJvb2wgY2FuSW5pdGlhbGl6ZVdpdGhNZW1zZXQgPSBmYWxzZTsgLy8gTm90IGFsbCBTY29wZSBk YXRhIG1lbWJlcnMgaW5pdGlhbGl6ZSB0byAwLgorfTsKK30KIAogbmFtZXNwYWNlIEpTQyB7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmgKaW5kZXggYzE4 NDkyMzQ0NjA1ODQxODBmYjQyYTdlMjRkZDFlN2IzOTFhZDU5My4uODBjOGFhOGQwMDY2OTcyZWNi YWQ5MjUzZTU5NzkwMWFhMTZlNzVkNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNBY3RpdmF0aW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNBY3RpdmF0aW9uLmgKQEAgLTc1LDYgKzc1LDggQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAg ICAgICAgc3RhdGljIFN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKEpTR2xvYmFsRGF0YSYgZ2xv YmFsRGF0YSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSBwcm90bykgeyBy ZXR1cm4gU3RydWN0dXJlOjpjcmVhdGUoZ2xvYmFsRGF0YSwgZ2xvYmFsT2JqZWN0LCBwcm90bywg VHlwZUluZm8oQWN0aXZhdGlvbk9iamVjdFR5cGUsIFN0cnVjdHVyZUZsYWdzKSwgJnNfaW5mbyk7 IH0KIAorICAgICAgICBib29sIGlzVmFsaWRTY29wZWRMb29rdXAoaW50IGluZGV4KSB7IHJldHVy biBpbmRleCA8IG1fbnVtQ2FwdHVyZWRWYXJzOyB9CisKICAgICBwcm90ZWN0ZWQ6CiAgICAgICAg IHZvaWQgZmluaXNoQ3JlYXRpb24oQ2FsbEZyYW1lKik7CiAgICAgICAgIHN0YXRpYyBjb25zdCB1 bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IElzRW52aXJvbm1lbnRSZWNvcmQgfCBPdmVycmlkZXNH ZXRPd25Qcm9wZXJ0eVNsb3QgfCBPdmVycmlkZXNWaXNpdENoaWxkcmVuIHwgT3ZlcnJpZGVzR2V0 UHJvcGVydHlOYW1lcyB8IEpTVmFyaWFibGVPYmplY3Q6OlN0cnVjdHVyZUZsYWdzOwo=