78304 2012-02-09 17:54:48 -0800 Web Inspector: Prevent attaching when inspecting the Web Inspector 2012-02-09 22:24:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 553656 0 timothy 2012-02-09 17:54:48 -0800 We should prevent attaching when inspecting the Web Inspector. It is confusing and fails bad in WebKit2. 553660 1 126414 timothy 2012-02-09 17:58:56 -0800 Created attachment 126414 Proposed Change 553718 2 126414 bweinstein 2012-02-09 18:52:29 -0800 Comment on attachment 126414 Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 > + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight. 553719 3 126414 timothy 2012-02-09 18:54:25 -0800 Comment on attachment 126414 Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review >> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 >> + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; > > Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight. IIRC, we can't use "static float" in class headers on Windows, so that is why we never did that. 553842 4 126414 webkit.review.bot 2012-02-09 22:24:05 -0800 Comment on attachment 126414 Proposed Change Clearing flags on attachment: 126414 Committed r107362: <http://trac.webkit.org/changeset/107362> 553843 5 webkit.review.bot 2012-02-09 22:24:10 -0800 All reviewed patches have been landed. Closing bug. 126414 2012-02-09 17:58:56 -0800 2012-02-09 22:24:05 -0800 Proposed Change 0001-Prevent-attaching-when-inspecting-the-Web-Inspector.patch text/plain 6552 timothy RnJvbSBkMDQ3ZDllYTdmOGI0ZmIwZGNmYjkwYjUwYWZmYTgxMjcwMTA4OThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDkgRmViIDIwMTIgMTc6NTU6MjYgLTA4MDAKU3ViamVjdDogW1BBVENIXSBQcmV2 ZW50IGF0dGFjaGluZyB3aGVuIGluc3BlY3RpbmcgdGhlIFdlYiBJbnNwZWN0b3IuCgpTb3VyY2Uv V2ViQ29yZToKCmh0dHBzOi8vd2Via2l0Lm9yZy9iLzc4MzA0CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwOgoo V2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6Y2FuQXR0YWNoV2luZG93KTog UHJldmVudCBhdHRhY2hpbmcgd2hlbiB0aGUgcGFnZSBpcyBhbiBpbnNwZWN0b3IgcGFnZS4KClNv dXJjZS9XZWJLaXQyOgoKQWxzbyBhZGRzIHNvbWUgY29tbWVudHMgYWJvdXQga2VlcGluZyBpbiBz eW5jIHdpdGggSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6Y2FuQXR0YWNoV2luZG93CmFu ZCB3aHkgdGhlcmUgYXJlIHR3byBpbXBsZW1lbnRhdGlvbnMgb2YgdGhlIHNhbWUgZnVuY3Rpb24u CgpodHRwczovL3dlYmtpdC5vcmcvYi83ODMwNAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgoqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHA6CihXZWJLaXQ6OldlYkluc3BlY3Rv clByb3h5OjpjYW5BdHRhY2gpOiBQcmV2ZW50IGF0dGFjaGluZyB3aGVuIHRoZSBwYWdlIGlzIGFu IGluc3BlY3RvciBwYWdlLgpBZGRlZCBjb21tZW50cyBhYm91dCBJbnNwZWN0b3JGcm9udGVuZENs aWVudExvY2FsOjpjYW5BdHRhY2hXaW5kb3cuCiogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5 Lmg6CihXZWJJbnNwZWN0b3JQcm94eSk6IEFkZGVkIGNvbW1lbnQgYWJvdXQga2VlcGluZyBpbiBz eW5jIHdpdGggSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC4KLS0tCiBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysK IC4uLi9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAgICAgIHwgICAg OCArKysrKy0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViSW5zcGVjdG9yUHJveHkuY3BwICAgICB8ICAgMTMgKysrKysrKysrKystLQogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmggICAgICAgfCAgICAyICsrCiA1IGZp bGVzIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDkxODU0NjcuLmQxYTAzMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0w Mi0wOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgUHJl dmVudCBhdHRhY2hpbmcgd2hlbiBpbnNwZWN0aW5nIHRoZSBXZWIgSW5zcGVjdG9yLgorCisgICAg ICAgIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzc4MzA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGll bnRMb2NhbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZENsaWVudExv Y2FsOjpjYW5BdHRhY2hXaW5kb3cpOiBQcmV2ZW50IGF0dGFjaGluZyB3aGVuIHRoZSBwYWdlIGlz IGFuIGluc3BlY3RvciBwYWdlLgorCiAyMDEyLTAyLTA5ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW5hbWUgRE9NRWRpdG9y IHRvIERPTVBhdGNoU3VwcG9ydCwgbW92ZSB1bmRvYWJsZSBhY3Rpb25zIGZyb20KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2Fs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExv Y2FsLmNwcAppbmRleCAxMTdhZThiLi43YmZjZTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwCkBAIC0x NTksMTAgKzE1OSwxMiBAQCB2b2lkIEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OnJlcXVl c3REZXRhY2hXaW5kb3coKQogCiBib29sIEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OmNh bkF0dGFjaFdpbmRvdygpCiB7Ci0gICAgdW5zaWduZWQgaW5zcGVjdGVkUGFnZUhlaWdodCA9IG1f aW5zcGVjdG9yQ29udHJvbGxlci0+aW5zcGVjdGVkUGFnZSgpLT5tYWluRnJhbWUoKS0+dmlldygp LT52aXNpYmxlSGVpZ2h0KCk7Ci0KICAgICAvLyBEb24ndCBhbGxvdyB0aGUgYXR0YWNoIGlmIHRo ZSB3aW5kb3cgd291bGQgYmUgdG9vIHNtYWxsIHRvIGFjY29tbW9kYXRlIHRoZSBtaW5pbXVtIGlu c3BlY3RvciBoZWlnaHQuCi0gICAgcmV0dXJuIG1pbmltdW1BdHRhY2hlZEhlaWdodCA8PSBpbnNw ZWN0ZWRQYWdlSGVpZ2h0ICogbWF4aW11bUF0dGFjaGVkSGVpZ2h0UmF0aW87CisgICAgLy8gQWxz byBkb24ndCBhbGxvdyBhdHRhY2hpbmcgdG8gYW5vdGhlciBpbnNwZWN0b3IgLS0gdHdvIGluc3Bl Y3RvcnMgaW4gb25lIHdpbmRvdyBpcyB0b28gbXVjaCEKKyAgICBib29sIGlzSW5zcGVjdG9yUGFn ZSA9IG1faW5zcGVjdG9yQ29udHJvbGxlci0+aW5zcGVjdGVkUGFnZSgpLT5pbnNwZWN0b3JDb250 cm9sbGVyKCktPmhhc0luc3BlY3RvckZyb250ZW5kQ2xpZW50KCk7CisgICAgdW5zaWduZWQgaW5z cGVjdGVkUGFnZUhlaWdodCA9IG1faW5zcGVjdG9yQ29udHJvbGxlci0+aW5zcGVjdGVkUGFnZSgp LT5tYWluRnJhbWUoKS0+dmlldygpLT52aXNpYmxlSGVpZ2h0KCk7CisgICAgdW5zaWduZWQgbWF4 aW11bUF0dGFjaGVkSGVpZ2h0ID0gaW5zcGVjdGVkUGFnZUhlaWdodCAqIG1heGltdW1BdHRhY2hl ZEhlaWdodFJhdGlvOworICAgIHJldHVybiBtaW5pbXVtQXR0YWNoZWRIZWlnaHQgPD0gbWF4aW11 bUF0dGFjaGVkSGVpZ2h0ICYmICFpc0luc3BlY3RvclBhZ2U7CiB9CiAKIHZvaWQgSW5zcGVjdG9y RnJvbnRlbmRDbGllbnRMb2NhbDo6Y2hhbmdlQXR0YWNoZWRXaW5kb3dIZWlnaHQodW5zaWduZWQg aGVpZ2h0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCmluZGV4IGFhYjc3ZmIuLmUwOWQ0MDYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMi0wMi0wOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgUHJldmVudCBhdHRhY2hpbmcgd2hlbiBpbnNwZWN0aW5nIHRoZSBXZWIg SW5zcGVjdG9yLgorCisgICAgICAgIEFsc28gYWRkcyBzb21lIGNvbW1lbnRzIGFib3V0IGtlZXBp bmcgaW4gc3luYyB3aXRoIEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OmNhbkF0dGFjaFdp bmRvdworICAgICAgICBhbmQgd2h5IHRoZXJlIGFyZSB0d28gaW1wbGVtZW50YXRpb25zIG9mIHRo ZSBzYW1lIGZ1bmN0aW9uLgorCisgICAgICAgIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzc4MzA0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQ cm94eTo6Y2FuQXR0YWNoKTogUHJldmVudCBhdHRhY2hpbmcgd2hlbiB0aGUgcGFnZSBpcyBhbiBp bnNwZWN0b3IgcGFnZS4KKyAgICAgICAgQWRkZWQgY29tbWVudHMgYWJvdXQgSW5zcGVjdG9yRnJv bnRlbmRDbGllbnRMb2NhbDo6Y2FuQXR0YWNoV2luZG93LgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJJbnNwZWN0b3JQcm94eS5oOgorICAgICAgICAoV2ViSW5zcGVjdG9yUHJveHkpOiBBZGRlZCBj b21tZW50IGFib3V0IGtlZXBpbmcgaW4gc3luYyB3aXRoIEluc3BlY3RvckZyb250ZW5kQ2xpZW50 TG9jYWwuCisKIDIwMTItMDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBXZWJLaXRXZWJWaWV3Ojptb3VzZS10YXJnZXQt Y2hhbmdlZCBzaWduYWwgdG8gV2ViS2l0MiBHVEsrIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKaW5kZXggY2I1ZGY3OS4uMTQ4NzJmMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCkBAIC0y NjAsOCArMjYwLDE3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RlZFVSTENoYW5n ZWQoY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcpCiAKIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OmNh bkF0dGFjaCgpCiB7Ci0gICAgdW5zaWduZWQgaW5zcGVjdGVkV2luZG93SGVpZ2h0ID0gcGxhdGZv cm1JbnNwZWN0ZWRXaW5kb3dIZWlnaHQoKTsKLSAgICByZXR1cm4gaW5zcGVjdGVkV2luZG93SGVp Z2h0ICYmIG1pbmltdW1BdHRhY2hlZEhlaWdodCA8PSAoaW5zcGVjdGVkV2luZG93SGVpZ2h0ICog MyAvIDQpOworICAgIC8vIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggSW5zcGVjdG9yRnJvbnRlbmRD bGllbnRMb2NhbDo6Y2FuQXR0YWNoV2luZG93LiBUaGVyZSBhcmUgdHdvIGltcGxlbWVudGF0aW9u cworICAgIC8vIHRvIG1ha2UgbGlmZSBlYXNpZXIgaW4gdGhlIG11bHRpLXByb2Nlc3Mgd29ybGQg d2UgaGF2ZS4gV2ViSW5zcGVjdG9yUHJveHkgdXNlcyBjYW5BdHRhY2ggdG8gZGVjaWRlIGlmCisg ICAgLy8gd2UgY2FuIGF0dGFjaCBvbiBvcGVuIChvbiB0aGUgVUkgcHJvY2VzcyBzaWRlKS4gQW5k IEluc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OmNhbkF0dGFjaFdpbmRvdyBpcworICAgIC8v IHVzZWQgdG8gZGVjaWRlIGlmIHdlIGNhbiBhdHRhY2ggd2hlbiB0aGUgYXR0YWNoIGJ1dHRvbiBp cyBwcmVzc2VkIChvbiB0aGUgV2ViUHJvY2VzcyBzaWRlKS4KKworICAgIC8vIERvbid0IGFsbG93 IHRoZSBhdHRhY2ggaWYgdGhlIHdpbmRvdyB3b3VsZCBiZSB0b28gc21hbGwgdG8gYWNjb21tb2Rh dGUgdGhlIG1pbmltdW0gaW5zcGVjdG9yIGhlaWdodC4KKyAgICAvLyBBbHNvIGRvbid0IGFsbG93 IGF0dGFjaGluZyB0byBhbm90aGVyIGluc3BlY3RvciAtLSB0d28gaW5zcGVjdG9ycyBpbiBvbmUg d2luZG93IGlzIHRvbyBtdWNoIQorICAgIGJvb2wgaXNJbnNwZWN0b3JQYWdlID0gbV9wYWdlLT5w YWdlR3JvdXAoKSA9PSBpbnNwZWN0b3JQYWdlR3JvdXAoKTsKKyAgICB1bnNpZ25lZCBpbnNwZWN0 ZWRQYWdlSGVpZ2h0ID0gcGxhdGZvcm1JbnNwZWN0ZWRXaW5kb3dIZWlnaHQoKTsKKyAgICB1bnNp Z25lZCBtYXhpbXVtQXR0YWNoZWRIZWlnaHQgPSBpbnNwZWN0ZWRQYWdlSGVpZ2h0ICogMyAvIDQ7 CisgICAgcmV0dXJuIG1pbmltdW1BdHRhY2hlZEhlaWdodCA8PSBtYXhpbXVtQXR0YWNoZWRIZWln aHQgJiYgIWlzSW5zcGVjdG9yUGFnZTsKIH0KIAogYm9vbCBXZWJJbnNwZWN0b3JQcm94eTo6c2hv dWxkT3BlbkF0dGFjaGVkKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJJbnNwZWN0b3JQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3Rv clByb3h5LmgKaW5kZXggNTZkZjc4Yy4uMDY0NWFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmgKQEAgLTE2NCw2ICsxNjQsOCBAQCBwcml2YXRlOgog CiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGluaXRpYWxXaW5kb3dXaWR0aCA9IDc1MDsKICAg ICBzdGF0aWMgY29uc3QgdW5zaWduZWQgaW5pdGlhbFdpbmRvd0hlaWdodCA9IDY1MDsKKworICAg IC8vIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggdGhlIHZhbHVlIGluIEluc3BlY3RvckZyb250ZW5k Q2xpZW50TG9jYWwuCiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIG1pbmltdW1BdHRhY2hlZEhl aWdodCA9IDI1MDsKIAogICAgIFdlYlBhZ2VQcm94eSogbV9wYWdlOwotLSAKMS43LjUuNAoK