78302 2012-02-09 17:54:24 -0800 [ActiveDOMObject] attribute should be inherited 2013-01-30 00:47:14 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 107877 P2 Normal --- 1 haraken haraken abarth darin oldest_to_newest 553654 0 haraken 2012-02-09 17:54:24 -0800 If interface B inherits interface A and interface A has [ActiveDOMObject], then interface B should have [ActiveDOMObject]. 553673 1 abarth 2012-02-09 18:05:41 -0800 Isn't any case where we don't do this a bug because the wrappers get GCed too early? 553690 2 haraken 2012-02-09 18:16:24 -0800 I searched the code base and confirmed that DedicatedWorkerContext and SharedWorkerContext are the only interfaces that do not have [ActiveDOMObject] but inherit an interface with [ActiveDOMObject]. I agree that this would be a bug. Though I am not familiar with workers and have not yet written tests which causes the bug. 553696 3 abarth 2012-02-09 18:21:04 -0800 It might be hard to write such a test because code running in workers can only see one global object and any function would retain its global object by another means. 553698 4 haraken 2012-02-09 18:23:55 -0800 (In reply to comment #3) > It might be hard to write such a test because code running in workers can only see one global object and any function would retain its global object by another means. Thanks! Then is it OK to add [ActiveDOMObject] to DedicatedWorkerContext and SharedWorkerContext without tests? (After that patch is landed, I can work on IDL attribute inheritance if needed.) 553712 5 abarth 2012-02-09 18:41:41 -0800 Sounds like a good plan. 554041 6 haraken 2012-02-10 05:54:13 -0800 (In reply to comment #2) > I searched the code base and confirmed that DedicatedWorkerContext and SharedWorkerContext are the only interfaces that do not have [ActiveDOMObject] but inherit an interface with [ActiveDOMObject]. Correction: I confirmed that all interfaces which inherits an [ActiveDOMObject] interface has [ActiveDOMObject]. (Nit: "grep -r ': Worker' *" told me DedicatedWorkerContext and SharedWorkerContext, and I thought that they inherit Worker. But actually they inherit WorkerContext:-) 555684 7 darin 2012-02-13 15:40:49 -0800 The only reason we don’t do this already is that interface generation never involves reading the IDL of base classes. So mechanically there is no straightforward way to do inheritance. The concept of inheriting automatically seems fine. The real issue is just the mechanics of how we’d compile IDLs to accomplish this. I think it would be even better to not need [ActiveDOMObject] at all; maybe there’s a compile time trick we can do with templates or something like that to automatically figure out if the implementation class derives from ActiveDOMObject. 819895 8 haraken 2013-01-30 00:47:14 -0800 *** This bug has been marked as a duplicate of bug 107877 ***