78291 2012-02-09 15:29:25 -0800 FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly 2012-02-09 17:55:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 553568 0 andersca 2012-02-09 15:29:25 -0800 FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly 553569 1 126388 andersca 2012-02-09 15:32:03 -0800 Created attachment 126388 Patch 553573 2 126388 mitz 2012-02-09 15:38:38 -0800 Comment on attachment 126388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126388&action=review > Source/WebCore/page/FrameView.cpp:1332 > m_slowRepaintObjectCount++; > + if (m_slowRepaintObjectCount == 1) This is one case where I think collapsing this into a single line would have made things clearer: if (!m_slowRepaintObjectCount++) 553658 3 andersca 2012-02-09 17:55:00 -0800 Committed r107332: <http://trac.webkit.org/changeset/107332> 126388 2012-02-09 15:32:03 -0800 2012-02-09 15:38:38 -0800 Patch bug-78291-20120209153238.patch text/plain 1798 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmU5MTNlYzg2NGY1Njhh NDlmOTA3MDZlNTY5Zjc3ZjI5NjI0YWQ4Ny4uZGFhNTBhMTUzYjYwMTE0ZGMyMzY0N2MwNzA0ZWY3 NWQyZTdlNTk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTAyLTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRnJhbWVWaWV3Ojph ZGRTbG93UmVwYWludE9iamVjdCgpIGRvZXNuJ3QgdXBkYXRlIG1fY2FuQmxpdE9uU2Nyb2xsIGNv cnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzgyOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBt X3Nsb3dSZXBhaW50T2JqZWN0Q291bnQgbmVlZHMgdG8gYmUgaW5jcmVtZW50ZWQgYmVmb3JlIGNh bGxpbmcgdXBkYXRlQ2FuQmxpdE9uU2Nyb2xsUmVjdXJzaXZlbHkoKSwKKyAgICAgICAgYmVjYXVz ZSBvdGhlcndpc2UgdXNlU2xvd1JlcGFpbnRzKCkgd2lsbCByZXR1cm4gZmFsc2UgZXZlbiB0aG91 Z2ggd2UgaGF2ZSB0byB1c2Ugc2xvdyByZXBhaW50cy4KKworICAgICAgICBJIHdhcyB1bmFibGUg dG8gbWFrZSBhIGxheW91dCB0ZXN0IGZvciB0aGlzIGJlY2F1c2UgaXQgcmVxdWlyZXMgdGhhdCB1 cGRhdGVDYW5CbGl0T25TY3JvbGxSZWN1cnNpdmVseSgpIGlzbid0CisgICAgICAgIGNhbGxlZCBh Z2FpbiBhZnRlciBtX3Nsb3dSZXBhaW50T2JqZWN0Q291bnQgaGFzIGJlZW4gaW5jcmVtZW50ZWQu CisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFt ZVZpZXc6OmFkZFNsb3dSZXBhaW50T2JqZWN0KToKKworMjAxMi0wMi0wOSAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFNjcm9sbGluZ1RyZWVOb2RlTWFj IHNob3VsZCBpbXBsZW1lbnQgU2Nyb2xsRWxhc3RpY2l0eUNvbnRyb2xsZXIKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4Mjc3CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcAppbmRleCBlODE2Y2EwMTU3NWFiNDE0MDkwYjU0MjE3NTMwNWM0OWE0YjFi MWJjLi44ZWUyMjQ0NDRhOTIyN2E0NTk5MzU5NDZiMDA0ZDk1YmRlNWI4ZjVkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xMzI4LDkgKzEzMjgsOSBAQCB2b2lkIEZyYW1lVmlldzo6 c2V0Q2Fubm90QmxpdFRvV2luZG93KCkKIAogdm9pZCBGcmFtZVZpZXc6OmFkZFNsb3dSZXBhaW50 T2JqZWN0KCkKIHsKLSAgICBpZiAoIW1fc2xvd1JlcGFpbnRPYmplY3RDb3VudCkKLSAgICAgICAg dXBkYXRlQ2FuQmxpdE9uU2Nyb2xsUmVjdXJzaXZlbHkoKTsKICAgICBtX3Nsb3dSZXBhaW50T2Jq ZWN0Q291bnQrKzsKKyAgICBpZiAobV9zbG93UmVwYWludE9iamVjdENvdW50ID09IDEpCisgICAg ICAgIHVwZGF0ZUNhbkJsaXRPblNjcm9sbFJlY3Vyc2l2ZWx5KCk7CiB9CiAKIHZvaWQgRnJhbWVW aWV3OjpyZW1vdmVTbG93UmVwYWludE9iamVjdCgpCg==