78284 2012-02-09 14:40:09 -0800 Make WebGLRenderingContext::printWarningToConsole safer 2012-02-09 21:59:13 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gman webkit-unassigned kbr webkit.review.bot oldest_to_newest 553516 0 gman 2012-02-09 14:40:09 -0800 Make WebGLRenderingContext::printWarningToConsole safer 553517 1 126375 gman 2012-02-09 14:41:00 -0800 Created attachment 126375 Patch 553518 2 gman 2012-02-09 14:41:51 -0800 apparently some of these can go NULL causing a crash so I added checks. 553520 3 126375 kbr 2012-02-09 14:43:57 -0800 Comment on attachment 126375 Patch Looks good. 553820 4 126375 webkit.review.bot 2012-02-09 21:59:09 -0800 Comment on attachment 126375 Patch Clearing flags on attachment: 126375 Committed r107358: <http://trac.webkit.org/changeset/107358> 553821 5 webkit.review.bot 2012-02-09 21:59:13 -0800 All reviewed patches have been landed. Closing bug. 126375 2012-02-09 14:41:00 -0800 2012-02-09 21:59:09 -0800 Patch bug-78284-20120209144059.patch text/plain 2072 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY3M2YyNTdmNjIwNjMw MGI1MjUzZTJkNjI2ODExYzlhZmIxNTNjYS4uYjVjMTlkY2NlNmZmMTIxYWM2YzgwOTQ2MGM4ODA2 MGQzZTM0ZGNlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA5ICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIE1ha2UgV2ViR0xSZW5kZXJp bmdDb250ZXh0OjpwcmludFdhcm5pbmdUb0NvbnNvbGUgc2FmZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc4Mjg0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugbm8gY2hh bmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRl cmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpX ZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnByaW50V2FybmluZ1RvQ29uc29sZSk6CisKIDIwMTItMDIt MDkgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODI1NgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggOWE1YTI5NWI1 MmI5ZmY5MjcwNTIyNzI4MDVjZDY5OWJkYmY5YjI0ZC4uYmQ2YjUwODU4NjhlNDM1OWE4ODM0YmYz MWYzMTk4MTQxOWYxMWNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC00ODkwLDcgKzQ4OTAsMjEgQEAgYm9vbCBX ZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZhbGlkYXRlU3RlbmNpbEZ1bmMoY29uc3QgY2hhciogZnVu Y3Rpb25OYW1lLCBHQzNEZW4KIAogdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnByaW50V2Fy bmluZ1RvQ29uc29sZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiB7Ci0gICAgY2FudmFzKCktPmRv Y3VtZW50KCktPmZyYW1lKCktPmRvbVdpbmRvdygpLT5jb25zb2xlKCktPmFkZE1lc3NhZ2UoSFRN TE1lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBXYXJuaW5nTWVzc2FnZUxldmVsLCBtZXNz YWdlLCBjYW52YXMoKS0+ZG9jdW1lbnQoKS0+dXJsKCkuc3RyaW5nKCkpOworICAgIGlmICghY2Fu dmFzKCkpCisgICAgICAgIHJldHVybjsKKyAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBjYW52YXMo KS0+ZG9jdW1lbnQoKTsKKyAgICBpZiAoIWRvY3VtZW50KQorICAgICAgICByZXR1cm47CisgICAg RnJhbWUqIGZyYW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAg ICAgcmV0dXJuOworICAgIERPTVdpbmRvdyogd2luZG93ID0gZnJhbWUtPmRvbVdpbmRvdygpOwor ICAgIGlmICghd2luZG93KQorICAgICAgICByZXR1cm47CisgICAgQ29uc29sZSogY29uc29sZSA9 IHdpbmRvdy0+Y29uc29sZSgpOworICAgIGlmICghY29uc29sZSkKKyAgICAgICAgcmV0dXJuOwor ICAgIGNvbnNvbGUtPmFkZE1lc3NhZ2UoSFRNTE1lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBl LCBXYXJuaW5nTWVzc2FnZUxldmVsLCBtZXNzYWdlLCBkb2N1bWVudC0+dXJsKCkuc3RyaW5nKCkp OwogfQogCiBib29sIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6dmFsaWRhdGVGcmFtZWJ1ZmZlckZ1 bmNQYXJhbWV0ZXJzKGNvbnN0IGNoYXIqIGZ1bmN0aW9uTmFtZSwgR0MzRGVudW0gdGFyZ2V0LCBH QzNEZW51bSBhdHRhY2htZW50KQo=