78283 2012-02-09 14:21:41 -0800 some tests in webkitpy are being run three times 2012-02-09 15:21:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric levin ojan rniwa tony oldest_to_newest 553500 0 dpranke 2012-02-09 14:21:41 -0800 some tests in webkitpy are being run three times 553502 1 126371 dpranke 2012-02-09 14:23:20 -0800 Created attachment 126371 Patch 553505 2 dpranke 2012-02-09 14:25:08 -0800 people who often write unittests in python ... fyi. 553506 3 126371 abarth 2012-02-09 14:28:15 -0800 Comment on attachment 126371 Patch Good to know! 553510 4 dpranke 2012-02-09 14:33:26 -0800 Committed r107293: <http://trac.webkit.org/changeset/107293> 553526 5 126371 eric 2012-02-09 14:49:17 -0800 Comment on attachment 126371 Patch Why are we even importing these into other unittests in the first place... How did you find these? I assume by using the -v output? How much faster did this make test-webkitpy? :)) 553560 6 dpranke 2012-02-09 15:21:23 -0800 (In reply to comment #5) > (From update of attachment 126371 [details]) > Why are we even importing these into other unittests in the first place... > > How did you find these? I assume by using the -v output? > -v plus debugging a script I wrote that buckets the test times ... > How much faster did this make test-webkitpy? :)) Not much, maybe a second. For more details on test speed, see bug 78289, where I summarize what I've dug up recently in service of whether or not parallel testing would be worthwhile. 126371 2012-02-09 14:23:20 -0800 2012-02-09 14:49:17 -0800 Patch bug-78283-20120209142319.patch text/plain 3710 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3Mjg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjBiZDI2NjUxMTQwOGI2NTIzN2M2MmY0ODQwZmVlZjFh ZTllZDgwZC4uM2U4OGJkMWY3NTRlYTFiNDU5ZTU5OGVmYjVmOTJlZmEzMjFkNzYzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTAyLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHNvbWUgdGVzdHMgaW4gd2Via2l0cHkgYXJlIGJlaW5nIHJ1biB0aHJlZSB0aW1lcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgyODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB0dXJucyBv dXQgdGhhdCBpZiB5b3UgaW1wb3J0IGEgY2xhc3MgZGVyaXZlZCBmcm9tCisgICAgICAgIHVuaXR0 ZXN0LlRlc3RDYXNlIGFzIGEgYmFzZSBuYW1lIChlLmcuLCBmcm9tIC4uLiBpbXBvcnQgQ2hhbmdl TG9nVGVzdCksCisgICAgICAgIHRoZSB1bml0dGVzdCBmcmFtZXdvcmsgdHJlYXRzIGl0IGFzIGlm IHRoZSBjbGFzcyB3YXMgZGVmaW5lZCBpbgorICAgICAgICB0aGUgZmlsZSAoYXMgd2VsbCBpbiB0 aGUgb3JpZ2luYWwgZmlsZSkuIFRoaXMgbGVkIHVzIHRvIHJ1bm5pbmcKKyAgICAgICAgdGhlIHRl c3RzIGluIENoYW5nZUxvZ1Rlc3QgdGhyZWUgdGltZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc3RlcHMvcHJlcGFyZWNoYW5nZWxvZ191bml0dGVzdC5weToKKyAgICAgICAg KFByZXBhcmVDaGFuZ2VMb2dUZXN0KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvcHJlcGFyZWNoYW5nZWxvZ2ZvcnJldmVydF91bml0dGVzdC5weToKKyAgICAgICAgKF9h c3NlcnRfbWVzc2FnZV9mb3JfcmV2ZXJ0X291dHB1dCk6CisKIDIwMTItMDItMDkgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgZXh0cmFuZW91cyBsaW5l IGluIHByZXZpb3VzIHBhdGNoLiAgSSBmb3Jnb3QgdG8gcmVtb3ZlIHRoaXMKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wcmVwYXJlY2hhbmdlbG9nX3VuaXR0 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ByZXBhcmVjaGFuZ2Vs b2dfdW5pdHRlc3QucHkKaW5kZXggNzFhZTUxYWZkNTI1ZGFkNTJhYzNmOGU2ZDc3YTk0OGJhN2Qx NzFkNC4uMWY4YTgzOTgxM2M0N2Q2NGNjNjM2YzNlMjEzZTVkNjJhNmY1NzkwZSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ByZXBhcmVjaGFuZ2Vsb2dfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ByZXBhcmVj aGFuZ2Vsb2dfdW5pdHRlc3QucHkKQEAgLTI5LDEzICsyOSwxNSBAQAogaW1wb3J0IG9zCiBpbXBv cnQgdW5pdHRlc3QKIAotZnJvbSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuY2hhbmdlbG9nX3Vu aXR0ZXN0IGltcG9ydCBDaGFuZ2VMb2dUZXN0CisjIERvIG5vdCBpbXBvcnQgY2hhbmdlbG9nX3Vu aXR0ZXN0LkNoYW5nZUxvZ1Rlc3QgZGlyZWN0bHkgYXMgdGhhdCB3aWxsIGNhdXNlIGl0IHRvIGJl IHJ1biBhZ2Fpbi4KK2Zyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0IGltcG9ydCBjaGFuZ2Vs b2dfdW5pdHRlc3QKKwogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLm91dHB1dGNhcHR1cmUg aW1wb3J0IE91dHB1dENhcHR1cmUKIGZyb20gd2Via2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQg TW9ja09wdGlvbnMsIE1vY2tUb29sCiBmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMucHJlcGFyZWNo YW5nZWxvZyBpbXBvcnQgUHJlcGFyZUNoYW5nZUxvZwogCiAKLWNsYXNzIFByZXBhcmVDaGFuZ2VM b2dUZXN0KENoYW5nZUxvZ1Rlc3QpOgorY2xhc3MgUHJlcGFyZUNoYW5nZUxvZ1Rlc3QoY2hhbmdl bG9nX3VuaXR0ZXN0LkNoYW5nZUxvZ1Rlc3QpOgogICAgIGRlZiB0ZXN0X2Vuc3VyZV9idWdfdXJs KHNlbGYpOgogICAgICAgICBjYXB0dXJlID0gT3V0cHV0Q2FwdHVyZSgpCiAgICAgICAgIHN0ZXAg PSBQcmVwYXJlQ2hhbmdlTG9nKE1vY2tUb29sKCksIE1vY2tPcHRpb25zKCkpCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcHJlcGFyZWNoYW5nZWxvZ2ZvcnJl dmVydF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wcmVw YXJlY2hhbmdlbG9nZm9ycmV2ZXJ0X3VuaXR0ZXN0LnB5CmluZGV4IGI1ZjJkMWI0ZmM5MmE0MWFl MGU2NmU3ZjQ4NDk2M2ZhMTFkN2U5MGQuLjA3NmU2MDI1MjJlY2E3Y2MxNTM0N2M0ZmNjN2MwNDli MTU0ZmYzMDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9w cmVwYXJlY2hhbmdlbG9nZm9ycmV2ZXJ0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9zdGVwcy9wcmVwYXJlY2hhbmdlbG9nZm9ycmV2ZXJ0X3VuaXR0ZXN0LnB5 CkBAIC0zMSw4ICszMSwxMCBAQCBpbXBvcnQgb3MKIGltcG9ydCB0ZW1wZmlsZQogaW1wb3J0IHVu aXR0ZXN0CiAKKyMgRG8gbm90IGltcG9ydCBjaGFuZ2Vsb2dfdW5pdHRlc3QuQ2hhbmdlTG9nVGVz dCBkaXJlY3RseSBhcyB0aGF0IHdpbGwgY2F1c2UgaXQgdG8gYmUgcnVuIGFnYWluLgorZnJvbSB3 ZWJraXRweS5jb21tb24uY2hlY2tvdXQgaW1wb3J0IGNoYW5nZWxvZ191bml0dGVzdAorCiBmcm9t IHdlYmtpdHB5LmNvbW1vbi5jaGVja291dC5jaGFuZ2Vsb2cgaW1wb3J0IENoYW5nZUxvZwotZnJv bSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuY2hhbmdlbG9nX3VuaXR0ZXN0IGltcG9ydCBDaGFu Z2VMb2dUZXN0CiBmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMucHJlcGFyZWNoYW5nZWxvZ2ZvcnJl dmVydCBpbXBvcnQgKgogCiAKQEAgLTEwNyw3ICsxMDksNyBAQCBjbGFzcyBVcGRhdGVDaGFuZ2VM b2dzRm9yUmV2ZXJ0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAiIiIKIAogICAgIGRlZiBfYXNz ZXJ0X21lc3NhZ2VfZm9yX3JldmVydF9vdXRwdXQoc2VsZiwgYXJncywgZXhwZWN0ZWRfZW50cnkp OgotICAgICAgICBjaGFuZ2Vsb2dfY29udGVudHMgPSB1IiVzXG4lcyIgJSAoQ2hhbmdlTG9nVGVz dC5fbmV3X2VudHJ5X2JvaWxlcnBsYXRlLCBDaGFuZ2VMb2dUZXN0Ll9leGFtcGxlX2NoYW5nZWxv ZykKKyAgICAgICAgY2hhbmdlbG9nX2NvbnRlbnRzID0gdSIlc1xuJXMiICUgKGNoYW5nZWxvZ191 bml0dGVzdC5DaGFuZ2VMb2dUZXN0Ll9uZXdfZW50cnlfYm9pbGVycGxhdGUsIGNoYW5nZWxvZ191 bml0dGVzdC5DaGFuZ2VMb2dUZXN0Ll9leGFtcGxlX2NoYW5nZWxvZykKICAgICAgICAgY2hhbmdl bG9nX3BhdGggPSBzZWxmLl93cml0ZV90bXBfZmlsZV93aXRoX2NvbnRlbnRzKGNoYW5nZWxvZ19j b250ZW50cy5lbmNvZGUoInV0Zi04IikpCiAgICAgICAgIGNoYW5nZWxvZyA9IENoYW5nZUxvZyhj aGFuZ2Vsb2dfcGF0aCkKICAgICAgICAgY2hhbmdlbG9nLnVwZGF0ZV93aXRoX3VucmV2aWV3ZWRf bWVzc2FnZShQcmVwYXJlQ2hhbmdlTG9nRm9yUmV2ZXJ0Ll9tZXNzYWdlX2Zvcl9yZXZlcnQoKmFy Z3MpKQo=