78242 2012-02-09 08:05:14 -0800 Eliminate dead code in BytecodeGenerator::resolve() 2012-02-09 19:49:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough ggaren oliver webkit.review.bot oldest_to_newest 553181 0 wingo 2012-02-09 08:05:14 -0800 BytecodeGenerator::shouldOptimizeLocals() is only true for FunctionCode, and thus cannot be true for GlobalCode. This patch removes an impossible branch. 553183 1 126308 wingo 2012-02-09 08:07:53 -0800 Created attachment 126308 Patch 553758 2 126308 webkit.review.bot 2012-02-09 19:49:07 -0800 Comment on attachment 126308 Patch Clearing flags on attachment: 126308 Committed r107348: <http://trac.webkit.org/changeset/107348> 553759 3 webkit.review.bot 2012-02-09 19:49:11 -0800 All reviewed patches have been landed. Closing bug. 126308 2012-02-09 08:07:53 -0800 2012-02-09 19:49:07 -0800 Patch bug-78242-20120209170751.patch text/plain 2067 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MzFkNTg2MDhmYTE5NTE3ZDRlYTE2MDkxMTdkYzhlYmJiNDJiODZlLi5kY2VjM2RiYzczYWNjNDRl NzZiOWEwOGM2Yjg2M2NiOTYzYzI3ZjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMS0wMi0wOCAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CiAK KyAgICAgICAgRWxpbWluYXRlIGRlYWQgY29kZSBpbiBCeXRlY29kZUdlbmVyYXRvcjo6cmVzb2x2 ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODI0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVH ZW5lcmF0b3I6OnJlc29sdmUpOgorICAgICAgICBCeXRlY29kZUdlbmVyYXRvcjo6c2hvdWxkT3B0 aW1pemVMb2NhbHMoKSBpcyBvbmx5IHRydWUgZm9yCisgICAgICAgIEZ1bmN0aW9uQ29kZSwgYW5k IHRodXMgY2Fubm90IGJlIHRydWUgZm9yIEdsb2JhbENvZGUuCisKKzIwMTEtMDItMDggIEFuZHkg V2luZ28gIDx3aW5nb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFJlbW92ZSBCeXRlY29kZUdlbmVy YXRvcjo6aXNMb2NhbAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzgyNDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21w aWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv bXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAppbmRleCA0ODk5Zjk4ZTFkMDlkN2VhNGNiM2My Yzg0ODkyNWNlNjMyYjAxNmZlLi4zNmI0MGE2YWYyY2YzNTEwNjg1NjE2YjA0NjdjYTVkZjM1MmFh NTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVy L0J5dGVjb2RlR2VuZXJhdG9yLmNwcApAQCAtMTE2MSwxNSArMTE2MSw4IEBAIFJlc29sdmVSZXN1 bHQgQnl0ZWNvZGVHZW5lcmF0b3I6OnJlc29sdmUoY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHkp CiAgICAgfQogCiAgICAgLy8gQ2FzZXMgd2hlcmUgd2UgY2Fubm90IHN0YXRpY2FsbHkgb3B0aW1p emUgdGhlIGxvb2t1cC4KLSAgICBpZiAocHJvcGVydHkgPT0gcHJvcGVydHlOYW1lcygpLmFyZ3Vt ZW50cyB8fCAhY2FuT3B0aW1pemVOb25Mb2NhbHMoKSkgewotICAgICAgICBpZiAoc2hvdWxkT3B0 aW1pemVMb2NhbHMoKSAmJiBtX2NvZGVUeXBlID09IEdsb2JhbENvZGUpIHsKLSAgICAgICAgICAg IFNjb3BlQ2hhaW5JdGVyYXRvciBpdGVyID0gbV9zY29wZUNoYWluLT5iZWdpbigpOwotICAgICAg ICAgICAgSlNPYmplY3QqIGdsb2JhbE9iamVjdCA9IGl0ZXItPmdldCgpOwotICAgICAgICAgICAg QVNTRVJUKCgrK2l0ZXIpID09IG1fc2NvcGVDaGFpbi0+ZW5kKCkpOwotICAgICAgICAgICAgcmV0 dXJuIFJlc29sdmVSZXN1bHQ6Omdsb2JhbFJlc29sdmUoZ2xvYmFsT2JqZWN0KTsKLSAgICAgICAg fSBlbHNlCi0gICAgICAgICAgICByZXR1cm4gUmVzb2x2ZVJlc3VsdDo6ZHluYW1pY1Jlc29sdmUo MCk7Ci0gICAgfQorICAgIGlmIChwcm9wZXJ0eSA9PSBwcm9wZXJ0eU5hbWVzKCkuYXJndW1lbnRz IHx8ICFjYW5PcHRpbWl6ZU5vbkxvY2FscygpKQorICAgICAgICByZXR1cm4gUmVzb2x2ZVJlc3Vs dDo6ZHluYW1pY1Jlc29sdmUoMCk7CiAKICAgICBTY29wZUNoYWluSXRlcmF0b3IgaXRlciA9IG1f c2NvcGVDaGFpbi0+YmVnaW4oKTsKICAgICBTY29wZUNoYWluSXRlcmF0b3IgZW5kID0gbV9zY29w ZUNoYWluLT5lbmQoKTsK