78241 2012-02-09 07:56:20 -0800 remove BytecodeGenerator::isLocal 2012-02-09 19:14:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough ggaren oliver webkit.review.bot oldest_to_newest 553172 0 wingo 2012-02-09 07:56:20 -0800 The patch to be attached is a small cleanup to BytecodeGenerator. 553176 1 126306 wingo 2012-02-09 07:59:05 -0800 Created attachment 126306 Patch 553178 2 wingo 2012-02-09 08:00:58 -0800 Adding some JSC folk for review. 553735 3 126306 webkit.review.bot 2012-02-09 19:14:51 -0800 Comment on attachment 126306 Patch Clearing flags on attachment: 126306 Committed r107345: <http://trac.webkit.org/changeset/107345> 553737 4 webkit.review.bot 2012-02-09 19:14:57 -0800 All reviewed patches have been landed. Closing bug. 126306 2012-02-09 07:59:05 -0800 2012-02-09 19:14:50 -0800 Patch bug-78241-20120209165903.patch text/plain 4116 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YmVmMjM2MjgwZTdkMDE5MGJmZjdlMjhlZmU5NjlmNDkyMmVlNzc5Li5iMzFkNTg2MDhmYTE5NTE3 ZDRlYTE2MDkxMTdkYzhlYmJiNDJiODZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxMS0wMi0wOCAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgUmVtb3ZlIEJ5dGVjb2RlR2VuZXJhdG9yOjppc0xvY2FsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODI0MQorCisgICAgICAgIE1pbm9y IHJlZmFjdG9yIHRvIEJ5dGVjb2RlR2VuZXJhdG9yLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y Lmg6CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcDoKKyAgICAg ICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmlzTG9jYWwpOgorICAgICAgICAoSlNDOjpCeXRl Y29kZUdlbmVyYXRvcjo6aXNMb2NhbENvbnN0YW50KTogUmVtb3ZlIG5vdy11bnVzZWQKKyAgICAg ICAgbWV0aG9kcy4KKyAgICAgICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcDoKKyAg ICAgICAgKEpTQzo6UmVzb2x2ZU5vZGU6OmlzUHVyZSk6IFVzZSB0aGUgUmVzb2x2ZVJlc3VsdCBt ZWNoYW5pc20KKyAgICAgICAgaW5zdGVhZCBvZiBpc0xvY2FsLiAgVGhpcyB3aWxsIHJlY29nbml6 ZSBtb3JlIHJlc29sdmUgbm9kZXMgYXMKKyAgICAgICAgYmVpbmcgcHVyZS4KKyAgICAgICAgKEpT Qzo6UHJlZml4UmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZSk6IFVzZSBpc1JlYWRPbmx5IG9uIHRo ZQorICAgICAgICBsb2NhdGlvbiBpbnN0ZWFkIG9mIGlzTG9jYWxDb25zdGFudC4KKwogMjAxMi0w Mi0wOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdob29wcywg Zml4IHRoZSBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t cGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggNDM3ZGQ1M2IwN2Y2YjFkOWE3ZTg5 NjA3ZWFhMTg4ZTE0ZTQ0MjUyMC4uNDg5OWY5OGUxZDA5ZDdlYTRjYjNjMmM4NDg5MjVjZTYzMmIw MTZmZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRl Y29kZUdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5jcHAKQEAgLTU2MCwxOSArNTYwLDYgQEAgUmVnaXN0ZXJJRCog Qnl0ZWNvZGVHZW5lcmF0b3I6OmNyZWF0ZUxhenlSZWdpc3RlcklmTmVjZXNzYXJ5KFJlZ2lzdGVy SUQqIHJlZykKICAgICByZXR1cm4gcmVnOwogfQogCi1ib29sIEJ5dGVjb2RlR2VuZXJhdG9yOjpp c0xvY2FsKGNvbnN0IElkZW50aWZpZXImIGlkZW50KQotewotICAgIGlmIChpZGVudCA9PSBwcm9w ZXJ0eU5hbWVzKCkudGhpc0lkZW50aWZpZXIpCi0gICAgICAgIHJldHVybiB0cnVlOwotICAgIAot ICAgIHJldHVybiBzaG91bGRPcHRpbWl6ZUxvY2FscygpICYmIHN5bWJvbFRhYmxlKCkuY29udGFp bnMoaWRlbnQuaW1wbCgpKTsKLX0KLQotYm9vbCBCeXRlY29kZUdlbmVyYXRvcjo6aXNMb2NhbENv bnN0YW50KGNvbnN0IElkZW50aWZpZXImIGlkZW50KQotewotICAgIHJldHVybiBzeW1ib2xUYWJs ZSgpLmdldChpZGVudC5pbXBsKCkpLmlzUmVhZE9ubHkoKTsKLX0KLQogUmVnaXN0ZXJJRCogQnl0 ZWNvZGVHZW5lcmF0b3I6Om5ld1JlZ2lzdGVyKCkKIHsKICAgICBtX2NhbGxlZVJlZ2lzdGVycy5h cHBlbmQobV9jYWxsZWVSZWdpc3RlcnMuc2l6ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAppbmRleCBjOWVjNWQ4 NTJjMTA4MzhlZDVjZjg1MzA1ZmNjYmVjY2VhZjg0NWM0Li5kNjFiNDJiNzZiZGRhOWQzMTE5Yjhk YjhhNzg5NTdhNWY5ZDY3YzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCkBAIC0yNjIsOSArMjYyLDYgQEAgbmFt ZXNwYWNlIEpTQyB7CiAgICAgICAgIC8vIFJldHVybnMgdGhlIHJlZ2lzdGVyIHN0b3JpbmcgInRo aXMiCiAgICAgICAgIFJlZ2lzdGVySUQqIHRoaXNSZWdpc3RlcigpIHsgcmV0dXJuICZtX3RoaXNS ZWdpc3RlcjsgfQogCi0gICAgICAgIGJvb2wgaXNMb2NhbChjb25zdCBJZGVudGlmaWVyJik7Ci0g ICAgICAgIGJvb2wgaXNMb2NhbENvbnN0YW50KGNvbnN0IElkZW50aWZpZXImKTsKLQogICAgICAg ICAvLyBSZXR1cm5zIHRoZSBuZXh0IGF2YWlsYWJsZSB0ZW1wb3JhcnkgcmVnaXN0ZXIuIFJlZ2lz dGVycyByZXR1cm5lZCBieQogICAgICAgICAvLyBuZXdUZW1wb3JhcnkgcmVxdWlyZSBhIG1vZGlm aWVkIGZvcm0gb2YgcmVmZXJlbmNlIGNvdW50aW5nOiBhbnkKICAgICAgICAgLy8gcmVnaXN0ZXIg d2l0aCBhIHJlZmNvdW50IG9mIDAgaXMgY29uc2lkZXJlZCAiYXZhaWxhYmxlIiwgbWVhbmluZyB0 aGF0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVz Q29kZWdlbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29k ZWdlbi5jcHAKaW5kZXggNDZlYzY5OGRlZTg1Zjc5ZGFjOGQxMGY4YWM0MTcxNmIyNzg3YWRjMy4u Y2UyY2FiY2E2ODE5YWY3Y2IzZWZlZmM0ZWUwZTYyZTJlMDgxN2MyNyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcApAQCAtMTQy LDcgKzE0Miw3IEBAIFJlZ2lzdGVySUQqIFRoaXNOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVH ZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCogZHN0CiAKIGJvb2wgUmVzb2x2ZU5vZGU6 OmlzUHVyZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yKSBjb25zdAogewotICAgIHJldHVy biBnZW5lcmF0b3IuaXNMb2NhbChtX2lkZW50KTsKKyAgICByZXR1cm4gZ2VuZXJhdG9yLnJlc29s dmUobV9pZGVudCkuaXNTdGF0aWMoKTsKIH0KIAogUmVnaXN0ZXJJRCogUmVzb2x2ZU5vZGU6OmVt aXRCeXRlY29kZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpc3RlcklEKiBkc3Qp CkBAIC03OTIsNyArNzkyLDcgQEAgUmVnaXN0ZXJJRCogUHJlZml4UmVzb2x2ZU5vZGU6OmVtaXRC eXRlY29kZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpc3QKIHsKICAgICBSZXNv bHZlUmVzdWx0IHJlc29sdmVSZXN1bHQgPSBnZW5lcmF0b3IucmVzb2x2ZShtX2lkZW50KTsKICAg ICBpZiAoUmVnaXN0ZXJJRCogbG9jYWwgPSByZXNvbHZlUmVzdWx0LmxvY2FsKCkpIHsKLSAgICAg ICAgaWYgKGdlbmVyYXRvci5pc0xvY2FsQ29uc3RhbnQobV9pZGVudCkpIHsKKyAgICAgICAgaWYg KHJlc29sdmVSZXN1bHQuaXNSZWFkT25seSgpKSB7CiAgICAgICAgICAgICBpZiAoZHN0ID09IGdl bmVyYXRvci5pZ25vcmVkUmVzdWx0KCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAg ICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gcjAgPSBnZW5lcmF0b3IuZW1pdExvYWQoZ2VuZXJh dG9yLmZpbmFsRGVzdGluYXRpb24oZHN0KSwgKG1fb3BlcmF0b3IgPT0gT3BQbHVzUGx1cykgPyAx LjAgOiAtMS4wKTsK