78236 2012-02-09 07:19:26 -0800 Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console 2012-02-10 07:42:02 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 553143 0 apavlov 2012-02-09 07:19:26 -0800 Patch to follow. Upstreaming http://code.google.com/p/chromium/issues/detail?id=112283 553159 1 126302 apavlov 2012-02-09 07:45:03 -0800 Created attachment 126302 Patch 554069 2 126302 vsevik 2012-02-10 07:25:54 -0800 Comment on attachment 126302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126302&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:445 > + } Please extract this method. > Source/WebCore/inspector/front-end/TextPrompt.js:516 > + if (!this.autoCompleteElement || !this._commonPrefix || !this._userEnteredText || this._userEnteredText.length >= this._commonPrefix.length) We'd better check that user entered text is prefix of common prefix. 554072 3 apavlov 2012-02-10 07:42:02 -0800 Committed r107402: <http://trac.webkit.org/changeset/107402> 126302 2012-02-09 07:45:03 -0800 2012-02-10 07:25:54 -0800 Patch bug-78236-20120209194501.patch text/plain 4150 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzBjOThhMTYyMWIwMDNh OTk5NmI0ODE4ZWVlZjVlMmJkZDMzYTNiYy4uZjA2OWFiYzgyNjNjMTNkYjUxM2M4NDRhNmUwMTVl OGVlN2RkMzNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA5ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW1RleHRQcm9tcHRdIFRBQiBzaG91bGQgY29tcGxldGUgc3VnZ2VzdGlvbnMgdXAgdG8g dGhlaXIgY29tbW9uIHByZWZpeCBpbiBDb25zb2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0Lmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlLl9jb21wbGV0aW9u c1JlYWR5KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5fY29t cGxldGVDb21tb25QcmVmaXgpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJv dG90eXBlLmFjY2VwdFN1Z2dlc3Rpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9t cHQucHJvdG90eXBlLnRhYktleVByZXNzZWQpOgorCiAyMDEyLTAyLTA5ICBBbGV4ZWkgRmlsaXBw b3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93 IHBlcmNlbnRhZ2UgYnkgZGVmYXVsdCBpbiBoZWFwIHByb2ZpbGVyLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCmluZGV4IDJjNDc5ZDgxZjk5 ZTBkMzk2OTNmMTA2ODQ5YWIwMGQ0MTZhM2E0MGIuLjY0NzdhZDlkNDM5MDNmNjQ4MDM3MDYzZDk2 OTZmMTkyNjE2OWZhM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGV4dFByb21wdC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RleHRQcm9tcHQuanMKQEAgLTQzMCw5ICs0MzAsMjIgQEAgV2ViSW5zcGVjdG9yLlRleHRQ cm9tcHQucHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciB3b3JkUHJlZml4TGVuZ3RoID0gb3Jp Z2luYWxXb3JkUHJlZml4UmFuZ2UudG9TdHJpbmcoKS5sZW5ndGg7CiAKLSAgICAgICAgaWYgKGF1 dG8pCisgICAgICAgIGlmIChhdXRvKSB7CiAgICAgICAgICAgICB2YXIgY29tcGxldGlvblRleHQg PSBjb21wbGV0aW9uc1swXTsKLSAgICAgICAgZWxzZSB7CisgICAgICAgICAgICB2YXIgY29tbW9u UHJlZml4ID0gY29tcGxldGlvbnNbMF07CisgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IGNvbXBsZXRpb25zLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIGNvbXBsZXRp b24gPSBjb21wbGV0aW9uc1tpXTsKKyAgICAgICAgICAgICAgICB2YXIgbGFzdEluZGV4ID0gTWF0 aC5taW4oY29tbW9uUHJlZml4Lmxlbmd0aCwgY29tcGxldGlvbi5sZW5ndGgpOworICAgICAgICAg ICAgICAgIGZvciAodmFyIGogPSB3b3JkUHJlZml4TGVuZ3RoOyBqIDwgbGFzdEluZGV4OyArK2op IHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGNvbW1vblByZWZpeFtqXSAhPT0gY29tcGxldGlv bltqXSkgeworICAgICAgICAgICAgICAgICAgICAgICAgY29tbW9uUHJlZml4ID0gY29tbW9uUHJl Zml4LnN1YnN0cigwLCBqKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorCisgICAg ICAgICAgICB0aGlzLl9jb21tb25QcmVmaXggPSBjb21tb25QcmVmaXg7CisgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICBpZiAoY29tcGxldGlvbnMubGVuZ3RoID09PSAxKSB7CiAgICAgICAg ICAgICAgICAgdmFyIGNvbXBsZXRpb25UZXh0ID0gY29tcGxldGlvbnNbMF07CiAgICAgICAgICAg ICAgICAgd29yZFByZWZpeExlbmd0aCA9IGNvbXBsZXRpb25UZXh0Lmxlbmd0aDsKQEAgLTQ5OCw2 ICs1MTEsMjAgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewogICAgICAg ICAgICAgdGhpcy5hcHBseVN1Z2dlc3Rpb24oY29tcGxldGlvblRleHQsIGNvbXBsZXRpb25zLmxl bmd0aCA+IDEsIG9yaWdpbmFsV29yZFByZWZpeFJhbmdlKTsKICAgICB9LAogCisgICAgX2NvbXBs ZXRlQ29tbW9uUHJlZml4OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAoIXRoaXMuYXV0 b0NvbXBsZXRlRWxlbWVudCB8fCAhdGhpcy5fY29tbW9uUHJlZml4IHx8ICF0aGlzLl91c2VyRW50 ZXJlZFRleHQgfHwgdGhpcy5fdXNlckVudGVyZWRUZXh0Lmxlbmd0aCA+PSB0aGlzLl9jb21tb25Q cmVmaXgubGVuZ3RoKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmICghdGhpcy5p c1N1Z2dlc3RCb3hWaXNpYmxlKCkpIHsKKyAgICAgICAgICAgIHRoaXMuYWNjZXB0QXV0b0NvbXBs ZXRlKCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICB0aGlzLmF1 dG9Db21wbGV0ZUVsZW1lbnQudGV4dENvbnRlbnQgPSB0aGlzLl9jb21tb25QcmVmaXguc3Vic3Ry aW5nKHRoaXMuX3VzZXJFbnRlcmVkVGV4dC5sZW5ndGgpOworICAgICAgICB0aGlzLmFjY2VwdFN1 Z2dlc3Rpb24odHJ1ZSkKKyAgICB9LAorCiAgICAgLyoqCiAgICAgICogQHBhcmFtIHtSYW5nZT19 IG9yaWdpbmFsUHJlZml4UmFuZ2UKICAgICAgKi8KQEAgLTUzMyw3ICs1NjAsMTAgQEAgV2ViSW5z cGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQuRXZlbnRzLkl0ZW1BcHBs aWVkLCB7IGl0ZW1UZXh0OiBjb21wbGV0aW9uVGV4dCB9KTsKICAgICB9LAogCi0gICAgYWNjZXB0 U3VnZ2VzdGlvbjogZnVuY3Rpb24oKQorICAgIC8qKgorICAgICAqIEBwYXJhbSB7Ym9vbGVhbj19 IHByZWZpeEFjY2VwdGVkCisgICAgICovCisgICAgYWNjZXB0U3VnZ2VzdGlvbjogZnVuY3Rpb24o cHJlZml4QWNjZXB0ZWQpCiAgICAgewogICAgICAgICBpZiAodGhpcy5faXNBY2NlcHRpbmdTdWdn ZXN0aW9uKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtNTU0LDggKzU4NCwxMSBAQCBX ZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHNlbGVjdGlvbi5y ZW1vdmVBbGxSYW5nZXMoKTsKICAgICAgICAgc2VsZWN0aW9uLmFkZFJhbmdlKGZpbmFsU2VsZWN0 aW9uUmFuZ2UpOwogCi0gICAgICAgIHRoaXMuaGlkZVN1Z2dlc3RCb3goKTsKLSAgICAgICAgdGhp cy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQuRXZlbnRz Lkl0ZW1BY2NlcHRlZCk7CisgICAgICAgIGlmICghcHJlZml4QWNjZXB0ZWQpIHsKKyAgICAgICAg ICAgIHRoaXMuaGlkZVN1Z2dlc3RCb3goKTsKKyAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVu dFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LkV2ZW50cy5JdGVtQWNjZXB0ZWQp OworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHRoaXMuYXV0b0NvbXBsZXRlU29vbih0cnVl KTsKIAogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LApAQCAtNjYzLDcgKzY5Niw5IEBAIFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZSA9IHsKIAogICAgIHRhYktleVByZXNzZWQ6 IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgLy8gSnVzdCBjb25zdW1lIHRoZSBrZXku CisgICAgICAgIHRoaXMuX2NvbXBsZXRlQ29tbW9uUHJlZml4KCk7CisKKyAgICAgICAgLy8gQ29u c3VtZSB0aGUga2V5LgogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCg==