78230 2012-02-09 06:26:09 -0800 Web Inspector: [refactoring] take _showShortEvents out of timeline calculator 2012-02-09 08:54:22 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq caseq apavlov bweinstein keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 553105 0 caseq 2012-02-09 06:26:09 -0800 The _showShortEvents property is not used by TimelineCalculator, yet the TimelinePanel put this property on TimelinePanel._calculator. _showShortEvents better belongs to TimelinePanel. 553108 1 126293 caseq 2012-02-09 06:28:19 -0800 Created attachment 126293 Patch 553206 2 caseq 2012-02-09 08:54:22 -0800 Committed r107251: <http://trac.webkit.org/changeset/107251> 126293 2012-02-09 06:28:19 -0800 2012-02-09 07:00:28 -0800 Patch bug-78230-20120209182817.patch text/plain 3773 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQ2MWU4ZGQ3ZjIxMjhk YWY2NmU4NGY3ZmRhY2M0ZjNlZDAxM2Y5OS4uNzM2ZDhhNjk3OTEyNDQ5YjVlMWU2MGVhZGQxZDc3 Y2UyMmY0ZWNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA5ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogW3JlZmFjdG9yaW5nXSB0YWtlIF9zaG93U2hvcnRFdmVudHMgb3V0IG9mIHRpbWVsaW5lIGNh bGN1bGF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc4MjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVQYW5lbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5l bC5wcm90b3R5cGUuX3RvZ2dsZUZpbHRlckJ1dHRvbkNsaWNrZWQpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlLl9yZWZyZXNoKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5fYWRkVG9SZWNvcmRzV2luZG93KToKKwog MjAxMi0wMi0wOSAgUm9sYW5kIFN0ZWluZXIgIDxyb2xhbmRzdGVpbmVyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBTZWxlY3RvckNoZWNrZXI6OmNoZWNrU2VsZWN0b3I6IG1vdmUgcGFyYW1ldGVy cyBpbnRvIGEgc3RydWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMjhkYjRlZDA1OTJjY2QwNTkwMDJkZTAzMGRmM2Ji OGQ5MjAxNWI5OC4uYTdjODUyNjdmMWM0MmViOTY3YmE2ZjA4NDBkMDgwNDNiYjg3NWRjNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5l bC5qcwpAQCAtOTUsNyArOTUsNiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9IGZ1bmN0 aW9uKCkKICAgICB0aGlzLl9yZWdpc3RlcmVkQW5pbWF0aW9uQ2FsbGJhY2tSZWNvcmRzID0ge307 CiAKICAgICB0aGlzLl9jYWxjdWxhdG9yID0gbmV3IFdlYkluc3BlY3Rvci5UaW1lbGluZUNhbGN1 bGF0b3IoKTsKLSAgICB0aGlzLl9jYWxjdWxhdG9yLl9zaG93U2hvcnRFdmVudHMgPSBmYWxzZTsK ICAgICB2YXIgc2hvcnRSZWNvcmRUaHJlc2hvbGRUaXRsZSA9IE51bWJlci5zZWNvbmRzVG9TdHJp bmcoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwuc2hvcnRSZWNvcmRUaHJlc2hvbGQpOwogICAg IHRoaXMuX3Nob3dTaG9ydFJlY29yZHNUaXRsZVRleHQgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmco IlNob3cgdGhlIHJlY29yZHMgdGhhdCBhcmUgc2hvcnRlciB0aGFuICVzIiwgc2hvcnRSZWNvcmRU aHJlc2hvbGRUaXRsZSk7CiAgICAgdGhpcy5faGlkZVNob3J0UmVjb3Jkc1RpdGxlVGV4dCA9IFdl Ykluc3BlY3Rvci5VSVN0cmluZygiSGlkZSB0aGUgcmVjb3JkcyB0aGF0IGFyZSBzaG9ydGVyIHRo YW4gJXMiLCBzaG9ydFJlY29yZFRocmVzaG9sZFRpdGxlKTsKQEAgLTExMCw3ICsxMDksNyBAQCBX ZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9IGZ1bmN0aW9uKCkKIAogICAgIC8vIERpc2FibGUg c2hvcnQgZXZlbnRzIGZpbHRlciBieSBkZWZhdWx0LgogICAgIHRoaXMudG9nZ2xlRmlsdGVyQnV0 dG9uLnRvZ2dsZWQgPSB0cnVlOwotICAgIHRoaXMuX2NhbGN1bGF0b3IuX3Nob3dTaG9ydEV2ZW50 cyA9IHRoaXMudG9nZ2xlRmlsdGVyQnV0dG9uLnRvZ2dsZWQ7CisgICAgdGhpcy5fc2hvd1Nob3J0 RXZlbnRzID0gdGhpcy50b2dnbGVGaWx0ZXJCdXR0b24udG9nZ2xlZDsKICAgICB0aGlzLl90aW1l U3RhbXBSZWNvcmRzID0gW107CiAgICAgdGhpcy5fZXhwYW5kT2Zmc2V0ID0gMTU7CiAKQEAgLTQz NSw4ICs0MzQsOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAg ICAgX3RvZ2dsZUZpbHRlckJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAg IHRoaXMudG9nZ2xlRmlsdGVyQnV0dG9uLnRvZ2dsZWQgPSAhdGhpcy50b2dnbGVGaWx0ZXJCdXR0 b24udG9nZ2xlZDsKLSAgICAgICAgdGhpcy5fY2FsY3VsYXRvci5fc2hvd1Nob3J0RXZlbnRzID0g dGhpcy50b2dnbGVGaWx0ZXJCdXR0b24udG9nZ2xlZDsKLSAgICAgICAgdGhpcy50b2dnbGVGaWx0 ZXJCdXR0b24uZWxlbWVudC50aXRsZSA9IHRoaXMuX2NhbGN1bGF0b3IuX3Nob3dTaG9ydEV2ZW50 cyA/IHRoaXMuX2hpZGVTaG9ydFJlY29yZHNUaXRsZVRleHQgOiB0aGlzLl9zaG93U2hvcnRSZWNv cmRzVGl0bGVUZXh0OworICAgICAgICB0aGlzLl9zaG93U2hvcnRFdmVudHMgPSB0aGlzLnRvZ2ds ZUZpbHRlckJ1dHRvbi50b2dnbGVkOworICAgICAgICB0aGlzLnRvZ2dsZUZpbHRlckJ1dHRvbi5l bGVtZW50LnRpdGxlID0gdGhpcy5fc2hvd1Nob3J0RXZlbnRzID8gdGhpcy5faGlkZVNob3J0UmVj b3Jkc1RpdGxlVGV4dCA6IHRoaXMuX3Nob3dTaG9ydFJlY29yZHNUaXRsZVRleHQ7CiAgICAgICAg IHRoaXMuX3NjaGVkdWxlUmVmcmVzaCh0cnVlKTsKICAgICB9LAogCkBAIC02NzIsNyArNjcxLDcg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAg ZGVsZXRlIHRoaXMuX3JlZnJlc2hUaW1lb3V0OwogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5f b3ZlcnZpZXdQYW5lLnVwZGF0ZSh0aGlzLl9yb290UmVjb3JkLmNoaWxkcmVuLCB0aGlzLl9jYWxj dWxhdG9yLl9zaG93U2hvcnRFdmVudHMpOworICAgICAgICB0aGlzLl9vdmVydmlld1BhbmUudXBk YXRlKHRoaXMuX3Jvb3RSZWNvcmQuY2hpbGRyZW4sIHRoaXMuX3Nob3dTaG9ydEV2ZW50cyk7CiAK ICAgICAgICAgdGhpcy5fcmVmcmVzaFJlY29yZHMoIXRoaXMuX2JvdW5kYXJpZXNBcmVWYWxpZCk7 CiAgICAgICAgIHRoaXMuX3VwZGF0ZVJlY29yZHNDb3VudGVyKCk7CkBAIC03MDAsNyArNjk5LDcg QEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAqLwogICAg IF9hZGRUb1JlY29yZHNXaW5kb3c6IGZ1bmN0aW9uKHJlY29yZCwgcmVjb3Jkc1dpbmRvdywgcGFy ZW50SXNDb2xsYXBzZWQpCiAgICAgewotICAgICAgICBpZiAoIXRoaXMuX2NhbGN1bGF0b3IuX3No b3dTaG9ydEV2ZW50cyAmJiAhcmVjb3JkLmlzTG9uZygpKQorICAgICAgICBpZiAoIXRoaXMuX3No b3dTaG9ydEV2ZW50cyAmJiAhcmVjb3JkLmlzTG9uZygpKQogICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB2YXIgcGVyY2VudGFnZXMgPSB0aGlzLl9jYWxjdWxhdG9yLmNvbXB1dGVCYXJHcmFw aFBlcmNlbnRhZ2VzKHJlY29yZCk7CiAgICAgICAgIGlmIChwZXJjZW50YWdlcy5zdGFydCA8IDEw MCAmJiBwZXJjZW50YWdlcy5lbmRXaXRoQ2hpbGRyZW4gPj0gMCAmJiAhcmVjb3JkLmNhdGVnb3J5 LmhpZGRlbikgewo=