78225 2012-02-09 05:46:38 -0800 Rename [Return] to [CustomReturn] 2012-02-09 15:41:52 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin japhet ojan webkit.review.bot oldest_to_newest 553094 0 haraken 2012-02-09 05:46:38 -0800 [Return] is used to handle custom code for a returned value, and thus should be renamed to [CustomReturn]. (Note: [Return] is used by ObjC, GObject and CPP's Node.idl only.) 553096 1 126290 haraken 2012-02-09 05:49:21 -0800 Created attachment 126290 Patch 553575 2 126290 webkit.review.bot 2012-02-09 15:41:48 -0800 Comment on attachment 126290 Patch Clearing flags on attachment: 126290 Committed r107299: <http://trac.webkit.org/changeset/107299> 553576 3 webkit.review.bot 2012-02-09 15:41:52 -0800 All reviewed patches have been landed. Closing bug. 126290 2012-02-09 05:49:21 -0800 2012-02-09 15:41:47 -0800 Patch bug-78225-20120209224920.patch text/plain 5132 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThmMjgwZTAyYjRjYjE5 MGQxM2EzM2EzZTU2NDdlOWE5Nzk5OTc1OC4uNTg4MTIyNDY1NjI2MTI2NjNmNjY3NTI4ZjJkMzIz MjMxMTk5MjA2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAyLTA5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgW1JldHVy bl0gdG8gW0N1c3RvbVJldHVybl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc4MjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1JldHVybl0gaXMgdXNlZCB0byBoYW5kbGUgY3VzdG9tIGNvZGUgZm9yIGEg cmV0dXJuZWQgdmFsdWUuCisgICAgICAgIFRvIGNsYXJpZnkgaXQsIHRoaXMgcGF0Y2ggcmVuYW1l cyBbUmV0dXJuXSB0byBbQ3VzdG9tUmV0dXJuXS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hh bmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yQ1BQLnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbToKKyAgICAgICAgKEdlbmVy YXRlRnVuY3Rpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9i akMucG06CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAgICAgICAgKiBkb20v Tm9kZS5pZGw6CisKIDIwMTItMDItMDkgIFJvbGFuZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNzE5Ny4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckNQUC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQ UC5wbQppbmRleCBhOTA5YTU3ZDA1YWQxZmM4NTBmY2YzM2I2NjBjYzcxZjMxZjE4Mjk4Li4zMjky OGQxOWNmM2U0M2Y1Y2FiMDZhNTQyOGMxZTc2OGFjNjhjYjEzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCkBAIC04MDcsNyAr ODA3LDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICBteSAk aW1wbEdldHRlciA9IEdldENQUFR5cGVHZXR0ZXIoJHBhcmFtTmFtZSwgJGlkbFR5cGUpOwogCiAg ICAgICAgICAgICAgICAgcHVzaChAcGFyYW1ldGVyTmFtZXMsICRpbXBsR2V0dGVyKTsKLSAgICAg ICAgICAgICAgICAkbmVlZHNDdXN0b217Ik5vZGVUb1JldHVybiJ9ID0gJHBhcmFtTmFtZSBpZiAk cGFyYW0tPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJSZXR1cm4ifTsKKyAgICAgICAgICAgICAgICAk bmVlZHNDdXN0b217Ik5vZGVUb1JldHVybiJ9ID0gJHBhcmFtTmFtZSBpZiAkcGFyYW0tPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJDdXN0b21SZXR1cm4ifTsKIAogICAgICAgICAgICAgICAgIHVubGVz cyAoJGNvZGVHZW5lcmF0b3ItPklzUHJpbWl0aXZlVHlwZSgkaWRsVHlwZSkgb3IgJGNvZGVHZW5l cmF0b3ItPklzU3RyaW5nVHlwZSgkaWRsVHlwZSkpIHsKICAgICAgICAgICAgICAgICAgICAgcHVz aChAbmVlZHNBc3NlcnQsICIgICAgQVNTRVJUKCRwYXJhbU5hbWUpO1xuIik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQppbmRleCA2ZWRmZDBjODA1YzliZDRhODA5N2EzZjYyYzE0ZDVlN2Q3Y2U0YmRmLi44YTZkZTE4 MTg3ZjFiZjMyYWY2MzM1OTExZTEwMzU4MTBkNDkwNDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KQEAgLTg2 OCw3ICs4NjgsNyBAQCBzdWIgR2VuZXJhdGVGdW5jdGlvbiB7CiAKICAgICAgICAgICAgIHB1c2go QGNCb2R5LCAiICAgIH1cbiIpOwogICAgICAgICB9Ci0gICAgICAgICRyZXR1cm5QYXJhbU5hbWUg PSAiY29udmVydGVkXyIuJHBhcmFtTmFtZSBpZiAkcGFyYW0tPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJSZXR1cm4ifTsKKyAgICAgICAgJHJldHVyblBhcmFtTmFtZSA9ICJjb252ZXJ0ZWRfIi4kcGFy YW1OYW1lIGlmICRwYXJhbS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbVJldHVybiJ9Owog ICAgIH0KIAogICAgIG15ICRhc3NpZ24gPSAiIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCmluZGV4IDVhNjNmYzMzYjJlZDli ZmM5N2RhNWRhYWI3YTgwMjkzYzNkMjlmNzUuLjM5Nzg0ODFiY2VmMWZiNzdjMDI0NzIwMmFiZDE5 NWViYWNlYTAwZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvck9iakMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQpAQCAtMTQ5NSw3ICsxNDk1LDcgQEAgc3ViIEdlbmVyYXRl SW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICAkbmVlZHNDdXN0b217Ik5vZGVGaWx0ZXIi fSA9ICRwYXJhbU5hbWUgaWYgJGlkbFR5cGUgZXEgIk5vZGVGaWx0ZXIiOwogICAgICAgICAgICAg ICAgICRuZWVkc0N1c3RvbXsiRXZlbnRMaXN0ZW5lciJ9ID0gJHBhcmFtTmFtZSBpZiAkaWRsVHlw ZSBlcSAiRXZlbnRMaXN0ZW5lciI7CiAgICAgICAgICAgICAgICAgJG5lZWRzQ3VzdG9teyJFdmVu dFRhcmdldCJ9ID0gJHBhcmFtTmFtZSBpZiAkaWRsVHlwZSBlcSAiRXZlbnRUYXJnZXQiOwotICAg ICAgICAgICAgICAgICRuZWVkc0N1c3RvbXsiTm9kZVRvUmV0dXJuIn0gPSAkcGFyYW1OYW1lIGlm ICRwYXJhbS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJldHVybiJ9OworICAgICAgICAgICAgICAg ICRuZWVkc0N1c3RvbXsiTm9kZVRvUmV0dXJuIn0gPSAkcGFyYW1OYW1lIGlmICRwYXJhbS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbVJldHVybiJ9OwogCiAgICAgICAgICAgICAgICAgdW5s ZXNzICgkY29kZUdlbmVyYXRvci0+SXNQcmltaXRpdmVUeXBlKCRpZGxUeXBlKSBvciAkY29kZUdl bmVyYXRvci0+SXNTdHJpbmdUeXBlKCRpZGxUeXBlKSkgewogICAgICAgICAgICAgICAgICAgICBw dXNoKEBuZWVkc0Fzc2VydCwgIiAgICBBU1NFUlQoJHBhcmFtTmFtZSk7XG4iKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl LmlkbAppbmRleCBiNjdiZTY4YjQ1ZDZhNWI1ZGQ4OWJhNmIxZDAwYjc3Y2FmOTQ1NTI0Li4xOGE2 ZjIzN2E0ZmQzYjY3YTE1ZjFiMzQxYWEzYWExZjNkYWM0N2U4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vTm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaWRsCkBA IC02NywxNSArNjcsMTUgQEAgbW9kdWxlIGNvcmUgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgTmFtZWROb2RlTWFwICAgICBhdHRyaWJ1dGVzOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgRG9jdW1lbnQgICAgICAgICBvd25lckRvY3VtZW50OwogCi0gICAgICAgIFtPYmpDTGVnYWN5 VW5uYW1lZFBhcmFtZXRlcnMsIEN1c3RvbV0gTm9kZSBpbnNlcnRCZWZvcmUoaW4gW1JldHVybl0g Tm9kZSBuZXdDaGlsZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpbiBOb2RlIHJlZkNoaWxkKQorICAgICAgICBbT2JqQ0xlZ2FjeVVubmFtZWRQYXJh bWV0ZXJzLCBDdXN0b21dIE5vZGUgaW5zZXJ0QmVmb3JlKGluIFtDdXN0b21SZXR1cm5dIE5vZGUg bmV3Q2hpbGQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW4gTm9kZSByZWZDaGlsZCkKICAgICAgICAgICAgIHJhaXNlcyhE T01FeGNlcHRpb24pOwogICAgICAgICBbT2JqQ0xlZ2FjeVVubmFtZWRQYXJhbWV0ZXJzLCBDdXN0 b21dIE5vZGUgcmVwbGFjZUNoaWxkKGluIE5vZGUgbmV3Q2hpbGQsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW1JldHVybl0gTm9kZSBvbGRDaGls ZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpbiBbQ3VzdG9tUmV0dXJuXSBOb2RlIG9sZENoaWxkKQogICAgICAgICAgICAg cmFpc2VzKERPTUV4Y2VwdGlvbkpTQyk7Ci0gICAgICAgIFtDdXN0b21dIE5vZGUgICAgICAgICAg ICAgICByZW1vdmVDaGlsZChpbiBbUmV0dXJuXSBOb2RlIG9sZENoaWxkKQorICAgICAgICBbQ3Vz dG9tXSBOb2RlICAgICAgICAgICAgICAgcmVtb3ZlQ2hpbGQoaW4gW0N1c3RvbVJldHVybl0gTm9k ZSBvbGRDaGlsZCkKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwotICAgICAgICBb Q3VzdG9tXSBOb2RlICAgICAgICAgICAgICAgYXBwZW5kQ2hpbGQoaW4gW1JldHVybl0gTm9kZSBu ZXdDaGlsZCkKKyAgICAgICAgW0N1c3RvbV0gTm9kZSAgICAgICAgICAgICAgIGFwcGVuZENoaWxk KGluIFtDdXN0b21SZXR1cm5dIE5vZGUgbmV3Q2hpbGQpCiAgICAgICAgICAgICByYWlzZXMoRE9N RXhjZXB0aW9uKTsKIAogICAgICAgICBib29sZWFuICAgICAgICAgICAgaGFzQ2hpbGROb2Rlcygp Owo=