78211 2012-02-09 00:19:37 -0800 [GTK] EWS command-line option to run the tests 2012-02-10 00:07:51 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand abarth gustavo ojan webkit.review.bot oldest_to_newest 552917 0 pnormand 2012-02-09 00:19:37 -0800 I'm not sure all the 3 EWS GTK bots can run all the tests for each patch fast enough. That's why I'd like to add a new command-line switch so each bot can choose to opt-in if it can run the tests fast :) The igalia-gtk-ews should at least be able to do this. Will attach a patch. 553034 1 gustavo 2012-02-09 03:52:38 -0800 Sounds like a great idea =) my local EWS is probably able to keep up, not so sure about the collabora one for now, so having the switch would be good. 553040 2 126276 pnormand 2012-02-09 04:06:28 -0800 Created attachment 126276 Patch 553300 3 126276 abarth 2012-02-09 10:40:50 -0800 Comment on attachment 126276 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126276&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:48 > + options = [make_option("--run-tests", action="store_true", dest="tests", default=self._default_run_tests, help="Run the Layout tests for each patch")] Can we name this run_tests ? We generally like to make the names in the code match the command line names. 553903 4 pnormand 2012-02-10 00:07:51 -0800 Committed r107374: <http://trac.webkit.org/changeset/107374> 126276 2012-02-09 04:06:28 -0800 2012-02-09 10:40:50 -0800 Patch bug-78211-20120209130625.patch text/plain 4285 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MjEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRmYjJkMDYwNmM2OTM4ZmIzZTM1ZTE1OTA0NTk0YmY2 ZTkyYjZkMy4uM2I4NjRkZmQ3MTk4YWIwNmJmNjhiYzRiZjA4NDNlZmQ1ZWZiMGYxZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTAyLTA5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBFV1MgY29tbWFuZC1saW5lIG9wdGlvbiB0byBydW4gdGhlIHRlc3Rz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODIxMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyAtLXJ1 bi10ZXN0cyBvcHRpb24gKGRlZmF1bHRzIHRvIEZhbHNlKSBmb3IgdGhlIEVXUyBjb21tYW5kcy4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdz eXN0ZW0ucHk6CisgICAgICAgIChBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbSk6CisgICAgICAg IChBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5fX2luaXRfXyk6CisgICAgICAgIChBYnN0cmFj dEVhcmx5V2FybmluZ1N5c3RlbS5yZXZpZXdfcGF0Y2gpOgorICAgICAgICAoQ2hyb21pdW1MaW51 eEVXUyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2Fy bmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAgKEVhcmx5V2FybmluZ1N5dGVtVGVzdC5f dGVzdF9idWlsZGVyX2V3cyk6CisKIDIwMTItMDItMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAga2lsbC1vbGQtcHJvY2Vzc2VzIHNob3VsZCBraWxsIGdjYyBh bmQgY2xhbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CmluZGV4IGNiZjRjZTZkMjViZTc2OWM1ZjgyN2Y4 MTFmMDljNWMyYzljOTFmZTEuLjRjMGIxMjIwYmViNTUxYmQ4YmZlNDJkYjBhYzFmNmMwZTM0YjEx ZmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJs eXdhcm5pbmdzeXN0ZW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQpAQCAtMjYsNiArMjYsOCBAQAogIyAoSU5DTFVESU5H IE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBV U0UKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElU WSBPRiBTVUNIIERBTUFHRS4KIAorZnJvbSBvcHRwYXJzZSBpbXBvcnQgbWFrZV9vcHRpb24KKwog ZnJvbSB3ZWJraXRweS5jb21tb24uY29uZmlnLmNvbW1pdHRlcnMgaW1wb3J0IENvbW1pdHRlckxp c3QKIGZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZy5wb3J0cyBpbXBvcnQgV2ViS2l0UG9ydAog ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmRlcHJlY2F0ZWRfbG9nZ2luZyBpbXBvcnQgZXJy b3IsIGxvZwpAQCAtMzksMTEgKzQxLDEyIEBAIGZyb20gd2Via2l0cHkudG9vbC5jb21tYW5kcy5x dWV1ZXMgaW1wb3J0IEFic3RyYWN0UmV2aWV3UXVldWUKIAogY2xhc3MgQWJzdHJhY3RFYXJseVdh cm5pbmdTeXN0ZW0oQWJzdHJhY3RSZXZpZXdRdWV1ZSwgRWFybHlXYXJuaW5nU3lzdGVtVGFza0Rl bGVnYXRlKToKICAgICBfYnVpbGRfc3R5bGUgPSAicmVsZWFzZSIKLSAgICAjIEZJWE1FOiBTd2l0 Y2ggX3J1bl90ZXN0cyBmcm9tIG9wdC1pbiB0byBvcHQtb3V0IG9uY2UgbW9yZSBib3RzIGFyZSBy ZWFkeSB0byBydW4gdGVzdHMuCi0gICAgX3J1bl90ZXN0cyA9IEZhbHNlCisgICAgIyBGSVhNRTog U3dpdGNoIF9kZWZhdWx0X3J1bl90ZXN0cyBmcm9tIG9wdC1pbiB0byBvcHQtb3V0IG9uY2UgbW9y ZSBib3RzIGFyZSByZWFkeSB0byBydW4gdGVzdHMuCisgICAgX2RlZmF1bHRfcnVuX3Rlc3RzID0g RmFsc2UKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKLSAgICAgICAgQWJzdHJhY3RSZXZpZXdR dWV1ZS5fX2luaXRfXyhzZWxmKQorICAgICAgICBvcHRpb25zID0gW21ha2Vfb3B0aW9uKCItLXJ1 bi10ZXN0cyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9InRlc3RzIiwgZGVmYXVsdD1zZWxm Ll9kZWZhdWx0X3J1bl90ZXN0cywgaGVscD0iUnVuIHRoZSBMYXlvdXQgdGVzdHMgZm9yIGVhY2gg cGF0Y2giKV0KKyAgICAgICAgQWJzdHJhY3RSZXZpZXdRdWV1ZS5fX2luaXRfXyhzZWxmLCBvcHRp b25zPW9wdGlvbnMpCiAgICAgICAgIHNlbGYucG9ydCA9IFdlYktpdFBvcnQucG9ydChzZWxmLnBv cnRfbmFtZSkKIAogICAgIGRlZiBzaG91bGRfcHJvY2VlZF93aXRoX3dvcmtfaXRlbShzZWxmLCBw YXRjaCk6CkBAIC03Myw3ICs3Niw3IEBAIGNsYXNzIEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVt KEFic3RyYWN0UmV2aWV3UXVldWUsIEVhcmx5V2FybmluZ1N5c3RlbVRhc2tEZWxlCiAgICAgICAg IHRvb2wuYnVncy5zZXRfZmxhZ19vbl9hdHRhY2htZW50KHBhdGNoLmlkKCksICJjb21taXQtcXVl dWUiLCAiLSIsIG1lc3NhZ2UsIGV4dHJhX21lc3NhZ2VfdGV4dCkKIAogICAgIGRlZiByZXZpZXdf cGF0Y2goc2VsZiwgcGF0Y2gpOgotICAgICAgICB0YXNrID0gRWFybHlXYXJuaW5nU3lzdGVtVGFz ayhzZWxmLCBwYXRjaCwgc2VsZi5fcnVuX3Rlc3RzKQorICAgICAgICB0YXNrID0gRWFybHlXYXJu aW5nU3lzdGVtVGFzayhzZWxmLCBwYXRjaCwgc2VsZi5fb3B0aW9ucy50ZXN0cykKICAgICAgICAg aWYgbm90IHRhc2sudmFsaWRhdGUoKToKICAgICAgICAgICAgIHNlbGYuX2RpZF9lcnJvcihwYXRj aCwgIiVzIGRpZCBub3QgcHJvY2VzcyBwYXRjaC4iICUgc2VsZi5uYW1lKQogICAgICAgICAgICAg cmV0dXJuIEZhbHNlCkBAIC0xNzksNyArMTgyLDcgQEAgY2xhc3MgQ2hyb21pdW1MaW51eEVXUyhB YnN0cmFjdENocm9taXVtRVdTKToKICAgICAjICAgICAgICBhIGRhdGFiYXNlIG1pZ3JhdGlvbi4g OigKICAgICBuYW1lID0gImNocm9taXVtLWV3cyIKICAgICBwb3J0X25hbWUgPSAiY2hyb21pdW0t eHZmYiIKLSAgICBfcnVuX3Rlc3RzID0gVHJ1ZQorICAgIF9kZWZhdWx0X3J1bl90ZXN0cyA9IFRy dWUKIAogCiBjbGFzcyBDaHJvbWl1bVdpbmRvd3NFV1MoQWJzdHJhY3RDaHJvbWl1bUVXUyk6CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu aW5nc3lzdGVtX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQppbmRleCBhZmIxZGIwZjc1MGEzMmVm NTQ5ODIzNjZhMTg4ODUyNzk1MGViOTNiLi44ODgwNDk4MDA2OThkOGNhNGI5NDVkMmVjNjM4OTYy OTkwN2QyOWVhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKQEAgLTY5 LDcgKzY5LDEwIEBAIGNsYXNzIEVhcmx5V2FybmluZ1N5dGVtVGVzdChRdWV1ZXNUZXN0KToKIAog ICAgIGRlZiBfdGVzdF9idWlsZGVyX2V3cyhzZWxmLCBld3MpOgogICAgICAgICBld3MuYmluZF90 b190b29sKE1vY2tUb29sKCkpCi0gICAgICAgIHNlbGYuYXNzZXJ0X3F1ZXVlX291dHB1dHMoZXdz LCBleHBlY3RlZF9zdGRlcnI9c2VsZi5fZGVmYXVsdF9leHBlY3RlZF9zdGRlcnIoZXdzKSkKKyAg ICAgICAgb3B0aW9ucyA9IE1vY2soKQorICAgICAgICBvcHRpb25zLnBvcnQgPSBOb25lCisgICAg ICAgIG9wdGlvbnMudGVzdHMgPSBld3MuX2RlZmF1bHRfcnVuX3Rlc3RzCisgICAgICAgIHNlbGYu YXNzZXJ0X3F1ZXVlX291dHB1dHMoZXdzLCBleHBlY3RlZF9zdGRlcnI9c2VsZi5fZGVmYXVsdF9l eHBlY3RlZF9zdGRlcnIoZXdzKSwgb3B0aW9ucz1vcHRpb25zKQogCiAgICAgZGVmIF90ZXN0X2Nv bW1pdHRlcl9vbmx5X2V3cyhzZWxmLCBld3MpOgogICAgICAgICBld3MuYmluZF90b190b29sKE1v Y2tUb29sKCkpCg==