78199 2012-02-08 19:52:36 -0800 Increased style sharing for elements with presentation attributes. 2012-02-08 20:41:30 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling koivisto macpherson menard rniwa webkit.review.bot oldest_to_newest 552780 0 kling 2012-02-08 19:52:36 -0800 Currently we only allow elements that have attributeStyle() to share style with others if they have the exact same attribute map contents. We can be more specific and increase the style sharing hit rate. 552781 1 126227 kling 2012-02-08 19:56:57 -0800 Created attachment 126227 Perhaps a patch 552787 2 126227 koivisto 2012-02-08 20:04:18 -0800 Comment on attachment 126227 Perhaps a patch r=me, could use a comment explaining the ways attributeStylesEqual is not generic. 552811 3 kling 2012-02-08 20:41:30 -0800 Committed r107173: <http://trac.webkit.org/changeset/107173> 126227 2012-02-08 19:56:57 -0800 2012-02-08 20:04:18 -0800 Perhaps a patch bug-78199.diff text/plain 3810 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZTU3MjZhLi5hNGVmNmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDItMDggIEFuZHJlYXMgS2xpbmcgIDxhd2Vzb21la2xpbmdAYXBwbGUuY29tPgor CisgICAgICAgIEluY3JlYXNlZCBzdHlsZSBzaGFyaW5nIGZvciBlbGVtZW50cyB3aXRoIHByZXNl bnRhdGlvbiBhdHRyaWJ1dGVzLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi83ODE5OT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGRl dGVybWluaW5nIHdoZXRoZXIgdHdvIGVsZW1lbnRzIGNhbiBzaGFyZSBzdHlsZSwgd2UgY2FuIGRv IGEgbG90IGJldHRlci4KKyAgICAgICAgSW5zdGVhZCBvZiBjb21wYXJpbmcgdGhlIGF0dHJpYnV0 ZSBtYXBzIGZvciBleGFjdCBlcXVhbGl0eSwgZG8gYSBwcm9wZXJ0eS1ieS1wcm9wZXJ0eQorICAg ICAgICBjb21wYXJpc29uIG9mIHRoZSBhdHRyaWJ1dGVTdHlsZSgpIGFuZCB0aGUgYWRkaXRpb25h bEF0dHJpYnV0ZVN0eWxlKCkgKGlmIGFueS4pCisKKyAgICAgICAgVGhpcyBpbmNyZWFzZXMgb3Vy IHN0eWxlIHNoYXJpbmcgaGl0IHJhdGUgYW5kIHNoYXZlcyAxMDBtcyBvZmYgb2YgZWFjaCBjeWNs ZSBvbgorICAgICAgICBDaHJvbWl1bSdzICJNb3oiIHBhZ2UgY3ljbGVyIHRlc3Qgb24gbXkgbWFj aGluZS4KKworICAgICAgICBUaGUgZnVuY3Rpb24gdGhhdCBjb21wYXJlcyBhdHRyaWJ1dGUgc3R5 bGVzIGhhcyBPKG5eMikgcnVudGltZSBpbiB0aGUgd29yc3QgY2FzZSwKKyAgICAgICAgd2hlcmUg biBpcyB0aGUgbnVtYmVyIG9mIHByb3BlcnRpZXMgaW4gdGhlIHN0eWxlcy4gSG93ZXZlciwgZ2l2 ZW4gdGhlIGxvdyBudW1iZXIgb2YKKyAgICAgICAgcHJvcGVydGllcyBmb3VuZCBpbiBhdHRyaWJ1 dGUgc3R5bGVzLCB0aGlzIHNob3VsZCBiZSBmaW5lLCBhbmQgaXQgZG9lc24ndCBzZWVtIHRvCisg ICAgICAgIGhlYXQgdXAgaW4gcHJvZmlsZXMuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxl Y3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjphdHRyaWJ1dGVTdHlsZXNFcXVhbCk6CisgICAg ICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQp OgorCiAyMDEyLTAyLTA4ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFNpbXBsaWZ5IGFuZCBjb3JyZWN0IG11dGF0aW9uIGRlbGl2ZXJ5IHRpbWluZyBmb3IgSlND CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKaW5kZXggZmZkN2M0Zi4uYjky ZjliZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtMTE5NCw2 ICsxMTk0LDI5IEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhDb250 cm9sKFN0eWxlZEVsZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK K3N0YXRpYyBpbmxpbmUgYm9vbCBhdHRyaWJ1dGVTdHlsZXNFcXVhbChTdHlsZVByb3BlcnR5U2V0 KiBhLCBTdHlsZVByb3BlcnR5U2V0KiBiKQoreworICAgIGlmIChhID09IGIpCisgICAgICAgIHJl dHVybiB0cnVlOworICAgIGlmIChhLT5wcm9wZXJ0eUNvdW50KCkgIT0gYi0+cHJvcGVydHlDb3Vu dCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8 IGEtPnByb3BlcnR5Q291bnQoKTsgKytpKSB7CisgICAgICAgIGNvbnN0IENTU1Byb3BlcnR5JiBh UHJvcGVydHkgPSBhLT5wcm9wZXJ0eUF0KGkpOworICAgICAgICB1bnNpZ25lZCBqOworICAgICAg ICBmb3IgKGogPSAwOyBqIDwgYi0+cHJvcGVydHlDb3VudCgpOyArK2opIHsKKyAgICAgICAgICAg IGNvbnN0IENTU1Byb3BlcnR5JiBiUHJvcGVydHkgPSBiLT5wcm9wZXJ0eUF0KGopOworICAgICAg ICAgICAgaWYgKGFQcm9wZXJ0eS5pZCgpICE9IGJQcm9wZXJ0eS5pZCgpKQorICAgICAgICAgICAg ICAgIGNvbnRpbnVlOworICAgICAgICAgICAgaWYgKGFQcm9wZXJ0eS52YWx1ZSgpICE9IGJQcm9w ZXJ0eS52YWx1ZSgpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICB9CisgICAgICAgIGlmIChqID09IGItPnByb3BlcnR5Q291bnQoKSkK KyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9CisK IGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KFN0eWxlZEVs ZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiB7CiAgICAgUmVuZGVyU3R5bGUqIHN0eWxlID0gZWxlbWVu dC0+cmVuZGVyU3R5bGUoKTsKQEAgLTEyMTAsNiArMTIzMyw4IEBAIGJvb2wgQ1NTU3R5bGVTZWxl Y3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KFN0eWxlZEVsZW1lbnQqIGVsZW1lbnQpIGNv bnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoISFlbGVtZW50LT5hdHRyaWJ1dGVT dHlsZSgpICE9ICEhbV9zdHlsZWRFbGVtZW50LT5hdHRyaWJ1dGVTdHlsZSgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgaWYgKCEhZWxlbWVudC0+YWRkaXRpb25hbEF0dHJpYnV0ZVN0eWxl KCkgIT0gISFtX3N0eWxlZEVsZW1lbnQtPmFkZGl0aW9uYWxBdHRyaWJ1dGVTdHlsZSgpKQorICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGVsZW1lbnQtPmlzTGluaygpICE9IG1fZWxlbWVu dC0+aXNMaW5rKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoc3R5bGUtPmFmZmVj dGVkQnlVbmNvbW1vbkF0dHJpYnV0ZVNlbGVjdG9ycygpKQpAQCAtMTI3NCw3ICsxMjk5LDEwIEBA IGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KFN0eWxlZEVs ZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiAgICAgaWYgKGVsZW1lbnQtPmhhc0NsYXNzKCkgJiYgbV9l bGVtZW50LT5nZXRBdHRyaWJ1dGUoY2xhc3NBdHRyKSAhPSBlbGVtZW50LT5nZXRBdHRyaWJ1dGUo Y2xhc3NBdHRyKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKGVsZW1lbnQtPmF0 dHJpYnV0ZVN0eWxlKCkgJiYgIWVsZW1lbnQtPmF0dHJpYnV0ZU1hcCgpLT5tYXBzRXF1aXZhbGVu dChtX3N0eWxlZEVsZW1lbnQtPmF0dHJpYnV0ZU1hcCgpKSkKKyAgICBpZiAoZWxlbWVudC0+YXR0 cmlidXRlU3R5bGUoKSAmJiAhYXR0cmlidXRlU3R5bGVzRXF1YWwoZWxlbWVudC0+YXR0cmlidXRl U3R5bGUoKSwgbV9zdHlsZWRFbGVtZW50LT5hdHRyaWJ1dGVTdHlsZSgpKSkKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworCisgICAgaWYgKGVsZW1lbnQtPmFkZGl0aW9uYWxBdHRyaWJ1dGVTdHlsZSgp ICYmICFhdHRyaWJ1dGVTdHlsZXNFcXVhbChlbGVtZW50LT5hZGRpdGlvbmFsQXR0cmlidXRlU3R5 bGUoKS5nZXQoKSwgbV9zdHlsZWRFbGVtZW50LT5hZGRpdGlvbmFsQXR0cmlidXRlU3R5bGUoKS5n ZXQoKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChlbGVtZW50LT5pc0xpbmso KSAmJiBtX2VsZW1lbnRMaW5rU3RhdGUgIT0gc3R5bGUtPmluc2lkZUxpbmsoKSkK