78197 2012-02-08 19:41:55 -0800 The localization of htmlSelectMultipleItems() needs better support of pluralization 2012-02-09 13:54:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix, InRadar P2 Normal --- 1 benjamin benjamin ap joepeck oldest_to_newest 552773 0 benjamin 2012-02-08 19:41:55 -0800 The pluralization of 0 and 1 depends on the language. 552782 1 126228 benjamin 2012-02-08 19:58:08 -0800 Created attachment 126228 Patch 552826 2 126228 joepeck 2012-02-08 21:22:01 -0800 Comment on attachment 126228 Patch Can we ASSERT(count > 0) or even better convert its type to be unsigned [and then the localization to be %u]? Likewise we could change the WEB_UI_STRING description string to be slightly different for 0 items and 1 items. In the 0 case its a presentation string when there are no selected options, and the 1 is for just 1 selected option, in a <select multiple>. 552878 3 benjamin 2012-02-08 22:46:23 -0800 (In reply to comment #2) > (From update of attachment 126228 [details]) > Can we ASSERT(count > 0) or even better convert its type to be unsigned [and then the localization to be %u]? That is a good point, there is really no reason to use an int here. I will make a separate patch for that to avoid messing up our stuff too much. 553278 4 ap 2012-02-09 10:22:54 -0800 It's not just 0 and 1 that are language dependent. For example, 20 and 21 need different noun forms in Russian. I believe that there are lots of other cases like this. Is there a Radar bug tracking this issue? If there is one, please post its number in a comment, add it to ChangeLog, and add InRadar keyword. 553475 5 benjamin 2012-02-09 13:48:19 -0800 Committed r107288: <http://trac.webkit.org/changeset/107288> 553481 6 benjamin 2012-02-09 13:54:24 -0800 <rdar://problem/10814922> 126228 2012-02-08 19:58:08 -0800 2012-02-08 21:22:01 -0800 Patch bug-78197-20120208195806.patch text/plain 2649 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI3MWViNDc0NjA4NTdl NTM4YWQ0MDM0NDYxZTM5ZTA5YjJiZmQxOS4uNGZkM2NiMmU2NTBkYmQwODI0Y2QzNzczODY4MGZm MTdkNmMyYWI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAyLTA4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFRoZSBsb2NhbGl6 YXRpb24gb2YgaHRtbFNlbGVjdE11bHRpcGxlSXRlbXMoKSBuZWVkcyBiZXR0ZXIgc3VwcG9ydCBv ZiBwbHVyYWxpemF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03ODE5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZvciB0cmFuc2xhdGlvbiwgdGhlIGxvY2FsaXphdGlvbiBvZiAwIGFuZCAxIGRlcGVu ZHMgb24gdGhlIGxhbmd1YWdlLgorCisgICAgICAgICogRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJs ZS5zdHJpbmdzOgorICAgICAgICAqIHBsYXRmb3JtL0RlZmF1bHRMb2NhbGl6YXRpb25TdHJhdGVn eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEZWZhdWx0TG9jYWxpemF0aW9uU3RyYXRlZ3k6Omh0 bWxTZWxlY3RNdWx0aXBsZUl0ZW1zKToKKwogMjAxMi0wMi0wOCAgQWRhbSBLbGVpbiAgPGFkYW1r QGNocm9taXVtLm9yZz4KIAogICAgICAgICBET00gbXV0YXRpb25zIHNob3VsZCBub3QgYmUgZGVs aXZlcmVkIG9uIHdvcmtlciB0aHJlYWRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Fbmds aXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxw cm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggMjQ1ZGFjYjA0NDdjNDVkNGQ1ZWNkYjhiMzI1 ZWJkN2I2M2QzOGU5Zi4uYzNmZmY3YjlhNzAxMmM3OWJlNzc5ZDBkYjk0YWQwZWVhOTlhMzY0YSAx MDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSAzMDgKemNtYlFSaXV1ZU08XyNBKTYkPT1PNyYw MDE3KWx0QDchLWd3QUlRJlROQ2Zoc3l2WVRlcVY8X1Rla3hHQjckXiEtCnp0LSM+SDVXP1dnLX4o aDgxNyZpNkkybykqZ0NQX3drXis+OzJkZDByczA2Wi16Kz9iV3koM1ZjOC1xVlg1S3ktVQp6Z0N+ I2AlJUJOV2txbEl3MHlHODApPygwUzs5Xmk+RmFXWVdLe25UZXR5VGhaWkdqamAweEU2fFImRUdX NGlyVkcKYU1IUGpwUjBVY0VINSQhaU9je2BsJV9sa0NQWGhvYS1aTWJ9CgpkZWx0YSAxNApXY21Y QEpoSXpzJjxfI0EpSH1pN2FwOVRPaWp8TGIzCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vRGVmYXVsdExvY2FsaXphdGlvblN0cmF0ZWd5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0RlZmF1bHRMb2NhbGl6YXRpb25TdHJhdGVneS5jcHAKaW5kZXggMmE1ZjBmOTY0 YTEzZDcxYmIyNDdiOTZhNzkwNjcyZGYyMTRmM2JiMS4uOGIyNzExMmU4NWRiZjQ2ZTRiMzZhYmRh MzliOWNiMzI2MTU5ZmZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVm YXVsdExvY2FsaXphdGlvblN0cmF0ZWd5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9EZWZhdWx0TG9jYWxpemF0aW9uU3RyYXRlZ3kuY3BwCkBAIC03NzAsNyArNzcwLDE0IEBAIFN0 cmluZyBEZWZhdWx0TG9jYWxpemF0aW9uU3RyYXRlZ3k6OmtleWdlbktleWNoYWluSXRlbU5hbWUo Y29uc3QgU3RyaW5nJiBob3N0KQogI2lmIFBMQVRGT1JNKElPUykKIFN0cmluZyBEZWZhdWx0TG9j YWxpemF0aW9uU3RyYXRlZ3k6Omh0bWxTZWxlY3RNdWx0aXBsZUl0ZW1zKGludCBjb3VudCkKIHsK LSAgICByZXR1cm4gZm9ybWF0TG9jYWxpemVkU3RyaW5nKFdFQl9VSV9TVFJJTkcoIiVkIEl0ZW1z IiwgIlByZXNlbnQgdGhlIG51bWJlciBvZiBzZWxlY3RlZCA8b3B0aW9uPiBpdGVtcyBpbiBhIDxz ZWxlY3QgbXVsdGlwbGU+IGVsZW1lbnQgKGlPUyBvbmx5KSIpLCBjb3VudCk7CisgICAgc3dpdGNo IChjb3VudCkgeworICAgIGNhc2UgMDoKKyAgICAgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoIjAg SXRlbXMiLCAiUHJlc2VudCB0aGUgbnVtYmVyIG9mIHNlbGVjdGVkIDxvcHRpb24+IGl0ZW1zIGlu IGEgPHNlbGVjdCBtdWx0aXBsZT4gZWxlbWVudCAoaU9TIG9ubHkpIik7CisgICAgY2FzZSAxOgor ICAgICAgICByZXR1cm4gV0VCX1VJX1NUUklORygiMSBJdGVtIiwgIlByZXNlbnQgdGhlIG51bWJl ciBvZiBzZWxlY3RlZCA8b3B0aW9uPiBpdGVtcyBpbiBhIDxzZWxlY3QgbXVsdGlwbGU+IGVsZW1l bnQgKGlPUyBvbmx5KSIpOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBmb3JtYXRMb2Nh bGl6ZWRTdHJpbmcoV0VCX1VJX1NUUklORygiJWQgSXRlbXMiLCAiUHJlc2VudCB0aGUgbnVtYmVy IG9mIHNlbGVjdGVkIDxvcHRpb24+IGl0ZW1zIGluIGEgPHNlbGVjdCBtdWx0aXBsZT4gZWxlbWVu dCAoaU9TIG9ubHkpIiksIGNvdW50KTsKKyAgICB9CiB9CiAjZW5kaWYgLy8gUExBVEZPUk0oSU9T KQogI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykK