78179 2012-02-08 16:41:48 -0800 version_check.py should inform users that we don't support Python 2.5 anymore 2012-02-08 17:08:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dpranke eric ojan webkit.review.bot oldest_to_newest 552623 0 abarth 2012-02-08 16:41:48 -0800 version_check.py should inform users that we don't support Python 2.5 anymore 552626 1 126187 abarth 2012-02-08 16:44:24 -0800 Created attachment 126187 Patch 552627 2 126187 eric 2012-02-08 16:45:01 -0800 Comment on attachment 126187 Patch Does this have unittests we need to update? 552628 3 abarth 2012-02-08 16:46:16 -0800 Committed r107155: <http://trac.webkit.org/changeset/107155> 552633 4 abarth 2012-02-08 16:50:22 -0800 Not that I found. 552657 5 dpranke 2012-02-08 17:08:44 -0800 (In reply to comment #2) > (From update of attachment 126187 [details]) > Does this have unittests we need to update? No. When I wrote this, I argued that the code was too simple to write and too hard to test to be worth unit-testing, and I still think that that's true :). 126187 2012-02-08 16:44:24 -0800 2012-02-08 16:45:01 -0800 Patch bug-78179-20120208164423.patch text/plain 1311 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNzE1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAyLTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgdmVyc2lvbl9jaGVjay5weSBzaG91bGQgaW5mb3JtIHVzZXJzIHRoYXQgd2UgZG9u J3Qgc3VwcG9ydCBQeXRob24gMi41IGFueW1vcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc4MTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3Qgc3VwcG9ydCBQeXRob24gMi41IGFueW1vcmUu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uX2NoZWNrLnB5Ogor CiAyMDEyLTAyLTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg dGVzdF9jb25maWd1cmF0aW9uLnB5IHNob3VsZG4ndCByZS1pbXBsZW1lbnQgaXRlcnRvb2xzCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uX2NoZWNrLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3ZlcnNpb25fY2hlY2sucHkJ KHJldmlzaW9uIDEwNzE1NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3ZlcnNp b25fY2hlY2sucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDYgQEAKIAogaW1wb3J0IHN5 cwogCi1pZiBzeXMudmVyc2lvbiA8ICcyLjUnIG9yIHN5cy52ZXJzaW9uID49ICcyLjgnOgotICAg IHByaW50ID4+IHN5cy5zdGRlcnIsICJVbnN1cHBvcnRlZCBQeXRob24gdmVyc2lvbjogV2ViS2l0 IG9ubHkgc3VwcG9ydHMgMi41LnggLSAyLjcueCwgYW5kIHlvdSdyZSBydW5uaW5nICVzLiIgJSBz eXMudmVyc2lvbi5zcGxpdCgpWzBdCitpZiBzeXMudmVyc2lvbiA8ICcyLjYnIG9yIHN5cy52ZXJz aW9uID49ICcyLjgnOgorICAgIHByaW50ID4+IHN5cy5zdGRlcnIsICJVbnN1cHBvcnRlZCBQeXRo b24gdmVyc2lvbjogV2ViS2l0IG9ubHkgc3VwcG9ydHMgMi42LnggLSAyLjcueCwgYW5kIHlvdSdy ZSBydW5uaW5nICVzLiIgJSBzeXMudmVyc2lvbi5zcGxpdCgpWzBdCiAgICAgc3lzLmV4aXQoMSkK