78125 2012-02-08 09:52:42 -0800 r107042 caused compile breakages on chromium try bots 2012-02-08 11:30:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 podivilov jamesr abarth jamesr oldest_to_newest 552219 0 podivilov 2012-02-08 09:52:42 -0800 --------------------Configuration: webkit_platform - Release|Win32------------- Compiling... WebFloatQuad.cpp e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory WebCString.cpp WebString.cpp Copying WebCore headers needed by Platform API webkit_platform - 1 error(s), 0 warning(s) 552220 1 podivilov 2012-02-08 09:53:12 -0800 Looks like platform_api_copy_webcore_headers action added in http://trac.webkit.org/changeset/107042 is sometimes performed in parallel with compiling sources: --------------------Configuration: webkit_platform - Release|Win32------------- Compiling... WebFloatQuad.cpp e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory WebCString.cpp WebString.cpp Copying WebCore headers needed by Platform API webkit_platform - 1 error(s), 0 warning(s) 552315 2 126124 jamesr 2012-02-08 11:19:44 -0800 Created attachment 126124 Patch 552319 3 126124 abarth 2012-02-08 11:24:01 -0800 Comment on attachment 126124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126124&action=review > Source/Platform/Platform.gyp/Platform.gyp:91 > + 'destination': '<(output_dir)', Not SHARED_INTERMEDIATE_DIR ? 552321 4 jamesr 2012-02-08 11:24:32 -0800 output_dir is <(SHARED_INTERMEDIATE_DIR)/webcore_headers - see the variables section 552324 5 126124 abarth 2012-02-08 11:28:30 -0800 Comment on attachment 126124 Patch r=me 552325 6 jamesr 2012-02-08 11:30:11 -0800 Committed r107110: <http://trac.webkit.org/changeset/107110> 126124 2012-02-08 11:19:44 -0800 2012-02-08 11:29:16 -0800 Patch bug-78125-20120208111943.patch text/plain 4467 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzZjk2ZmYzZDA4YTFl YTRkZjhhMzg5MGNkZGMzM2EyNzczNGRhYzlkLi4zMmI4MzYxYjI0MzdjOWVhZGFhYjY0YjVjNjk3 YzZmMGQ4YTc5NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wMi0wOCAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIHIxMDcwNDIg Y2F1c2VkIGNvbXBpbGUgYnJlYWthZ2VzIG9uIGNocm9taXVtIHRyeSBib3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODEyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgdGhlIGNvcHkgc2Ny aXB0IHdpdGggYSBjb3BpZXMgR1lQIGFjdGlvbiBzaW5jZSB0aGUgTVNWUyBnZW5lcmF0b3IgdHJh Y2tzIGRlcGVuZGVuY2llcyBvbiBhIHBlci1maWxlCisgICAgICAgIGJhc2lzLgorCisgICAgICAg ICogUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cDoKKyAgICAgICAgKiBQbGF0Zm9ybS5neXAvY29w eV93ZWJjb3JlX2hlYWRlcnMucHk6IFJlbW92ZWQuCisKIDIwMTItMDItMDcgIEphbWVzIFJvYmlu c29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIE1vdmUgZ2Vv bWV0cnkgaGVhZGVycyBpbiBQbGF0Zm9ybSBBUEkgdG8gUGxhdGZvcm0gZGlyZWN0b3J5CmRpZmYg LS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cCBiL1NvdXJj ZS9QbGF0Zm9ybS9QbGF0Zm9ybS5neXAvUGxhdGZvcm0uZ3lwCmluZGV4IDdiNjlmMzNhYjE2NDg3 MmY5N2RlMTc1NTVlMzA3MjdlMTZlOTRiNzYuLjkxODJhYjM5MjA5ZGU2ZTllMmFiMTg3NWM4MTkw ZTRlOTVjOGI0M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9QbGF0Zm9ybS5neXAvUGxh dGZvcm0uZ3lwCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9QbGF0Zm9ybS5neXAvUGxhdGZvcm0uZ3lw CkBAIC04NiwyMiArODYsMTIgQEAKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAg ICAgICB9XSwKICAgICAgICAgICAgIF0sCi0gICAgICAgICAgICAnYWN0aW9ucyc6IFsKKyAgICAg ICAgICAgICdjb3BpZXMnOiBbCiAgICAgICAgICAgICAgICAgewotICAgICAgICAgICAgICAgICAg ICAnYWN0aW9uX25hbWUnOiAncGxhdGZvcm1fYXBpX2NvcHlfd2ViY29yZV9oZWFkZXJzJywKLSAg ICAgICAgICAgICAgICAgICAgJ2lucHV0cyc6IFsKKyAgICAgICAgICAgICAgICAgICAgJ2Rlc3Rp bmF0aW9uJzogJzwob3V0cHV0X2RpciknLAorICAgICAgICAgICAgICAgICAgICAnZmlsZXMnOiBb CiAgICAgICAgICAgICAgICAgICAgICAgICAnPEAod2ViY29yZV9oZWFkZXJzKScKLSAgICAgICAg ICAgICAgICAgICAgXSwKLSAgICAgICAgICAgICAgICAgICAgJ291dHB1dHMnOiBbCi0gICAgICAg ICAgICAgICAgICAgICAgICAnPChvdXRwdXRfZGlyKS9JbnRQb2ludC5oJyAjIEp1c3QgaGF2ZSB0 byBkZXBlbmQgb24gYW55IG9uZSBjb3BpZWQgaGVhZGVyCi0gICAgICAgICAgICAgICAgICAgIF0s Ci0gICAgICAgICAgICAgICAgICAgICdhY3Rpb24nOiBbCi0gICAgICAgICAgICAgICAgICAgICAg ICAncHl0aG9uJywKLSAgICAgICAgICAgICAgICAgICAgICAgICdjb3B5X3dlYmNvcmVfaGVhZGVy cy5weScsCi0gICAgICAgICAgICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJ Uikvd2ViY29yZV9oZWFkZXJzJywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8QCh3ZWJjb3Jl X2hlYWRlcnMpJwotICAgICAgICAgICAgICAgICAgICBdLAotICAgICAgICAgICAgICAgICAgICAn bWVzc2FnZSc6ICdDb3B5aW5nIFdlYkNvcmUgaGVhZGVycyBuZWVkZWQgYnkgUGxhdGZvcm0gQVBJ JworICAgICAgICAgICAgICAgICAgICBdCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg XQogICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL2Nv cHlfd2ViY29yZV9oZWFkZXJzLnB5IGIvU291cmNlL1BsYXRmb3JtL1BsYXRmb3JtLmd5cC9jb3B5 X3dlYmNvcmVfaGVhZGVycy5weQpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggY2QyYTM4 ZDRhZmQ2Mjg5ZjJjOTZmZGVmZDg0OTFmYzYwNWM0ZmJkNS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL2Nv cHlfd2ViY29yZV9oZWFkZXJzLnB5CisrKyAvZGV2L251bGwKQEAgLTEsNDkgKzAsMCBAQAotIyEv dXNyL2Jpbi9lbnYgcHl0aG9uCi0jIENvcHlyaWdodCAoYykgMjAxMiBHb29nbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgotIwotIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKLSMgbW9kaWZpY2F0aW9uLCBhcmUgcGVy bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0jIGFyZSBtZXQ6 Ci0jIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAotIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSMgICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKLSMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZSBkaXN0cmlidXRpb24uCi0jCi0jIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkg QVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5EIEFOWQotIyBFWFBS RVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8s IFRIRSBJTVBMSUVECi0jIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKLSMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQg U0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCi0j IERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTCi0jIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJP Q1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKLSMgTE9TUyBPRiBVU0Us IERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OCi0jIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCi0jIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTCi0jIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgotCi0iIiJBIGhlbHBlciBzY3JpcHQgZm9yIGNvcHlpbmcgV2ViQ29yZS9wbGF0Zm9ybSBoZWFk ZXJzIGludG8gYSBsb2NhdGlvbiB0aGUgV2ViS2l0IFBsYXRmb3JtIEFQSSBoZWFkZXJzIGNhbiBp bmNsdWRlIiIiCi0KLWltcG9ydCBlcnJubwotaW1wb3J0IG9zCi1pbXBvcnQgc2h1dGlsCi1pbXBv cnQgc3lzCi0KLQotZGVmIENvcHlIZWFkZXJzKGRlc3RfZGlyLCBoZWFkZXJzKToKLSAgICB0cnk6 Ci0gICAgICAgIG9zLm1ha2VkaXJzKGRlc3RfZGlyKQotICAgIGV4Y2VwdCBPU0Vycm9yLCBlOgot ICAgICAgICBpZiBlLmVycm5vICE9IGVycm5vLkVFWElTVDoKLSAgICAgICAgICAgIHJhaXNlCi0g ICAgZm9yIGhlYWRlciBpbiBoZWFkZXJzOgotICAgICAgICBkZXN0X2ZpbGVuYW1lID0gZGVzdF9k aXIgKyBvcy5zZXAgKyBoZWFkZXIuc3BsaXQoJy8nKVstMV0KLSAgICAgICAgc2h1dGlsLmNvcHlm aWxlKGhlYWRlciwgZGVzdF9maWxlbmFtZSkKLQotCi1kZWYgTWFpbihhcmd2KToKLSAgICBkZXN0 X2RpciA9IGFyZ3ZbMV0KLSAgICBoZWFkZXJzID0gYXJndlsyOl0KLSAgICBDb3B5SGVhZGVycyhk ZXN0X2RpciwgaGVhZGVycykKLQotaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKLSAgICBzeXMu ZXhpdChNYWluKHN5cy5hcmd2KSkK