78118 2012-02-08 08:36:35 -0800 [GTK] Fails to build docs with non-standard build directories 2012-02-08 09:32:04 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo webkit.review.bot oldest_to_newest 552144 0 gustavo 2012-02-08 08:36:35 -0800 So in Debian and Ubuntu our webkit package builds the two flavors of WebkitGTK+: gtk2 and gtk3. We use build-2.0 to build the former and build-3.0 for the later. We get this error after the gtk-doc stuff changed: ../Tools/gtk/generate-gtkdoc Could not determine build directory. make[1]: *** [docs-build.stamp] Error 1 A patch is forthcoming. 552151 1 126089 gustavo 2012-02-08 08:41:01 -0800 Created attachment 126089 Patch 552191 2 126089 mrobinson 2012-02-08 09:11:53 -0800 Comment on attachment 126089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126089&action=review > Tools/gtk/common.py:70 > + build_dir = os.getcwd() > + if is_valid_build_directory(build_dir): > + return build_dir > + I think you should drop a comment here explaining this is necessary. Might also want to mention who had the problem originally (Debian downstream), so that in the future we know who ask about it if the code is moved around. 552207 3 126089 webkit.review.bot 2012-02-08 09:32:00 -0800 Comment on attachment 126089 Patch Clearing flags on attachment: 126089 Committed r107098: <http://trac.webkit.org/changeset/107098> 552208 4 webkit.review.bot 2012-02-08 09:32:04 -0800 All reviewed patches have been landed. Closing bug. 126089 2012-02-08 08:41:01 -0800 2012-02-08 09:32:00 -0800 Patch bug-78118-20120208143941.patch text/plain 1299 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzA0NjUwNmFmMzBkODQyMTQwMGIwYTczYjYxMDEzYTgw MTA2MThjYi4uYTk4NmVhZTliOTZhMjJiMDhjNDNmNWI1Njk3MjczMmExZGVlMWY1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAyLTA4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgor CisgICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxkIGRvY3Mgd2l0aCBub24tc3RhbmRhcmQgYnVp bGQgZGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc4MTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBndGsvY29tbW9uLnB5OgorICAgICAgICAoZ2V0X2J1aWxkX3BhdGgpOiBhbHNvIHRy eSB0aGUgY3VycmVudCBkaXJlY3RvcnkgYXMgYSB2YWxpZCBidWlsZAorICAgICAgICBkaXIsIHdo aWNoIG1ha2VzIG5vbi1zdGFuZGFyZCBidWlsZCBkaXJlY3RvcmllcyBzdWNoIGFzIGJ1aWxkLTIu MAorICAgICAgICBhbmQgYnVpbGQtMy4wIHdvcmsKKwogMjAxMi0wMi0wOCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gT3BlbiBsaW5r cyBpbiBhIG5ldyB3aW5kb3cgd2hlbiBjbGlja2luZyB3aXRoIHRoZSBtaWRkbGUgYnV0dG9uIGlu IE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvY29tbW9uLnB5IGIvVG9vbHMvZ3Rr L2NvbW1vbi5weQppbmRleCA4OGNhN2ZjNzQwMDA2N2FmMThkMDMxOWZkZjIyNGZjYTFlMmZlNzky Li5mOGM0N2I2NDRhYmY3NGZhZWI1OGNhNzgwYWJhNmFkMzg0NDIxMGExIDEwMDY0NAotLS0gYS9U b29scy9ndGsvY29tbW9uLnB5CisrKyBiL1Rvb2xzL2d0ay9jb21tb24ucHkKQEAgLTY0LDYgKzY0 LDEwIEBAIGRlZiBnZXRfYnVpbGRfcGF0aCgpOgogICAgIGlmIGlzX3ZhbGlkX2J1aWxkX2RpcmVj dG9yeShidWlsZF9kaXIpOgogICAgICAgICByZXR1cm4gYnVpbGRfZGlyCiAKKyAgICBidWlsZF9k aXIgPSBvcy5nZXRjd2QoKQorICAgIGlmIGlzX3ZhbGlkX2J1aWxkX2RpcmVjdG9yeShidWlsZF9k aXIpOgorICAgICAgICByZXR1cm4gYnVpbGRfZGlyCisKICAgICBwcmludCAnQ291bGQgbm90IGRl dGVybWluZSBidWlsZCBkaXJlY3RvcnkuJwogICAgIHN5cy5leGl0KDEpCiAK