<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>78115</bug_id>
          
          <creation_ts>2012-02-08 08:16:09 -0800</creation_ts>
          <short_desc>Switch svg/custom tests to repaint harness</short_desc>
          <delta_ts>2012-04-05 12:50:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>77736</dependson>
    
    <dependson>78332</dependson>
          <blocked>77541</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nikolas Zimmermann">zimmermann</reporter>
          <assigned_to name="Nikolas Zimmermann">zimmermann</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>ossy</cc>
    
    <cc>rhodovan.u-szeged</cc>
    
    <cc>schenney</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zherczeg</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>552130</commentid>
    <comment_count>0</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-08 08:16:09 -0800</bug_when>
    <thetext>Switch svg/custom tests to repaint harness. Follow-up for bug 77736.
Next and last is svg/dynamic-updates.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>552135</commentid>
    <comment_count>1</comment_count>
      <attachid>126085</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-08 08:20:43 -0800</bug_when>
    <thetext>Created attachment 126085
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>552989</commentid>
    <comment_count>2</comment_count>
      <attachid>126262</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-09 02:40:55 -0800</bug_when>
    <thetext>Created attachment 126262
Patch v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553003</commentid>
    <comment_count>3</comment_count>
      <attachid>126262</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2012-02-09 03:07:03 -0800</bug_when>
    <thetext>Comment on attachment 126262
Patch v2

LGTM!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553012</commentid>
    <comment_count>4</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-09 03:22:32 -0800</bug_when>
    <thetext>Committed r107207: &lt;http://trac.webkit.org/changeset/107207&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553014</commentid>
    <comment_count>5</comment_count>
      <attachid>126262</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-02-09 03:23:15 -0800</bug_when>
    <thetext>Comment on attachment 126262
Patch v2

Attachment 126262 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11487197

New failing tests:
platform/chromium/compositing/layout-width-change.html
svg/carto.net/slider.svg</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553057</commentid>
    <comment_count>6</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-09 04:34:15 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 126262 [details])
&gt; Attachment 126262 [details] did not pass chromium-ews (chromium-xvfb):
&gt; Output: http://queues.webkit.org/results/11487197
&gt; 
&gt; New failing tests:
&gt; platform/chromium/compositing/layout-width-change.html
&gt; svg/carto.net/slider.svg
For the record, these are not related to this bug, it only changed layout tests, and none in those directories.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553171</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-09 07:56:00 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Committed r107207: &lt;http://trac.webkit.org/changeset/107207&gt;

Reopen, because it made the following tests assert on Qt in debug mode:
svg/custom/mask-child-changes.svg
svg/custom/mask-invalidation.svg
svg/custom/absolute-sized-content-with-resources.xhtml

ASSERTION FAILED: m_transparencyCount &gt; 0
../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553180</commentid>
    <comment_count>8</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-09 08:03:49 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #4)
&gt; &gt; Committed r107207: &lt;http://trac.webkit.org/changeset/107207&gt;
&gt; 
&gt; Reopen, because it made the following tests assert on Qt in debug mode:
&gt; svg/custom/mask-child-changes.svg
&gt; svg/custom/mask-invalidation.svg
&gt; svg/custom/absolute-sized-content-with-resources.xhtml
&gt; 
&gt; ASSERTION FAILED: m_transparencyCount &gt; 0
&gt; ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()

hm, I guess this only exposes a Qt bug - that&apos;s now visible due the changed timing. It&apos;s not something I can fix without a Qt build - You forgot to reopen btw.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>553182</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-02-09 08:05:42 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; (In reply to comment #4)
&gt; &gt; &gt; Committed r107207: &lt;http://trac.webkit.org/changeset/107207&gt;
&gt; &gt; 
&gt; &gt; Reopen, because it made the following tests assert on Qt in debug mode:
&gt; &gt; svg/custom/mask-child-changes.svg
&gt; &gt; svg/custom/mask-invalidation.svg
&gt; &gt; svg/custom/absolute-sized-content-with-resources.xhtml
&gt; &gt; 
&gt; &gt; ASSERTION FAILED: m_transparencyCount &gt; 0
&gt; &gt; ../../../../Source/WebCore/platform/graphics/GraphicsContext.cpp(346) : void WebCore::GraphicsContext::endTransparencyLayer()
&gt; 
&gt; hm, I guess this only exposes a Qt bug - that&apos;s now visible due the changed timing. It&apos;s not something I can fix without a Qt build - You forgot to reopen btw.

:-(

Zoltán or Reni or any other Qt and svg expert, could you check this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>554163</commentid>
    <comment_count>10</comment_count>
      <attachid>126262</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-02-10 10:22:37 -0800</bug_when>
    <thetext>Comment on attachment 126262
Patch v2

Cleared Andreas Kling&apos;s review+ from obsolete attachment 126262 so that this bug does not appear in http://webkit.org/pending-commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>557058</commentid>
    <comment_count>11</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2012-02-15 01:47:30 -0800</bug_when>
    <thetext>I&apos;m closing this bug, we can move the Qt specific fixing into bug 78332.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>596814</commentid>
    <comment_count>12</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-04-05 12:50:22 -0700</bug_when>
    <thetext>Committed r113360: &lt;http://trac.webkit.org/changeset/113360&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126085</attachid>
            <date>2012-02-08 08:20:43 -0800</date>
            <delta_ts>2012-02-09 02:32:46 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-78115-20120208172010.patch</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Nikolas Zimmermann">zimmermann</attacher>
            
              <data encoding="base64"></data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>126262</attachid>
            <date>2012-02-09 02:40:55 -0800</date>
            <delta_ts>2012-02-10 10:22:37 -0800</delta_ts>
            <desc>Patch v2</desc>
            <filename>bug-78115-20120209114010.patch</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Nikolas Zimmermann">zimmermann</attacher>
            
              <data encoding="base64"></data>

          </attachment>
      

    </bug>

</bugzilla>