78104 2012-02-08 04:50:00 -0800 [GTK] Fix a crash when WebKitWebView is created without a WebContext 2012-02-08 08:31:33 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 552032 0 cgarcia 2012-02-08 04:50:00 -0800 WebContext is a construct only property of WebKitWebView. webkit_web_view_new() passes the default web context as g_object_new parameter. If a web view is created with g_object_new without passing the web context parameter (which is a normal situation when creating objects derived from WebKitWebView), the default value for GObject propetrties is set (NULL). In webkitWebViewConstructed we assume the view already has a web context and it crashes if it hasn't. 552036 1 126060 cgarcia 2012-02-08 04:52:10 -0800 Created attachment 126060 Patch 552039 2 webkit.review.bot 2012-02-08 04:55:34 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 552138 3 cgarcia 2012-02-08 08:31:33 -0800 Committed r107092: <http://trac.webkit.org/changeset/107092> 126060 2012-02-08 04:52:10 -0800 2012-02-08 05:01:40 -0800 Patch wk2-webview-crash.diff text/plain 1656 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4MDFiY2QyLi5kZjUxNTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBhIGNyYXNoIHdoZW4gV2ViS2l0V2ViVmlldyBpcyBjcmVh dGVkIHdpdGhvdXQgYSBXZWJDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03ODEwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6Cisg ICAgICAgICh3ZWJraXRXZWJWaWV3U2V0UHJvcGVydHkpOiBNYWtlIHN1cmUgV2ViS2l0V2ViVmll dzp3ZWItY29udGV4dAorICAgICAgICBwcm9wZXJ0eSBpcyBpbml0aWFsaXplZCB0byB0aGUgZGVm YXVsdCB3ZWIgY29udGV4dCB3aGVuIGEgd2ViCisgICAgICAgIGNvbnRleHQgaXMgbm90IHBhc3Nl ZCB0byBnX29iamVjdF9uZXcoKS4KKwogMjAxMi0wMi0wNyAgTWFydGluIFJvYmluc29uICA8bXJv Ymluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW1dLMl0gQWRkIFdlYktpdFJlc3Bv bnNlUG9saWN5RGVjaXNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggNmE4Yjk2MC4uM2M5NzQ3NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKQEAgLTE4 MCw5ICsxODAsMTEgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld1NldFByb3BlcnR5KEdPYmpl Y3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBjb25zdCBHVmFsdWUKICAgICBXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXKG9iamVjdCk7CiAKICAgICBzd2l0Y2ggKHByb3BJ ZCkgewotICAgIGNhc2UgUFJPUF9XRUJfQ09OVEVYVDoKLSAgICAgICAgd2ViVmlldy0+cHJpdi0+ Y29udGV4dCA9IFdFQktJVF9XRUJfQ09OVEVYVChnX3ZhbHVlX2dldF9vYmplY3QodmFsdWUpKTsK KyAgICBjYXNlIFBST1BfV0VCX0NPTlRFWFQ6IHsKKyAgICAgICAgZ3BvaW50ZXIgd2ViQ29udGV4 dCA9IGdfdmFsdWVfZ2V0X29iamVjdCh2YWx1ZSk7CisgICAgICAgIHdlYlZpZXctPnByaXYtPmNv bnRleHQgPSB3ZWJDb250ZXh0ID8gV0VCS0lUX1dFQl9DT05URVhUKHdlYkNvbnRleHQpIDogd2Vi a2l0X3dlYl9jb250ZXh0X2dldF9kZWZhdWx0KCk7CiAgICAgICAgIGJyZWFrOworICAgIH0KICAg ICBjYXNlIFBST1BfWk9PTV9MRVZFTDoKICAgICAgICAgd2Via2l0X3dlYl92aWV3X3NldF96b29t X2xldmVsKHdlYlZpZXcsIGdfdmFsdWVfZ2V0X2RvdWJsZSh2YWx1ZSkpOwogICAgICAgICBicmVh azsK