78102 2012-02-08 04:22:51 -0800 Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane 2012-02-08 04:58:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 552010 0 apavlov 2012-02-08 04:22:51 -0800 _updateHoveredElement() removes and adds the "hovered" style class (perhaps on the same element) on every "mousemove" event 552015 1 126054 apavlov 2012-02-08 04:28:18 -0800 Created attachment 126054 Patch 552037 2 126054 vsevik 2012-02-08 04:54:40 -0800 Comment on attachment 126054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126054&action=review > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:293 > + candidateElement.addStyleClass("hovered"); Please check that candidateElement is not null here. 552041 3 apavlov 2012-02-08 04:58:36 -0800 Committed r107076: <http://trac.webkit.org/changeset/107076> 126054 2012-02-08 04:28:18 -0800 2012-02-08 04:54:39 -0800 Patch bug-78102-20120208162816.patch text/plain 2460 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JiYTU3Njg2ZTgyMDg1 M2I2ZTZiZDFkYmQ3YTc5M2ZiOTVjZTA5Zi4uNTVjMzc1ZDY1Yzk3MjRkM2Y4ZGU5YWNjOGIxNDcy NTg4ZTFiYzA0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEyLTAyLTA4ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQXZvaWQgYW4gYXZhbGFuY2hlIG9mICJjbGFzcyIgYXR0cmlidXRlIG1vZGlmaWNhdGlv bnMgaW4gV2F0Y2hFeHByZXNzaW9uc1NpZGViYXJQYW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODEwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJl c3Npb25zU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuV2F0Y2hFeHByZXNz aW9uc1NlY3Rpb24ucHJvdG90eXBlLl91cGRhdGVIb3ZlcmVkRWxlbWVudCk6CisKKzIwMTItMDIt MDggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBbQ1JBU0hdIEluc3BlY3RvckRPTUFnZW50Ojp1cGRhdGVUb3VjaEV2ZW50 RW11bGF0aW9uSW5QYWdlKCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc4MDkwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvV2F0Y2hFeHByZXNzaW9uc1NpZGViYXJQYW5lLmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBhbmUuanMKaW5kZXgg ZWM5NjViY2EyYjM2N2ZlMWE5MzYyZjgzYWZiMGE0NGQ5ZjY4YTk4OC4uNWVjNWJhMWIxNzJlMzI3 NzY5ZDE3NGE0NzM1MDA3Y2M0ZmYwY2M2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBhbmUuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBh bmUuanMKQEAgLTI3NywxOSArMjc3LDIyIEBAIFdlYkluc3BlY3Rvci5XYXRjaEV4cHJlc3Npb25z U2VjdGlvbi5wcm90b3R5cGUgPSB7CiAKICAgICBfdXBkYXRlSG92ZXJlZEVsZW1lbnQ6IGZ1bmN0 aW9uKHBhZ2VZKQogICAgIHsKLSAgICAgICAgaWYgKHRoaXMuX2hvdmVyZWRFbGVtZW50KQotICAg ICAgICAgICAgdGhpcy5faG92ZXJlZEVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygiaG92ZXJlZCIp OwotCi0gICAgICAgIHRoaXMuX2hvdmVyZWRFbGVtZW50ID0gdGhpcy5wcm9wZXJ0aWVzRWxlbWVu dC5maXJzdENoaWxkOworICAgICAgICB2YXIgY2FuZGlkYXRlRWxlbWVudCA9IHRoaXMucHJvcGVy dGllc0VsZW1lbnQuZmlyc3RDaGlsZDsKICAgICAgICAgd2hpbGUgKHRydWUpIHsKLSAgICAgICAg ICAgIHZhciBuZXh0ID0gdGhpcy5faG92ZXJlZEVsZW1lbnQubmV4dFNpYmxpbmc7Ci0gICAgICAg ICAgICB3aGlsZShuZXh0ICYmICFuZXh0LmNsaWVudEhlaWdodCkKKyAgICAgICAgICAgIHZhciBu ZXh0ID0gY2FuZGlkYXRlRWxlbWVudC5uZXh0U2libGluZzsKKyAgICAgICAgICAgIHdoaWxlIChu ZXh0ICYmICFuZXh0LmNsaWVudEhlaWdodCkKICAgICAgICAgICAgICAgICBuZXh0ID0gbmV4dC5u ZXh0U2libGluZzsKICAgICAgICAgICAgIGlmICghbmV4dCB8fCBuZXh0LnRvdGFsT2Zmc2V0VG9w KCkgPiBwYWdlWSkKICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIHRoaXMuX2hv dmVyZWRFbGVtZW50ID0gbmV4dDsKKyAgICAgICAgICAgIGNhbmRpZGF0ZUVsZW1lbnQgPSBuZXh0 OworICAgICAgICB9CisKKyAgICAgICAgaWYgKHRoaXMuX2hvdmVyZWRFbGVtZW50ICE9PSBjYW5k aWRhdGVFbGVtZW50KSB7CisgICAgICAgICAgICBpZiAodGhpcy5faG92ZXJlZEVsZW1lbnQpCisg ICAgICAgICAgICAgICAgdGhpcy5faG92ZXJlZEVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygiaG92 ZXJlZCIpOworICAgICAgICAgICAgY2FuZGlkYXRlRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJob3Zl cmVkIik7CisgICAgICAgICAgICB0aGlzLl9ob3ZlcmVkRWxlbWVudCA9IGNhbmRpZGF0ZUVsZW1l bnQ7CiAgICAgICAgIH0KLSAgICAgICAgdGhpcy5faG92ZXJlZEVsZW1lbnQuYWRkU3R5bGVDbGFz cygiaG92ZXJlZCIpOwogCiAgICAgICAgIHRoaXMuX2xhc3RNb3VzZU1vdmVQYWdlWSA9IHBhZ2VZ OwogICAgIH0K