78100 2012-02-08 03:54:40 -0800 Remove [ConvertToString] from CodeGeneratorCPP.pm and rename it to [ObjCImplementedAsUnsignedLong] 2012-02-08 16:21:43 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77393 1 haraken haraken abarth darin eric japhet ojan timothy tkent webkit.review.bot oldest_to_newest 551990 0 haraken 2012-02-08 03:54:40 -0800 Now [ConvertToString] is used in ObjC's HTMLElement.size only. We can remove [ConvertToString] code from CodeGeneratorCPP.pm, and rename [ConvertToString] to [ObjCImplementedAsUnsignedLong]. 551995 1 126048 haraken 2012-02-08 04:00:20 -0800 Created attachment 126048 Patch 552552 2 126048 eric 2012-02-08 15:34:08 -0800 Comment on attachment 126048 Patch Amazing. 552601 3 126048 webkit.review.bot 2012-02-08 16:21:35 -0800 Comment on attachment 126048 Patch Clearing flags on attachment: 126048 Committed r107148: <http://trac.webkit.org/changeset/107148> 552602 4 webkit.review.bot 2012-02-08 16:21:43 -0800 All reviewed patches have been landed. Closing bug. 126048 2012-02-08 04:00:20 -0800 2012-02-08 16:21:35 -0800 Patch bug-78100-20120208210018.patch text/plain 4882 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTA3MDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhjZDJjMjcxN2I2YzQw ZjM5ZTE5YzdmMDcwN2U5OGJlZTk1M2JlZC4uOTQzZWFiNGU5YWIyOGUyNjQ4MmNiNDhkZTk0ODli YmE4NDZhY2I1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAyLTA4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgW0NvbnZl cnRUb1N0cmluZ10gZnJvbSBDb2RlR2VuZXJhdG9yQ1BQLnBtIGFuZCByZW5hbWUKKyAgICAgICAg aXQgdG8gW09iakNJbXBsZW1lbnRlZEFzVW5zaWduZWRMb25nXQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgxMDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgW0NvbnZlcnRUb1N0cmluZ10gaXMgdXNl ZCBieSBPYmpDJ3MgSFRNTEVsZW1lbnQuc2l6ZSBvbmx5LgorICAgICAgICBUaGlzIHBhdGNoIHJl bW92ZXMgW0NvbnZlcnRUb1N0cmluZ10gY29kZSBmcm9tIENvZGVHZW5lcmF0b3JDUFAucG0sCisg ICAgICAgIGFuZCByZW5hbWVzIFtDb252ZXJ0VG9TdHJpbmddIHRvIFtPYmpDSW1wbGVtZW50ZWRB c1Vuc2lnbmVkTG9uZ10uCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbToKKyAg ICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvck9iakMucG06CisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9u KToKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsOiBSZW1vdmVkIEZJWE1FIGNv bW1lbnQsIGJlY2F1c2UgdGhlIGxhdGVzdCBzcGVjCisgICAgICAgIHNheXMgSFRNTElucHV0RWxl bWVudC5zaXplIHNob3VsZCBiZSB1bnNpZ25lZCBsb25nLgorICAgICAgICAoaHR0cDovL3d3dy53 aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2UvdGhlLWlucHV0 LWVsZW1lbnQuaHRtbCN0aGUtaW5wdXQtZWxlbWVudCkKKwogMjAxMi0wMi0wOCAgQWxleGFuZGVy IFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFRvdWNoIGV2ZW50IGVtdWxhdGlvbiBmYWlscyBmb3IgaWZyYW1lcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yQ1BQLnBtCmluZGV4IGU4Nzg1 NWMzOTMzZWJmN2IwZDJmOGI5N2UyZWEyY2M4M2JlMzQ5MDAuLmE5MDlhNTdkMDVhZDFmYzg1MGZj ZjMzYjY2MGNjNzFmMzFmMTgyOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAucG0KQEAgLTc0OCwxMSArNzQ4LDYgQEAgc3ViIEdl bmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICBteSAkYXJnTmFtZSA9ICJuZXci IC4gdWNmaXJzdCgkYXR0cmlidXRlTmFtZSk7CiAgICAgICAgICAgICAgICAgbXkgJGFyZyA9IEdl dENQUFR5cGVHZXR0ZXIoJGFyZ05hbWUsICRpZGxUeXBlKTsKIAotICAgICAgICAgICAgICAgICMg VGhlIGRlZmluaXRpb24gb2YgQ29udmVydFRvU3RyaW5nIGlzIGZsaXBwZWQgZm9yIHRoZSBzZXR0 ZXIKLSAgICAgICAgICAgICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0 dHJpYnV0ZXMtPnsiQ29udmVydFRvU3RyaW5nIn0pIHsKLSAgICAgICAgICAgICAgICAgICAgJGFy ZyA9ICJXVEY6OlN0cmluZygkYXJnKS50b0ludCgpIjsKLSAgICAgICAgICAgICAgICB9Ci0KICAg ICAgICAgICAgICAgICBteSAkYXR0cmlidXRlVHlwZSA9IEdldENQUFR5cGUoJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT50eXBlLCAxKTsKICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwg InZvaWQgJGNsYXNzTmFtZVw6XDokc2V0dGVyTmFtZSgkYXR0cmlidXRlVHlwZSAkYXJnTmFtZSlc biIpOwogICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAie1xuIik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBt IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQpp bmRleCA2YzdlZGE5ODkwZGVlNGFlNzM3OWZlMWNhYzk0ODBmZTlkZGQ0NmIwLi41YTYzZmMzM2Iy ZWQ5YmZjOTdkYTVkYWFiN2E4MDI5M2MzZDI5Zjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JPYmpDLnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KQEAgLTEyNTcsNyArMTI1 Nyw3IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siRE9NUHJp dmF0ZS5oIn0gPSAxOwotICAgICAgICAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29udmVydFRvU3RyaW5nIn0pIHsKKyAgICAgICAgICAg IH0gZWxzaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ik9i akNJbXBsZW1lbnRlZEFzVW5zaWduZWRMb25nIn0pIHsKICAgICAgICAgICAgICAgICAkZ2V0dGVy Q29udGVudEhlYWQgPSAiV1RGOjpTdHJpbmc6Om51bWJlcigiIC4gJGdldHRlckNvbnRlbnRIZWFk OwogICAgICAgICAgICAgICAgICRnZXR0ZXJDb250ZW50VGFpbCAuPSAiKSI7CiAgICAgICAgICAg ICB9IGVsc2lmICgkaWRsVHlwZSBlcSAiRGF0ZSIpIHsKQEAgLTEzODQsOCArMTM4NCw4IEBAIHN1 YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAgbXkgJGFyZ05hbWUgPSAi bmV3IiAuIHVjZmlyc3QoJGF0dHJpYnV0ZUludGVyZmFjZU5hbWUpOwogICAgICAgICAgICAgICAg IG15ICRhcmcgPSBHZXRPYmpDVHlwZUdldHRlcigkYXJnTmFtZSwgJGlkbFR5cGUpOwogCi0gICAg ICAgICAgICAgICAgIyBUaGUgZGVmaW5pdGlvbiBvZiBDb252ZXJ0VG9TdHJpbmcgaXMgZmxpcHBl ZCBmb3IgdGhlIHNldHRlcgotICAgICAgICAgICAgICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1 cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb252ZXJ0VG9TdHJpbmcifSkgeworICAgICAgICAg ICAgICAgICMgVGhlIGRlZmluaXRpb24gb2YgT2JqQ0ltcGxlbWVudGVkQXNVbnNpZ25lZExvbmcg aXMgZmxpcHBlZCBmb3IgdGhlIHNldHRlcgorICAgICAgICAgICAgICAgIGlmICgkYXR0cmlidXRl LT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPYmpDSW1wbGVtZW50ZWRBc1Vuc2ln bmVkTG9uZyJ9KSB7CiAgICAgICAgICAgICAgICAgICAgICRhcmcgPSAiV1RGOjpTdHJpbmcoJGFy ZykudG9JbnQoKSI7CiAgICAgICAgICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmlkbAppbmRleCAyMDI4ZDAyNGJiN2E2OTMwYTUxNDVhYjBlMzg2NTEyYTAw ZDUyN2NlLi40ZTIxOGI5NmNjZWUyZDU4ODIwNWYyODc5Nzc0ODhjNWNhNmU5ODY0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKQEAgLTUwLDEwICs1MCw5IEBAIG1v ZHVsZSBodG1sIHsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIHJlYWRPbmx5 OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gcmVxdWlyZWQ7CiAjaWYgZGVm aW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKLSAgICAg ICAgYXR0cmlidXRlIFtDb252ZXJ0VG9TdHJpbmddIERPTVN0cmluZyBzaXplOyAvLyBET00gbGV2 ZWwgMiBjaGFuZ2VkIHRoaXMgdG8gYSBsb25nLCBidXQgb3VyIGV4aXN0aW5nIEFQSSBpcyBhIHN0 cmluZworICAgICAgICBhdHRyaWJ1dGUgW09iakNJbXBsZW1lbnRlZEFzVW5zaWduZWRMb25nXSBE T01TdHJpbmcgc2l6ZTsgLy8gRE9NIGxldmVsIDIgY2hhbmdlZCB0aGlzIHRvIGEgbG9uZywgYnV0 IE9iakMgQVBJIGlzIGEgc3RyaW5nCiAjZWxzZQotICAgICAgICAvLyBGSVhNRTogVGhlIHNwZWMg c2F5cyB0aGlzIHNob3VsZCBiZSBhIGxvbmcsIG5vdCBhbiB1bnNpZ25lZCBsb25nLgotICAgICAg ICBhdHRyaWJ1dGUgdW5zaWduZWQgbG9uZyBzaXplOyAvLyBDaGFuZ2VkIHN0cmluZyAtPiBsb25n IGFzIHBhcnQgb2YgRE9NIGxldmVsIDIKKyAgICAgICAgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcg c2l6ZTsgLy8gQ2hhbmdlZCBzdHJpbmcgLT4gbG9uZyAtPiB1bnNpZ25lZCBsb25nCiAjZW5kaWYK ICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0LCBVUkxdIERPTVN0cmluZyBzcmM7CiAgICAgICAg IGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIHN0ZXA7Cg==