78099 2012-02-08 03:52:39 -0800 [GTK] Open links in a new window when clicking with the middle button in MiniBrowser 2012-02-08 07:51:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 71447 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 551985 0 cgarcia 2012-02-08 03:52:39 -0800 I think this is the last regression since the migration to the GTK+ API 551992 1 126047 cgarcia 2012-02-08 03:56:03 -0800 Created attachment 126047 Patch 552122 2 cgarcia 2012-02-08 07:51:27 -0800 Committed r107088: <http://trac.webkit.org/changeset/107088> 126047 2012-02-08 03:56:03 -0800 2012-02-08 07:37:42 -0800 Patch mb-middle-click.diff text/plain 2987 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0OTYz ZjY4Li4yMThjZWQ2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE9wZW4gbGlua3MgaW4gYSBu ZXcgd2luZG93IHdoZW4gY2xpY2tpbmcgd2l0aCB0aGUgbWlkZGxlIGJ1dHRvbiBpbiBNaW5pQnJv d3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Nzgw OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgICh3ZWJWaWV3RGVjaWRlUG9s aWN5KTogQ2hlY2sgd2hldGhlciBpdCdzIGEgbGluayBjbGlja2VkIHdpdGggdGhlCisgICAgICAg IG1pZGRsZSBtb3VzZSBidXR0b24gYW5kIGxvYWQgdGhlIHJlcXVlc3QgaW4gYSBuZXcgd2luZG93 LgorICAgICAgICAoYnJvd3NlcldpbmRvd0NvbnN0cnVjdGVkKTogQ29ubmVjdCB0bworICAgICAg ICBXZWJLaXRXZWJWaWV3OjpkZWNpZGUtcG9saWN5IHNpZ25hbC4KKwogMjAxMi0wMi0wNyAgSnVz dGluIE5vdm9zYWQgIDxqdW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBh ZGQgb3B0aW9uIGZvciAyZCBjYW52YXMgZGVmZXJlZCByZW5kZXJpbmcgdG8gRHVtcFJlbmRlclRy ZWUKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9U b29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IGUwNGFiMGIuLjRkNmJk ZTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtMjM1LDYgKzIzNSwy NiBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViVmlld0xvYWRGYWlsZWQoV2ViS2l0V2ViVmlldyAqd2Vi VmlldywgV2ViS2l0TG9hZEV2ZW50IGxvYWRFdgogICAgIHJldHVybiBGQUxTRTsKIH0KIAorc3Rh dGljIGdib29sZWFuIHdlYlZpZXdEZWNpZGVQb2xpY3koV2ViS2l0V2ViVmlldyAqd2ViVmlldywg V2ViS2l0UG9saWN5RGVjaXNpb24gKmRlY2lzaW9uLCBXZWJLaXRQb2xpY3lEZWNpc2lvblR5cGUg ZGVjaXNpb25UeXBlLCBCcm93c2VyV2luZG93ICp3aW5kb3cpCit7CisgICAgaWYgKGRlY2lzaW9u VHlwZSAhPSBXRUJLSVRfUE9MSUNZX0RFQ0lTSU9OX1RZUEVfTkFWSUdBVElPTl9BQ1RJT04pCisg ICAgICAgIHJldHVybiBGQUxTRTsKKworICAgIFdlYktpdE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lv biAqbmF2aWdhdGlvbkRlY2lzaW9uID0gV0VCS0lUX05BVklHQVRJT05fUE9MSUNZX0RFQ0lTSU9O KGRlY2lzaW9uKTsKKyAgICBpZiAod2Via2l0X25hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uX2dl dF9uYXZpZ2F0aW9uX3R5cGUobmF2aWdhdGlvbkRlY2lzaW9uKSAhPSBXRUJLSVRfTkFWSUdBVElP Tl9UWVBFX0xJTktfQ0xJQ0tFRAorICAgICAgICB8fCB3ZWJraXRfbmF2aWdhdGlvbl9wb2xpY3lf ZGVjaXNpb25fZ2V0X21vdXNlX2J1dHRvbihuYXZpZ2F0aW9uRGVjaXNpb24pICE9IDIpCisgICAg ICAgIHJldHVybiBGQUxTRTsKKworICAgIFdlYktpdFdlYlZpZXcgKm5ld1dlYlZpZXcgPSBXRUJL SVRfV0VCX1ZJRVcod2Via2l0X3dlYl92aWV3X25ld193aXRoX2NvbnRleHQod2Via2l0X3dlYl92 aWV3X2dldF9jb250ZXh0KHdlYlZpZXcpKSk7CisgICAgd2Via2l0X3dlYl92aWV3X3NldF9zZXR0 aW5ncyhuZXdXZWJWaWV3LCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NldHRpbmdzKHdlYlZpZXcpKTsK KyAgICBHdGtXaWRnZXQgKm5ld1dpbmRvdyA9IGJyb3dzZXJfd2luZG93X25ldyhuZXdXZWJWaWV3 KTsKKyAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF9yZXF1ZXN0KG5ld1dlYlZpZXcsIHdlYmtpdF9u YXZpZ2F0aW9uX3BvbGljeV9kZWNpc2lvbl9nZXRfcmVxdWVzdChuYXZpZ2F0aW9uRGVjaXNpb24p KTsKKyAgICBndGtfd2lkZ2V0X3Nob3cobmV3V2luZG93KTsKKworICAgIHdlYmtpdF9wb2xpY3lf ZGVjaXNpb25faWdub3JlKGRlY2lzaW9uKTsKKyAgICByZXR1cm4gVFJVRTsKK30KKwogc3RhdGlj IHZvaWQgYnJvd3NlcldpbmRvd0ZpbmFsaXplKEdPYmplY3QgKmdPYmplY3QpCiB7CiAgICAgR19P QkpFQ1RfQ0xBU1MoYnJvd3Nlcl93aW5kb3dfcGFyZW50X2NsYXNzKS0+ZmluYWxpemUoZ09iamVj dCk7CkBAIC0zMzMsNiArMzUzLDcgQEAgc3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0NvbnN0cnVj dGVkKEdPYmplY3QgKmdPYmplY3QpCiAgICAgZ19zaWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZp ZXcsICJub3RpZnk6OnRpdGxlIiwgR19DQUxMQkFDSyh3ZWJWaWV3VGl0bGVDaGFuZ2VkKSwgd2lu ZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgImNyZWF0ZSIsIEdf Q0FMTEJBQ0sod2ViVmlld0NyZWF0ZSksIHdpbmRvdyk7CiAgICAgZ19zaWduYWxfY29ubmVjdCh3 aW5kb3ctPndlYlZpZXcsICJsb2FkLWZhaWxlZCIsIEdfQ0FMTEJBQ0sod2ViVmlld0xvYWRGYWls ZWQpLCB3aW5kb3cpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luZG93LT53ZWJWaWV3LCAiZGVj aWRlLXBvbGljeSIsIEdfQ0FMTEJBQ0sod2ViVmlld0RlY2lkZVBvbGljeSksIHdpbmRvdyk7CiAK ICAgICBXZWJLaXRCYWNrRm9yd2FyZExpc3QgKmJhY2tGb3J3YWRsaXN0ID0gd2Via2l0X3dlYl92 aWV3X2dldF9iYWNrX2ZvcndhcmRfbGlzdCh3aW5kb3ctPndlYlZpZXcpOwogICAgIGdfc2lnbmFs X2Nvbm5lY3QoYmFja0ZvcndhZGxpc3QsICJjaGFuZ2VkIiwgR19DQUxMQkFDSyhiYWNrRm9yd2Fk bGlzdENoYW5nZWQpLCB3aW5kb3cpOwo=