78098 2012-02-08 03:19:19 -0800 [GTK] Show url of current hovered link in MiniBrowser 2012-02-09 09:18:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 78097 71447 1 cgarcia webkit-unassigned gustavo pnormand xan.lopez oldest_to_newest 551965 0 cgarcia 2012-02-08 03:19:19 -0800 This was implemented when MiniBrowser used the C API 551970 1 126044 cgarcia 2012-02-08 03:22:26 -0800 Created attachment 126044 Patch 551972 2 126044 pnormand 2012-02-08 03:25:52 -0800 Comment on attachment 126044 Patch Attachment 126044 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11453359 551974 3 cgarcia 2012-02-08 03:30:49 -0800 (In reply to comment #2) > (From update of attachment 126044 [details]) > Attachment 126044 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/11453359 This is because it depends on bug #78097 552136 4 126044 mrobinson 2012-02-08 08:23:28 -0800 Comment on attachment 126044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126044&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:165 > g_signal_connect(menu, "hide", G_CALLBACK(resetStatusText), window); I guess this comment was incorrect? 553205 5 126313 cgarcia 2012-02-09 08:53:07 -0800 Created attachment 126313 Patch updated to current git master 553217 6 cgarcia 2012-02-09 09:18:24 -0800 Committed r107254: <http://trac.webkit.org/changeset/107254> 126044 2012-02-08 03:22:26 -0800 2012-02-09 08:53:07 -0800 Patch mb-hovered-link.diff text/plain 2658 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0OTYz ZjY4Li5iZjAyNThkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFNob3cgdXJsIG9mIGN1cnJl bnQgaG92ZXJlZCBsaW5rIGluIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoK KyAgICAgICAgKHdlYlZpZXdIb3ZlcmVkT3ZlckVsZW1lbnQpOiBDaGVjayB3aGV0aGVyIGhpdCB0 ZXN0IHJlc3VsdCBpcyBhCisgICAgICAgIGxpbmsgYW5kIHVzZSB0aGUgdXJsIHRvIHVwZGF0ZSB0 aGUgc3RhdHVzIGJhciB0ZXh0LgorICAgICAgICAoYnJvd3NlcldpbmRvd0NvbnN0cnVjdGVkKTog Q29ubmVjdCB0bworICAgICAgICBXZWJLaXRXZWJWaWV3Ojpob3ZlcmVkLW92ZXItZWxlbWVudCBz aWduYWwuCisKIDIwMTItMDItMDcgIEp1c3RpbiBOb3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtDaHJvbWl1bV0gYWRkIG9wdGlvbiBmb3IgMmQgY2FudmFzIGRlZmVyZWQg cmVuZGVyaW5nIHRvIER1bXBSZW5kZXJUcmVlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5k b3cuYwppbmRleCBlMDRhYjBiLi42ODJjMTQ1IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKQEAgLTE2Miw5ICsxNjIsNiBAQCBzdGF0aWMgR3RrV2lkZ2V0ICpicm93c2VyV2lu ZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KEJyb3dzZXJXaW5kb3cgKndpbmRvdywgR0xpcwogICAg ICAgICBndGtfd2lkZ2V0X3Nob3cobWVudUl0ZW0pOwogICAgIH0KIAotICAgIC8qIEZJWE1FOiBU aGlzIHNob3VsbmQndCBiZSBuZWNlc3Nhcnkgd2hlbiBkaWRNb3VzZU1vdmVPdmVyRWxlbWVudAot ICAgICAqIGlzIGltcGxlbWVudGVkIGluIFdlYktpdDIgR1RLKyBBUEkuCi0gICAgICovCiAgICAg Z19zaWduYWxfY29ubmVjdChtZW51LCAiaGlkZSIsIEdfQ0FMTEJBQ0socmVzZXRTdGF0dXNUZXh0 KSwgd2luZG93KTsKIAogICAgIHJldHVybiBtZW51OwpAQCAtMjM1LDYgKzIzMiwxNSBAQCBzdGF0 aWMgZ2Jvb2xlYW4gd2ViVmlld0xvYWRGYWlsZWQoV2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2Vi S2l0TG9hZEV2ZW50IGxvYWRFdgogICAgIHJldHVybiBGQUxTRTsKIH0KIAorc3RhdGljIHZvaWQg d2ViVmlld0hvdmVyZWRPdmVyRWxlbWVudChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBXZWJLaXRI aXRUZXN0UmVzdWx0ICpoaXRUZXN0UmVzdWx0LCBndWludCBtb3VzZU1vZGlmaWVycywgQnJvd3Nl cldpbmRvdyAqd2luZG93KQoreworICAgIGlmICghaGl0VGVzdFJlc3VsdCB8fCAhd2Via2l0X2hp dF90ZXN0X3Jlc3VsdF9jb250ZXh0X2lzX2xpbmsoaGl0VGVzdFJlc3VsdCkpIHsKKyAgICAgICAg YnJvd3NlcldpbmRvd1NldFN0YXR1c1RleHQod2luZG93LCBOVUxMKTsKKyAgICAgICAgcmV0dXJu OworICAgIH0KKyAgICBicm93c2VyV2luZG93U2V0U3RhdHVzVGV4dCh3aW5kb3csIHdlYmtpdF9o aXRfdGVzdF9yZXN1bHRfZ2V0X2xpbmtfdXJpKGhpdFRlc3RSZXN1bHQpKTsKK30KKwogc3RhdGlj IHZvaWQgYnJvd3NlcldpbmRvd0ZpbmFsaXplKEdPYmplY3QgKmdPYmplY3QpCiB7CiAgICAgR19P QkpFQ1RfQ0xBU1MoYnJvd3Nlcl93aW5kb3dfcGFyZW50X2NsYXNzKS0+ZmluYWxpemUoZ09iamVj dCk7CkBAIC0zMzMsNiArMzM5LDcgQEAgc3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0NvbnN0cnVj dGVkKEdPYmplY3QgKmdPYmplY3QpCiAgICAgZ19zaWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZp ZXcsICJub3RpZnk6OnRpdGxlIiwgR19DQUxMQkFDSyh3ZWJWaWV3VGl0bGVDaGFuZ2VkKSwgd2lu ZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgImNyZWF0ZSIsIEdf Q0FMTEJBQ0sod2ViVmlld0NyZWF0ZSksIHdpbmRvdyk7CiAgICAgZ19zaWduYWxfY29ubmVjdCh3 aW5kb3ctPndlYlZpZXcsICJsb2FkLWZhaWxlZCIsIEdfQ0FMTEJBQ0sod2ViVmlld0xvYWRGYWls ZWQpLCB3aW5kb3cpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luZG93LT53ZWJWaWV3LCAiaG92 ZXJlZC1vdmVyLWVsZW1lbnQiLCBHX0NBTExCQUNLKHdlYlZpZXdIb3ZlcmVkT3ZlckVsZW1lbnQp LCB3aW5kb3cpOwogCiAgICAgV2ViS2l0QmFja0ZvcndhcmRMaXN0ICpiYWNrRm9yd2FkbGlzdCA9 IHdlYmtpdF93ZWJfdmlld19nZXRfYmFja19mb3J3YXJkX2xpc3Qod2luZG93LT53ZWJWaWV3KTsK ICAgICBnX3NpZ25hbF9jb25uZWN0KGJhY2tGb3J3YWRsaXN0LCAiY2hhbmdlZCIsIEdfQ0FMTEJB Q0soYmFja0ZvcndhZGxpc3RDaGFuZ2VkKSwgd2luZG93KTsK 126313 2012-02-09 08:53:07 -0800 2012-02-09 09:14:59 -0800 Patch updated to current git master mb-hovered-links2.diff text/plain 2620 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZmQw YzY1Li44ZDZkNzYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFNob3cgdXJsIG9mIGN1cnJl bnQgaG92ZXJlZCBsaW5rIGluIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03ODA5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoK KyAgICAgICAgKHdlYlZpZXdNb3VzZVRhcmdldENoYW5nZWQpOiBDaGVjayB3aGV0aGVyIGhpdCB0 ZXN0IHJlc3VsdCBpcyBhCisgICAgICAgIGxpbmsgYW5kIHVzZSB0aGUgdXJsIHRvIHVwZGF0ZSB0 aGUgc3RhdHVzIGJhciB0ZXh0LgorICAgICAgICAoYnJvd3NlcldpbmRvd0NvbnN0cnVjdGVkKTog Q29ubmVjdCB0bworICAgICAgICBXZWJLaXRXZWJWaWV3Ojptb3VzZS10YXJnZXQtY2hhbmdlZCBz aWduYWwuCisKIDIwMTItMDItMDcgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmVwbGFjZW1lbnQgdGV4dCBzaG91bGQgYmUgYXZhaWxhYmxlIGZyb20gdGhl IG1hcmtlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93 LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDRkNmJkZTQu LmZjMDQwNmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93 LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtMTYyLDkg KzE2Miw2IEBAIHN0YXRpYyBHdGtXaWRnZXQgKmJyb3dzZXJXaW5kb3dDcmVhdGVCYWNrRm9yd2Fy ZE1lbnUoQnJvd3NlcldpbmRvdyAqd2luZG93LCBHTGlzCiAgICAgICAgIGd0a193aWRnZXRfc2hv dyhtZW51SXRlbSk7CiAgICAgfQogCi0gICAgLyogRklYTUU6IFRoaXMgc2hvdWxuZCd0IGJlIG5l Y2Vzc2FyeSB3aGVuIGRpZE1vdXNlTW92ZU92ZXJFbGVtZW50Ci0gICAgICogaXMgaW1wbGVtZW50 ZWQgaW4gV2ViS2l0MiBHVEsrIEFQSS4KLSAgICAgKi8KICAgICBnX3NpZ25hbF9jb25uZWN0KG1l bnUsICJoaWRlIiwgR19DQUxMQkFDSyhyZXNldFN0YXR1c1RleHQpLCB3aW5kb3cpOwogCiAgICAg cmV0dXJuIG1lbnU7CkBAIC0yNTUsNiArMjUyLDE1IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJWaWV3 RGVjaWRlUG9saWN5KFdlYktpdFdlYlZpZXcgKndlYlZpZXcsIFdlYktpdFBvbGljeURlY2lzaW9u CiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKK3N0YXRpYyB2b2lkIHdlYlZpZXdNb3VzZVRhcmdldENo YW5nZWQoV2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0SGl0VGVzdFJlc3VsdCAqaGl0VGVz dFJlc3VsdCwgZ3VpbnQgbW91c2VNb2RpZmllcnMsIEJyb3dzZXJXaW5kb3cgKndpbmRvdykKK3sK KyAgICBpZiAoIXdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY29udGV4dF9pc19saW5rKGhpdFRlc3RS ZXN1bHQpKSB7CisgICAgICAgIGJyb3dzZXJXaW5kb3dTZXRTdGF0dXNUZXh0KHdpbmRvdywgTlVM TCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgYnJvd3NlcldpbmRvd1NldFN0YXR1c1Rl eHQod2luZG93LCB3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2dldF9saW5rX3VyaShoaXRUZXN0UmVz dWx0KSk7Cit9CisKIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dGaW5hbGl6ZShHT2JqZWN0ICpn T2JqZWN0KQogewogICAgIEdfT0JKRUNUX0NMQVNTKGJyb3dzZXJfd2luZG93X3BhcmVudF9jbGFz cyktPmZpbmFsaXplKGdPYmplY3QpOwpAQCAtMzU0LDYgKzM2MCw3IEBAIHN0YXRpYyB2b2lkIGJy b3dzZXJXaW5kb3dDb25zdHJ1Y3RlZChHT2JqZWN0ICpnT2JqZWN0KQogICAgIGdfc2lnbmFsX2Nv bm5lY3Qod2luZG93LT53ZWJWaWV3LCAiY3JlYXRlIiwgR19DQUxMQkFDSyh3ZWJWaWV3Q3JlYXRl KSwgd2luZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgImxvYWQt ZmFpbGVkIiwgR19DQUxMQkFDSyh3ZWJWaWV3TG9hZEZhaWxlZCksIHdpbmRvdyk7CiAgICAgZ19z aWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZpZXcsICJkZWNpZGUtcG9saWN5IiwgR19DQUxMQkFD Syh3ZWJWaWV3RGVjaWRlUG9saWN5KSwgd2luZG93KTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdp bmRvdy0+d2ViVmlldywgIm1vdXNlLXRhcmdldC1jaGFuZ2VkIiwgR19DQUxMQkFDSyh3ZWJWaWV3 TW91c2VUYXJnZXRDaGFuZ2VkKSwgd2luZG93KTsKIAogICAgIFdlYktpdEJhY2tGb3J3YXJkTGlz dCAqYmFja0ZvcndhZGxpc3QgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2JhY2tfZm9yd2FyZF9saXN0 KHdpbmRvdy0+d2ViVmlldyk7CiAgICAgZ19zaWduYWxfY29ubmVjdChiYWNrRm9yd2FkbGlzdCwg ImNoYW5nZWQiLCBHX0NBTExCQUNLKGJhY2tGb3J3YWRsaXN0Q2hhbmdlZCksIHdpbmRvdyk7Cg==